Re: [PATCH 4/4] [media] dt/bindings: Add bindings for OV2685
Rob, On 2017年12月27日 07:28, Rob Herring wrote: On Mon, Dec 25, 2017 at 10:11:26PM +0800, Shunqian Zheng wrote: Add device tree binding documentation for the OV2685 sensor. Signed-off-by: Shunqian Zheng--- .../devicetree/bindings/media/i2c/ov2685.txt | 35 ++ 1 file changed, 35 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/i2c/ov2685.txt diff --git a/Documentation/devicetree/bindings/media/i2c/ov2685.txt b/Documentation/devicetree/bindings/media/i2c/ov2685.txt new file mode 100644 index 000..c62db9c --- /dev/null +++ b/Documentation/devicetree/bindings/media/i2c/ov2685.txt @@ -0,0 +1,35 @@ +* Omnivision OV2685 MIPI CSI-2 sensor + +Required Properties: +- compatible: should be "ovti,ov2685" +- clocks: reference to the 24M xvclk input clock. +- clock-names: should be "xvclk". +- avdd-supply: Analog voltage supply, 2.8 volts +- dvdd-supply: Digital core voltage supply, 1.2 volts +- reset-gpios: Low active reset gpio + +The device node must contain one 'port' child node for its digital output +video port, in accordance with the video interface bindings defined in +Documentation/devicetree/bindings/media/video-interfaces.txt. + +Example: + ucam: ov2680@3c { camera-sensor@3c + compatible = "ovti,ov2685"; + reg = <0x3c>; + pinctrl-names = "default"; + pinctrl-0 = <_24m_cam _rst>; Not documented. The _24m_cam is pin mux on my rk3399. While the _rst is board special pin, I should remove it in Document. Thanks, Shunqian + + clocks = < SCLK_TESTCLKOUT1>; + clock-names = "xvclk"; + + avdd-supply = <_cam>; + dovdd-supply = <>; + reset-gpios = < 3 GPIO_ACTIVE_LOW>; + + port { + ucam_out: endpoint { + remote-endpoint = <_in_ucam>; + data-lanes = <1>; + }; + }; + }; -- 1.9.1
Re: [PATCH 4/4] [media] dt/bindings: Add bindings for OV2685
On Mon, Dec 25, 2017 at 10:11:26PM +0800, Shunqian Zheng wrote: > Add device tree binding documentation for the OV2685 sensor. > > Signed-off-by: Shunqian Zheng> --- > .../devicetree/bindings/media/i2c/ov2685.txt | 35 > ++ > 1 file changed, 35 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/i2c/ov2685.txt > > diff --git a/Documentation/devicetree/bindings/media/i2c/ov2685.txt > b/Documentation/devicetree/bindings/media/i2c/ov2685.txt > new file mode 100644 > index 000..c62db9c > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/i2c/ov2685.txt > @@ -0,0 +1,35 @@ > +* Omnivision OV2685 MIPI CSI-2 sensor > + > +Required Properties: > +- compatible: should be "ovti,ov2685" > +- clocks: reference to the 24M xvclk input clock. > +- clock-names: should be "xvclk". > +- avdd-supply: Analog voltage supply, 2.8 volts > +- dvdd-supply: Digital core voltage supply, 1.2 volts > +- reset-gpios: Low active reset gpio > + > +The device node must contain one 'port' child node for its digital output > +video port, in accordance with the video interface bindings defined in > +Documentation/devicetree/bindings/media/video-interfaces.txt. > + > +Example: > + ucam: ov2680@3c { camera-sensor@3c > + compatible = "ovti,ov2685"; > + reg = <0x3c>; > + pinctrl-names = "default"; > + pinctrl-0 = <_24m_cam _rst>; Not documented. > + > + clocks = < SCLK_TESTCLKOUT1>; > + clock-names = "xvclk"; > + > + avdd-supply = <_cam>; > + dovdd-supply = <>; > + reset-gpios = < 3 GPIO_ACTIVE_LOW>; > + > + port { > + ucam_out: endpoint { > + remote-endpoint = <_in_ucam>; > + data-lanes = <1>; > + }; > + }; > + }; > -- > 1.9.1 >
[PATCH 4/4] [media] dt/bindings: Add bindings for OV2685
Add device tree binding documentation for the OV2685 sensor. Signed-off-by: Shunqian Zheng--- .../devicetree/bindings/media/i2c/ov2685.txt | 35 ++ 1 file changed, 35 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/i2c/ov2685.txt diff --git a/Documentation/devicetree/bindings/media/i2c/ov2685.txt b/Documentation/devicetree/bindings/media/i2c/ov2685.txt new file mode 100644 index 000..c62db9c --- /dev/null +++ b/Documentation/devicetree/bindings/media/i2c/ov2685.txt @@ -0,0 +1,35 @@ +* Omnivision OV2685 MIPI CSI-2 sensor + +Required Properties: +- compatible: should be "ovti,ov2685" +- clocks: reference to the 24M xvclk input clock. +- clock-names: should be "xvclk". +- avdd-supply: Analog voltage supply, 2.8 volts +- dvdd-supply: Digital core voltage supply, 1.2 volts +- reset-gpios: Low active reset gpio + +The device node must contain one 'port' child node for its digital output +video port, in accordance with the video interface bindings defined in +Documentation/devicetree/bindings/media/video-interfaces.txt. + +Example: + ucam: ov2680@3c { + compatible = "ovti,ov2685"; + reg = <0x3c>; + pinctrl-names = "default"; + pinctrl-0 = <_24m_cam _rst>; + + clocks = < SCLK_TESTCLKOUT1>; + clock-names = "xvclk"; + + avdd-supply = <_cam>; + dovdd-supply = <>; + reset-gpios = < 3 GPIO_ACTIVE_LOW>; + + port { + ucam_out: endpoint { + remote-endpoint = <_in_ucam>; + data-lanes = <1>; + }; + }; + }; -- 1.9.1