Re: [PATCH 8/9] iio: gyro: mpu3050: stop double error reporting

2017-04-03 Thread Jonathan Cameron 
On 03/04/17 18:56, Linus Walleij wrote:
> On Mon, Apr 3, 2017 at 10:38 AM, Peter Rosin  wrote:
> 
>> i2c_mux_add_adapter already logs a message on failure.
>>
>> Signed-off-by: Peter Rosin 
> 
> Reviewed-by: Linus Walleij 
Applied to the togreg branch of iio.git.

Can't see any reason not to split this set up and apply through
the various trees so I've picked this one up.

Good little series.  We should do more of these in general!

Jonathan
> 
> Yours,
> Linus Walleij
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

Re: [PATCH 8/9] iio: gyro: mpu3050: stop double error reporting

2017-04-03 Thread Linus Walleij 
On Mon, Apr 3, 2017 at 10:38 AM, Peter Rosin  wrote:

> i2c_mux_add_adapter already logs a message on failure.
>
> Signed-off-by: Peter Rosin 

Reviewed-by: Linus Walleij 

Yours,
Linus Walleij

[PATCH 8/9] iio: gyro: mpu3050: stop double error reporting

2017-04-03 Thread Peter Rosin 
i2c_mux_add_adapter already logs a message on failure.

Signed-off-by: Peter Rosin 
---
 drivers/iio/gyro/mpu3050-i2c.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/iio/gyro/mpu3050-i2c.c b/drivers/iio/gyro/mpu3050-i2c.c
index 06007200bf49..93f08b304a63 100644
--- a/drivers/iio/gyro/mpu3050-i2c.c
+++ b/drivers/iio/gyro/mpu3050-i2c.c
@@ -70,9 +70,8 @@ static int mpu3050_i2c_probe(struct i2c_client *client,
dev_err(>dev, "failed to allocate I2C mux\n");
else {
mpu3050->i2cmux->priv = mpu3050;
-   ret = i2c_mux_add_adapter(mpu3050->i2cmux, 0, 0, 0);
-   if (ret)
-   dev_err(>dev, "failed to add I2C mux\n");
+   /* Ignore failure, not critical */
+   i2c_mux_add_adapter(mpu3050->i2cmux, 0, 0, 0);
}
 
return 0;
-- 
2.1.4