Re: [PATCH RFC 02/13] of: add a dummy inline function for when CONFIG_OF is not defined

[Grant Likely]

On Mon, 10 Dec 2012 20:41:28 +0100, Sylwester Nawrocki s.nawro...@samsung.com 
wrote:
 From: Guennadi Liakhovetski g.liakhovet...@gmx.de
 
 If CONFIG_OF isn't defined, no declaration of of_get_parent will be found
 and compilation can fail. This patch adds a dummy inline function
 definition to fix the problem.

Where is this function getting called when CONFIG_OF is not defined? I
suspect that any code calling of_get_parent() should be CONFIG_OF
specific code and configured out when CONFIG_OF=n, but let me know if
I'm missing something.

g.

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH RFC 02/13] of: add a dummy inline function for when CONFIG_OF is not defined

[Sylwester Nawrocki]

From: Guennadi Liakhovetski g.liakhovet...@gmx.de

If CONFIG_OF isn't defined, no declaration of of_get_parent will be found
and compilation can fail. This patch adds a dummy inline function
definition to fix the problem.

Signed-off-by: Guennadi Liakhovetski g.liakhovet...@gmx.de
---
 include/linux/of.h |5 +
 1 file changed, 5 insertions(+)

diff --git a/include/linux/of.h b/include/linux/of.h
index b4e50d5..9ba8cf1 100644
--- a/include/linux/of.h
+++ b/include/linux/of.h
@@ -427,6 +427,11 @@ static inline int of_parse_phandle_with_args(struct 
device_node *np,
return -ENOSYS;
 }
 
+static inline struct device_node *of_get_parent(const struct device_node *np)
+{
+   return NULL;
+}
+
 static inline int of_alias_get_id(struct device_node *np, const char *stem)
 {
return -ENOSYS;
-- 
1.7.9.5

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html