Re: [PATCH RFC 2/3] dvb_frontend: return -ENOTTY for unimplement IOCTL

2012-08-12 Thread Mauro Carvalho Chehab 
Em 09-08-2012 19:25, Antti Palosaari escreveu:
 Earlier it was returning -EOPNOTSUPP.

This change makes all sense to me. We just need to be sure that this won't
cause any regressions on userspace apps.

Regards,
Mauro
 
 Signed-off-by: Antti Palosaari cr...@iki.fi
 ---
  drivers/media/dvb/dvb-core/dvb_frontend.c | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)
 
 diff --git a/drivers/media/dvb/dvb-core/dvb_frontend.c 
 b/drivers/media/dvb/dvb-core/dvb_frontend.c
 index 4548fc9..4fc11eb 100644
 --- a/drivers/media/dvb/dvb-core/dvb_frontend.c
 +++ b/drivers/media/dvb/dvb-core/dvb_frontend.c
 @@ -1830,7 +1830,7 @@ static int dvb_frontend_ioctl(struct file *file,
   struct dvb_frontend *fe = dvbdev-priv;
   struct dtv_frontend_properties *c = fe-dtv_property_cache;
   struct dvb_frontend_private *fepriv = fe-frontend_priv;
 - int err = -EOPNOTSUPP;
 + int err = -ENOTTY;
  
   dev_dbg(fe-dvb-device, %s: (%d)\n, __func__, _IOC_NR(cmd));
   if (fepriv-exit != DVB_FE_NO_EXIT)
 @@ -1948,7 +1948,7 @@ static int dvb_frontend_ioctl_properties(struct file 
 *file,
   }
  
   } else
 - err = -EOPNOTSUPP;
 + err = -ENOTTY;
  
  out:
   kfree(tvp);
 @@ -2081,7 +2081,7 @@ static int dvb_frontend_ioctl_legacy(struct file *file,
   struct dvb_frontend *fe = dvbdev-priv;
   struct dvb_frontend_private *fepriv = fe-frontend_priv;
   struct dtv_frontend_properties *c = fe-dtv_property_cache;
 - int cb_err, err = -EOPNOTSUPP;
 + int cb_err, err = -ENOTTY;
  
   if (fe-dvb-fe_ioctl_override) {
   cb_err = fe-dvb-fe_ioctl_override(fe, cmd, parg,
 

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH RFC 2/3] dvb_frontend: return -ENOTTY for unimplement IOCTL

2012-08-09 Thread Antti Palosaari 
Earlier it was returning -EOPNOTSUPP.

Signed-off-by: Antti Palosaari cr...@iki.fi
---
 drivers/media/dvb/dvb-core/dvb_frontend.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/media/dvb/dvb-core/dvb_frontend.c 
b/drivers/media/dvb/dvb-core/dvb_frontend.c
index 4548fc9..4fc11eb 100644
--- a/drivers/media/dvb/dvb-core/dvb_frontend.c
+++ b/drivers/media/dvb/dvb-core/dvb_frontend.c
@@ -1830,7 +1830,7 @@ static int dvb_frontend_ioctl(struct file *file,
struct dvb_frontend *fe = dvbdev-priv;
struct dtv_frontend_properties *c = fe-dtv_property_cache;
struct dvb_frontend_private *fepriv = fe-frontend_priv;
-   int err = -EOPNOTSUPP;
+   int err = -ENOTTY;
 
dev_dbg(fe-dvb-device, %s: (%d)\n, __func__, _IOC_NR(cmd));
if (fepriv-exit != DVB_FE_NO_EXIT)
@@ -1948,7 +1948,7 @@ static int dvb_frontend_ioctl_properties(struct file 
*file,
}
 
} else
-   err = -EOPNOTSUPP;
+   err = -ENOTTY;
 
 out:
kfree(tvp);
@@ -2081,7 +2081,7 @@ static int dvb_frontend_ioctl_legacy(struct file *file,
struct dvb_frontend *fe = dvbdev-priv;
struct dvb_frontend_private *fepriv = fe-frontend_priv;
struct dtv_frontend_properties *c = fe-dtv_property_cache;
-   int cb_err, err = -EOPNOTSUPP;
+   int cb_err, err = -ENOTTY;
 
if (fe-dvb-fe_ioctl_override) {
cb_err = fe-dvb-fe_ioctl_override(fe, cmd, parg,
-- 
1.7.11.2

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html