Re: [PATCH v10 3/4] arm64: dts: rockchip: add VPU device node for RK3399

[Tomasz Figa]

On Thu, Nov 22, 2018 at 4:58 AM Ezequiel Garcia  wrote:
>
> Add the Video Processing Unit node for the RK3399 SoC.
>
> Also, fix the VPU IOMMU node, which was disabled and lacking
> its power domain property.
>
> Signed-off-by: Ezequiel Garcia 
> ---
>  arch/arm64/boot/dts/rockchip/rk3399.dtsi | 14 +-
>  1 file changed, 13 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi 
> b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> index 99e7f65c1779..040d3080565f 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> @@ -1226,6 +1226,18 @@
> status = "disabled";
> };
>
> +   vpu: video-codec@ff65 {
> +   compatible = "rockchip,rk3399-vpu";
> +   reg = <0x0 0xff65 0x0 0x800>;
> +   interrupts = ,
> +;
> +   interrupt-names = "vepu", "vdpu";
> +   clocks = < ACLK_VCODEC>, < HCLK_VCODEC>;
> +   clock-names = "aclk", "hclk";
> +   power-domains = < RK3399_PD_VCODEC>;
> +   iommus = <_mmu>;
> +   };
> +
> vpu_mmu: iommu@ff650800 {
> compatible = "rockchip,iommu";
> reg = <0x0 0xff650800 0x0 0x40>;
> @@ -1233,8 +1245,8 @@
> interrupt-names = "vpu_mmu";
> clocks = < ACLK_VCODEC>, < HCLK_VCODEC>;
> clock-names = "aclk", "iface";
> +   power-domains = < RK3399_PD_VCODEC>;
> #iommu-cells = <0>;
> -   status = "disabled";
> };
>
> vdec_mmu: iommu@ff660480 {


Reviewed-by: Tomasz Figa 

Best regards,
Tomasz

[PATCH v10 3/4] arm64: dts: rockchip: add VPU device node for RK3399

[Ezequiel Garcia]

Add the Video Processing Unit node for the RK3399 SoC.

Also, fix the VPU IOMMU node, which was disabled and lacking
its power domain property.

Signed-off-by: Ezequiel Garcia 
---
 arch/arm64/boot/dts/rockchip/rk3399.dtsi | 14 +-
 1 file changed, 13 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi 
b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
index 99e7f65c1779..040d3080565f 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
@@ -1226,6 +1226,18 @@
status = "disabled";
};
 
+   vpu: video-codec@ff65 {
+   compatible = "rockchip,rk3399-vpu";
+   reg = <0x0 0xff65 0x0 0x800>;
+   interrupts = ,
+;
+   interrupt-names = "vepu", "vdpu";
+   clocks = < ACLK_VCODEC>, < HCLK_VCODEC>;
+   clock-names = "aclk", "hclk";
+   power-domains = < RK3399_PD_VCODEC>;
+   iommus = <_mmu>;
+   };
+
vpu_mmu: iommu@ff650800 {
compatible = "rockchip,iommu";
reg = <0x0 0xff650800 0x0 0x40>;
@@ -1233,8 +1245,8 @@
interrupt-names = "vpu_mmu";
clocks = < ACLK_VCODEC>, < HCLK_VCODEC>;
clock-names = "aclk", "iface";
+   power-domains = < RK3399_PD_VCODEC>;
#iommu-cells = <0>;
-   status = "disabled";
};
 
vdec_mmu: iommu@ff660480 {
-- 
2.19.1