Re: [PATCH v16 11/32] omap3isp: Fix check for our own sub-devices

2017-10-27 Thread Sebastian Reichel
Hi,

On Thu, Oct 26, 2017 at 10:53:21AM +0300, Sakari Ailus wrote:
> We only want to link sub-devices that were bound to the async notifier the
> isp driver registered but there may be other sub-devices in the
> v4l2_device as well. Check for the correct async notifier.
> 
> Signed-off-by: Sakari Ailus 
> Acked-by: Hans Verkuil 
> Acked-by: Pavel Machek 
> ---

Reviewed-by: Sebastian Reichel 

-- Sebastian

>  drivers/media/platform/omap3isp/isp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/platform/omap3isp/isp.c 
> b/drivers/media/platform/omap3isp/isp.c
> index 97a5206b6ddc..4afd7ba4fad6 100644
> --- a/drivers/media/platform/omap3isp/isp.c
> +++ b/drivers/media/platform/omap3isp/isp.c
> @@ -2155,7 +2155,7 @@ static int isp_subdev_notifier_complete(struct 
> v4l2_async_notifier *async)
>   return ret;
>  
>   list_for_each_entry(sd, &v4l2_dev->subdevs, list) {
> - if (!sd->asd)
> + if (sd->notifier != &isp->notifier)
>   continue;
>  
>   ret = isp_link_entity(isp, &sd->entity,
> -- 
> 2.11.0
> 


signature.asc
Description: PGP signature


[PATCH v16 11/32] omap3isp: Fix check for our own sub-devices

2017-10-26 Thread Sakari Ailus
We only want to link sub-devices that were bound to the async notifier the
isp driver registered but there may be other sub-devices in the
v4l2_device as well. Check for the correct async notifier.

Signed-off-by: Sakari Ailus 
Acked-by: Hans Verkuil 
Acked-by: Pavel Machek 
---
 drivers/media/platform/omap3isp/isp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/platform/omap3isp/isp.c 
b/drivers/media/platform/omap3isp/isp.c
index 97a5206b6ddc..4afd7ba4fad6 100644
--- a/drivers/media/platform/omap3isp/isp.c
+++ b/drivers/media/platform/omap3isp/isp.c
@@ -2155,7 +2155,7 @@ static int isp_subdev_notifier_complete(struct 
v4l2_async_notifier *async)
return ret;
 
list_for_each_entry(sd, &v4l2_dev->subdevs, list) {
-   if (!sd->asd)
+   if (sd->notifier != &isp->notifier)
continue;
 
ret = isp_link_entity(isp, &sd->entity,
-- 
2.11.0