Re: [PATCH v2] media: soc_camera: rcar_vin: Add r8a7794, r8a7793 device support
On Fri, Oct 17, 2014 at 11:01:07AM +0300, Laurent Pinchart wrote:
> Hi Kaneko-san,
>
> Thank you for the patch.
>
> Could you please also update
> Documentation/devicetree/bindings/media/rcar_vin.txt with the new compatible
> strings ?
Hi Laurent,
thanks for pointing that out. It is true that we want DT support for the
new SoCs for this driver and in that case updating the bindings
documentation would be necessary. However, this patch adds platform device
support.
What I suggest is dropping this patch for now and working on
a replacement that adds DT support only. I do not believe there
are any plans to use a platform device in mainline for this driver on the
new SoCs.
> On Friday 17 October 2014 16:07:39 Yoshihiro Kaneko wrote:
> > From: Koji Matsuoka
> >
> > Signed-off-by: Koji Matsuoka
> > Signed-off-by: Yoshihiro Kaneko
> > Acked-by: Simon Horman
> >
> > ---
> >
> > This patch is against master branch of linuxtv.org/media_tree.git.
> >
> > v2 [Yoshihiro Kaneko]
> > * Squashed r8a7793 and r8a7794 patches
> >
> > drivers/media/platform/soc_camera/rcar_vin.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/media/platform/soc_camera/rcar_vin.c
> > b/drivers/media/platform/soc_camera/rcar_vin.c index 234cf86..4acae8f
> > 100644
> > --- a/drivers/media/platform/soc_camera/rcar_vin.c
> > +++ b/drivers/media/platform/soc_camera/rcar_vin.c
> > @@ -1881,6 +1881,8 @@ MODULE_DEVICE_TABLE(of, rcar_vin_of_table);
> > #endif
> >
> > static struct platform_device_id rcar_vin_id_table[] = {
> > + { "r8a7794-vin", RCAR_GEN2 },
> > + { "r8a7793-vin", RCAR_GEN2 },
> > { "r8a7791-vin", RCAR_GEN2 },
> > { "r8a7790-vin", RCAR_GEN2 },
> > { "r8a7779-vin", RCAR_H1 },
>
> --
> Regards,
>
> Laurent Pinchart
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2] media: soc_camera: rcar_vin: Add r8a7794, r8a7793 device support
Hi Kaneko-san,
Thank you for the patch.
Could you please also update
Documentation/devicetree/bindings/media/rcar_vin.txt with the new compatible
strings ?
On Friday 17 October 2014 16:07:39 Yoshihiro Kaneko wrote:
> From: Koji Matsuoka
>
> Signed-off-by: Koji Matsuoka
> Signed-off-by: Yoshihiro Kaneko
> Acked-by: Simon Horman
>
> ---
>
> This patch is against master branch of linuxtv.org/media_tree.git.
>
> v2 [Yoshihiro Kaneko]
> * Squashed r8a7793 and r8a7794 patches
>
> drivers/media/platform/soc_camera/rcar_vin.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/media/platform/soc_camera/rcar_vin.c
> b/drivers/media/platform/soc_camera/rcar_vin.c index 234cf86..4acae8f
> 100644
> --- a/drivers/media/platform/soc_camera/rcar_vin.c
> +++ b/drivers/media/platform/soc_camera/rcar_vin.c
> @@ -1881,6 +1881,8 @@ MODULE_DEVICE_TABLE(of, rcar_vin_of_table);
> #endif
>
> static struct platform_device_id rcar_vin_id_table[] = {
> + { "r8a7794-vin", RCAR_GEN2 },
> + { "r8a7793-vin", RCAR_GEN2 },
> { "r8a7791-vin", RCAR_GEN2 },
> { "r8a7790-vin", RCAR_GEN2 },
> { "r8a7779-vin", RCAR_H1 },
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH v2] media: soc_camera: rcar_vin: Add r8a7794, r8a7793 device support
From: Koji Matsuoka
Signed-off-by: Koji Matsuoka
Signed-off-by: Yoshihiro Kaneko
Acked-by: Simon Horman
---
This patch is against master branch of linuxtv.org/media_tree.git.
v2 [Yoshihiro Kaneko]
* Squashed r8a7793 and r8a7794 patches
drivers/media/platform/soc_camera/rcar_vin.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/media/platform/soc_camera/rcar_vin.c
b/drivers/media/platform/soc_camera/rcar_vin.c
index 234cf86..4acae8f 100644
--- a/drivers/media/platform/soc_camera/rcar_vin.c
+++ b/drivers/media/platform/soc_camera/rcar_vin.c
@@ -1881,6 +1881,8 @@ MODULE_DEVICE_TABLE(of, rcar_vin_of_table);
#endif
static struct platform_device_id rcar_vin_id_table[] = {
+ { "r8a7794-vin", RCAR_GEN2 },
+ { "r8a7793-vin", RCAR_GEN2 },
{ "r8a7791-vin", RCAR_GEN2 },
{ "r8a7790-vin", RCAR_GEN2 },
{ "r8a7779-vin", RCAR_H1 },
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
