Re: [PATCH v2 05/19] media: fsl-viu: allow building it with COMPILE_TEST
Hi Mauro, I love your patch! Perhaps something to improve: [auto build test WARNING on linuxtv-media/master] [also build test WARNING on v4.16 next-20180406] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Mauro-Carvalho-Chehab/Make-all-media-drivers-build-with-COMPILE_TEST/20180406-163048 base: git://linuxtv.org/media_tree.git master config: x86_64-allmodconfig (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All warnings (new ones prefixed by >>): drivers/media/platform/fsl-viu.c:1081:25: sparse: incorrect type in argument 2 (different address spaces) drivers/media/platform/fsl-viu.c:1081:25:expected void volatile [noderef] *addr drivers/media/platform/fsl-viu.c:1081:25:got unsigned int * drivers/media/platform/fsl-viu.c:1082:25: sparse: incorrect type in argument 2 (different address spaces) drivers/media/platform/fsl-viu.c:1082:25:expected void volatile [noderef] *addr drivers/media/platform/fsl-viu.c:1082:25:got unsigned int * drivers/media/platform/fsl-viu.c:1083:25: sparse: incorrect type in argument 2 (different address spaces) drivers/media/platform/fsl-viu.c:1083:25:expected void volatile [noderef] *addr drivers/media/platform/fsl-viu.c:1083:25:got unsigned int * drivers/media/platform/fsl-viu.c:1095:17: sparse: incorrect type in argument 1 (different address spaces) drivers/media/platform/fsl-viu.c:1095:17:expected void const volatile [noderef] *addr drivers/media/platform/fsl-viu.c:1095:17:got unsigned int * drivers/media/platform/fsl-viu.c:446:9: sparse: incorrect type in argument 2 (different address spaces) drivers/media/platform/fsl-viu.c:446:9:expected void volatile [noderef] *addr drivers/media/platform/fsl-viu.c:446:9:got unsigned int * drivers/media/platform/fsl-viu.c:447:9: sparse: incorrect type in argument 2 (different address spaces) drivers/media/platform/fsl-viu.c:447:9:expected void volatile [noderef] *addr drivers/media/platform/fsl-viu.c:447:9:got unsigned int * drivers/media/platform/fsl-viu.c:448:9: sparse: incorrect type in argument 2 (different address spaces) drivers/media/platform/fsl-viu.c:448:9:expected void volatile [noderef] *addr drivers/media/platform/fsl-viu.c:448:9:got unsigned int * drivers/media/platform/fsl-viu.c:446:9: sparse: incorrect type in argument 2 (different address spaces) drivers/media/platform/fsl-viu.c:446:9:expected void volatile [noderef] *addr drivers/media/platform/fsl-viu.c:446:9:got unsigned int * drivers/media/platform/fsl-viu.c:447:9: sparse: incorrect type in argument 2 (different address spaces) drivers/media/platform/fsl-viu.c:447:9:expected void volatile [noderef] *addr drivers/media/platform/fsl-viu.c:447:9:got unsigned int * drivers/media/platform/fsl-viu.c:448:9: sparse: incorrect type in argument 2 (different address spaces) drivers/media/platform/fsl-viu.c:448:9:expected void volatile [noderef] *addr drivers/media/platform/fsl-viu.c:448:9:got unsigned int * drivers/media/platform/fsl-viu.c:1000:9: sparse: incorrect type in argument 2 (different address spaces) drivers/media/platform/fsl-viu.c:1000:9:expected void volatile [noderef] *addr drivers/media/platform/fsl-viu.c:1000:9:got unsigned int * drivers/media/platform/fsl-viu.c:1001:9: sparse: incorrect type in argument 2 (different address spaces) drivers/media/platform/fsl-viu.c:1001:9:expected void volatile [noderef] *addr drivers/media/platform/fsl-viu.c:1001:9:got unsigned int * drivers/media/platform/fsl-viu.c:1002:9: sparse: incorrect type in argument 2 (different address spaces) drivers/media/platform/fsl-viu.c:1002:9:expected void volatile [noderef] *addr drivers/media/platform/fsl-viu.c:1002:9:got unsigned int * drivers/media/platform/fsl-viu.c:1003:9: sparse: incorrect type in argument 2 (different address spaces) drivers/media/platform/fsl-viu.c:1003:9:expected void volatile [noderef] *addr drivers/media/platform/fsl-viu.c:1003:9:got unsigned int * drivers/media/platform/fsl-viu.c:1004:9: sparse: incorrect type in argument 2 (different address spaces) drivers/media/platform/fsl-viu.c:1004:9:expected void volatile [noderef] *addr drivers/media/platform/fsl-viu.c:1004:9:got unsigned int * drivers/media/platform/fsl-viu.c:1005:9: sparse: incorrect type in argument 2 (different address spaces) drivers/media/platform/fsl-viu.c:1005:9:expected void volatile [noderef] *addr drivers/media/platform/fsl-viu.c:1005:9:got unsigned int * drivers/media/platform/fsl-viu.c:1006:9: sparse: incorrect type in argument 1 (different address spaces)
Re: [PATCH v2 05/19] media: fsl-viu: allow building it with COMPILE_TEST
Hi Mauro, I love your patch! Perhaps something to improve: [auto build test WARNING on linuxtv-media/master] [also build test WARNING on v4.16 next-20180406] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Mauro-Carvalho-Chehab/Make-all-media-drivers-build-with-COMPILE_TEST/20180406-163048 base: git://linuxtv.org/media_tree.git master config: sparc64-allyesconfig (attached as .config) compiler: sparc64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=sparc64 All warnings (new ones prefixed by >>): >> drivers/media/platform/fsl-viu.c:41:0: warning: "NO_IRQ" redefined #define NO_IRQ 0 In file included from arch/sparc/include/asm/irq.h:5:0, from include/linux/interrupt.h:19, from drivers/media/platform/fsl-viu.c:22: arch/sparc/include/asm/irq_64.h:98:0: note: this is the location of the previous definition #define NO_IRQ 0x drivers/media/platform/fsl-viu.c: In function 'viu_setup_preview': drivers/media/platform/fsl-viu.c:760:28: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] reg_val.field_base_addr = (u32)dev->ovbuf.base; ^ vim +/NO_IRQ +41 drivers/media/platform/fsl-viu.c 38 39 /* Allow building this driver with COMPILE_TEST */ 40 #ifndef CONFIG_PPC_MPC512x > 41 #define NO_IRQ 0 42 --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
[PATCH v2 05/19] media: fsl-viu: allow building it with COMPILE_TEST
There aren't many things that would be needed to allow it to build with compile test. Add the needed bits. Signed-off-by: Mauro Carvalho Chehab--- drivers/media/platform/Kconfig | 2 +- drivers/media/platform/fsl-viu.c | 8 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig index 03c9dfeb7781..e6eb1eb776e1 100644 --- a/drivers/media/platform/Kconfig +++ b/drivers/media/platform/Kconfig @@ -42,7 +42,7 @@ config VIDEO_SH_VOU config VIDEO_VIU tristate "Freescale VIU Video Driver" - depends on VIDEO_V4L2 && PPC_MPC512x + depends on VIDEO_V4L2 && (PPC_MPC512x || COMPILE_TEST) select VIDEOBUF_DMA_CONTIG default y ---help--- diff --git a/drivers/media/platform/fsl-viu.c b/drivers/media/platform/fsl-viu.c index 9abe79779659..466053e00378 100644 --- a/drivers/media/platform/fsl-viu.c +++ b/drivers/media/platform/fsl-viu.c @@ -36,6 +36,14 @@ #define DRV_NAME "fsl_viu" #define VIU_VERSION"0.5.1" +/* Allow building this driver with COMPILE_TEST */ +#ifndef CONFIG_PPC_MPC512x +#define NO_IRQ 0 + +#define out_be32(v, a) writel(a, v) +#define in_be32(a) readl(a) +#endif + #define BUFFER_TIMEOUT msecs_to_jiffies(500) /* 0.5 seconds */ #defineVIU_VID_MEM_LIMIT 4 /* Video memory limit, in Mb */ -- 2.14.3