Re: [PATCH v2 06/48] v4l: Add pad-level DV timings subdev operations
Reviewed-by: Hans Verkuil
On 03/11/14 00:15, Laurent Pinchart wrote:
> Signed-off-by: Laurent Pinchart
> ---
> include/media/v4l2-subdev.h| 4
> include/uapi/linux/videodev2.h | 10 --
> 2 files changed, 12 insertions(+), 2 deletions(-)
>
> diff --git a/include/media/v4l2-subdev.h b/include/media/v4l2-subdev.h
> index 1752530..2b5ec32 100644
> --- a/include/media/v4l2-subdev.h
> +++ b/include/media/v4l2-subdev.h
> @@ -509,6 +509,10 @@ struct v4l2_subdev_pad_ops {
>struct v4l2_subdev_selection *sel);
> int (*get_edid)(struct v4l2_subdev *sd, struct v4l2_subdev_edid *edid);
> int (*set_edid)(struct v4l2_subdev *sd, struct v4l2_subdev_edid *edid);
> + int (*dv_timings_cap)(struct v4l2_subdev *sd,
> + struct v4l2_dv_timings_cap *cap);
> + int (*enum_dv_timings)(struct v4l2_subdev *sd,
> +struct v4l2_enum_dv_timings *timings);
> #ifdef CONFIG_MEDIA_CONTROLLER
> int (*link_validate)(struct v4l2_subdev *sd, struct media_link *link,
>struct v4l2_subdev_format *source_fmt,
> diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h
> index 17acba8..72fbbd4 100644
> --- a/include/uapi/linux/videodev2.h
> +++ b/include/uapi/linux/videodev2.h
> @@ -1103,12 +1103,15 @@ struct v4l2_dv_timings {
>
> /** struct v4l2_enum_dv_timings - DV timings enumeration
> * @index: enumeration index
> + * @pad: the pad number for which to enumerate timings (used with
> + * v4l-subdev nodes only)
> * @reserved:must be zeroed
> * @timings: the timings for the given index
> */
> struct v4l2_enum_dv_timings {
> __u32 index;
> - __u32 reserved[3];
> + __u32 pad;
> + __u32 reserved[2];
> struct v4l2_dv_timings timings;
> };
>
> @@ -1146,11 +1149,14 @@ struct v4l2_bt_timings_cap {
>
> /** struct v4l2_dv_timings_cap - DV timings capabilities
> * @type:the type of the timings (same as in struct v4l2_dv_timings)
> + * @pad: the pad number for which to query capabilities (used with
> + * v4l-subdev nodes only)
> * @bt: the BT656/1120 timings capabilities
> */
> struct v4l2_dv_timings_cap {
> __u32 type;
> - __u32 reserved[3];
> + __u32 pad;
> + __u32 reserved[2];
> union {
> struct v4l2_bt_timings_cap bt;
> __u32 raw_data[32];
>
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 06/48] v4l: Add pad-level DV timings subdev operations
On Tue, Mar 11, 2014 at 4:45 AM, Laurent Pinchart
wrote:
> Signed-off-by: Laurent Pinchart
Acked-by: Lad, Prabhakar
Regards,
--Prabhakar lad
> ---
> include/media/v4l2-subdev.h| 4
> include/uapi/linux/videodev2.h | 10 --
> 2 files changed, 12 insertions(+), 2 deletions(-)
>
> diff --git a/include/media/v4l2-subdev.h b/include/media/v4l2-subdev.h
> index 1752530..2b5ec32 100644
> --- a/include/media/v4l2-subdev.h
> +++ b/include/media/v4l2-subdev.h
> @@ -509,6 +509,10 @@ struct v4l2_subdev_pad_ops {
> struct v4l2_subdev_selection *sel);
> int (*get_edid)(struct v4l2_subdev *sd, struct v4l2_subdev_edid
> *edid);
> int (*set_edid)(struct v4l2_subdev *sd, struct v4l2_subdev_edid
> *edid);
> + int (*dv_timings_cap)(struct v4l2_subdev *sd,
> + struct v4l2_dv_timings_cap *cap);
> + int (*enum_dv_timings)(struct v4l2_subdev *sd,
> + struct v4l2_enum_dv_timings *timings);
> #ifdef CONFIG_MEDIA_CONTROLLER
> int (*link_validate)(struct v4l2_subdev *sd, struct media_link *link,
> struct v4l2_subdev_format *source_fmt,
> diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h
> index 17acba8..72fbbd4 100644
> --- a/include/uapi/linux/videodev2.h
> +++ b/include/uapi/linux/videodev2.h
> @@ -1103,12 +1103,15 @@ struct v4l2_dv_timings {
>
> /** struct v4l2_enum_dv_timings - DV timings enumeration
> * @index: enumeration index
> + * @pad: the pad number for which to enumerate timings (used with
> + * v4l-subdev nodes only)
> * @reserved: must be zeroed
> * @timings: the timings for the given index
> */
> struct v4l2_enum_dv_timings {
> __u32 index;
> - __u32 reserved[3];
> + __u32 pad;
> + __u32 reserved[2];
> struct v4l2_dv_timings timings;
> };
>
> @@ -1146,11 +1149,14 @@ struct v4l2_bt_timings_cap {
>
> /** struct v4l2_dv_timings_cap - DV timings capabilities
> * @type: the type of the timings (same as in struct v4l2_dv_timings)
> + * @pad: the pad number for which to query capabilities (used with
> + * v4l-subdev nodes only)
> * @bt:the BT656/1120 timings capabilities
> */
> struct v4l2_dv_timings_cap {
> __u32 type;
> - __u32 reserved[3];
> + __u32 pad;
> + __u32 reserved[2];
> union {
> struct v4l2_bt_timings_cap bt;
> __u32 raw_data[32];
> --
> 1.8.3.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH v2 06/48] v4l: Add pad-level DV timings subdev operations
Signed-off-by: Laurent Pinchart
---
include/media/v4l2-subdev.h| 4
include/uapi/linux/videodev2.h | 10 --
2 files changed, 12 insertions(+), 2 deletions(-)
diff --git a/include/media/v4l2-subdev.h b/include/media/v4l2-subdev.h
index 1752530..2b5ec32 100644
--- a/include/media/v4l2-subdev.h
+++ b/include/media/v4l2-subdev.h
@@ -509,6 +509,10 @@ struct v4l2_subdev_pad_ops {
struct v4l2_subdev_selection *sel);
int (*get_edid)(struct v4l2_subdev *sd, struct v4l2_subdev_edid *edid);
int (*set_edid)(struct v4l2_subdev *sd, struct v4l2_subdev_edid *edid);
+ int (*dv_timings_cap)(struct v4l2_subdev *sd,
+ struct v4l2_dv_timings_cap *cap);
+ int (*enum_dv_timings)(struct v4l2_subdev *sd,
+ struct v4l2_enum_dv_timings *timings);
#ifdef CONFIG_MEDIA_CONTROLLER
int (*link_validate)(struct v4l2_subdev *sd, struct media_link *link,
struct v4l2_subdev_format *source_fmt,
diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h
index 17acba8..72fbbd4 100644
--- a/include/uapi/linux/videodev2.h
+++ b/include/uapi/linux/videodev2.h
@@ -1103,12 +1103,15 @@ struct v4l2_dv_timings {
/** struct v4l2_enum_dv_timings - DV timings enumeration
* @index: enumeration index
+ * @pad: the pad number for which to enumerate timings (used with
+ * v4l-subdev nodes only)
* @reserved: must be zeroed
* @timings: the timings for the given index
*/
struct v4l2_enum_dv_timings {
__u32 index;
- __u32 reserved[3];
+ __u32 pad;
+ __u32 reserved[2];
struct v4l2_dv_timings timings;
};
@@ -1146,11 +1149,14 @@ struct v4l2_bt_timings_cap {
/** struct v4l2_dv_timings_cap - DV timings capabilities
* @type: the type of the timings (same as in struct v4l2_dv_timings)
+ * @pad: the pad number for which to query capabilities (used with
+ * v4l-subdev nodes only)
* @bt:the BT656/1120 timings capabilities
*/
struct v4l2_dv_timings_cap {
__u32 type;
- __u32 reserved[3];
+ __u32 pad;
+ __u32 reserved[2];
union {
struct v4l2_bt_timings_cap bt;
__u32 raw_data[32];
--
1.8.3.2
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
