Re: [PATCH v2 1/8] v4l: vsp1: Use SPDX license headers

[Laurent Pinchart]

Hi Kieran,

On Saturday, 28 April 2018 00:25:51 EEST Kieran Bingham wrote:
> Hi Laurent,
> 
> Thank you for the patch, and going through the whole driver for this update.
> On 22/04/18 23:34, Laurent Pinchart wrote:
> > Adopt the SPDX license identifier headers to ease license compliance
> > management. All files in the driver are licensed under the GPLv2+ except
> > for the vsp1_regs.h file which is licensed under the GPLv2. This is
> > likely an oversight, but fixing this requires contacting the copyright
> > owners and is out of scope for this patch.
> 
> I agree that's out of scope for this patch, but it's not too exhaustive a
> list to correct at a later date:
> 
> git shortlog -e -n -s -- ./drivers/media/platform/vsp1/vsp1_regs.h
> 19  Laurent Pinchart 
>  5  Nobuhiro Iwamatsu 
>  3  Kieran Bingham 
>  2  Geert Uytterhoeven 
>  2  Sergei Shtylyov 
>  1  Linus Torvalds 
>  1  Niklas Söderlund 
>  1  Wolfram Sang 
> 
> (Both Geert and Linus are merge commits there)

I agree with you, I've sent a separate patch.

> > While at it fix the file descriptions to match file names where copy and
> > paste error occurred.
> > 
> > Signed-off-by: Laurent Pinchart
> > 
> 
> It's crazy that we have two types of comment style for the SPDX identifier -
> but that's not a fault in this patch, so:
> 
> Reviewed-by: Kieran Bingham 
> 
> > ---
> > 
> >  drivers/media/platform/vsp1/vsp1.h| 6 +-
> >  drivers/media/platform/vsp1/vsp1_brx.c| 6 +-
> >  drivers/media/platform/vsp1/vsp1_brx.h| 6 +-
> >  drivers/media/platform/vsp1/vsp1_clu.c| 6 +-
> >  drivers/media/platform/vsp1/vsp1_clu.h| 6 +-
> >  drivers/media/platform/vsp1/vsp1_dl.c | 8 ++--
> >  drivers/media/platform/vsp1/vsp1_dl.h | 6 +-
> >  drivers/media/platform/vsp1/vsp1_drm.c| 8 ++--
> >  drivers/media/platform/vsp1/vsp1_drm.h| 6 +-
> >  drivers/media/platform/vsp1/vsp1_drv.c| 6 +-
> >  drivers/media/platform/vsp1/vsp1_entity.c | 6 +-
> >  drivers/media/platform/vsp1/vsp1_entity.h | 6 +-
> >  drivers/media/platform/vsp1/vsp1_hgo.c| 6 +-
> >  drivers/media/platform/vsp1/vsp1_hgo.h| 6 +-
> >  drivers/media/platform/vsp1/vsp1_hgt.c| 6 +-
> >  drivers/media/platform/vsp1/vsp1_hgt.h| 6 +-
> >  drivers/media/platform/vsp1/vsp1_histo.c  | 6 +-
> >  drivers/media/platform/vsp1/vsp1_histo.h  | 6 +-
> >  drivers/media/platform/vsp1/vsp1_hsit.c   | 6 +-
> >  drivers/media/platform/vsp1/vsp1_hsit.h   | 6 +-
> >  drivers/media/platform/vsp1/vsp1_lif.c| 6 +-
> >  drivers/media/platform/vsp1/vsp1_lif.h| 6 +-
> >  drivers/media/platform/vsp1/vsp1_lut.c| 6 +-
> >  drivers/media/platform/vsp1/vsp1_lut.h| 6 +-
> >  drivers/media/platform/vsp1/vsp1_pipe.c   | 6 +-
> >  drivers/media/platform/vsp1/vsp1_pipe.h   | 6 +-
> >  drivers/media/platform/vsp1/vsp1_regs.h   | 5 +
> >  drivers/media/platform/vsp1/vsp1_rpf.c| 6 +-
> >  drivers/media/platform/vsp1/vsp1_rwpf.c   | 6 +-
> >  drivers/media/platform/vsp1/vsp1_rwpf.h   | 6 +-
> >  drivers/media/platform/vsp1/vsp1_sru.c| 6 +-
> >  drivers/media/platform/vsp1/vsp1_sru.h| 6 +-
> >  drivers/media/platform/vsp1/vsp1_uds.c| 6 +-
> >  drivers/media/platform/vsp1/vsp1_uds.h| 6 +-
> >  drivers/media/platform/vsp1/vsp1_video.c  | 6 +-
> >  drivers/media/platform/vsp1/vsp1_video.h  | 6 +-
> >  drivers/media/platform/vsp1/vsp1_wpf.c| 6 +-
> >  37 files changed, 39 insertions(+), 186 deletions(-)

-- 
Regards,

Laurent Pinchart

Re: [PATCH v2 1/8] v4l: vsp1: Use SPDX license headers

[Kieran Bingham]

Hi Laurent,

Thank you for the patch, and going through the whole driver for this update.

On 22/04/18 23:34, Laurent Pinchart wrote:
> Adopt the SPDX license identifier headers to ease license compliance
> management. All files in the driver are licensed under the GPLv2+ except
> for the vsp1_regs.h file which is licensed under the GPLv2. This is
> likely an oversight, but fixing this requires contacting the copyright
> owners and is out of scope for this patch.

I agree that's out of scope for this patch, but it's not too exhaustive a list
to correct at a later date:

git shortlog -e -n -s -- ./drivers/media/platform/vsp1/vsp1_regs.h
19  Laurent Pinchart 
 5  Nobuhiro Iwamatsu 
 3  Kieran Bingham 
 2  Geert Uytterhoeven 
 2  Sergei Shtylyov 
 1  Linus Torvalds 
 1  Niklas Söderlund 
 1  Wolfram Sang 

(Both Geert and Linus are merge commits there)

> While at it fix the file descriptions to match file names where copy and
> paste error occurred.
> 
> Signed-off-by: Laurent Pinchart 

It's crazy that we have two types of comment style for the SPDX identifier - but
that's not a fault in this patch, so:

Reviewed-by: Kieran Bingham 

> ---
>  drivers/media/platform/vsp1/vsp1.h| 6 +-
>  drivers/media/platform/vsp1/vsp1_brx.c| 6 +-
>  drivers/media/platform/vsp1/vsp1_brx.h| 6 +-
>  drivers/media/platform/vsp1/vsp1_clu.c| 6 +-
>  drivers/media/platform/vsp1/vsp1_clu.h| 6 +-
>  drivers/media/platform/vsp1/vsp1_dl.c | 8 ++--
>  drivers/media/platform/vsp1/vsp1_dl.h | 6 +-
>  drivers/media/platform/vsp1/vsp1_drm.c| 8 ++--
>  drivers/media/platform/vsp1/vsp1_drm.h| 6 +-
>  drivers/media/platform/vsp1/vsp1_drv.c| 6 +-
>  drivers/media/platform/vsp1/vsp1_entity.c | 6 +-
>  drivers/media/platform/vsp1/vsp1_entity.h | 6 +-
>  drivers/media/platform/vsp1/vsp1_hgo.c| 6 +-
>  drivers/media/platform/vsp1/vsp1_hgo.h| 6 +-
>  drivers/media/platform/vsp1/vsp1_hgt.c| 6 +-
>  drivers/media/platform/vsp1/vsp1_hgt.h| 6 +-
>  drivers/media/platform/vsp1/vsp1_histo.c  | 6 +-
>  drivers/media/platform/vsp1/vsp1_histo.h  | 6 +-
>  drivers/media/platform/vsp1/vsp1_hsit.c   | 6 +-
>  drivers/media/platform/vsp1/vsp1_hsit.h   | 6 +-
>  drivers/media/platform/vsp1/vsp1_lif.c| 6 +-
>  drivers/media/platform/vsp1/vsp1_lif.h| 6 +-
>  drivers/media/platform/vsp1/vsp1_lut.c| 6 +-
>  drivers/media/platform/vsp1/vsp1_lut.h| 6 +-
>  drivers/media/platform/vsp1/vsp1_pipe.c   | 6 +-
>  drivers/media/platform/vsp1/vsp1_pipe.h   | 6 +-
>  drivers/media/platform/vsp1/vsp1_regs.h   | 5 +
>  drivers/media/platform/vsp1/vsp1_rpf.c| 6 +-
>  drivers/media/platform/vsp1/vsp1_rwpf.c   | 6 +-
>  drivers/media/platform/vsp1/vsp1_rwpf.h   | 6 +-
>  drivers/media/platform/vsp1/vsp1_sru.c| 6 +-
>  drivers/media/platform/vsp1/vsp1_sru.h| 6 +-
>  drivers/media/platform/vsp1/vsp1_uds.c| 6 +-
>  drivers/media/platform/vsp1/vsp1_uds.h| 6 +-
>  drivers/media/platform/vsp1/vsp1_video.c  | 6 +-
>  drivers/media/platform/vsp1/vsp1_video.h  | 6 +-
>  drivers/media/platform/vsp1/vsp1_wpf.c| 6 +-
>  37 files changed, 39 insertions(+), 186 deletions(-)
> 
> diff --git a/drivers/media/platform/vsp1/vsp1.h 
> b/drivers/media/platform/vsp1/vsp1.h
> index 894cc725c2d4..9cf4e1c4b036 100644
> --- a/drivers/media/platform/vsp1/vsp1.h
> +++ b/drivers/media/platform/vsp1/vsp1.h
> @@ -1,14 +1,10 @@
> +/* SPDX-License-Identifier: GPL-2.0+ */
>  /*
>   * vsp1.h  --  R-Car VSP1 Driver
>   *
>   * Copyright (C) 2013-2014 Renesas Electronics Corporation
>   *
>   * Contact: Laurent Pinchart (laurent.pinch...@ideasonboard.com)
> - *
> - * This program is free software; you can redistribute it and/or modify
> - * it under the terms of the GNU General Public License as published by
> - * the Free Software Foundation; either version 2 of the License, or
> - * (at your option) any later version.
>   */
>  #ifndef __VSP1_H__
>  #define __VSP1_H__
> diff --git a/drivers/media/platform/vsp1/vsp1_brx.c 
> b/drivers/media/platform/vsp1/vsp1_brx.c
> index b4af1d546022..3beec18fd863 100644
> --- a/drivers/media/platform/vsp1/vsp1_brx.c
> +++ b/drivers/media/platform/vsp1/vsp1_brx.c
> @@ -1,14 +1,10 @@
> +// SPDX-License-Identifier: GPL-2.0+
>  /*
>   * vsp1_brx.c  --  R-Car VSP1 Blend ROP Unit (BRU and BRS)
>   *
>   * Copyright (C) 2013 Renesas Corporation
>   *
>   * Contact: Laurent Pinchart (laurent.pinch...@ideasonboard.com)
> - *
> - * This program is free 

[PATCH v2 1/8] v4l: vsp1: Use SPDX license headers

[Laurent Pinchart]

Adopt the SPDX license identifier headers to ease license compliance
management. All files in the driver are licensed under the GPLv2+ except
for the vsp1_regs.h file which is licensed under the GPLv2. This is
likely an oversight, but fixing this requires contacting the copyright
owners and is out of scope for this patch.

While at it fix the file descriptions to match file names where copy and
paste error occurred.

Signed-off-by: Laurent Pinchart 
---
 drivers/media/platform/vsp1/vsp1.h| 6 +-
 drivers/media/platform/vsp1/vsp1_brx.c| 6 +-
 drivers/media/platform/vsp1/vsp1_brx.h| 6 +-
 drivers/media/platform/vsp1/vsp1_clu.c| 6 +-
 drivers/media/platform/vsp1/vsp1_clu.h| 6 +-
 drivers/media/platform/vsp1/vsp1_dl.c | 8 ++--
 drivers/media/platform/vsp1/vsp1_dl.h | 6 +-
 drivers/media/platform/vsp1/vsp1_drm.c| 8 ++--
 drivers/media/platform/vsp1/vsp1_drm.h| 6 +-
 drivers/media/platform/vsp1/vsp1_drv.c| 6 +-
 drivers/media/platform/vsp1/vsp1_entity.c | 6 +-
 drivers/media/platform/vsp1/vsp1_entity.h | 6 +-
 drivers/media/platform/vsp1/vsp1_hgo.c| 6 +-
 drivers/media/platform/vsp1/vsp1_hgo.h| 6 +-
 drivers/media/platform/vsp1/vsp1_hgt.c| 6 +-
 drivers/media/platform/vsp1/vsp1_hgt.h| 6 +-
 drivers/media/platform/vsp1/vsp1_histo.c  | 6 +-
 drivers/media/platform/vsp1/vsp1_histo.h  | 6 +-
 drivers/media/platform/vsp1/vsp1_hsit.c   | 6 +-
 drivers/media/platform/vsp1/vsp1_hsit.h   | 6 +-
 drivers/media/platform/vsp1/vsp1_lif.c| 6 +-
 drivers/media/platform/vsp1/vsp1_lif.h| 6 +-
 drivers/media/platform/vsp1/vsp1_lut.c| 6 +-
 drivers/media/platform/vsp1/vsp1_lut.h| 6 +-
 drivers/media/platform/vsp1/vsp1_pipe.c   | 6 +-
 drivers/media/platform/vsp1/vsp1_pipe.h   | 6 +-
 drivers/media/platform/vsp1/vsp1_regs.h   | 5 +
 drivers/media/platform/vsp1/vsp1_rpf.c| 6 +-
 drivers/media/platform/vsp1/vsp1_rwpf.c   | 6 +-
 drivers/media/platform/vsp1/vsp1_rwpf.h   | 6 +-
 drivers/media/platform/vsp1/vsp1_sru.c| 6 +-
 drivers/media/platform/vsp1/vsp1_sru.h| 6 +-
 drivers/media/platform/vsp1/vsp1_uds.c| 6 +-
 drivers/media/platform/vsp1/vsp1_uds.h| 6 +-
 drivers/media/platform/vsp1/vsp1_video.c  | 6 +-
 drivers/media/platform/vsp1/vsp1_video.h  | 6 +-
 drivers/media/platform/vsp1/vsp1_wpf.c| 6 +-
 37 files changed, 39 insertions(+), 186 deletions(-)

diff --git a/drivers/media/platform/vsp1/vsp1.h 
b/drivers/media/platform/vsp1/vsp1.h
index 894cc725c2d4..9cf4e1c4b036 100644
--- a/drivers/media/platform/vsp1/vsp1.h
+++ b/drivers/media/platform/vsp1/vsp1.h
@@ -1,14 +1,10 @@
+/* SPDX-License-Identifier: GPL-2.0+ */
 /*
  * vsp1.h  --  R-Car VSP1 Driver
  *
  * Copyright (C) 2013-2014 Renesas Electronics Corporation
  *
  * Contact: Laurent Pinchart (laurent.pinch...@ideasonboard.com)
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
  */
 #ifndef __VSP1_H__
 #define __VSP1_H__
diff --git a/drivers/media/platform/vsp1/vsp1_brx.c 
b/drivers/media/platform/vsp1/vsp1_brx.c
index b4af1d546022..3beec18fd863 100644
--- a/drivers/media/platform/vsp1/vsp1_brx.c
+++ b/drivers/media/platform/vsp1/vsp1_brx.c
@@ -1,14 +1,10 @@
+// SPDX-License-Identifier: GPL-2.0+
 /*
  * vsp1_brx.c  --  R-Car VSP1 Blend ROP Unit (BRU and BRS)
  *
  * Copyright (C) 2013 Renesas Corporation
  *
  * Contact: Laurent Pinchart (laurent.pinch...@ideasonboard.com)
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
  */
 
 #include 
diff --git a/drivers/media/platform/vsp1/vsp1_brx.h 
b/drivers/media/platform/vsp1/vsp1_brx.h
index 927aa4254c0f..6abbb8c3343c 100644
--- a/drivers/media/platform/vsp1/vsp1_brx.h
+++ b/drivers/media/platform/vsp1/vsp1_brx.h
@@ -1,14 +1,10 @@
+/* SPDX-License-Identifier: GPL-2.0+ */
 /*
  * vsp1_brx.h  --  R-Car VSP1 Blend ROP Unit (BRU and BRS)
  *
  * Copyright (C) 2013 Renesas Corporation
  *
  * Contact: Laurent Pinchart (laurent.pinch...@ideasonboard.com)
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
  */
 #ifndef __VSP1_BRX_H__
 #define __VSP1_BRX_H__
diff --git a/drivers/media/platform/vsp1/vsp1_clu.c 
b/drivers/media/platform/vsp1/vsp1_clu.c
index f2fb26e5ab4e..9626b6308585 100644
--- a/drivers/media/platform/vsp1/vsp1_clu.c