Re: [PATCH v2 11/19] media: davinci: allow building isif code

[kbuild test robot]

Hi Mauro,

I love your patch! Perhaps something to improve:

[auto build test WARNING on linuxtv-media/master]
[also build test WARNING on v4.16 next-20180406]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:
https://github.com/0day-ci/linux/commits/Mauro-Carvalho-Chehab/Make-all-media-drivers-build-with-COMPILE_TEST/20180406-163048
base:   git://linuxtv.org/media_tree.git master
reproduce:
# apt-get install sparse
make ARCH=x86_64 allmodconfig
make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

>> drivers/media/platform/davinci/isif.c:1066:22: sparse: incorrect type in 
>> assignment (different address spaces) @@expected void *[noderef] 
>> addr @@got void *[noderef] addr @@
   drivers/media/platform/davinci/isif.c:1066:22:expected void *[noderef] 
addr
   drivers/media/platform/davinci/isif.c:1066:22:got void [noderef] *
>> drivers/media/platform/davinci/isif.c:1074:44: sparse: incorrect type in 
>> assignment (different address spaces) @@expected void [noderef] 
>> *static [toplevel] [assigned] base_addr @@got  [toplevel] 
>> [assigned] base_addr @@
   drivers/media/platform/davinci/isif.c:1074:44:expected void [noderef] 
*static [toplevel] [assigned] base_addr
   drivers/media/platform/davinci/isif.c:1074:44:got void *[noderef] 
addr
>> drivers/media/platform/davinci/isif.c:1078:51: sparse: incorrect type in 
>> assignment (different address spaces) @@expected void [noderef] 
>> *static [toplevel] [assigned] linear_tbl0_addr @@got  [toplevel] 
>> [assigned] linear_tbl0_addr @@
   drivers/media/platform/davinci/isif.c:1078:51:expected void [noderef] 
*static [toplevel] [assigned] linear_tbl0_addr
   drivers/media/platform/davinci/isif.c:1078:51:got void *[noderef] 
addr
>> drivers/media/platform/davinci/isif.c:1082:51: sparse: incorrect type in 
>> assignment (different address spaces) @@expected void [noderef] 
>> *static [toplevel] [assigned] linear_tbl1_addr @@got  [toplevel] 
>> [assigned] linear_tbl1_addr @@
   drivers/media/platform/davinci/isif.c:1082:51:expected void [noderef] 
*static [toplevel] [assigned] linear_tbl1_addr
   drivers/media/platform/davinci/isif.c:1082:51:got void *[noderef] 
addr
>> drivers/media/platform/davinci/isif.c:1067:22: sparse: dereference of 
>> noderef expression

vim +1066 drivers/media/platform/davinci/isif.c

63e3ab14 drivers/media/video/davinci/isif.cMurali Karicheri   2010-02-21  
1025  
4c62e976 drivers/media/platform/davinci/isif.c Greg Kroah-Hartman 2012-12-21  
1026  static int isif_probe(struct platform_device *pdev)
63e3ab14 drivers/media/video/davinci/isif.cMurali Karicheri   2010-02-21  
1027  {
63e3ab14 drivers/media/video/davinci/isif.cMurali Karicheri   2010-02-21  
1028  void (*setup_pinmux)(void);
63e3ab14 drivers/media/video/davinci/isif.cMurali Karicheri   2010-02-21  
1029  struct resource *res;
63e3ab14 drivers/media/video/davinci/isif.cMurali Karicheri   2010-02-21  
1030  void *__iomem addr;
63e3ab14 drivers/media/video/davinci/isif.cMurali Karicheri   2010-02-21  
1031  int status = 0, i;
63e3ab14 drivers/media/video/davinci/isif.cMurali Karicheri   2010-02-21  
1032  
9a3e89b1 drivers/media/platform/davinci/isif.c Lad, Prabhakar 2013-03-22  
1033  /* Platform data holds setup_pinmux function ptr */
9a3e89b1 drivers/media/platform/davinci/isif.c Lad, Prabhakar 2013-03-22  
1034  if (!pdev->dev.platform_data)
9a3e89b1 drivers/media/platform/davinci/isif.c Lad, Prabhakar 2013-03-22  
1035  return -ENODEV;
9a3e89b1 drivers/media/platform/davinci/isif.c Lad, Prabhakar 2013-03-22  
1036  
63e3ab14 drivers/media/video/davinci/isif.cMurali Karicheri   2010-02-21  
1037  /*
63e3ab14 drivers/media/video/davinci/isif.cMurali Karicheri   2010-02-21  
1038   * first try to register with vpfe. If not correct platform, then we
63e3ab14 drivers/media/video/davinci/isif.cMurali Karicheri   2010-02-21  
1039   * don't have to iomap
63e3ab14 drivers/media/video/davinci/isif.cMurali Karicheri   2010-02-21  
1040   */
63e3ab14 drivers/media/video/davinci/isif.cMurali Karicheri   2010-02-21  
1041  status = vpfe_register_ccdc_device(_hw_dev);
63e3ab14 drivers/media/video/davinci/isif.cMurali Karicheri   2010-02-21  
1042  if (status < 0)
63e3ab14 drivers/media/video/davinci/isif.cMurali Karicheri   2010-02-21  
1043  return status;
63e3ab14 drivers/media/video/davinci/isif.cMurali Karicheri   2010-02-21  
1044  
63e3ab14 drivers/media/video/davinci/isif.cMurali Karicheri   2010-02-21  
1045  setup_pinmux = pdev->dev.platform_data;
63e3ab14 drivers/media/video/davinci/isif.cMurali Karicheri   2010-02-21  
1046  /*
63e3ab14 drivers/media/video/davinci/isif.cMurali Karicheri   2010-02-21  
1047   * setup Mux configuration for 

[PATCH v2 11/19] media: davinci: allow building isif code

[Mauro Carvalho Chehab]

The only reason why this driver doesn't build with COMPILE_TEST
is because it includes mach/mux.h. It turns that none of the
macros defined there are used.

So, get rid of it, in order to allow it to build with
COMPILE_TEST.

Signed-off-by: Mauro Carvalho Chehab 
---
 drivers/media/platform/davinci/Kconfig | 3 ++-
 drivers/media/platform/davinci/isif.c  | 2 --
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/media/platform/davinci/Kconfig 
b/drivers/media/platform/davinci/Kconfig
index 55982e681d77..babdb4877b3f 100644
--- a/drivers/media/platform/davinci/Kconfig
+++ b/drivers/media/platform/davinci/Kconfig
@@ -67,7 +67,8 @@ config VIDEO_DM355_CCDC
 
 config VIDEO_DM365_ISIF
tristate "TI DM365 ISIF video capture driver"
-   depends on VIDEO_V4L2 && ARCH_DAVINCI
+   depends on VIDEO_V4L2
+   depends on ARCH_DAVINCI || COMPILE_TEST
depends on HAS_DMA
depends on I2C
select VIDEOBUF_DMA_CONTIG
diff --git a/drivers/media/platform/davinci/isif.c 
b/drivers/media/platform/davinci/isif.c
index d5ff58494c1e..b14caadcd0df 100644
--- a/drivers/media/platform/davinci/isif.c
+++ b/drivers/media/platform/davinci/isif.c
@@ -31,8 +31,6 @@
 #include 
 #include 
 
-#include 
-
 #include 
 #include 
 
-- 
2.14.3