Re: [PATCH v2 3/5] v4l: Add media format codes for ARGB8888 and AYUV8888 on 32-bit busses

2013-07-25 Thread Laurent Pinchart 
Hi Sylwester,

On Wednesday 24 July 2013 23:26:32 Sylwester Nawrocki wrote:
 On 07/17/2013 04:54 PM, Laurent Pinchart wrote:
  Signed-off-by: Laurent Pinchartlaurent.pinchart+rene...@ideasonboard.com
  
  ---
  
Documentation/DocBook/media/v4l/subdev-formats.xml | 609   ++---
Documentation/DocBook/media_api.tmpl   |   6 +
include/uapi/linux/v4l2-mediabus.h |   6 +-
3 files changed, 254 insertions(+), 367 deletions(-)
  
  diff --git a/Documentation/DocBook/media/v4l/subdev-formats.xml
  b/Documentation/DocBook/media/v4l/subdev-formats.xml index
  0c2b1f2..9100674 100644
  --- a/Documentation/DocBook/media/v4l/subdev-formats.xml
  +++ b/Documentation/DocBook/media/v4l/subdev-formats.xml
  @@ -97,31 +97,39 @@
 
 [...]
 
  +   row id=V4L2-MBUS-FMT-ARGB888-1X24
  +   entryV4L2_MBUS_FMT_ARGB888_1X24/entry
 
 This should be V4L2_MBUS_FMT_ARGB888_1X32, right ?

Oops, indeed.

 
 Fix this correction feel free to add:
 
   Reviewed-by: Sylwester Nawrocki s.nawro...@samsung.com

Thank you.

  +   entry0x100d/entry
  +   entry/entry

-- 
Regards,

Laurent Pinchart

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 3/5] v4l: Add media format codes for ARGB8888 and AYUV8888 on 32-bit busses

2013-07-24 Thread Sylwester Nawrocki 

Hi Laurent,

On 07/17/2013 04:54 PM, Laurent Pinchart wrote:

Signed-off-by: Laurent Pinchartlaurent.pinchart+rene...@ideasonboard.com

---
  Documentation/DocBook/media/v4l/subdev-formats.xml | 609 +
  Documentation/DocBook/media_api.tmpl   |   6 +
  include/uapi/linux/v4l2-mediabus.h |   6 +-
  3 files changed, 254 insertions(+), 367 deletions(-)

diff --git a/Documentation/DocBook/media/v4l/subdev-formats.xml 
b/Documentation/DocBook/media/v4l/subdev-formats.xml
index 0c2b1f2..9100674 100644
--- a/Documentation/DocBook/media/v4l/subdev-formats.xml
+++ b/Documentation/DocBook/media/v4l/subdev-formats.xml
@@ -97,31 +97,39 @@

[...]

+   row id=V4L2-MBUS-FMT-ARGB888-1X24
+   entryV4L2_MBUS_FMT_ARGB888_1X24/entry


This should be V4L2_MBUS_FMT_ARGB888_1X32, right ?

Fix this correction feel free to add:

 Reviewed-by: Sylwester Nawrocki s.nawro...@samsung.com 


+   entry0x100d/entry
+   entry/entry

[...]

diff --git a/include/uapi/linux/v4l2-mediabus.h 
b/include/uapi/linux/v4l2-mediabus.h
index 6ee63d0..a960125 100644
--- a/include/uapi/linux/v4l2-mediabus.h
+++ b/include/uapi/linux/v4l2-mediabus.h
@@ -37,7 +37,7 @@
  enum v4l2_mbus_pixelcode {
V4L2_MBUS_FMT_FIXED = 0x0001,

-   /* RGB - next is 0x100d */
+   /* RGB - next is 0x100e */
V4L2_MBUS_FMT_RGB444_2X8_PADHI_BE = 0x1001,
V4L2_MBUS_FMT_RGB444_2X8_PADHI_LE = 0x1002,
V4L2_MBUS_FMT_RGB555_2X8_PADHI_BE = 0x1003,
@@ -50,8 +50,9 @@ enum v4l2_mbus_pixelcode {
V4L2_MBUS_FMT_RGB888_1X24 = 0x100a,
V4L2_MBUS_FMT_RGB888_2X12_BE = 0x100b,
V4L2_MBUS_FMT_RGB888_2X12_LE = 0x100c,
+   V4L2_MBUS_FMT_ARGB_1X32 = 0x100d,

-   /* YUV (including grey) - next is 0x2017 */
+   /* YUV (including grey) - next is 0x2018 */
V4L2_MBUS_FMT_Y8_1X8 = 0x2001,
V4L2_MBUS_FMT_UV8_1X8 = 0x2015,
V4L2_MBUS_FMT_UYVY8_1_5X8 = 0x2002,
@@ -74,6 +75,7 @@ enum v4l2_mbus_pixelcode {
V4L2_MBUS_FMT_YUYV10_1X20 = 0x200d,
V4L2_MBUS_FMT_YVYU10_1X20 = 0x200e,
V4L2_MBUS_FMT_YUV10_1X30 = 0x2016,
+   V4L2_MBUS_FMT_AYUV8_1X32 = 0x2017,

/* Bayer - next is 0x3019 */
V4L2_MBUS_FMT_SBGGR8_1X8 = 0x3001,


Thanks,
Sylwester
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v2 3/5] v4l: Add media format codes for ARGB8888 and AYUV8888 on 32-bit busses

2013-07-17 Thread Laurent Pinchart 
Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com
---
 Documentation/DocBook/media/v4l/subdev-formats.xml | 609 +
 Documentation/DocBook/media_api.tmpl   |   6 +
 include/uapi/linux/v4l2-mediabus.h |   6 +-
 3 files changed, 254 insertions(+), 367 deletions(-)

diff --git a/Documentation/DocBook/media/v4l/subdev-formats.xml 
b/Documentation/DocBook/media/v4l/subdev-formats.xml
index 0c2b1f2..9100674 100644
--- a/Documentation/DocBook/media/v4l/subdev-formats.xml
+++ b/Documentation/DocBook/media/v4l/subdev-formats.xml
@@ -97,31 +97,39 @@
  colspec colname=id align=left /
  colspec colname=code align=center/
  colspec colname=bit /
- colspec colnum=4 colname=b23 align=center /
- colspec colnum=5 colname=b22 align=center /
- colspec colnum=6 colname=b21 align=center /
- colspec colnum=7 colname=b20 align=center /
- colspec colnum=8 colname=b19 align=center /
- colspec colnum=9 colname=b18 align=center /
- colspec colnum=10 colname=b17 align=center /
- colspec colnum=11 colname=b16 align=center /
- colspec colnum=12 colname=b15 align=center /
- colspec colnum=13 colname=b14 align=center /
- colspec colnum=14 colname=b13 align=center /
- colspec colnum=15 colname=b12 align=center /
- colspec colnum=16 colname=b11 align=center /
- colspec colnum=17 colname=b10 align=center /
- colspec colnum=18 colname=b09 align=center /
- colspec colnum=19 colname=b08 align=center /
- colspec colnum=20 colname=b07 align=center /
- colspec colnum=21 colname=b06 align=center /
- colspec colnum=22 colname=b05 align=center /
- colspec colnum=23 colname=b04 align=center /
- colspec colnum=24 colname=b03 align=center /
- colspec colnum=25 colname=b02 align=center /
- colspec colnum=26 colname=b01 align=center /
- colspec colnum=27 colname=b00 align=center /
- spanspec namest=b23 nameend=b00 spanname=b0 /
+ colspec colnum=4 colname=b31 align=center /
+ colspec colnum=5 colname=b20 align=center /
+ colspec colnum=6 colname=b29 align=center /
+ colspec colnum=7 colname=b28 align=center /
+ colspec colnum=8 colname=b27 align=center /
+ colspec colnum=9 colname=b26 align=center /
+ colspec colnum=10 colname=b25 align=center /
+ colspec colnum=11 colname=b24 align=center /
+ colspec colnum=12 colname=b23 align=center /
+ colspec colnum=13 colname=b22 align=center /
+ colspec colnum=14 colname=b21 align=center /
+ colspec colnum=15 colname=b20 align=center /
+ colspec colnum=16 colname=b19 align=center /
+ colspec colnum=17 colname=b18 align=center /
+ colspec colnum=18 colname=b17 align=center /
+ colspec colnum=19 colname=b16 align=center /
+ colspec colnum=20 colname=b15 align=center /
+ colspec colnum=21 colname=b14 align=center /
+ colspec colnum=22 colname=b13 align=center /
+ colspec colnum=23 colname=b12 align=center /
+ colspec colnum=24 colname=b11 align=center /
+ colspec colnum=25 colname=b10 align=center /
+ colspec colnum=26 colname=b09 align=center /
+ colspec colnum=27 colname=b08 align=center /
+ colspec colnum=28 colname=b07 align=center /
+ colspec colnum=29 colname=b06 align=center /
+ colspec colnum=30 colname=b05 align=center /
+ colspec colnum=31 colname=b04 align=center /
+ colspec colnum=32 colname=b03 align=center /
+ colspec colnum=33 colname=b02 align=center /
+ colspec colnum=34 colname=b01 align=center /
+ colspec colnum=35 colname=b00 align=center /
+ spanspec namest=b31 nameend=b00 spanname=b0 /
  thead
row
  entryIdentifier/entry
@@ -133,6 +141,14 @@
  entry/entry
  entry/entry
  entryBit/entry
+ entry31/entry
+ entry30/entry
+ entry29/entry
+ entry28/entry
+ entry27/entry
+ entry26/entry
+ entry25/entry
+ entry24/entry
  entry23/entry
  entry22/entry
  entry21/entry
@@ -164,7 +180,7 @@
  entryV4L2_MBUS_FMT_RGB444_2X8_PADHI_BE/entry
  entry0x1001/entry
  entry/entry
- dash-ent-16;
+ dash-ent-24;
  entry0/entry
  entry0/entry
  entry0/entry
@@ -178,7 +194,7 @@
  entry/entry
  entry/entry
  entry/entry
- dash-ent-16;
+ dash-ent-24;
  entrygsubscript3/subscript/entry
  entrygsubscript2/subscript/entry
  entrygsubscript1/subscript/entry
@@ -192,7 +208,7 @@