Re: [PULL] bttv driver improvements

2009-02-14 Thread VDR User
On Sat, Feb 14, 2009 at 6:43 PM, Trent Piepho  wrote:
> It's a sil3124 PCI-X SATA II card that is extemely fussy.  I can only get
> to work if I have every other PCI card in my computer in a few specific
> configurations.  If I add the bt848 card, it won't work.  If I *remove* my
> sound card it won't work.  If I put the SATA card in another slot it won't
> work.  If I move my cx88 HD-5500 card to another slot it won't work.  If I
> install the cx88 HD-3000 card in place of the HD-5500 it won't work.
>
> Only problem with the cheap VIA PCI SATA I card I'm using is that it has
> much lower performance than the sil card when it works.  I just need a new
> computer, keeping this dual athlon system from 2001 working is getting too
> hard.  Faster Athlon-MP CPUs are insanely expensive on ebay.  No PCI-E
> slots for modern SATA or graphics cards.  Doesn't work with AGP 8x.  Won't
> boot unless I go through a magic sequence of turning it on and off in quick
> sequence.  And I'm sick of messing with the closed source nvidia driver
> that keeps getting worse and worse with each revision.

I have a friend who was in the same boat not too long ago but he wound
up saying forget it and built a new system.  Well, kept the old dvd
burner, psu, case, mouse, keyboard, monitor.  Basically just bought a
new mainboard + cpu + ram.  I can say he's very happy now and spent <
$150.  Maybe it's time to retire your old box to a file or email
server. ;)
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PULL] bttv driver improvements

2009-02-14 Thread hermann pitton
Hi,

Am Samstag, den 14.02.2009, 18:43 -0800 schrieb Trent Piepho:
> On Sat, 14 Feb 2009, VDR User wrote:
> > On Sat, Feb 14, 2009 at 11:54 AM, Trent Piepho  wrote:
> > >> Didn't you say in your original post that you _haven't_ tested the
> > >> code because of a conflict with your sata driver?  It's not safe to
> > >
> > > I was able to test it later by getting a different sata card.
> >
> > Ahh, gotcha.  Just curious, which card/drivers were you using that
> > conflicted with bttv?
> 
> It's a sil3124 PCI-X SATA II card that is extemely fussy.  I can only get
> to work if I have every other PCI card in my computer in a few specific
> configurations.  If I add the bt848 card, it won't work.  If I *remove* my
> sound card it won't work.  If I put the SATA card in another slot it won't
> work.  If I move my cx88 HD-5500 card to another slot it won't work.  If I
> install the cx88 HD-3000 card in place of the HD-5500 it won't work.
> 
> Only problem with the cheap VIA PCI SATA I card I'm using is that it has
> much lower performance than the sil card when it works.  I just need a new
> computer, keeping this dual athlon system from 2001 working is getting too
> hard.  Faster Athlon-MP CPUs are insanely expensive on ebay.  No PCI-E
> slots for modern SATA or graphics cards.  Doesn't work with AGP 8x.  Won't
> boot unless I go through a magic sequence of turning it on and off in quick
> sequence.  And I'm sick of messing with the closed source nvidia driver
> that keeps getting worse and worse with each revision.

if I would only know where to get such a more exotic bttv card others
still seem to have, but have no time to test. ;)

This will be the same on saa7134 and cx88xx soon.

Cheers,
Hermann




--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PULL] bttv driver improvements

2009-02-14 Thread Trent Piepho
On Sat, 14 Feb 2009, VDR User wrote:
> On Sat, Feb 14, 2009 at 11:54 AM, Trent Piepho  wrote:
> >> Didn't you say in your original post that you _haven't_ tested the
> >> code because of a conflict with your sata driver?  It's not safe to
> >
> > I was able to test it later by getting a different sata card.
>
> Ahh, gotcha.  Just curious, which card/drivers were you using that
> conflicted with bttv?

It's a sil3124 PCI-X SATA II card that is extemely fussy.  I can only get
to work if I have every other PCI card in my computer in a few specific
configurations.  If I add the bt848 card, it won't work.  If I *remove* my
sound card it won't work.  If I put the SATA card in another slot it won't
work.  If I move my cx88 HD-5500 card to another slot it won't work.  If I
install the cx88 HD-3000 card in place of the HD-5500 it won't work.

Only problem with the cheap VIA PCI SATA I card I'm using is that it has
much lower performance than the sil card when it works.  I just need a new
computer, keeping this dual athlon system from 2001 working is getting too
hard.  Faster Athlon-MP CPUs are insanely expensive on ebay.  No PCI-E
slots for modern SATA or graphics cards.  Doesn't work with AGP 8x.  Won't
boot unless I go through a magic sequence of turning it on and off in quick
sequence.  And I'm sick of messing with the closed source nvidia driver
that keeps getting worse and worse with each revision.
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PULL] bttv driver improvements

2009-02-14 Thread VDR User
On Sat, Feb 14, 2009 at 11:54 AM, Trent Piepho  wrote:
>> Didn't you say in your original post that you _haven't_ tested the
>> code because of a conflict with your sata driver?  It's not safe to
>
> I was able to test it later by getting a different sata card.

Ahh, gotcha.  Just curious, which card/drivers were you using that
conflicted with bttv?
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PULL] bttv driver improvements

2009-02-14 Thread Trent Piepho
On Sat, 14 Feb 2009, VDR User wrote:
> On Fri, Feb 13, 2009 at 5:07 PM, Trent Piepho  wrote:
> > I tested it on my bttv card.  I assume Mauro was able to test it too.  Have
> > you found a problem?
>
> Didn't you say in your original post that you _haven't_ tested the
> code because of a conflict with your sata driver?  It's not safe to

I was able to test it later by getting a different sata card.
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PULL] bttv driver improvements

2009-02-14 Thread VDR User
On Fri, Feb 13, 2009 at 5:07 PM, Trent Piepho  wrote:
> I tested it on my bttv card.  I assume Mauro was able to test it too.  Have
> you found a problem?

Didn't you say in your original post that you _haven't_ tested the
code because of a conflict with your sata driver?  It's not safe to
assume Mauro has tested the changes.  There have been times in the
past when he's changed code for cards he doesn't even have and
committed then with absolutely no testing what-so-ever.  I probably
still have the emails.

I haven't tested your patch yet.  Am currently testing other cards and
had to remove my vp1020.  Will let you know what results I get when I
have the chance to test it however.  Either way, thanks for working on
the driver, hopefully the code is safe or would just need little
fixes. :)
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PULL] bttv driver improvements

2009-02-13 Thread Trent Piepho
On Fri, 13 Feb 2009, user.vdr wrote:
> On Fri, Feb 13, 2009 at 2:15 PM, Mauro Carvalho Chehab
> > Very nice work! You've reduced the driver data/bss size a lot:
> >
> > Before:
> >   textdata bss dec hex filename
> >  88854   64312  123668  276834   43962 bttv.ko
> >
> > After:
> >   textdata bss dec hex filename
> >  88780   504881044  140312   22418 bttv.ko
> >
> > I've just committed it.
>
> Would be nice if someone at least tested a major change before it's committed.

I tested it on my bttv card.  I assume Mauro was able to test it too.  Have
you found a problem?

It would be nice to test the "weird" cards with digital inputs and external
muxes, but I don't have one.  There are probably very few, if any, people
who actually still use these cards.
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PULL] bttv driver improvements

2009-02-13 Thread user.vdr
On Fri, Feb 13, 2009 at 2:15 PM, Mauro Carvalho Chehab
 wrote:
>> I haven't been able to test this code.  It seems my bt848 card doesn't work
>> with my SATA controller and I sort of need the latter to access the
>> harddrive.  But I think everything should work.  It cuts the the bttv
>> driver to less than half its current size.
>>
>> A number of the changes are for specialized cards that likely have few if
>> any users left.  I'm pretty sure some have been broken for quite a while now.
>>
>> Please pull from http://linuxtv.org/hg/~tap/bttv
>>
> Very nice work! You've reduced the driver data/bss size a lot:
>
> Before:
>   textdata bss dec hex filename
>  88854   64312  123668  276834   43962 bttv.ko
>
> After:
>   textdata bss dec hex filename
>  88780   504881044  140312   22418 bttv.ko
>
> I've just committed it.

Would be nice if someone at least tested a major change before it's committed.
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PULL] bttv driver improvements

2009-02-13 Thread Mauro Carvalho Chehab
On Thu, 29 Jan 2009 17:19:24 -0800 (PST)
Trent Piepho  wrote:

> Mauro,
> 
> I haven't been able to test this code.  It seems my bt848 card doesn't work
> with my SATA controller and I sort of need the latter to access the
> harddrive.  But I think everything should work.  It cuts the the bttv
> driver to less than half its current size.
> 
> A number of the changes are for specialized cards that likely have few if
> any users left.  I'm pretty sure some have been broken for quite a while now.
> 
> Please pull from http://linuxtv.org/hg/~tap/bttv
> 
Very nice work! You've reduced the driver data/bss size a lot:

Before:
   textdata bss dec hex filename
  88854   64312  123668  276834   43962 bttv.ko

After:
   textdata bss dec hex filename
  88780   504881044  140312   22418 bttv.ko

I've just committed it.

Cheers,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PULL] bttv driver improvements

2009-02-04 Thread Trent Piepho
On Fri, 30 Jan 2009, Devin Heitmueller wrote:
> On Fri, Jan 30, 2009 at 4:20 AM, Trent Piepho  wrote:
> > On Thu, 29 Jan 2009, Devin Heitmueller wrote:
> >> On Thu, Jan 29, 2009 at 8:19 PM, Trent Piepho  wrote:
> >> > I haven't been able to test this code.  It seems my bt848 card doesn't 
> >> > work
> >> > with my SATA controller and I sort of need the latter to access the
> >> > harddrive.  But I think everything should work.  It cuts the the bttv
> >> > driver to less than half its current size.
> >> >
> >> > A number of the changes are for specialized cards that likely have few if
> >> > any users left.  I'm pretty sure some have been broken for quite a while 
> >> > now.
> >> >
> >> > Please pull from http://linuxtv.org/hg/~tap/bttv
> >> >
> >> >  bttv-cards.c  | 1323 
> >> > ++
> >> >  bttv-driver.c |   90 +--
> >> >  bttv-i2c.c|6
> >> >  bttv-if.c |   18
> >> >  bttv-risc.c   |4
> >> >  bttv-vbi.c|2
> >> >  bttv.h|   84 ++-
> >> >  bttvp.h   |   19
> >> >  8 files changed, 640 insertions(+), 906 deletions(-)
> >>
> >> Perhaps I am misunderstanding what you said in this email, but are you
> >> submitting a PULL request for 1500 lines of code that have had no
> >> testing?
> >
> > Bugs?!  In my code?  I think not!
> >
> > If you look at the patches you'll see it's not nearly as large as it might
> > seem.

> When I make a five line code change for a given chipset, I won't
> submit it unless it's tested against at least three cards.  In this
> case, it's 1500 lines, and you have tested it on zero cards.  You make
> one typo or screw up one pointer and we'll have potentially hundreds
> of people reporting kernel panics.

A typo would almost certainly result in some sort of compile failure or
warning.  Most of the repetitive changes where mistakes could creep in and
not cause an apparent problem were done via perl scripts.

Code pulled into v4l-dvb doesn't immediately go to the kernel anyway.  It
would sit there for a while and get some testing.

Anyway, by replacing my PCI-X SATA-II card with a PCI SATA-I card I was
able to get my bttv card to work.  Or rather I was able to get my HD to
work with the bttv card installed.  Everything worked fine for my card.

The testing I'd like is any of the card with external muxes or digital
inputs.  Especially the cards that I don't think were working before.
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PULL] bttv driver improvements

2009-01-30 Thread Devin Heitmueller
On Fri, Jan 30, 2009 at 8:58 AM, Mauro Carvalho Chehab
> Devin,
>
> I have one bttv hardware installed here available for testing. This one has 4
> bttv chips and uses 2 different board entries. I intend to test the changeset
> before applying. Anyway, it is good if more people could test it, especially
> with the exotic hardware.
>
> Unfortunately, my other bttv hardwares are on another city, so I can't test on
> them.
>
> Cheers,
> Mauro

Great.  Thanks, Mauro.

Devin

-- 
Devin J. Heitmueller
http://www.devinheitmueller.com
AIM: devinheitmueller
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PULL] bttv driver improvements

2009-01-30 Thread Mauro Carvalho Chehab
On Fri, 30 Jan 2009 08:27:20 -0500
Devin Heitmueller  wrote:

> On Fri, Jan 30, 2009 at 4:20 AM, Trent Piepho  wrote:
> > On Thu, 29 Jan 2009, Devin Heitmueller wrote:
> >> On Thu, Jan 29, 2009 at 8:19 PM, Trent Piepho  wrote:
> >> > I haven't been able to test this code.  It seems my bt848 card doesn't 
> >> > work
> >> > with my SATA controller and I sort of need the latter to access the
> >> > harddrive.  But I think everything should work.  It cuts the the bttv
> >> > driver to less than half its current size.
> >> >
> >> > A number of the changes are for specialized cards that likely have few if
> >> > any users left.  I'm pretty sure some have been broken for quite a while 
> >> > now.
> >> >
> >> > Please pull from http://linuxtv.org/hg/~tap/bttv
> >> >
> >> >  bttv-cards.c  | 1323 
> >> > ++
> >> >  bttv-driver.c |   90 +--
> >> >  bttv-i2c.c|6
> >> >  bttv-if.c |   18
> >> >  bttv-risc.c   |4
> >> >  bttv-vbi.c|2
> >> >  bttv.h|   84 ++-
> >> >  bttvp.h   |   19
> >> >  8 files changed, 640 insertions(+), 906 deletions(-)
> >>
> >> Perhaps I am misunderstanding what you said in this email, but are you
> >> submitting a PULL request for 1500 lines of code that have had no
> >> testing?
> >
> > Bugs?!  In my code?  I think not!
> >
> > If you look at the patches you'll see it's not nearly as large as it might
> > seem.
> 
> When I make a five line code change for a given chipset, I won't
> submit it unless it's tested against at least three cards.  In this
> case, it's 1500 lines, and you have tested it on zero cards.  You make
> one typo or screw up one pointer and we'll have potentially hundreds
> of people reporting kernel panics.
> 
> I don't care how safe you think the change is.  If it isn't tested it
> under at least one card, then it cannot be that important a change as
> to incur the risk of regressions.  This isn't a one-line change to a
> comment.
> 
> I'm just one developer and my opinion doesn't count for much, but
> checking in a large body of code blindly is a colossally stupid idea.

Devin,

I have one bttv hardware installed here available for testing. This one has 4
bttv chips and uses 2 different board entries. I intend to test the changeset
before applying. Anyway, it is good if more people could test it, especially
with the exotic hardware.

Unfortunately, my other bttv hardwares are on another city, so I can't test on
them.

Cheers,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PULL] bttv driver improvements

2009-01-30 Thread Devin Heitmueller
On Fri, Jan 30, 2009 at 4:20 AM, Trent Piepho  wrote:
> On Thu, 29 Jan 2009, Devin Heitmueller wrote:
>> On Thu, Jan 29, 2009 at 8:19 PM, Trent Piepho  wrote:
>> > I haven't been able to test this code.  It seems my bt848 card doesn't work
>> > with my SATA controller and I sort of need the latter to access the
>> > harddrive.  But I think everything should work.  It cuts the the bttv
>> > driver to less than half its current size.
>> >
>> > A number of the changes are for specialized cards that likely have few if
>> > any users left.  I'm pretty sure some have been broken for quite a while 
>> > now.
>> >
>> > Please pull from http://linuxtv.org/hg/~tap/bttv
>> >
>> >  bttv-cards.c  | 1323 
>> > ++
>> >  bttv-driver.c |   90 +--
>> >  bttv-i2c.c|6
>> >  bttv-if.c |   18
>> >  bttv-risc.c   |4
>> >  bttv-vbi.c|2
>> >  bttv.h|   84 ++-
>> >  bttvp.h   |   19
>> >  8 files changed, 640 insertions(+), 906 deletions(-)
>>
>> Perhaps I am misunderstanding what you said in this email, but are you
>> submitting a PULL request for 1500 lines of code that have had no
>> testing?
>
> Bugs?!  In my code?  I think not!
>
> If you look at the patches you'll see it's not nearly as large as it might
> seem.

When I make a five line code change for a given chipset, I won't
submit it unless it's tested against at least three cards.  In this
case, it's 1500 lines, and you have tested it on zero cards.  You make
one typo or screw up one pointer and we'll have potentially hundreds
of people reporting kernel panics.

I don't care how safe you think the change is.  If it isn't tested it
under at least one card, then it cannot be that important a change as
to incur the risk of regressions.  This isn't a one-line change to a
comment.

I'm just one developer and my opinion doesn't count for much, but
checking in a large body of code blindly is a colossally stupid idea.

Devin

-- 
Devin J. Heitmueller
http://www.devinheitmueller.com
AIM: devinheitmueller
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PULL] bttv driver improvements

2009-01-30 Thread Alan Garfield

Trent Piepho wrote:

On Thu, 29 Jan 2009, Devin Heitmueller wrote:
  

On Thu, Jan 29, 2009 at 8:19 PM, Trent Piepho  wrote:


I haven't been able to test this code.  It seems my bt848 card doesn't work
with my SATA controller and I sort of need the latter to access the
harddrive.  But I think everything should work.  It cuts the the bttv
driver to less than half its current size.

A number of the changes are for specialized cards that likely have few if
any users left.  I'm pretty sure some have been broken for quite a while now.

Please pull from http://linuxtv.org/hg/~tap/bttv

 bttv-cards.c  | 1323 ++
 bttv-driver.c |   90 +--
 bttv-i2c.c|6
 bttv-if.c |   18
 bttv-risc.c   |4
 bttv-vbi.c|2
 bttv.h|   84 ++-
 bttvp.h   |   19
 8 files changed, 640 insertions(+), 906 deletions(-)
  

Perhaps I am misunderstanding what you said in this email, but are you
submitting a PULL request for 1500 lines of code that have had no
testing?



Bugs?!  In my code?  I think not!

If you look at the patches you'll see it's not nearly as large as it might
seem.
  
The muxsel chunk in my IVC120G looks ok. I've not tried it on the 
hardware, but it is only a minor change and there would be no net effect 
after the modification in my case (other than removing an unnecessary 
mux switch and making the code smaller).


-A.

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PULL] bttv driver improvements

2009-01-30 Thread Trent Piepho
On Thu, 29 Jan 2009, Devin Heitmueller wrote:
> On Thu, Jan 29, 2009 at 8:19 PM, Trent Piepho  wrote:
> > I haven't been able to test this code.  It seems my bt848 card doesn't work
> > with my SATA controller and I sort of need the latter to access the
> > harddrive.  But I think everything should work.  It cuts the the bttv
> > driver to less than half its current size.
> >
> > A number of the changes are for specialized cards that likely have few if
> > any users left.  I'm pretty sure some have been broken for quite a while 
> > now.
> >
> > Please pull from http://linuxtv.org/hg/~tap/bttv
> >
> >  bttv-cards.c  | 1323 
> > ++
> >  bttv-driver.c |   90 +--
> >  bttv-i2c.c|6
> >  bttv-if.c |   18
> >  bttv-risc.c   |4
> >  bttv-vbi.c|2
> >  bttv.h|   84 ++-
> >  bttvp.h   |   19
> >  8 files changed, 640 insertions(+), 906 deletions(-)
>
> Perhaps I am misunderstanding what you said in this email, but are you
> submitting a PULL request for 1500 lines of code that have had no
> testing?

Bugs?!  In my code?  I think not!

If you look at the patches you'll see it's not nearly as large as it might
seem.
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PULL] bttv driver improvements

2009-01-29 Thread Devin Heitmueller
On Thu, Jan 29, 2009 at 8:19 PM, Trent Piepho  wrote:
> Mauro,
>
> I haven't been able to test this code.  It seems my bt848 card doesn't work
> with my SATA controller and I sort of need the latter to access the
> harddrive.  But I think everything should work.  It cuts the the bttv
> driver to less than half its current size.
>
> A number of the changes are for specialized cards that likely have few if
> any users left.  I'm pretty sure some have been broken for quite a while now.
>
> Please pull from http://linuxtv.org/hg/~tap/bttv
>
> for the following 11 changesets:
>
> 01/11: bttv: norm value should be unsigned
> http://linuxtv.org/hg/~tap/bttv?cmd=changeset;node=50f1e731724a
>
> 02/11: bttv: Fix TDA9880 norm setting code
> http://linuxtv.org/hg/~tap/bttv?cmd=changeset;node=57e9059c7351
>
> 03/11: bttv: make tuner card info more consistent
> http://linuxtv.org/hg/~tap/bttv?cmd=changeset;node=e00ad34122b7
>
> 04/11: bttv: store card database more efficiently
> http://linuxtv.org/hg/~tap/bttv?cmd=changeset;node=01eb02aea459
>
> 05/11: bttv: rework the way digital inputs are indicated
> http://linuxtv.org/hg/~tap/bttv?cmd=changeset;node=0478bab75dc0
>
> 06/11: bttv: clean up mux code for IVC-120G
> http://linuxtv.org/hg/~tap/bttv?cmd=changeset;node=c71a94680ca0
>
> 07/11: bttv: fix external mux for PHYTEC VD-009
> http://linuxtv.org/hg/~tap/bttv?cmd=changeset;node=67a52d2c6376
>
> 08/11: bttv: fix external mux for RemoteVision MX
> http://linuxtv.org/hg/~tap/bttv?cmd=changeset;node=d2f23dd03aef
>
> 09/11: bttv: clean up mux code for IDS Eagle
> http://linuxtv.org/hg/~tap/bttv?cmd=changeset;node=944eeb814dd8
>
> 10/11: bttv: shrink muxsel data in card database
> http://linuxtv.org/hg/~tap/bttv?cmd=changeset;node=d62cf6dd3da6
>
> 11/11: bttv: dynamically allocate device data
> http://linuxtv.org/hg/~tap/bttv?cmd=changeset;node=b99081ff66cf
>
>
>  bttv-cards.c  | 1323 
> ++
>  bttv-driver.c |   90 +--
>  bttv-i2c.c|6
>  bttv-if.c |   18
>  bttv-risc.c   |4
>  bttv-vbi.c|2
>  bttv.h|   84 ++-
>  bttvp.h   |   19
>  8 files changed, 640 insertions(+), 906 deletions(-)
>
> Thanks,
> Trent
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

Hello Trent,

Perhaps I am misunderstanding what you said in this email, but are you
submitting a PULL request for 1500 lines of code that have had no
testing?

Devin

-- 
Devin J. Heitmueller
http://www.devinheitmueller.com
AIM: devinheitmueller
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PULL] bttv driver improvements

2009-01-29 Thread Trent Piepho
Mauro,

I haven't been able to test this code.  It seems my bt848 card doesn't work
with my SATA controller and I sort of need the latter to access the
harddrive.  But I think everything should work.  It cuts the the bttv
driver to less than half its current size.

A number of the changes are for specialized cards that likely have few if
any users left.  I'm pretty sure some have been broken for quite a while now.

Please pull from http://linuxtv.org/hg/~tap/bttv

for the following 11 changesets:

01/11: bttv: norm value should be unsigned
http://linuxtv.org/hg/~tap/bttv?cmd=changeset;node=50f1e731724a

02/11: bttv: Fix TDA9880 norm setting code
http://linuxtv.org/hg/~tap/bttv?cmd=changeset;node=57e9059c7351

03/11: bttv: make tuner card info more consistent
http://linuxtv.org/hg/~tap/bttv?cmd=changeset;node=e00ad34122b7

04/11: bttv: store card database more efficiently
http://linuxtv.org/hg/~tap/bttv?cmd=changeset;node=01eb02aea459

05/11: bttv: rework the way digital inputs are indicated
http://linuxtv.org/hg/~tap/bttv?cmd=changeset;node=0478bab75dc0

06/11: bttv: clean up mux code for IVC-120G
http://linuxtv.org/hg/~tap/bttv?cmd=changeset;node=c71a94680ca0

07/11: bttv: fix external mux for PHYTEC VD-009
http://linuxtv.org/hg/~tap/bttv?cmd=changeset;node=67a52d2c6376

08/11: bttv: fix external mux for RemoteVision MX
http://linuxtv.org/hg/~tap/bttv?cmd=changeset;node=d2f23dd03aef

09/11: bttv: clean up mux code for IDS Eagle
http://linuxtv.org/hg/~tap/bttv?cmd=changeset;node=944eeb814dd8

10/11: bttv: shrink muxsel data in card database
http://linuxtv.org/hg/~tap/bttv?cmd=changeset;node=d62cf6dd3da6

11/11: bttv: dynamically allocate device data
http://linuxtv.org/hg/~tap/bttv?cmd=changeset;node=b99081ff66cf


 bttv-cards.c  | 1323 ++
 bttv-driver.c |   90 +--
 bttv-i2c.c|6
 bttv-if.c |   18
 bttv-risc.c   |4
 bttv-vbi.c|2
 bttv.h|   84 ++-
 bttvp.h   |   19
 8 files changed, 640 insertions(+), 906 deletions(-)

Thanks,
Trent
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html