Re: [RESEND PATCH v2 1/2] x86/mm/pat, drivers/infiniband/ipath: replace WARN() with pr_warn()

2015-07-20 Thread Doug Ledford

 On Jul 17, 2015, at 5:07 PM, Luis R. Rodriguez mcg...@do-not-panic.com 
 wrote:
 
 From: Luis R. Rodriguez mcg...@suse.com
 
 WARN() may confuse users, fix that. ipath_init_one() is part the
 device's probe so this would only be triggered if a corresponding
 device was found.
 
 Signed-off-by: Luis R. Rodriguez mcg...@suse.com

Acked-by: Doug Ledford dledf...@redhat.com

—
Doug Ledford dledf...@redhat.com
GPG Key ID: 0E572FDD







signature.asc
Description: Message signed with OpenPGP using GPGMail


[RESEND PATCH v2 1/2] x86/mm/pat, drivers/infiniband/ipath: replace WARN() with pr_warn()

2015-07-17 Thread Luis R. Rodriguez
From: Luis R. Rodriguez mcg...@suse.com

WARN() may confuse users, fix that. ipath_init_one() is part the
device's probe so this would only be triggered if a corresponding
device was found.

Signed-off-by: Luis R. Rodriguez mcg...@suse.com
---
 drivers/infiniband/hw/ipath/ipath_driver.c | 6 --
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/infiniband/hw/ipath/ipath_driver.c 
b/drivers/infiniband/hw/ipath/ipath_driver.c
index 2d7e503d13cb..871dbe56216a 100644
--- a/drivers/infiniband/hw/ipath/ipath_driver.c
+++ b/drivers/infiniband/hw/ipath/ipath_driver.c
@@ -31,6 +31,8 @@
  * SOFTWARE.
  */
 
+#define pr_fmt(fmt) KBUILD_MODNAME :  fmt
+
 #include linux/sched.h
 #include linux/spinlock.h
 #include linux/idr.h
@@ -399,8 +401,8 @@ static int ipath_init_one(struct pci_dev *pdev, const 
struct pci_device_id *ent)
u32 bar0 = 0, bar1 = 0;
 
 #ifdef CONFIG_X86_64
-   if (WARN(pat_enabled(),
-ipath needs PAT disabled, boot with nopat kernel 
parameter\n)) {
+   if (pat_enabled()) {
+   pr_warn(ipath needs PAT disabled, boot with nopat kernel 
parameter\n);
ret = -ENODEV;
goto bail;
}
-- 
2.3.2.209.gd67f9d5.dirty

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html