Re: [RFC PATCH 1/8] stk-webcam: various fixes.
On Sat February 9 2013 12:22:12 Arvydas Sidorenko wrote: On Fri, Feb 8, 2013 at 10:20 AM, Hans Verkuil hverk...@xs4all.nl wrote: Thanks for the testing! I've pushed some more improvements to my git branch. Hopefully the compliance tests are now running OK. Please check the dmesg output as well. In addition I've added an 'upside down' message to the kernel log that tells me whether the driver is aware that your sensor is upside down or not. Which laptop do you have? Asus G1? Regards, Hans Now it looks better, but clearly there is an issue with the upside down thing. I have ASUS F3Jc laptop. Although a commit '6f89814d3d' introduced a problem. if (rb-count == 0) dev-owner = NULL; Now 'v4l_stk_release' doesn't release the resources because 'dev-owner != fp'. Fixed. $ dmesg | grep upside [4.933507] upside down: 0 I've improved this message, so please run again with the latest code and let me know what it says. I don't understand all the upside-down problems... Regards, Hans $ v4l2-compliance -d /dev/video0 Driver Info: Driver name : stk Card type : stk Bus info : usb-:00:1d.7-8 Driver version: 3.1.0 Capabilities : 0x8501 Video Capture Read/Write Streaming Device Capabilities Device Caps : 0x0501 Video Capture Read/Write Streaming Compliance test for device /dev/video0 (not using libv4l2): Required ioctls: test VIDIOC_QUERYCAP: OK Allow for multiple opens: test second video open: OK test VIDIOC_QUERYCAP: OK test VIDIOC_G/S_PRIORITY: OK Debug ioctls: test VIDIOC_DBG_G_CHIP_IDENT: OK (Not Supported) test VIDIOC_DBG_G/S_REGISTER: OK (Not Supported) test VIDIOC_LOG_STATUS: OK Input ioctls: test VIDIOC_G/S_TUNER: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported) test VIDIOC_ENUMAUDIO: OK (Not Supported) test VIDIOC_G/S/ENUMINPUT: OK test VIDIOC_G/S_AUDIO: OK (Not Supported) Inputs: 1 Audio Inputs: 0 Tuners: 0 Output ioctls: test VIDIOC_G/S_MODULATOR: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_ENUMAUDOUT: OK (Not Supported) test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported) test VIDIOC_G/S_AUDOUT: OK (Not Supported) Outputs: 0 Audio Outputs: 0 Modulators: 0 Control ioctls: test VIDIOC_QUERYCTRL/MENU: OK test VIDIOC_G/S_CTRL: OK test VIDIOC_G/S/TRY_EXT_CTRLS: OK test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK test VIDIOC_G/S_JPEGCOMP: OK (Not Supported) Standard Controls: 4 Private Controls: 0 Input/Output configuration ioctls: test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported) test VIDIOC_ENUM/G/S/QUERY_DV_PRESETS: OK (Not Supported) test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported) test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported) Format ioctls: test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK test VIDIOC_G/S_PARM: OK test VIDIOC_G_FBUF: OK (Not Supported) test VIDIOC_G_FMT: OK warn: v4l2-test-formats.cpp(565): TRY_FMT cannot handle an invalid pixelformat. This may or may not be a problem. See http://www.mail-archive.com/linux-media@vger.kernel.org/msg56550.html for more information. test VIDIOC_TRY_FMT: OK warn: v4l2-test-formats.cpp(723): S_FMT cannot handle an invalid pixelformat. This may or may not be a problem. See http://www.mail-archive.com/linux-media@vger.kernel.org/msg56550.html for more information. test VIDIOC_S_FMT: OK test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported) Codec ioctls: test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported) test VIDIOC_G_ENC_INDEX: OK (Not Supported) test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported) Buffer ioctls: warn: v4l2-test-buffers.cpp(175): VIDIOC_CREATE_BUFS not supported test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK Total: 38, Succeeded: 38, Failed: 0, Warnings: 3 Arvydas -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFC PATCH 1/8] stk-webcam: various fixes.
On Sun, Feb 10, 2013 at 8:28 AM, Hans Verkuil hverk...@xs4all.nl wrote: I've improved this message, so please run again with the latest code and let me know what it says. I don't understand all the upside-down problems... $ dmesg | grep upside upside down: 0 -1 -1 -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFC PATCH 1/8] stk-webcam: various fixes.
On Sun February 10 2013 15:46:05 Arvydas Sidorenko wrote: On Sun, Feb 10, 2013 at 8:28 AM, Hans Verkuil hverk...@xs4all.nl wrote: I've improved this message, so please run again with the latest code and let me know what it says. I don't understand all the upside-down problems... $ dmesg | grep upside upside down: 0 -1 -1 Thanks, I found the bug. It's my fault: I made a logic error w.r.t. setting up the initial hflip/vflip values. I've read over it dozens of times without actually catching the - rather obvious - bug :-) Get the latest code, try again and if everything works fine for you then I'll clean up my patches and post the final version. Thanks for testing! Regards, Hans -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFC PATCH 1/8] stk-webcam: various fixes.
On Sun, Feb 10, 2013 at 3:02 PM, Hans Verkuil hverk...@xs4all.nl wrote: Thanks, I found the bug. It's my fault: I made a logic error w.r.t. setting up the initial hflip/vflip values. I've read over it dozens of times without actually catching the - rather obvious - bug :-) Get the latest code, try again and if everything works fine for you then I'll clean up my patches and post the final version. Looks good. Thanks for you effort! Arvydas -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFC PATCH 1/8] stk-webcam: various fixes.
On Sun February 10 2013 17:16:30 Arvydas Sidorenko wrote: On Sun, Feb 10, 2013 at 3:02 PM, Hans Verkuil hverk...@xs4all.nl wrote: Thanks, I found the bug. It's my fault: I made a logic error w.r.t. setting up the initial hflip/vflip values. I've read over it dozens of times without actually catching the - rather obvious - bug :-) After rechecking I discovered that I didn't introduce this after all. It was recently introduced in a patch for the 3.9 kernel. Luckily that patch isn't in the upcoming 3.8 kernel. Get the latest code, try again and if everything works fine for you then I'll clean up my patches and post the final version. Looks good. Thanks for you effort! No problem, nice to have another driver pass the compliance test. Regards, Hans -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFC PATCH 1/8] stk-webcam: various fixes.
On Fri, Feb 8, 2013 at 10:20 AM, Hans Verkuil hverk...@xs4all.nl wrote: Thanks for the testing! I've pushed some more improvements to my git branch. Hopefully the compliance tests are now running OK. Please check the dmesg output as well. In addition I've added an 'upside down' message to the kernel log that tells me whether the driver is aware that your sensor is upside down or not. Which laptop do you have? Asus G1? Regards, Hans Now it looks better, but clearly there is an issue with the upside down thing. I have ASUS F3Jc laptop. Although a commit '6f89814d3d' introduced a problem. if (rb-count == 0) dev-owner = NULL; Now 'v4l_stk_release' doesn't release the resources because 'dev-owner != fp'. $ dmesg | grep upside [4.933507] upside down: 0 $ v4l2-compliance -d /dev/video0 Driver Info: Driver name : stk Card type : stk Bus info : usb-:00:1d.7-8 Driver version: 3.1.0 Capabilities : 0x8501 Video Capture Read/Write Streaming Device Capabilities Device Caps : 0x0501 Video Capture Read/Write Streaming Compliance test for device /dev/video0 (not using libv4l2): Required ioctls: test VIDIOC_QUERYCAP: OK Allow for multiple opens: test second video open: OK test VIDIOC_QUERYCAP: OK test VIDIOC_G/S_PRIORITY: OK Debug ioctls: test VIDIOC_DBG_G_CHIP_IDENT: OK (Not Supported) test VIDIOC_DBG_G/S_REGISTER: OK (Not Supported) test VIDIOC_LOG_STATUS: OK Input ioctls: test VIDIOC_G/S_TUNER: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported) test VIDIOC_ENUMAUDIO: OK (Not Supported) test VIDIOC_G/S/ENUMINPUT: OK test VIDIOC_G/S_AUDIO: OK (Not Supported) Inputs: 1 Audio Inputs: 0 Tuners: 0 Output ioctls: test VIDIOC_G/S_MODULATOR: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_ENUMAUDOUT: OK (Not Supported) test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported) test VIDIOC_G/S_AUDOUT: OK (Not Supported) Outputs: 0 Audio Outputs: 0 Modulators: 0 Control ioctls: test VIDIOC_QUERYCTRL/MENU: OK test VIDIOC_G/S_CTRL: OK test VIDIOC_G/S/TRY_EXT_CTRLS: OK test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK test VIDIOC_G/S_JPEGCOMP: OK (Not Supported) Standard Controls: 4 Private Controls: 0 Input/Output configuration ioctls: test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported) test VIDIOC_ENUM/G/S/QUERY_DV_PRESETS: OK (Not Supported) test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported) test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported) Format ioctls: test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK test VIDIOC_G/S_PARM: OK test VIDIOC_G_FBUF: OK (Not Supported) test VIDIOC_G_FMT: OK warn: v4l2-test-formats.cpp(565): TRY_FMT cannot handle an invalid pixelformat. This may or may not be a problem. See http://www.mail-archive.com/linux-media@vger.kernel.org/msg56550.html for more information. test VIDIOC_TRY_FMT: OK warn: v4l2-test-formats.cpp(723): S_FMT cannot handle an invalid pixelformat. This may or may not be a problem. See http://www.mail-archive.com/linux-media@vger.kernel.org/msg56550.html for more information. test VIDIOC_S_FMT: OK test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported) Codec ioctls: test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported) test VIDIOC_G_ENC_INDEX: OK (Not Supported) test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported) Buffer ioctls: warn: v4l2-test-buffers.cpp(175): VIDIOC_CREATE_BUFS not supported test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK Total: 38, Succeeded: 38, Failed: 0, Warnings: 3 Arvydas -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFC PATCH 1/8] stk-webcam: various fixes.
On Thu February 7 2013 23:39:58 Arvydas Sidorenko wrote: On Wed, Feb 6, 2013 at 8:32 AM, Hans Verkuil hverk...@xs4all.nl wrote: I've improved v4l2-compliance a bit, but I've also pushed a fix (I hope) to my git branch. It's great if you can test this! Thanks for the testing! I've pushed some more improvements to my git branch. Hopefully the compliance tests are now running OK. Please check the dmesg output as well. In addition I've added an 'upside down' message to the kernel log that tells me whether the driver is aware that your sensor is upside down or not. Which laptop do you have? Asus G1? Regards, Hans -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFC PATCH 1/8] stk-webcam: various fixes.
On Wed, Feb 6, 2013 at 8:32 AM, Hans Verkuil hverk...@xs4all.nl wrote: I've improved v4l2-compliance a bit, but I've also pushed a fix (I hope) to my git branch. It's great if you can test this! $ v4l2-compliance -d /dev/video0 Driver Info: Driver name : stk Card type : stk Bus info : usb-:00:1d.7-8 Driver version: 3.1.0 Capabilities : 0x8501 Video Capture Read/Write Streaming Device Capabilities Device Caps : 0x0501 Video Capture Read/Write Streaming Compliance test for device /dev/video0 (not using libv4l2): Required ioctls: test VIDIOC_QUERYCAP: OK Allow for multiple opens: test second video open: OK test VIDIOC_QUERYCAP: OK test VIDIOC_G/S_PRIORITY: OK Debug ioctls: test VIDIOC_DBG_G_CHIP_IDENT: OK (Not Supported) test VIDIOC_DBG_G/S_REGISTER: OK (Not Supported) test VIDIOC_LOG_STATUS: OK Input ioctls: test VIDIOC_G/S_TUNER: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported) test VIDIOC_ENUMAUDIO: OK (Not Supported) test VIDIOC_G/S/ENUMINPUT: OK test VIDIOC_G/S_AUDIO: OK (Not Supported) Inputs: 1 Audio Inputs: 0 Tuners: 0 Output ioctls: test VIDIOC_G/S_MODULATOR: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_ENUMAUDOUT: OK (Not Supported) test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported) test VIDIOC_G/S_AUDOUT: OK (Not Supported) Outputs: 0 Audio Outputs: 0 Modulators: 0 Control ioctls: test VIDIOC_QUERYCTRL/MENU: OK test VIDIOC_G/S_CTRL: OK test VIDIOC_G/S/TRY_EXT_CTRLS: OK test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK test VIDIOC_G/S_JPEGCOMP: OK (Not Supported) Standard Controls: 4 Private Controls: 0 Input/Output configuration ioctls: test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported) test VIDIOC_ENUM/G/S/QUERY_DV_PRESETS: OK (Not Supported) test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported) test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported) Format ioctls: test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK test VIDIOC_G/S_PARM: OK test VIDIOC_G_FBUF: OK (Not Supported) test VIDIOC_G_FMT: OK warn: v4l2-test-formats.cpp(565): TRY_FMT cannot handle an invalid pixelformat. This may or may not be a problem. See http://www.mail-archive.com/linux-media@vger.kernel.org/msg56550.html for more information. test VIDIOC_TRY_FMT: OK warn: v4l2-test-formats.cpp(723): S_FMT cannot handle an invalid pixelformat. This may or may not be a problem. See http://www.mail-archive.com/linux-media@vger.kernel.org/msg56550.html for more information. warn: v4l2-test-formats.cpp(658): Could not set fmt1 test VIDIOC_S_FMT: OK test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported) Codec ioctls: test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported) test VIDIOC_G_ENC_INDEX: OK (Not Supported) test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported) Buffer ioctls: fail: v4l2-test-buffers.cpp(166): doioctl(node-node2, VIDIOC_REQBUFS, bufs) test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: FAIL Total: 38, Succeeded: 37, Failed: 1, Warnings: 3 On top of that it generates some dmesg output: [ 70.514849] stkwebcam 5-8:1.0: = START STATUS = [ 70.514856] stkwebcam 5-8:1.0: Brightness: 96 [ 70.514860] stkwebcam 5-8:1.0: Horizontal Flip: true [ 70.514863] stkwebcam 5-8:1.0: Vertical Flip: true [ 70.514866] stkwebcam 5-8:1.0: == END STATUS == [ 70.596727] stkwebcam: OmniVision sensor detected, id 9652 at address 60 [ 70.859490] stkwebcam: isobufs already allocated. Bad [ 70.859977] stkwebcam: isobuf data already allocated [ 70.860502] stkwebcam: Killing URB [ 70.860990] stkwebcam: isobuf data already allocated [ 70.861478] stkwebcam: Killing URB [ 70.862088] stkwebcam: isobuf data already allocated [ 70.862834] stkwebcam: Killing URB [ 70.863594] stkwebcam: sio_bufs already allocated [ 70.864319] stkwebcam: isobufs already allocated. Bad [ 70.865057] stkwebcam: isobuf data already allocated [ 70.865752] stkwebcam: Killing URB [ 70.866490] stkwebcam: isobuf data already allocated [ 70.867275] stkwebcam: Killing URB [ 70.867980] stkwebcam: isobuf data already allocated [ 70.868721] stkwebcam: Killing URB [ 70.869464] stkwebcam: sio_bufs already allocated [ 70.870244] stkwebcam: isobufs already allocated. Bad [ 70.870968] stkwebcam: isobuf data already allocated [ 70.871704] stkwebcam: Killing URB [ 70.872440] stkwebcam: isobuf data already allocated [ 70.873181]
Re: [RFC PATCH 1/8] stk-webcam: various fixes.
On Mon, Feb 4, 2013 at 2:35 PM, Hans Verkuil hverk...@xs4all.nl wrote: Hi Arvydas, Yes indeed, it would be great if you could test this! Note that the patch series is also available in my git tree: http://git.linuxtv.org/hverkuil/media_tree.git/shortlog/refs/heads/stkwebcam Besides the normal testing that everything works as expected, it would also be great if you could run the v4l2-compliance tool. It's part of the v4l-utils repository (http://git.linuxtv.org/v4l-utils.git) and it tests whether a driver complies to the V4L2 specification. Just compile the tool from the repository (don't use a distro-provided version) and run it as 'v4l2-compliance -d /dev/videoX' and mail me the output. You will get at least one failure at the end, but I'd like to know if there are other issues remaining. Regards, Hans I have tested the patches using STK-1135 webcam. Everything works well. $ v4l2-compliance -d /dev/video0 Driver Info: Driver name : stk Card type : stk Bus info : Driver version: 0.0.1 Capabilities : 0x0501 Video Capture Read/Write Streaming Compliance test for device /dev/video0 (not using libv4l2): Required ioctls: fail: v4l2-compliance.cpp(224): string empty fail: v4l2-compliance.cpp(276): check_ustring(vcap.bus_info, sizeof(vcap.bus_info)) test VIDIOC_QUERYCAP: FAIL Allow for multiple opens: test second video open: OK fail: v4l2-compliance.cpp(224): string empty fail: v4l2-compliance.cpp(276): check_ustring(vcap.bus_info, sizeof(vcap.bus_info)) test VIDIOC_QUERYCAP: FAIL fail: v4l2-compliance.cpp(334): doioctl(node, VIDIOC_G_PRIORITY, prio) test VIDIOC_G/S_PRIORITY: FAIL Debug ioctls: test VIDIOC_DBG_G_CHIP_IDENT: OK (Not Supported) test VIDIOC_DBG_G/S_REGISTER: OK (Not Supported) test VIDIOC_LOG_STATUS: OK (Not Supported) Input ioctls: test VIDIOC_G/S_TUNER: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported) test VIDIOC_ENUMAUDIO: OK (Not Supported) fail: v4l2-test-input-output.cpp(354): std == 0 fail: v4l2-test-input-output.cpp(409): invalid attributes for input 0 test VIDIOC_G/S/ENUMINPUT: FAIL test VIDIOC_G/S_AUDIO: OK (Not Supported) Inputs: 0 Audio Inputs: 0 Tuners: 0 Output ioctls: test VIDIOC_G/S_MODULATOR: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_ENUMAUDOUT: OK (Not Supported) test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported) test VIDIOC_G/S_AUDOUT: OK (Not Supported) Outputs: 0 Audio Outputs: 0 Modulators: 0 Control ioctls: fail: v4l2-test-controls.cpp(145): can do querymenu on a non-menu control fail: v4l2-test-controls.cpp(254): invalid control 00980900 test VIDIOC_QUERYCTRL/MENU: FAIL test VIDIOC_G/S_CTRL: OK test VIDIOC_G/S/TRY_EXT_CTRLS: OK (Not Supported) test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK (Not Supported) test VIDIOC_G/S_JPEGCOMP: OK (Not Supported) Standard Controls: 0 Private Controls: 0 Input/Output configuration ioctls: test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported) test VIDIOC_ENUM/G/S/QUERY_DV_PRESETS: OK (Not Supported) test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported) test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported) Format ioctls: test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK test VIDIOC_G/S_PARM: OK test VIDIOC_G_FBUF: OK (Not Supported) test VIDIOC_G_FMT: OK fail: v4l2-test-formats.cpp(385): priv is non-zero! test VIDIOC_TRY_FMT: FAIL fail: v4l2-test-formats.cpp(719): Video Capture is valid, but no S_FMT was implemented test VIDIOC_S_FMT: FAIL test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported) Codec ioctls: test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported) test VIDIOC_G_ENC_INDEX: OK (Not Supported) test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported) Buffer ioctls: fail: v4l2-test-buffers.cpp(132): ret != -1 test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: FAIL Total: 38, Succeeded: 30, Failed: 8, Warnings: 1 Arvydas -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFC PATCH 1/8] stk-webcam: various fixes.
On Tue February 5 2013 16:28:17 Arvydas Sidorenko wrote: On Mon, Feb 4, 2013 at 2:35 PM, Hans Verkuil hverk...@xs4all.nl wrote: Hi Arvydas, Yes indeed, it would be great if you could test this! Note that the patch series is also available in my git tree: http://git.linuxtv.org/hverkuil/media_tree.git/shortlog/refs/heads/stkwebcam Besides the normal testing that everything works as expected, it would also be great if you could run the v4l2-compliance tool. It's part of the v4l-utils repository (http://git.linuxtv.org/v4l-utils.git) and it tests whether a driver complies to the V4L2 specification. Just compile the tool from the repository (don't use a distro-provided version) and run it as 'v4l2-compliance -d /dev/videoX' and mail me the output. You will get at least one failure at the end, but I'd like to know if there are other issues remaining. Regards, Hans I have tested the patches using STK-1135 webcam. Everything works well. $ v4l2-compliance -d /dev/video0 Driver Info: Driver name : stk Card type : stk Bus info : Driver version: 0.0.1 This is the old version of the driver you are testing with :-) If you have the right version, then the driver version is much higher, bus info is filled in and you will see 'Device Caps' after the 'Capabilities' list. Regards, Hans Capabilities : 0x0501 Video Capture Read/Write Streaming Compliance test for device /dev/video0 (not using libv4l2): Required ioctls: fail: v4l2-compliance.cpp(224): string empty fail: v4l2-compliance.cpp(276): check_ustring(vcap.bus_info, sizeof(vcap.bus_info)) test VIDIOC_QUERYCAP: FAIL Allow for multiple opens: test second video open: OK fail: v4l2-compliance.cpp(224): string empty fail: v4l2-compliance.cpp(276): check_ustring(vcap.bus_info, sizeof(vcap.bus_info)) test VIDIOC_QUERYCAP: FAIL fail: v4l2-compliance.cpp(334): doioctl(node, VIDIOC_G_PRIORITY, prio) test VIDIOC_G/S_PRIORITY: FAIL Debug ioctls: test VIDIOC_DBG_G_CHIP_IDENT: OK (Not Supported) test VIDIOC_DBG_G/S_REGISTER: OK (Not Supported) test VIDIOC_LOG_STATUS: OK (Not Supported) Input ioctls: test VIDIOC_G/S_TUNER: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported) test VIDIOC_ENUMAUDIO: OK (Not Supported) fail: v4l2-test-input-output.cpp(354): std == 0 fail: v4l2-test-input-output.cpp(409): invalid attributes for input 0 test VIDIOC_G/S/ENUMINPUT: FAIL test VIDIOC_G/S_AUDIO: OK (Not Supported) Inputs: 0 Audio Inputs: 0 Tuners: 0 Output ioctls: test VIDIOC_G/S_MODULATOR: OK (Not Supported) test VIDIOC_G/S_FREQUENCY: OK (Not Supported) test VIDIOC_ENUMAUDOUT: OK (Not Supported) test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported) test VIDIOC_G/S_AUDOUT: OK (Not Supported) Outputs: 0 Audio Outputs: 0 Modulators: 0 Control ioctls: fail: v4l2-test-controls.cpp(145): can do querymenu on a non-menu control fail: v4l2-test-controls.cpp(254): invalid control 00980900 test VIDIOC_QUERYCTRL/MENU: FAIL test VIDIOC_G/S_CTRL: OK test VIDIOC_G/S/TRY_EXT_CTRLS: OK (Not Supported) test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK (Not Supported) test VIDIOC_G/S_JPEGCOMP: OK (Not Supported) Standard Controls: 0 Private Controls: 0 Input/Output configuration ioctls: test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported) test VIDIOC_ENUM/G/S/QUERY_DV_PRESETS: OK (Not Supported) test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported) test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported) Format ioctls: test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK test VIDIOC_G/S_PARM: OK test VIDIOC_G_FBUF: OK (Not Supported) test VIDIOC_G_FMT: OK fail: v4l2-test-formats.cpp(385): priv is non-zero! test VIDIOC_TRY_FMT: FAIL fail: v4l2-test-formats.cpp(719): Video Capture is valid, but no S_FMT was implemented test VIDIOC_S_FMT: FAIL test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported) Codec ioctls: test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported) test VIDIOC_G_ENC_INDEX: OK (Not Supported) test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported) Buffer ioctls: fail: v4l2-test-buffers.cpp(132): ret != -1 test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: FAIL Total: 38, Succeeded: 30, Failed: 8, Warnings: 1 Arvydas -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at
Re: [RFC PATCH 1/8] stk-webcam: various fixes.
On Tue, Feb 5, 2013 at 12:35 PM, Hans Verkuil hverk...@xs4all.nl wrote: On Tue February 5 2013 16:28:17 Arvydas Sidorenko wrote: On Mon, Feb 4, 2013 at 2:35 PM, Hans Verkuil hverk...@xs4all.nl wrote: Hi Arvydas, Yes indeed, it would be great if you could test this! Note that the patch series is also available in my git tree: http://git.linuxtv.org/hverkuil/media_tree.git/shortlog/refs/heads/stkwebcam Besides the normal testing that everything works as expected, it would also be great if you could run the v4l2-compliance tool. It's part of the v4l-utils repository (http://git.linuxtv.org/v4l-utils.git) and it tests whether a driver complies to the V4L2 specification. Just compile the tool from the repository (don't use a distro-provided version) and run it as 'v4l2-compliance -d /dev/videoX' and mail me the output. You will get at least one failure at the end, but I'd like to know if there are other issues remaining. Regards, Hans I have tested the patches using STK-1135 webcam. Everything works well. $ v4l2-compliance -d /dev/video0 Driver Info: Driver name : stk Card type : stk Bus info : Driver version: 0.0.1 This is the old version of the driver you are testing with :-) @Arvydas: First of all, thanks for taking the time to test Hans' patches. I suggest to double check the old driver is not loaded and then run depmod -a to update modules. As a last resource you can always wipe out the driver from /lib/modules/what-ever and reinstall. Hope this helps! -- Ezequiel -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFC PATCH 1/8] stk-webcam: various fixes.
On Tue, Feb 5, 2013 at 5:56 PM, Ezequiel Garcia elezegar...@gmail.com wrote:
On Tue, Feb 5, 2013 at 12:35 PM, Hans Verkuil hverk...@xs4all.nl wrote:
On Tue February 5 2013 16:28:17 Arvydas Sidorenko wrote:
I have tested the patches using STK-1135 webcam. Everything works well.
$ v4l2-compliance -d /dev/video0
Driver Info:
Driver name : stk
Card type : stk
Bus info :
Driver version: 0.0.1
This is the old version of the driver you are testing with :-)
@Arvydas: First of all, thanks for taking the time to test Hans' patches.
I suggest to double check the old driver
is not loaded and then run depmod -a to update modules.
As a last resource you can always wipe out the driver from
/lib/modules/what-ever and reinstall.
Hope this helps!
--
Ezequiel
Yes, I am sorry. I built the wrong branch.
The cam works, but the view is upside down.
$ v4l2-compliance -d /dev/video0
Driver Info:
Driver name : stk
Card type : stk
Bus info : 4-8
Driver version: 3.1.0
Capabilities : 0x8501
Video Capture
Read/Write
Streaming
Device Capabilities
Device Caps : 0x0501
Video Capture
Read/Write
Streaming
Compliance test for device /dev/video0 (not using libv4l2):
Required ioctls:
fail: v4l2-compliance.cpp(285): missing bus_info prefix ('4-8')
test VIDIOC_QUERYCAP: FAIL
Allow for multiple opens:
test second video open: OK
fail: v4l2-compliance.cpp(285): missing bus_info prefix ('4-8')
test VIDIOC_QUERYCAP: FAIL
test VIDIOC_G/S_PRIORITY: OK
Debug ioctls:
test VIDIOC_DBG_G_CHIP_IDENT: OK (Not Supported)
test VIDIOC_DBG_G/S_REGISTER: OK (Not Supported)
test VIDIOC_LOG_STATUS: OK
Input ioctls:
test VIDIOC_G/S_TUNER: OK (Not Supported)
test VIDIOC_G/S_FREQUENCY: OK (Not Supported)
test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported)
test VIDIOC_ENUMAUDIO: OK (Not Supported)
test VIDIOC_G/S/ENUMINPUT: OK
test VIDIOC_G/S_AUDIO: OK (Not Supported)
Inputs: 1 Audio Inputs: 0 Tuners: 0
Output ioctls:
test VIDIOC_G/S_MODULATOR: OK (Not Supported)
test VIDIOC_G/S_FREQUENCY: OK (Not Supported)
test VIDIOC_ENUMAUDOUT: OK (Not Supported)
test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported)
test VIDIOC_G/S_AUDOUT: OK (Not Supported)
Outputs: 0 Audio Outputs: 0 Modulators: 0
Control ioctls:
test VIDIOC_QUERYCTRL/MENU: OK
test VIDIOC_G/S_CTRL: OK
test VIDIOC_G/S/TRY_EXT_CTRLS: OK
test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK
test VIDIOC_G/S_JPEGCOMP: OK (Not Supported)
Standard Controls: 4 Private Controls: 0
Input/Output configuration ioctls:
test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported)
test VIDIOC_ENUM/G/S/QUERY_DV_PRESETS: OK (Not Supported)
test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported)
test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported)
Format ioctls:
test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK
test VIDIOC_G/S_PARM: OK
test VIDIOC_G_FBUF: OK (Not Supported)
test VIDIOC_G_FMT: OK
fail: v4l2-test-formats.cpp(566): Video Capture is valid, but
TRY_FMT failed to return a format
test VIDIOC_TRY_FMT: FAIL
fail: v4l2-test-formats.cpp(719): Video Capture is valid, but no
S_FMT was implemented
test VIDIOC_S_FMT: FAIL
test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported)
Codec ioctls:
test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported)
test VIDIOC_G_ENC_INDEX: OK (Not Supported)
test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported)
Buffer ioctls:
fail: v4l2-test-buffers.cpp(132): ret != -1
test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: FAIL
Total: 38, Succeeded: 33, Failed: 5, Warnings: 0
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFC PATCH 1/8] stk-webcam: various fixes.
On Tue February 5 2013 18:08:31 Arvydas Sidorenko wrote:
On Tue, Feb 5, 2013 at 5:56 PM, Ezequiel Garcia elezegar...@gmail.com wrote:
On Tue, Feb 5, 2013 at 12:35 PM, Hans Verkuil hverk...@xs4all.nl wrote:
On Tue February 5 2013 16:28:17 Arvydas Sidorenko wrote:
I have tested the patches using STK-1135 webcam. Everything works well.
$ v4l2-compliance -d /dev/video0
Driver Info:
Driver name : stk
Card type : stk
Bus info :
Driver version: 0.0.1
This is the old version of the driver you are testing with :-)
@Arvydas: First of all, thanks for taking the time to test Hans' patches.
I suggest to double check the old driver
is not loaded and then run depmod -a to update modules.
As a last resource you can always wipe out the driver from
/lib/modules/what-ever and reinstall.
Hope this helps!
--
Ezequiel
Yes, I am sorry. I built the wrong branch.
The cam works, but the view is upside down.
Hmm, can you try this without my patches? Some work has been done recently
regarding upside-down sensors and I need to know whether I broke it or
whether those earlier changes broke it for you. I checked my code and I
didn't see anything obviously wrong.
$ v4l2-compliance -d /dev/video0
Driver Info:
Driver name : stk
Card type : stk
Bus info : 4-8
Driver version: 3.1.0
Capabilities : 0x8501
Video Capture
Read/Write
Streaming
Device Capabilities
Device Caps : 0x0501
Video Capture
Read/Write
Streaming
Compliance test for device /dev/video0 (not using libv4l2):
Required ioctls:
fail: v4l2-compliance.cpp(285): missing bus_info prefix ('4-8')
Correct, that's my fault. I've fixed that in my git branch.
test VIDIOC_QUERYCAP: FAIL
Allow for multiple opens:
test second video open: OK
fail: v4l2-compliance.cpp(285): missing bus_info prefix ('4-8')
test VIDIOC_QUERYCAP: FAIL
test VIDIOC_G/S_PRIORITY: OK
Debug ioctls:
test VIDIOC_DBG_G_CHIP_IDENT: OK (Not Supported)
test VIDIOC_DBG_G/S_REGISTER: OK (Not Supported)
test VIDIOC_LOG_STATUS: OK
Input ioctls:
test VIDIOC_G/S_TUNER: OK (Not Supported)
test VIDIOC_G/S_FREQUENCY: OK (Not Supported)
test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported)
test VIDIOC_ENUMAUDIO: OK (Not Supported)
test VIDIOC_G/S/ENUMINPUT: OK
test VIDIOC_G/S_AUDIO: OK (Not Supported)
Inputs: 1 Audio Inputs: 0 Tuners: 0
Output ioctls:
test VIDIOC_G/S_MODULATOR: OK (Not Supported)
test VIDIOC_G/S_FREQUENCY: OK (Not Supported)
test VIDIOC_ENUMAUDOUT: OK (Not Supported)
test VIDIOC_G/S/ENUMOUTPUT: OK (Not Supported)
test VIDIOC_G/S_AUDOUT: OK (Not Supported)
Outputs: 0 Audio Outputs: 0 Modulators: 0
Control ioctls:
test VIDIOC_QUERYCTRL/MENU: OK
test VIDIOC_G/S_CTRL: OK
test VIDIOC_G/S/TRY_EXT_CTRLS: OK
test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: OK
test VIDIOC_G/S_JPEGCOMP: OK (Not Supported)
Standard Controls: 4 Private Controls: 0
Input/Output configuration ioctls:
test VIDIOC_ENUM/G/S/QUERY_STD: OK (Not Supported)
test VIDIOC_ENUM/G/S/QUERY_DV_PRESETS: OK (Not Supported)
test VIDIOC_ENUM/G/S/QUERY_DV_TIMINGS: OK (Not Supported)
test VIDIOC_DV_TIMINGS_CAP: OK (Not Supported)
Format ioctls:
test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK
test VIDIOC_G/S_PARM: OK
test VIDIOC_G_FBUF: OK (Not Supported)
test VIDIOC_G_FMT: OK
fail: v4l2-test-formats.cpp(566): Video Capture is valid, but
TRY_FMT failed to return a format
test VIDIOC_TRY_FMT: FAIL
fail: v4l2-test-formats.cpp(719): Video Capture is valid, but no
S_FMT was implemented
Are you sure you are using the v4l2-compliance from the latest v4l-utils.git
repository? I've made some changes in these format compliance tests and I think
you don't have those changes.
test VIDIOC_S_FMT: FAIL
test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported)
Codec ioctls:
test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported)
test VIDIOC_G_ENC_INDEX: OK (Not Supported)
test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported)
Buffer ioctls:
fail: v4l2-test-buffers.cpp(132): ret != -1
I need to look into this a bit more. I probably need to improve v4l2-compliance
itself so I get better feedback as to which error is actually returned here.
Thank you very much for testing!
Regards,
Hans
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFC PATCH 1/8] stk-webcam: various fixes.
On Tue February 5 2013 19:41:31 Hans Verkuil wrote: Buffer ioctls: fail: v4l2-test-buffers.cpp(132): ret != -1 I need to look into this a bit more. I probably need to improve v4l2-compliance itself so I get better feedback as to which error is actually returned here. I've improved v4l2-compliance a bit, but I've also pushed a fix (I hope) to my git branch. It's great if you can test this! Regards, Hans Thank you very much for testing! Regards, Hans -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[RFC PATCH 1/8] stk-webcam: various fixes.
This patch series updates this driver to the control framework, switches it to unlocked_ioctl, fixes a variety of V4L2 compliance issues. It compiles, but to my knowledge nobody has hardware to test this :-( If anyone has hardware to test this, please let me know! Regards, Hans -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFC PATCH 1/8] stk-webcam: various fixes.
Hi, On 02/04/2013 01:36 PM, Hans Verkuil wrote: This patch series updates this driver to the control framework, switches it to unlocked_ioctl, fixes a variety of V4L2 compliance issues. Good stuff! It compiles, but to my knowledge nobody has hardware to test this :-( If anyone has hardware to test this, please let me know! I've recently done some changes to stk-webcam because of upside-down issues with it, and my changes where (eventually) tested by the upside-down bug-reporter. I'll send you his mail-address in a private mail. I would like to suggest to keep this series as RFC only until this is actually tested, since this driver is still being actively used, so regressing on it would be bad. Regards, Hans -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFC PATCH 1/8] stk-webcam: various fixes.
Hello Hans, On Mon, Feb 4, 2013 at 9:36 AM, Hans Verkuil hverk...@xs4all.nl wrote: This patch series updates this driver to the control framework, switches it to unlocked_ioctl, fixes a variety of V4L2 compliance issues. It compiles, but to my knowledge nobody has hardware to test this :-( If anyone has hardware to test this, please let me know! I've sent a patch for stk-webcam recently and Arvydas Sidorenko (in Cc) was kind enough to test it. @Arvydas: If you're not too busy, we'd really appreciate a lot if you can test this series. Thanks a lot, -- Ezequiel -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFC PATCH 1/8] stk-webcam: various fixes.
On Mon February 4 2013 14:23:55 Ezequiel Garcia wrote: Hello Hans, On Mon, Feb 4, 2013 at 9:36 AM, Hans Verkuil hverk...@xs4all.nl wrote: This patch series updates this driver to the control framework, switches it to unlocked_ioctl, fixes a variety of V4L2 compliance issues. It compiles, but to my knowledge nobody has hardware to test this :-( If anyone has hardware to test this, please let me know! I've sent a patch for stk-webcam recently and Arvydas Sidorenko (in Cc) was kind enough to test it. @Arvydas: If you're not too busy, we'd really appreciate a lot if you can test this series. Hi Arvydas, Yes indeed, it would be great if you could test this! Note that the patch series is also available in my git tree: http://git.linuxtv.org/hverkuil/media_tree.git/shortlog/refs/heads/stkwebcam Besides the normal testing that everything works as expected, it would also be great if you could run the v4l2-compliance tool. It's part of the v4l-utils repository (http://git.linuxtv.org/v4l-utils.git) and it tests whether a driver complies to the V4L2 specification. Just compile the tool from the repository (don't use a distro-provided version) and run it as 'v4l2-compliance -d /dev/videoX' and mail me the output. You will get at least one failure at the end, but I'd like to know if there are other issues remaining. Regards, Hans -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
