Re: [patch] [media] davinci: remove an unneeded check

[Prabhakar Lad]

Hi Dan,

Thanks for the patch!

On Mon, Sep 22, 2014 at 9:00 AM, Dan Carpenter dan.carpen...@oracle.com wrote:
 We don't need to check ret, we know it's zero.

 Signed-off-by: Dan Carpenter dan.carpen...@oracle.com

Acked-by: Lad, Prabhakar prabhakar.cse...@gmail.com

Regards,
--Prabhakar Lad


 diff --git a/drivers/media/platform/davinci/vpfe_capture.c 
 b/drivers/media/platform/davinci/vpfe_capture.c
 index c557eb5..3eb6e4b 100644
 --- a/drivers/media/platform/davinci/vpfe_capture.c
 +++ b/drivers/media/platform/davinci/vpfe_capture.c
 @@ -442,11 +442,10 @@ static int vpfe_config_image_format(struct vpfe_device 
 *vpfe_dev,
 return ret;

 /* Update the values of sizeimage and bytesperline */
 -   if (!ret) {
 -   pix-bytesperline = ccdc_dev-hw_ops.get_line_length();
 -   pix-sizeimage = pix-bytesperline * pix-height;
 -   }
 -   return ret;
 +   pix-bytesperline = ccdc_dev-hw_ops.get_line_length();
 +   pix-sizeimage = pix-bytesperline * pix-height;
 +
 +   return 0;
  }

  static int vpfe_initialize_device(struct vpfe_device *vpfe_dev)
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[patch] [media] davinci: remove an unneeded check

[Dan Carpenter]

We don't need to check ret, we know it's zero.

Signed-off-by: Dan Carpenter dan.carpen...@oracle.com

diff --git a/drivers/media/platform/davinci/vpfe_capture.c 
b/drivers/media/platform/davinci/vpfe_capture.c
index c557eb5..3eb6e4b 100644
--- a/drivers/media/platform/davinci/vpfe_capture.c
+++ b/drivers/media/platform/davinci/vpfe_capture.c
@@ -442,11 +442,10 @@ static int vpfe_config_image_format(struct vpfe_device 
*vpfe_dev,
return ret;
 
/* Update the values of sizeimage and bytesperline */
-   if (!ret) {
-   pix-bytesperline = ccdc_dev-hw_ops.get_line_length();
-   pix-sizeimage = pix-bytesperline * pix-height;
-   }
-   return ret;
+   pix-bytesperline = ccdc_dev-hw_ops.get_line_length();
+   pix-sizeimage = pix-bytesperline * pix-height;
+
+   return 0;
 }
 
 static int vpfe_initialize_device(struct vpfe_device *vpfe_dev)
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html