Re: [v7] media: coda: Add driver for Coda video codec.
On 20 August 2012 05:03, Richard Zhao wrote: > Hi Javier, > > Did the patch get picked? I didn't see it on > git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media.git It got merged 6 days ago in 'for_v3.7' branch of the linux-media tree: http://git.linuxtv.org/media_tree.git/commitdiff/186b250a07253770717f41eee911b8c5467be04e?hp=6d8c4529f8058b4e8c902fe689786877f2224060 > > Still, how did you test this v4l2 device? Using V4L2 API in a mem2mem basis, i.e. the driver has one output and one capture interface that must be configured independently. Regards. -- Javier Martin Vista Silicon S.L. CDTUC - FASE C - Oficina S-345 Avda de los Castros s/n 39005- Santander. Cantabria. Spain +34 942 25 32 60 www.vista-silicon.com -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [v7] media: coda: Add driver for Coda video codec.
Hi Javier, Did the patch get picked? I didn't see it on git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media.git Still, how did you test this v4l2 device? Thanks Richard On Fri, Aug 03, 2012 at 01:21:02PM +0200, javier Martin wrote: > Hi Richard, > thank you for your review. > > This patch has been reviewed and acked by several people: > > Reviewed-by: Philipp Zabel > Reviewed-by: Sylwester Nawrocki > Acked-by: Hans Verkuil > > For this reason a pull request has already been sent to Mauro recently: > > http://patchwork.linuxtv.org/patch/13483/ > > > >> In this case I personally don't think it will be easier to read if this > >> line is split up. > > My point here is checkpatch. > > total: 2 errors, 30 warnings, 2086 lines checked > > Thank you for noticing this. I have solved it in my tree so that Mauro > can pull for 3.7. > > You can find it here: > > https://github.com/jmartinc/video_visstrim.git for_3.6 > > Regarding your i.MX6 question, maybe Philippe will be able to help you > since I am only interested on i.MX27. However, the driver was > developed considering much of his suggestions so that adding support > for different chips later is as straightforward as possible. > > -- > Javier Martin > Vista Silicon S.L. > CDTUC - FASE C - Oficina S-345 > Avda de los Castros s/n > 39005- Santander. Cantabria. Spain > +34 942 25 32 60 > www.vista-silicon.com > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [v7] media: coda: Add driver for Coda video codec.
Hi Richard, thank you for your review. This patch has been reviewed and acked by several people: Reviewed-by: Philipp Zabel Reviewed-by: Sylwester Nawrocki Acked-by: Hans Verkuil For this reason a pull request has already been sent to Mauro recently: http://patchwork.linuxtv.org/patch/13483/ >> In this case I personally don't think it will be easier to read if this line >> is split up. > My point here is checkpatch. > total: 2 errors, 30 warnings, 2086 lines checked Thank you for noticing this. I have solved it in my tree so that Mauro can pull for 3.7. You can find it here: https://github.com/jmartinc/video_visstrim.git for_3.6 Regarding your i.MX6 question, maybe Philippe will be able to help you since I am only interested on i.MX27. However, the driver was developed considering much of his suggestions so that adding support for different chips later is as straightforward as possible. -- Javier Martin Vista Silicon S.L. CDTUC - FASE C - Oficina S-345 Avda de los Castros s/n 39005- Santander. Cantabria. Spain +34 942 25 32 60 www.vista-silicon.com -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [v7] media: coda: Add driver for Coda video codec.
On Fri, Aug 03, 2012 at 10:47:01AM +0200, Hans Verkuil wrote:
> On Fri August 3 2012 10:24:43 Richard Zhao wrote:
> > Hi Javier,
> >
> > Glad to see the vpu patch. I'd like to try it on imx6. What else
> > do I need to do besides add vpu devices in dts? Do you have a gst
> > plugin or any other test program to test it?
> >
> > Please also see below comments.
> >
> > On Mon, Jul 23, 2012 at 11:31:01AM +, Javier Martin wrote:
> > > Coda is a range of video codecs from Chips&Media that
> > > support H.264, H.263, MPEG4 and other video standards.
> > >
> > > Currently only support for the codadx6 included in the
> > > i.MX27 SoC is added. H.264 and MPEG4 video encoding
> > > are the only supported capabilities by now.
> > >
> > > Signed-off-by: Javier Martin
> > > Acked-by: Hans Verkuil
> > > Reviewed-by: Sylwester Nawrocki
> > >
> > > ---
> > > Changes since v6:
> > > - Cosmetic fixes pointed out by Sakari.
> > > - Now passes 'v4l2-compliance'.
> > >
> > > ---
> > > drivers/media/video/Kconfig |9 +
> > > drivers/media/video/Makefile |1 +
> > > drivers/media/video/coda.c | 1848
> > > ++
> > > drivers/media/video/coda.h | 216 +
> > > 4 files changed, 2074 insertions(+)
> > > create mode 100644 drivers/media/video/coda.c
> > > create mode 100644 drivers/media/video/coda.h
> > >
> >
> > [...]
> >
> > > +static int coda_start_streaming(struct vb2_queue *q, unsigned int count)
> > > +{
> > > + struct coda_ctx *ctx = vb2_get_drv_priv(q);
> > > + struct v4l2_device *v4l2_dev = &ctx->dev->v4l2_dev;
> > > + u32 bitstream_buf, bitstream_size;
> > > + struct coda_dev *dev = ctx->dev;
> > > + struct coda_q_data *q_data_src, *q_data_dst;
> > > + u32 dst_fourcc;
> > > + struct vb2_buffer *buf;
> > > + struct vb2_queue *src_vq;
> > > + u32 value;
> > > + int i = 0;
> > > +
> > > + if (count < 1)
> > > + return -EINVAL;
> > > +
> > > + if (q->type == V4L2_BUF_TYPE_VIDEO_OUTPUT)
> > > + ctx->rawstreamon = 1;
> > > + else
> > > + ctx->compstreamon = 1;
> > > +
> > > + /* Don't start the coda unless both queues are on */
> > > + if (!(ctx->rawstreamon & ctx->compstreamon))
> > > + return 0;
> > > +
> > Remove spaces above.
> > > + ctx->gopcounter = ctx->params.gop_size - 1;
> > > +
> > > + q_data_src = get_q_data(ctx, V4L2_BUF_TYPE_VIDEO_OUTPUT);
> > > + buf = v4l2_m2m_next_dst_buf(ctx->m2m_ctx);
> > > + bitstream_buf = vb2_dma_contig_plane_dma_addr(buf, 0);
> > > + q_data_dst = get_q_data(ctx, V4L2_BUF_TYPE_VIDEO_CAPTURE);
> > > + bitstream_size = q_data_dst->sizeimage;
> > > + dst_fourcc = q_data_dst->fmt->fourcc;
> > > +
> > > + /* Find out whether coda must encode or decode */
> > > + if (q_data_src->fmt->type == CODA_FMT_RAW &&
> > > + q_data_dst->fmt->type == CODA_FMT_ENC) {
> > > + ctx->inst_type = CODA_INST_ENCODER;
> > > + } else if (q_data_src->fmt->type == CODA_FMT_ENC &&
> > > +q_data_dst->fmt->type == CODA_FMT_RAW) {
> > > + ctx->inst_type = CODA_INST_DECODER;
> > > + v4l2_err(v4l2_dev, "decoding not supported.\n");
> > > + return -EINVAL;
> > > + } else {
> > > + v4l2_err(v4l2_dev, "couldn't tell instance type.\n");
> > > + return -EINVAL;
> > > + }
> > > +
> > > + if (!coda_is_initialized(dev)) {
> > > + v4l2_err(v4l2_dev, "coda is not initialized.\n");
> > > + return -EFAULT;
> > > + }
> > > + coda_write(dev, ctx->parabuf.paddr, CODA_REG_BIT_PARA_BUF_ADDR);
> > > + coda_write(dev, bitstream_buf, CODA_REG_BIT_RD_PTR(ctx->idx));
> > > + coda_write(dev, bitstream_buf, CODA_REG_BIT_WR_PTR(ctx->idx));
> > > + switch (dev->devtype->product) {
> > > + case CODA_DX6:
> > > + coda_write(dev, CODADX6_STREAM_BUF_DYNALLOC_EN |
> > > + CODADX6_STREAM_BUF_PIC_RESET, CODA_REG_BIT_STREAM_CTRL);
> > > + break;
> > > + default:
> > > + coda_write(dev, CODA7_STREAM_BUF_DYNALLOC_EN |
> > > + CODA7_STREAM_BUF_PIC_RESET, CODA_REG_BIT_STREAM_CTRL);
> > > + }
> > > +
> > > + /* Configure the coda */
> > > + coda_write(dev, 0x4c00, CODA_REG_BIT_SEARCH_RAM_BASE_ADDR);
> > > +
> > > + /* Could set rotation here if needed */
> > > + switch (dev->devtype->product) {
> > > + case CODA_DX6:
> > > + value = (q_data_src->width & CODADX6_PICWIDTH_MASK) <<
> > > CODADX6_PICWIDTH_OFFSET;
> > longer than 80 characters. Could you run checkpatch to do further check?
>
> This is a checkpatch warning, not an error. One should use one's own
> judgement whether
> to take action or not. It is more important that the code is readable than
> that it fits
> within 80 characters, although long lines can be an indication of poor
> readability.
Yes, you are right. I don't insist but I like cut it off except for
files like register definition with aligned lines.
>
> In this case I personally don't think it will be easier to read if this line
> is split up.
My point here is checkpatch.
to
Re: [v7] media: coda: Add driver for Coda video codec.
On Fri August 3 2012 10:24:43 Richard Zhao wrote:
> Hi Javier,
>
> Glad to see the vpu patch. I'd like to try it on imx6. What else
> do I need to do besides add vpu devices in dts? Do you have a gst
> plugin or any other test program to test it?
>
> Please also see below comments.
>
> On Mon, Jul 23, 2012 at 11:31:01AM +, Javier Martin wrote:
> > Coda is a range of video codecs from Chips&Media that
> > support H.264, H.263, MPEG4 and other video standards.
> >
> > Currently only support for the codadx6 included in the
> > i.MX27 SoC is added. H.264 and MPEG4 video encoding
> > are the only supported capabilities by now.
> >
> > Signed-off-by: Javier Martin
> > Acked-by: Hans Verkuil
> > Reviewed-by: Sylwester Nawrocki
> >
> > ---
> > Changes since v6:
> > - Cosmetic fixes pointed out by Sakari.
> > - Now passes 'v4l2-compliance'.
> >
> > ---
> > drivers/media/video/Kconfig |9 +
> > drivers/media/video/Makefile |1 +
> > drivers/media/video/coda.c | 1848
> > ++
> > drivers/media/video/coda.h | 216 +
> > 4 files changed, 2074 insertions(+)
> > create mode 100644 drivers/media/video/coda.c
> > create mode 100644 drivers/media/video/coda.h
> >
>
> [...]
>
> > +static int coda_start_streaming(struct vb2_queue *q, unsigned int count)
> > +{
> > + struct coda_ctx *ctx = vb2_get_drv_priv(q);
> > + struct v4l2_device *v4l2_dev = &ctx->dev->v4l2_dev;
> > + u32 bitstream_buf, bitstream_size;
> > + struct coda_dev *dev = ctx->dev;
> > + struct coda_q_data *q_data_src, *q_data_dst;
> > + u32 dst_fourcc;
> > + struct vb2_buffer *buf;
> > + struct vb2_queue *src_vq;
> > + u32 value;
> > + int i = 0;
> > +
> > + if (count < 1)
> > + return -EINVAL;
> > +
> > + if (q->type == V4L2_BUF_TYPE_VIDEO_OUTPUT)
> > + ctx->rawstreamon = 1;
> > + else
> > + ctx->compstreamon = 1;
> > +
> > + /* Don't start the coda unless both queues are on */
> > + if (!(ctx->rawstreamon & ctx->compstreamon))
> > + return 0;
> > +
> Remove spaces above.
> > + ctx->gopcounter = ctx->params.gop_size - 1;
> > +
> > + q_data_src = get_q_data(ctx, V4L2_BUF_TYPE_VIDEO_OUTPUT);
> > + buf = v4l2_m2m_next_dst_buf(ctx->m2m_ctx);
> > + bitstream_buf = vb2_dma_contig_plane_dma_addr(buf, 0);
> > + q_data_dst = get_q_data(ctx, V4L2_BUF_TYPE_VIDEO_CAPTURE);
> > + bitstream_size = q_data_dst->sizeimage;
> > + dst_fourcc = q_data_dst->fmt->fourcc;
> > +
> > + /* Find out whether coda must encode or decode */
> > + if (q_data_src->fmt->type == CODA_FMT_RAW &&
> > + q_data_dst->fmt->type == CODA_FMT_ENC) {
> > + ctx->inst_type = CODA_INST_ENCODER;
> > + } else if (q_data_src->fmt->type == CODA_FMT_ENC &&
> > + q_data_dst->fmt->type == CODA_FMT_RAW) {
> > + ctx->inst_type = CODA_INST_DECODER;
> > + v4l2_err(v4l2_dev, "decoding not supported.\n");
> > + return -EINVAL;
> > + } else {
> > + v4l2_err(v4l2_dev, "couldn't tell instance type.\n");
> > + return -EINVAL;
> > + }
> > +
> > + if (!coda_is_initialized(dev)) {
> > + v4l2_err(v4l2_dev, "coda is not initialized.\n");
> > + return -EFAULT;
> > + }
> > + coda_write(dev, ctx->parabuf.paddr, CODA_REG_BIT_PARA_BUF_ADDR);
> > + coda_write(dev, bitstream_buf, CODA_REG_BIT_RD_PTR(ctx->idx));
> > + coda_write(dev, bitstream_buf, CODA_REG_BIT_WR_PTR(ctx->idx));
> > + switch (dev->devtype->product) {
> > + case CODA_DX6:
> > + coda_write(dev, CODADX6_STREAM_BUF_DYNALLOC_EN |
> > + CODADX6_STREAM_BUF_PIC_RESET, CODA_REG_BIT_STREAM_CTRL);
> > + break;
> > + default:
> > + coda_write(dev, CODA7_STREAM_BUF_DYNALLOC_EN |
> > + CODA7_STREAM_BUF_PIC_RESET, CODA_REG_BIT_STREAM_CTRL);
> > + }
> > +
> > + /* Configure the coda */
> > + coda_write(dev, 0x4c00, CODA_REG_BIT_SEARCH_RAM_BASE_ADDR);
> > +
> > + /* Could set rotation here if needed */
> > + switch (dev->devtype->product) {
> > + case CODA_DX6:
> > + value = (q_data_src->width & CODADX6_PICWIDTH_MASK) <<
> > CODADX6_PICWIDTH_OFFSET;
> longer than 80 characters. Could you run checkpatch to do further check?
This is a checkpatch warning, not an error. One should use one's own judgement
whether
to take action or not. It is more important that the code is readable than that
it fits
within 80 characters, although long lines can be an indication of poor
readability.
In this case I personally don't think it will be easier to read if this line is
split up.
Regards,
Hans
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [v7] media: coda: Add driver for Coda video codec.
Hi Javier,
Glad to see the vpu patch. I'd like to try it on imx6. What else
do I need to do besides add vpu devices in dts? Do you have a gst
plugin or any other test program to test it?
Please also see below comments.
On Mon, Jul 23, 2012 at 11:31:01AM +, Javier Martin wrote:
> Coda is a range of video codecs from Chips&Media that
> support H.264, H.263, MPEG4 and other video standards.
>
> Currently only support for the codadx6 included in the
> i.MX27 SoC is added. H.264 and MPEG4 video encoding
> are the only supported capabilities by now.
>
> Signed-off-by: Javier Martin
> Acked-by: Hans Verkuil
> Reviewed-by: Sylwester Nawrocki
>
> ---
> Changes since v6:
> - Cosmetic fixes pointed out by Sakari.
> - Now passes 'v4l2-compliance'.
>
> ---
> drivers/media/video/Kconfig |9 +
> drivers/media/video/Makefile |1 +
> drivers/media/video/coda.c | 1848
> ++
> drivers/media/video/coda.h | 216 +
> 4 files changed, 2074 insertions(+)
> create mode 100644 drivers/media/video/coda.c
> create mode 100644 drivers/media/video/coda.h
>
[...]
> +static int coda_start_streaming(struct vb2_queue *q, unsigned int count)
> +{
> + struct coda_ctx *ctx = vb2_get_drv_priv(q);
> + struct v4l2_device *v4l2_dev = &ctx->dev->v4l2_dev;
> + u32 bitstream_buf, bitstream_size;
> + struct coda_dev *dev = ctx->dev;
> + struct coda_q_data *q_data_src, *q_data_dst;
> + u32 dst_fourcc;
> + struct vb2_buffer *buf;
> + struct vb2_queue *src_vq;
> + u32 value;
> + int i = 0;
> +
> + if (count < 1)
> + return -EINVAL;
> +
> + if (q->type == V4L2_BUF_TYPE_VIDEO_OUTPUT)
> + ctx->rawstreamon = 1;
> + else
> + ctx->compstreamon = 1;
> +
> + /* Don't start the coda unless both queues are on */
> + if (!(ctx->rawstreamon & ctx->compstreamon))
> + return 0;
> +
Remove spaces above.
> + ctx->gopcounter = ctx->params.gop_size - 1;
> +
> + q_data_src = get_q_data(ctx, V4L2_BUF_TYPE_VIDEO_OUTPUT);
> + buf = v4l2_m2m_next_dst_buf(ctx->m2m_ctx);
> + bitstream_buf = vb2_dma_contig_plane_dma_addr(buf, 0);
> + q_data_dst = get_q_data(ctx, V4L2_BUF_TYPE_VIDEO_CAPTURE);
> + bitstream_size = q_data_dst->sizeimage;
> + dst_fourcc = q_data_dst->fmt->fourcc;
> +
> + /* Find out whether coda must encode or decode */
> + if (q_data_src->fmt->type == CODA_FMT_RAW &&
> + q_data_dst->fmt->type == CODA_FMT_ENC) {
> + ctx->inst_type = CODA_INST_ENCODER;
> + } else if (q_data_src->fmt->type == CODA_FMT_ENC &&
> +q_data_dst->fmt->type == CODA_FMT_RAW) {
> + ctx->inst_type = CODA_INST_DECODER;
> + v4l2_err(v4l2_dev, "decoding not supported.\n");
> + return -EINVAL;
> + } else {
> + v4l2_err(v4l2_dev, "couldn't tell instance type.\n");
> + return -EINVAL;
> + }
> +
> + if (!coda_is_initialized(dev)) {
> + v4l2_err(v4l2_dev, "coda is not initialized.\n");
> + return -EFAULT;
> + }
> + coda_write(dev, ctx->parabuf.paddr, CODA_REG_BIT_PARA_BUF_ADDR);
> + coda_write(dev, bitstream_buf, CODA_REG_BIT_RD_PTR(ctx->idx));
> + coda_write(dev, bitstream_buf, CODA_REG_BIT_WR_PTR(ctx->idx));
> + switch (dev->devtype->product) {
> + case CODA_DX6:
> + coda_write(dev, CODADX6_STREAM_BUF_DYNALLOC_EN |
> + CODADX6_STREAM_BUF_PIC_RESET, CODA_REG_BIT_STREAM_CTRL);
> + break;
> + default:
> + coda_write(dev, CODA7_STREAM_BUF_DYNALLOC_EN |
> + CODA7_STREAM_BUF_PIC_RESET, CODA_REG_BIT_STREAM_CTRL);
> + }
> +
> + /* Configure the coda */
> + coda_write(dev, 0x4c00, CODA_REG_BIT_SEARCH_RAM_BASE_ADDR);
> +
> + /* Could set rotation here if needed */
> + switch (dev->devtype->product) {
> + case CODA_DX6:
> + value = (q_data_src->width & CODADX6_PICWIDTH_MASK) <<
> CODADX6_PICWIDTH_OFFSET;
longer than 80 characters. Could you run checkpatch to do further check?
> + break;
> + default:
> + value = (q_data_src->width & CODA7_PICWIDTH_MASK) <<
> CODA7_PICWIDTH_OFFSET;
> + }
> + value |= (q_data_src->height & CODA_PICHEIGHT_MASK) <<
> CODA_PICHEIGHT_OFFSET;
> + coda_write(dev, value, CODA_CMD_ENC_SEQ_SRC_SIZE);
> + coda_write(dev, ctx->params.framerate,
> +CODA_CMD_ENC_SEQ_SRC_F_RATE);
> +
[...]
> +static int coda_firmware_request(struct coda_dev *dev)
> +{
> + char *fw = dev->devtype->firmware;
> +
> + dev_dbg(&dev->plat_dev->dev, "requesting firmware '%s' for %s\n", fw,
> + coda_product_name(dev->devtype->product));
> +
> + return request_firmware_nowait(THIS_MODULE, true,
> + fw, &dev->plat_dev->dev, GFP_KERNEL, dev, coda_fw_callback);
why not remove the wrapper and call request_firmware_no
Re: [PATCH v7] media: coda: Add driver for Coda video codec.
On 07/23/2012 01:56 PM, javier Martin wrote: > > Sakari, Sylwester could I get an ack from you too? Sure, I just replied in the patch thread. -- Thanks, Sylwester -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v7] media: coda: Add driver for Coda video codec.
On 07/23/2012 01:31 PM, Javier Martin wrote: > Coda is a range of video codecs from Chips&Media that > support H.264, H.263, MPEG4 and other video standards. > > Currently only support for the codadx6 included in the > i.MX27 SoC is added. H.264 and MPEG4 video encoding > are the only supported capabilities by now. > > Signed-off-by: Javier Martin Reviewed-by: Sylwester Nawrocki -- Regards, Sylwester -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v7] media: coda: Add driver for Coda video codec.
On Mon July 23 2012 13:56:49 javier Martin wrote: > On 23 July 2012 13:38, Hans Verkuil wrote: > > On Mon July 23 2012 13:31:01 Javier Martin wrote: > >> Coda is a range of video codecs from Chips&Media that > >> support H.264, H.263, MPEG4 and other video standards. > >> > >> Currently only support for the codadx6 included in the > >> i.MX27 SoC is added. H.264 and MPEG4 video encoding > >> are the only supported capabilities by now. > >> > >> Signed-off-by: Javier Martin > >> --- > >> Changes since v6: > >> - Cosmetic fixes pointed out by Sakari. > >> - Now passes 'v4l2-compliance'. > > > > Acked-by: Hans Verkuil > > > > Regards, > > > > Hans > > Thank you Hans. > Do you plan to make a new release of libv4l? No, but v4l2-compliance doesn't decide that. I think it is Hans de Goede anyway who (co-?)decides when a new release is made. Regards, Hans -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v7] media: coda: Add driver for Coda video codec.
On 23 July 2012 13:38, Hans Verkuil wrote: > On Mon July 23 2012 13:31:01 Javier Martin wrote: >> Coda is a range of video codecs from Chips&Media that >> support H.264, H.263, MPEG4 and other video standards. >> >> Currently only support for the codadx6 included in the >> i.MX27 SoC is added. H.264 and MPEG4 video encoding >> are the only supported capabilities by now. >> >> Signed-off-by: Javier Martin >> --- >> Changes since v6: >> - Cosmetic fixes pointed out by Sakari. >> - Now passes 'v4l2-compliance'. > > Acked-by: Hans Verkuil > > Regards, > > Hans Thank you Hans. Do you plan to make a new release of libv4l? Sakari, Sylwester could I get an ack from you too? Regards. -- Javier Martin Vista Silicon S.L. CDTUC - FASE C - Oficina S-345 Avda de los Castros s/n 39005- Santander. Cantabria. Spain +34 942 25 32 60 www.vista-silicon.com -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v7] media: coda: Add driver for Coda video codec.
On Mon July 23 2012 13:31:01 Javier Martin wrote: > Coda is a range of video codecs from Chips&Media that > support H.264, H.263, MPEG4 and other video standards. > > Currently only support for the codadx6 included in the > i.MX27 SoC is added. H.264 and MPEG4 video encoding > are the only supported capabilities by now. > > Signed-off-by: Javier Martin > --- > Changes since v6: > - Cosmetic fixes pointed out by Sakari. > - Now passes 'v4l2-compliance'. Acked-by: Hans Verkuil Regards, Hans -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
