Re: Bug in mxl5005s driver

2009-03-23 Thread Andy Walls
On Sun, 2009-03-22 at 22:31 +0100, Jose Alberto Reguero wrote:
 In line 3992:
 
 if (fe-ops.info.type == FE_ATSC) {
 switch (params-u.vsb.modulation) {
 case VSB_8:
 req_mode = MXL_ATSC; break;
 default:
 case QAM_64:
 case QAM_256:
 case QAM_AUTO:
 req_mode = MXL_QAM; break;
 }
 } else
 req_mode = MXL_DVBT;
 
 req_mode is filled with MXL_ATSC, MXL_QAM, or MXL_DVBT
 
 and in line 4007 req_mode is used like params-u.vsb.modulation
 
 switch (req_mode) {
 case VSB_8:
 case QAM_64:
 case QAM_256:
 case QAM_AUTO:
 req_bw  = MXL5005S_BANDWIDTH_6MHZ;
 break;
 default:
 /* Assume DVB-T */
 switch (params-u.ofdm.bandwidth) {
 case BANDWIDTH_6_MHZ:
 req_bw  = MXL5005S_BANDWIDTH_6MHZ;
 break;
 case BANDWIDTH_7_MHZ:
 req_bw  = MXL5005S_BANDWIDTH_7MHZ;
 break;
 case BANDWIDTH_AUTO:
 case BANDWIDTH_8_MHZ:
 
 
 Jose Alberto Reguero

Easy enough.  Please try the patch here:

http://linuxtv.org/hg/~awalls/v4l-dvb



Sorry I forgot to add a

Reported-by: Jose Alberto Reguero jaregu...@telefonica.net

in the commit.  I can fix that if things work out.


Regards,
Andy

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Bug in mxl5005s driver

2009-03-22 Thread Jose Alberto Reguero
In line 3992:

if (fe-ops.info.type == FE_ATSC) {
switch (params-u.vsb.modulation) {
case VSB_8:
req_mode = MXL_ATSC; break;
default:
case QAM_64:
case QAM_256:
case QAM_AUTO:
req_mode = MXL_QAM; break;
}
} else
req_mode = MXL_DVBT;

req_mode is filled with MXL_ATSC, MXL_QAM, or MXL_DVBT

and in line 4007 req_mode is used like params-u.vsb.modulation

switch (req_mode) {
case VSB_8:
case QAM_64:
case QAM_256:
case QAM_AUTO:
req_bw  = MXL5005S_BANDWIDTH_6MHZ;
break;
default:
/* Assume DVB-T */
switch (params-u.ofdm.bandwidth) {
case BANDWIDTH_6_MHZ:
req_bw  = MXL5005S_BANDWIDTH_6MHZ;
break;
case BANDWIDTH_7_MHZ:
req_bw  = MXL5005S_BANDWIDTH_7MHZ;
break;
case BANDWIDTH_AUTO:
case BANDWIDTH_8_MHZ:


Jose Alberto Reguero


--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html