Re: [PATCH] [media] convert drivers/media/* to use module_platform_driver()
Hello. On Sat, 2011-11-26 at 14:48 +0800, ext Axel Lin wrote: This patch converts the drivers in drivers/media/* to use the module_platform_driver() macro which makes the code smaller and a bit simpler. Cc: Mauro Carvalho Chehab mche...@infradead.org Cc: Laurent Pinchart laurent.pinch...@ideasonboard.com Cc: Kyungmin Park kyungmin.p...@samsung.com Cc: Hans Verkuil hans.verk...@cisco.com Cc: Richard Röjfors richard.rojf...@pelagicore.com Cc: Matti J. Aaltonen matti.j.aalto...@nokia.com Cc: Lucas De Marchi lucas.demar...@profusion.mobi Cc: Manjunath Hadli manjunath.ha...@ti.com Cc: Muralidharan Karicheri m-kariche...@ti.com Cc: Anatolij Gustschin ag...@denx.de Cc: Guennadi Liakhovetski g.liakhovet...@gmx.de Cc: Marek Szyprowski m.szyprow...@samsung.com Cc: Robert Jarzmik robert.jarz...@free.fr Cc: Jonathan Corbet cor...@lwn.net Cc: Daniel Drake d...@laptop.org Signed-off-by: Axel Lin axel@gmail.com drivers/media/radio/radio-wl1273.c | 17 +--- For the above: Acked-by: Matti J. Aaltonen matti.j.aalto...@nokia.com -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] [media] convert drivers/media/* to use module_platform_driver()
On Sat, 26 Nov 2011, Axel Lin wrote: This patch converts the drivers in drivers/media/* to use the module_platform_driver() macro which makes the code smaller and a bit simpler. Cc: Mauro Carvalho Chehab mche...@infradead.org Cc: Laurent Pinchart laurent.pinch...@ideasonboard.com Cc: Kyungmin Park kyungmin.p...@samsung.com Cc: Hans Verkuil hans.verk...@cisco.com Cc: Richard Röjfors richard.rojf...@pelagicore.com Cc: Matti J. Aaltonen matti.j.aalto...@nokia.com Cc: Lucas De Marchi lucas.demar...@profusion.mobi Cc: Manjunath Hadli manjunath.ha...@ti.com Cc: Muralidharan Karicheri m-kariche...@ti.com Cc: Anatolij Gustschin ag...@denx.de Cc: Guennadi Liakhovetski g.liakhovet...@gmx.de Cc: Marek Szyprowski m.szyprow...@samsung.com Cc: Robert Jarzmik robert.jarz...@free.fr Cc: Jonathan Corbet cor...@lwn.net Cc: Daniel Drake d...@laptop.org Signed-off-by: Axel Lin axel@gmail.com For mx3_camera.c, omap1_camera.c, pxa_camera.c, sh_mobile_csi2.c, soc_camera_platform.c: Acked-by: Guennadi Liakhovetski g.liakhovet...@gmx.de Thanks Guennadi --- drivers/media/radio/radio-si4713.c | 15 +-- drivers/media/radio/radio-timb.c | 15 +-- drivers/media/radio/radio-wl1273.c | 17 +--- drivers/media/video/davinci/dm355_ccdc.c | 13 +- drivers/media/video/davinci/dm644x_ccdc.c | 13 +- drivers/media/video/davinci/isif.c | 13 +- drivers/media/video/davinci/vpbe.c | 24 +- drivers/media/video/davinci/vpbe_display.c | 38 +--- drivers/media/video/davinci/vpbe_osd.c | 18 + drivers/media/video/davinci/vpbe_venc.c| 18 + drivers/media/video/davinci/vpfe_capture.c | 18 + drivers/media/video/fsl-viu.c | 13 +- drivers/media/video/mx3_camera.c | 14 +- drivers/media/video/omap1_camera.c | 12 + drivers/media/video/omap24xxcam.c | 19 +- drivers/media/video/omap3isp/isp.c | 19 +- drivers/media/video/pxa_camera.c | 14 +- drivers/media/video/s5p-g2d/g2d.c | 16 +--- drivers/media/video/s5p-mfc/s5p_mfc.c | 22 +--- drivers/media/video/s5p-tv/hdmi_drv.c | 26 +-- drivers/media/video/s5p-tv/sdo_drv.c | 22 +--- drivers/media/video/sh_mobile_csi2.c | 13 +- drivers/media/video/soc_camera_platform.c | 13 +- drivers/media/video/timblogiw.c| 15 +-- drivers/media/video/via-camera.c | 12 + 25 files changed, 26 insertions(+), 406 deletions(-) diff --git a/drivers/media/radio/radio-si4713.c b/drivers/media/radio/radio-si4713.c index d1fab58..c54210c 100644 --- a/drivers/media/radio/radio-si4713.c +++ b/drivers/media/radio/radio-si4713.c @@ -355,17 +355,4 @@ static struct platform_driver radio_si4713_pdriver = { .remove = __exit_p(radio_si4713_pdriver_remove), }; -/* Module Interface */ -static int __init radio_si4713_module_init(void) -{ - return platform_driver_register(radio_si4713_pdriver); -} - -static void __exit radio_si4713_module_exit(void) -{ - platform_driver_unregister(radio_si4713_pdriver); -} - -module_init(radio_si4713_module_init); -module_exit(radio_si4713_module_exit); - +module_platform_driver(radio_si4713_pdriver); diff --git a/drivers/media/radio/radio-timb.c b/drivers/media/radio/radio-timb.c index 3e9209f..5d9a90a 100644 --- a/drivers/media/radio/radio-timb.c +++ b/drivers/media/radio/radio-timb.c @@ -226,20 +226,7 @@ static struct platform_driver timbradio_platform_driver = { .remove = timbradio_remove, }; -/*--*/ - -static int __init timbradio_init(void) -{ - return platform_driver_register(timbradio_platform_driver); -} - -static void __exit timbradio_exit(void) -{ - platform_driver_unregister(timbradio_platform_driver); -} - -module_init(timbradio_init); -module_exit(timbradio_exit); +module_platform_driver(timbradio_platform_driver); MODULE_DESCRIPTION(Timberdale Radio driver); MODULE_AUTHOR(Mocean Laboratories i...@mocean-labs.com); diff --git a/drivers/media/radio/radio-wl1273.c b/drivers/media/radio/radio-wl1273.c index 8aa4968..f1b6070 100644 --- a/drivers/media/radio/radio-wl1273.c +++ b/drivers/media/radio/radio-wl1273.c @@ -2148,8 +2148,6 @@ pdata_err: return r; } -MODULE_ALIAS(platform:wl1273_fm_radio); - static struct platform_driver wl1273_fm_radio_driver = { .probe = wl1273_fm_radio_probe, .remove = __devexit_p(wl1273_fm_radio_remove), @@ -2159,20 +2157,9 @@ static struct platform_driver wl1273_fm_radio_driver = { }, }; -static int
RE: [PATCH] [media] convert drivers/media/* to use module_platform_driver()
Hello, On Saturday, November 26, 2011 7:49 AM Axel Lin wrote: This patch converts the drivers in drivers/media/* to use the module_platform_driver() macro which makes the code smaller and a bit simpler. Cc: Mauro Carvalho Chehab mche...@infradead.org Cc: Laurent Pinchart laurent.pinch...@ideasonboard.com Cc: Kyungmin Park kyungmin.p...@samsung.com Cc: Hans Verkuil hans.verk...@cisco.com Cc: Richard Röjfors richard.rojf...@pelagicore.com Cc: Matti J. Aaltonen matti.j.aalto...@nokia.com Cc: Lucas De Marchi lucas.demar...@profusion.mobi Cc: Manjunath Hadli manjunath.ha...@ti.com Cc: Muralidharan Karicheri m-kariche...@ti.com Cc: Anatolij Gustschin ag...@denx.de Cc: Guennadi Liakhovetski g.liakhovet...@gmx.de Cc: Marek Szyprowski m.szyprow...@samsung.com Cc: Robert Jarzmik robert.jarz...@free.fr Cc: Jonathan Corbet cor...@lwn.net Cc: Daniel Drake d...@laptop.org Signed-off-by: Axel Lin axel@gmail.com --- drivers/media/radio/radio-si4713.c | 15 +-- drivers/media/radio/radio-timb.c | 15 +-- drivers/media/radio/radio-wl1273.c | 17 +--- drivers/media/video/davinci/dm355_ccdc.c | 13 +- drivers/media/video/davinci/dm644x_ccdc.c | 13 +- drivers/media/video/davinci/isif.c | 13 +- drivers/media/video/davinci/vpbe.c | 24 +- drivers/media/video/davinci/vpbe_display.c | 38 +--- drivers/media/video/davinci/vpbe_osd.c | 18 + drivers/media/video/davinci/vpbe_venc.c| 18 + drivers/media/video/davinci/vpfe_capture.c | 18 + drivers/media/video/fsl-viu.c | 13 +- drivers/media/video/mx3_camera.c | 14 +- drivers/media/video/omap1_camera.c | 12 + drivers/media/video/omap24xxcam.c | 19 +- drivers/media/video/omap3isp/isp.c | 19 +- drivers/media/video/pxa_camera.c | 14 +- drivers/media/video/s5p-g2d/g2d.c | 16 +--- drivers/media/video/s5p-mfc/s5p_mfc.c | 22 +--- drivers/media/video/s5p-tv/hdmi_drv.c | 26 +-- drivers/media/video/s5p-tv/sdo_drv.c | 22 +--- For Samsung drivers in drivers/media/video/s5p-* Acked-by: Marek Szyprowski m.szyprow...@samsung.com drivers/media/video/sh_mobile_csi2.c | 13 +- drivers/media/video/soc_camera_platform.c | 13 +- drivers/media/video/timblogiw.c| 15 +-- drivers/media/video/via-camera.c | 12 + 25 files changed, 26 insertions(+), 406 deletions(-) Best regards -- Marek Szyprowski Samsung Poland RD Center -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] [media] convert drivers/media/* to use module_platform_driver()
Hi Axel, On Saturday 26 November 2011 07:48:55 Axel Lin wrote: This patch converts the drivers in drivers/media/* to use the module_platform_driver() macro which makes the code smaller and a bit simpler. Cc: Mauro Carvalho Chehab mche...@infradead.org Cc: Laurent Pinchart laurent.pinch...@ideasonboard.com Cc: Kyungmin Park kyungmin.p...@samsung.com Cc: Hans Verkuil hans.verk...@cisco.com Cc: Richard Röjfors richard.rojf...@pelagicore.com Cc: Matti J. Aaltonen matti.j.aalto...@nokia.com Cc: Lucas De Marchi lucas.demar...@profusion.mobi Cc: Manjunath Hadli manjunath.ha...@ti.com Cc: Muralidharan Karicheri m-kariche...@ti.com Cc: Anatolij Gustschin ag...@denx.de Cc: Guennadi Liakhovetski g.liakhovet...@gmx.de Cc: Marek Szyprowski m.szyprow...@samsung.com Cc: Robert Jarzmik robert.jarz...@free.fr Cc: Jonathan Corbet cor...@lwn.net Cc: Daniel Drake d...@laptop.org Signed-off-by: Axel Lin axel@gmail.com --- drivers/media/radio/radio-si4713.c | 15 +-- drivers/media/radio/radio-timb.c | 15 +-- drivers/media/radio/radio-wl1273.c | 17 +--- drivers/media/video/davinci/dm355_ccdc.c | 13 +- drivers/media/video/davinci/dm644x_ccdc.c | 13 +- drivers/media/video/davinci/isif.c | 13 +- drivers/media/video/davinci/vpbe.c | 24 +- drivers/media/video/davinci/vpbe_display.c | 38 + drivers/media/video/davinci/vpbe_osd.c | 18 + drivers/media/video/davinci/vpbe_venc.c| 18 + drivers/media/video/davinci/vpfe_capture.c | 18 + drivers/media/video/fsl-viu.c | 13 +- drivers/media/video/mx3_camera.c | 14 +- drivers/media/video/omap1_camera.c | 12 + drivers/media/video/omap24xxcam.c | 19 +- drivers/media/video/omap3isp/isp.c | 19 +- For drivers/media/video/omap3isp/isp.c, Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com drivers/media/video/pxa_camera.c | 14 +- drivers/media/video/s5p-g2d/g2d.c | 16 +--- drivers/media/video/s5p-mfc/s5p_mfc.c | 22 +--- drivers/media/video/s5p-tv/hdmi_drv.c | 26 +-- drivers/media/video/s5p-tv/sdo_drv.c | 22 +--- drivers/media/video/sh_mobile_csi2.c | 13 +- drivers/media/video/soc_camera_platform.c | 13 +- drivers/media/video/timblogiw.c| 15 +-- drivers/media/video/via-camera.c | 12 + 25 files changed, 26 insertions(+), 406 deletions(-) -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html