Re: [PATCH] lmedm04 v2.05 conversion to dvb-usb-v2
On 08/05/2012 05:36 PM, Mauro Carvalho Chehab wrote: Em 05-08-2012 11:10, Malcolm Priestley escreveu: Conversion of lmedm04 to dvb-usb-v2 You were faster than I :) Thanks! http://blog.palosaari.fi/2012/08/naked-hardware-1-dm04-usb-20-satellite.html functional changes are that callbacks have been moved to fe_ioctl_override. Don't do that: fe_ioctl_override has a broken design and only handles DVBv3 ioctl's. So, if userspace is using DVBv5, this will cause a regression. Antti, IMO, the best thing to do is to either remove fe_ioctl_override or to print a warning when a driver calls it, in order to warn developers that they're using a legacy callback that could cause the driver to not work properly. I agree that. regards Antti -- http://palosaari.fi/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] lmedm04 v2.05 conversion to dvb-usb-v2
On 08/05/2012 05:10 PM, Malcolm Priestley wrote: Conversion of lmedm04 to dvb-usb-v2 functional changes are that callbacks have been moved to fe_ioctl_override. This patch is applied on top of [BUG] Re: dvb_usb_lmedm04 crash Kernel (rs2000) http://patchwork.linuxtv.org/patch/13584/ Signed-off-by: Malcolm Priestley tvbox...@gmail.com I reviewed it quickly and didn't see any dvb-usb-v2 issues. Anyhow, that driver look quite complex overall and maybe there is room for cleaning. There is even own urb handling routines for both data streaming and control messages, why? (due to that it is not possible to use dvb-usb power-management) regards Antti -- http://palosaari.fi/ -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] lmedm04 v2.05 conversion to dvb-usb-v2
Em 05-08-2012 11:10, Malcolm Priestley escreveu: Conversion of lmedm04 to dvb-usb-v2 functional changes are that callbacks have been moved to fe_ioctl_override. Don't do that: fe_ioctl_override has a broken design and only handles DVBv3 ioctl's. So, if userspace is using DVBv5, this will cause a regression. Antti, IMO, the best thing to do is to either remove fe_ioctl_override or to print a warning when a driver calls it, in order to warn developers that they're using a legacy callback that could cause the driver to not work properly. Regards, Mauro -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
