Re: [PATCH] si2157: Use name si2157_ops instead of si2157_tuner_ops (harmonize with si2168)

2014-07-18 Thread Luis Alves 
This actually fixes a bug.
The struct prototype is defined at the beginning of the code as
si2157_ops but the real struct is called si2157_tuner_ops.

This is causing the name to be empty on this info msg: si2157 16-0060:
si2157: found a '' in cold state

Luis


On Fri, Jul 18, 2014 at 6:41 AM, Olli Salonen olli.salo...@iki.fi wrote:
 Signed-off-by: Olli Salonen olli.salo...@iki.fi
 ---
  drivers/media/tuners/si2157.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

 diff --git a/drivers/media/tuners/si2157.c b/drivers/media/tuners/si2157.c
 index 329004f..4730f69 100644
 --- a/drivers/media/tuners/si2157.c
 +++ b/drivers/media/tuners/si2157.c
 @@ -277,7 +277,7 @@ err:
 return ret;
  }

 -static const struct dvb_tuner_ops si2157_tuner_ops = {
 +static const struct dvb_tuner_ops si2157_ops = {
 .info = {
 .name   = Silicon Labs Si2157/Si2158,
 .frequency_min  = 11000,
 @@ -317,7 +317,7 @@ static int si2157_probe(struct i2c_client *client,
 goto err;

 fe-tuner_priv = s;
 -   memcpy(fe-ops.tuner_ops, si2157_tuner_ops,
 +   memcpy(fe-ops.tuner_ops, si2157_ops,
 sizeof(struct dvb_tuner_ops));

 i2c_set_clientdata(client, s);
 --
 1.9.1

 --
 To unsubscribe from this list: send the line unsubscribe linux-media in
 the body of a message to majord...@vger.kernel.org
 More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] si2157: Use name si2157_ops instead of si2157_tuner_ops (harmonize with si2168)

2014-07-18 Thread Antti Palosaari 

I will apply that, thanks!

Could you and also Luis pay attention to commit message in future 
patches. I have had practically fixed almost every commit message from 
your patches. Long one liner just like this one is not correct. It 
should be short subject line and then explained more in the commit 
message body. I tend ask myself questions why and how and then write 
commit message based answers of those questions.


regards
Antti

On 07/18/2014 08:41 AM, Olli Salonen wrote:

Signed-off-by: Olli Salonen olli.salo...@iki.fi
---
  drivers/media/tuners/si2157.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/media/tuners/si2157.c b/drivers/media/tuners/si2157.c
index 329004f..4730f69 100644
--- a/drivers/media/tuners/si2157.c
+++ b/drivers/media/tuners/si2157.c
@@ -277,7 +277,7 @@ err:
return ret;
  }

-static const struct dvb_tuner_ops si2157_tuner_ops = {
+static const struct dvb_tuner_ops si2157_ops = {
.info = {
.name   = Silicon Labs Si2157/Si2158,
.frequency_min  = 11000,
@@ -317,7 +317,7 @@ static int si2157_probe(struct i2c_client *client,
goto err;

fe-tuner_priv = s;
-   memcpy(fe-ops.tuner_ops, si2157_tuner_ops,
+   memcpy(fe-ops.tuner_ops, si2157_ops,
sizeof(struct dvb_tuner_ops));

i2c_set_clientdata(client, s);



--
http://palosaari.fi/
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html