Re: [PATCH v13 00/33] rcar-vin: Add Gen3 with media controller
Hi Hans, On 2018-04-04 12:28:30 +0200, Hans Verkuil wrote: > Hi Niklas, > > It might be a good idea if you can rebase the patch series on the latest > master (we've just synced to Linus' master tree) and incorporate the few > comments that Laurent had. I have now rebased this and incorporate the comments from Laurent. I still need to test the rebased work so will post this tomorrow or early next week. > > Then once the merge window closes I can make the pull request, probably on > the 16th. Thanks for that and thanks again for all your help in my pursuit to get this series accepted! > > Regards, > > Hans > > On 03/04/18 14:30, Hans Verkuil wrote: > > On 26/03/18 23:44, Niklas Söderlund wrote: > >> Hi, > >> > >> This series adds Gen3 VIN support to rcar-vin driver for Renesas r8a7795, > >> r8a7796 and r8a77970. It is based on the media-tree and depends on > >> Fabrizio Castro patches as they touches the order of the compatible > >> strings in the documentation to reduce merge conflicts. The dependencies > >> are included in this series. > > > > Laurent, Kieran, > > > > Unless there are any objections I want to make a pull request for this > > series once 4.17-rc1 has been merged back into our master tree. It all > > looks good to me, and it will be nice to get this in (finally!). > > > > I don't want to postpone the pull request for small improvements, they > > can be applied later. But if there are more serious concerns, then let > > us know. > > > > Regards, > > > > Hans > > > >> > >> The driver is tested on Renesas H3 (r8a7795, ES2.0), > >> M3-W (r8a7796) together with the rcar-csi2 driver (posted separately and > >> not yet upstream) and the Salvator-X onboard ADV7482. It is also tested > >> on the V3M (r8a77970) on the Eagle board together with its expansion > >> board with a ADV7482 and out of tree patches for GMSL capture using the > >> max9286 and rdacm20 drivers. > >> > >> It is possible to capture both CVBS and HDMI video streams, > >> v4l2-compliance passes with no errors and media-ctl can be used to > >> change the routing and formats for the different entities in the media > >> graph. > >> > >> Gen2 compatibility is verified on Koelsch and no problems where found, > >> video can be captured just like before and v4l2-compliance passes > >> without errors or warnings just like before this series. > >> > >> For convenience the series can be fetched from: > >> > >> git://git.ragnatech.se/linux rcar/vin/mc-v13 > >> > >> I have started on a very basic test suite for the VIN driver at: > >> > >> https://git.ragnatech.se/vin-tests > >> > >> And as before the state of the driver and information about how to test > >> it can be found on the elinux wiki: > >> > >> http://elinux.org/R-Car/Tests:rcar-vin > >> > >> * Changes from v12 > >> - Rebase to latest media-tree/master changed a 'return ret' to a 'goto > >> out' in rvin_start_streaming() to take recent changes to the VIN > >> driver into account. > >> - Moved field != V4L2_FIELD_ANY in 'rcar-vin: set a default field to > >> fallback on' check from a later commit 'rcar-vin: simplify how formats > >> are set and reset' in the series. This is to avoid ignoring the field > >> returned from the sensor if FIELD_ANY was requested by the user. This > >> was only a problem between this change and a few patches later, but > >> better to fix it now. Reported by Hans, thanks for spotting this. > >> - Fix spelling. > >> - Add review tags from Hans. > >> > >> * Changes since v11 > >> - Rewrote commit message for '[PATCH v11 22/32] rcar-vin: force default > >> colorspace for media centric mode'. Also set fixed values for > >> xfer_func, quantization and ycbcr_enc. > >> - Reorderd filed order in struct rvin_group_route. > >> - Renamed chan to channel in struct rvin_group_route. > >> - Rework 'rcar-vin: read subdevice format for crop only when > >> needed' into 'rcar-vin: simplify how formats are set and reset'. > >> - Keep caching the source dimensions and drop all changes to > >> rvin_g_selection() and rvin_s_selection(). > >> - Inline rvin_get_vin_format_from_source() into rvin_reset_format() > >> which now is the only user left. > >> - Add patch to cache the video standard instead of reading it at stream > >> on. > >> - Fix error labels in rvin_mc_open(). > >> - Fixed spelling in commit messages and comment, thanks Laurent! > >> - Added reviewed tags from Laurent, Thanks! > >> > >> * Changes since v10 > >> - Corrected spelling in comments and commit messages. > >> - Reworked 'rcar-vin: read subdevice format for crop only when needed' > >> to only get the source format once per operation. > >> - Moved some patches around to make it easier to review, moved: > >> - rcar-vin: set a default field to fallback on > >> - rcar-vin: fix handling of single field frames (top, bottom and > >> alternate fields) > >> - rcar-vin: update bytesperline and sizeimage calculation > >> - rcar-vin:
Re: [PATCH v13 00/33] rcar-vin: Add Gen3 with media controller
Hi Niklas, It might be a good idea if you can rebase the patch series on the latest master (we've just synced to Linus' master tree) and incorporate the few comments that Laurent had. Then once the merge window closes I can make the pull request, probably on the 16th. Regards, Hans On 03/04/18 14:30, Hans Verkuil wrote: > On 26/03/18 23:44, Niklas Söderlund wrote: >> Hi, >> >> This series adds Gen3 VIN support to rcar-vin driver for Renesas r8a7795, >> r8a7796 and r8a77970. It is based on the media-tree and depends on >> Fabrizio Castro patches as they touches the order of the compatible >> strings in the documentation to reduce merge conflicts. The dependencies >> are included in this series. > > Laurent, Kieran, > > Unless there are any objections I want to make a pull request for this > series once 4.17-rc1 has been merged back into our master tree. It all > looks good to me, and it will be nice to get this in (finally!). > > I don't want to postpone the pull request for small improvements, they > can be applied later. But if there are more serious concerns, then let > us know. > > Regards, > > Hans > >> >> The driver is tested on Renesas H3 (r8a7795, ES2.0), >> M3-W (r8a7796) together with the rcar-csi2 driver (posted separately and >> not yet upstream) and the Salvator-X onboard ADV7482. It is also tested >> on the V3M (r8a77970) on the Eagle board together with its expansion >> board with a ADV7482 and out of tree patches for GMSL capture using the >> max9286 and rdacm20 drivers. >> >> It is possible to capture both CVBS and HDMI video streams, >> v4l2-compliance passes with no errors and media-ctl can be used to >> change the routing and formats for the different entities in the media >> graph. >> >> Gen2 compatibility is verified on Koelsch and no problems where found, >> video can be captured just like before and v4l2-compliance passes >> without errors or warnings just like before this series. >> >> For convenience the series can be fetched from: >> >> git://git.ragnatech.se/linux rcar/vin/mc-v13 >> >> I have started on a very basic test suite for the VIN driver at: >> >> https://git.ragnatech.se/vin-tests >> >> And as before the state of the driver and information about how to test >> it can be found on the elinux wiki: >> >> http://elinux.org/R-Car/Tests:rcar-vin >> >> * Changes from v12 >> - Rebase to latest media-tree/master changed a 'return ret' to a 'goto >> out' in rvin_start_streaming() to take recent changes to the VIN >> driver into account. >> - Moved field != V4L2_FIELD_ANY in 'rcar-vin: set a default field to >> fallback on' check from a later commit 'rcar-vin: simplify how formats >> are set and reset' in the series. This is to avoid ignoring the field >> returned from the sensor if FIELD_ANY was requested by the user. This >> was only a problem between this change and a few patches later, but >> better to fix it now. Reported by Hans, thanks for spotting this. >> - Fix spelling. >> - Add review tags from Hans. >> >> * Changes since v11 >> - Rewrote commit message for '[PATCH v11 22/32] rcar-vin: force default >> colorspace for media centric mode'. Also set fixed values for >> xfer_func, quantization and ycbcr_enc. >> - Reorderd filed order in struct rvin_group_route. >> - Renamed chan to channel in struct rvin_group_route. >> - Rework 'rcar-vin: read subdevice format for crop only when >> needed' into 'rcar-vin: simplify how formats are set and reset'. >> - Keep caching the source dimensions and drop all changes to >> rvin_g_selection() and rvin_s_selection(). >> - Inline rvin_get_vin_format_from_source() into rvin_reset_format() >> which now is the only user left. >> - Add patch to cache the video standard instead of reading it at stream >> on. >> - Fix error labels in rvin_mc_open(). >> - Fixed spelling in commit messages and comment, thanks Laurent! >> - Added reviewed tags from Laurent, Thanks! >> >> * Changes since v10 >> - Corrected spelling in comments and commit messages. >> - Reworked 'rcar-vin: read subdevice format for crop only when needed' >> to only get the source format once per operation. >> - Moved some patches around to make it easier to review, moved: >> - rcar-vin: set a default field to fallback on >> - rcar-vin: fix handling of single field frames (top, bottom and >> alternate fields) >> - rcar-vin: update bytesperline and sizeimage calculation >> - rcar-vin: break out format alignment and checking >> - rcar-vin: update pixelformat check for M1 >> Before: >> - rcar-vin: read subdevice format for crop only when needed >> - Rename variable 'code' to 'mbus_code' in struct rvin_dev. >> - Add comment describing no locking is needed in >> rvin_set_channel_routing(). >> - Check return value of pm_runtime_get_sync() in >> rvin_set_channel_routing(). >> - Rework 'rcar-vin: add check for colorspace' to not try to check the >> format, instead force a default format. This
Re: [PATCH v13 00/33] rcar-vin: Add Gen3 with media controller
Hi Hans, On Tuesday, 3 April 2018 15:30:40 EEST Hans Verkuil wrote: > On 26/03/18 23:44, Niklas Söderlund wrote: > > Hi, > > > > This series adds Gen3 VIN support to rcar-vin driver for Renesas r8a7795, > > r8a7796 and r8a77970. It is based on the media-tree and depends on > > Fabrizio Castro patches as they touches the order of the compatible > > strings in the documentation to reduce merge conflicts. The dependencies > > are included in this series. > > Laurent, Kieran, > > Unless there are any objections I want to make a pull request for this > series once 4.17-rc1 has been merged back into our master tree. It all > looks good to me, and it will be nice to get this in (finally!). > > I don't want to postpone the pull request for small improvements, they > can be applied later. But if there are more serious concerns, then let > us know. There's just a handful of patchs I haven't acked (but I have reviewed previous version) and I don't think there's any blocker there, small problems can always be fixed later. I'll still try to review them, and if I notice any issue I'll ask Niklas to submit follow-up patches. v13 can be merged upstream from my point of view. Thank you for handling this. > > The driver is tested on Renesas H3 (r8a7795, ES2.0), > > M3-W (r8a7796) together with the rcar-csi2 driver (posted separately and > > not yet upstream) and the Salvator-X onboard ADV7482. It is also tested > > on the V3M (r8a77970) on the Eagle board together with its expansion > > board with a ADV7482 and out of tree patches for GMSL capture using the > > max9286 and rdacm20 drivers. > > > > It is possible to capture both CVBS and HDMI video streams, > > v4l2-compliance passes with no errors and media-ctl can be used to > > change the routing and formats for the different entities in the media > > graph. > > > > Gen2 compatibility is verified on Koelsch and no problems where found, > > video can be captured just like before and v4l2-compliance passes > > without errors or warnings just like before this series. > > > > For convenience the series can be fetched from: > > git://git.ragnatech.se/linux rcar/vin/mc-v13 > > > > I have started on a very basic test suite for the VIN driver at: > > https://git.ragnatech.se/vin-tests > > > > And as before the state of the driver and information about how to test > > > > it can be found on the elinux wiki: > > http://elinux.org/R-Car/Tests:rcar-vin > > > > * Changes from v12 > > - Rebase to latest media-tree/master changed a 'return ret' to a 'goto > > > > out' in rvin_start_streaming() to take recent changes to the VIN > > driver into account. > > > > - Moved field != V4L2_FIELD_ANY in 'rcar-vin: set a default field to > > > > fallback on' check from a later commit 'rcar-vin: simplify how formats > > are set and reset' in the series. This is to avoid ignoring the field > > returned from the sensor if FIELD_ANY was requested by the user. This > > was only a problem between this change and a few patches later, but > > better to fix it now. Reported by Hans, thanks for spotting this. > > > > - Fix spelling. > > - Add review tags from Hans. > > > > * Changes since v11 > > - Rewrote commit message for '[PATCH v11 22/32] rcar-vin: force default > > > > colorspace for media centric mode'. Also set fixed values for > > xfer_func, quantization and ycbcr_enc. > > > > - Reorderd filed order in struct rvin_group_route. > > - Renamed chan to channel in struct rvin_group_route. > > - Rework 'rcar-vin: read subdevice format for crop only when > > > > needed' into 'rcar-vin: simplify how formats are set and reset'. > > > > - Keep caching the source dimensions and drop all changes to > > > > rvin_g_selection() and rvin_s_selection(). > > > > - Inline rvin_get_vin_format_from_source() into rvin_reset_format() > > > > which now is the only user left. > > > > - Add patch to cache the video standard instead of reading it at stream > > > > on. > > > > - Fix error labels in rvin_mc_open(). > > - Fixed spelling in commit messages and comment, thanks Laurent! > > - Added reviewed tags from Laurent, Thanks! > > > > * Changes since v10 > > - Corrected spelling in comments and commit messages. > > - Reworked 'rcar-vin: read subdevice format for crop only when needed' > > > > to only get the source format once per operation. > > > > - Moved some patches around to make it easier to review, moved: > > - rcar-vin: set a default field to fallback on > > - rcar-vin: fix handling of single field frames (top, bottom and > > alternate fields) - rcar-vin: update bytesperline and sizeimage > > calculation > > - rcar-vin: break out format alignment and checking > > - rcar-vin: update pixelformat check for M1 > > > > Before: > > - rcar-vin: read subdevice format for crop only when needed > > > > - Rename variable 'code' to 'mbus_code' in struct rvin_dev. > > - Add comment describing no locking is needed in > > > >
Re: [PATCH v13 00/33] rcar-vin: Add Gen3 with media controller
Hi Hans, On 03/04/18 13:30, Hans Verkuil wrote: > On 26/03/18 23:44, Niklas Söderlund wrote: >> Hi, >> >> This series adds Gen3 VIN support to rcar-vin driver for Renesas r8a7795, >> r8a7796 and r8a77970. It is based on the media-tree and depends on >> Fabrizio Castro patches as they touches the order of the compatible >> strings in the documentation to reduce merge conflicts. The dependencies >> are included in this series. > > Laurent, Kieran, > > Unless there are any objections I want to make a pull request for this > series once 4.17-rc1 has been merged back into our master tree. It all > looks good to me, and it will be nice to get this in (finally!). > > I don't want to postpone the pull request for small improvements, they > can be applied later. But if there are more serious concerns, then let > us know. Certainly sounds good, and no objections from me. Looking forward to getting this series in. Thanks Kieran > Regards, > > Hans > >> >> The driver is tested on Renesas H3 (r8a7795, ES2.0), >> M3-W (r8a7796) together with the rcar-csi2 driver (posted separately and >> not yet upstream) and the Salvator-X onboard ADV7482. It is also tested >> on the V3M (r8a77970) on the Eagle board together with its expansion >> board with a ADV7482 and out of tree patches for GMSL capture using the >> max9286 and rdacm20 drivers. >> >> It is possible to capture both CVBS and HDMI video streams, >> v4l2-compliance passes with no errors and media-ctl can be used to >> change the routing and formats for the different entities in the media >> graph. >> >> Gen2 compatibility is verified on Koelsch and no problems where found, >> video can be captured just like before and v4l2-compliance passes >> without errors or warnings just like before this series. >> >> For convenience the series can be fetched from: >> >> git://git.ragnatech.se/linux rcar/vin/mc-v13 >> >> I have started on a very basic test suite for the VIN driver at: >> >> https://git.ragnatech.se/vin-tests >> >> And as before the state of the driver and information about how to test >> it can be found on the elinux wiki: >> >> http://elinux.org/R-Car/Tests:rcar-vin >> >> * Changes from v12 >> - Rebase to latest media-tree/master changed a 'return ret' to a 'goto >> out' in rvin_start_streaming() to take recent changes to the VIN >> driver into account. >> - Moved field != V4L2_FIELD_ANY in 'rcar-vin: set a default field to >> fallback on' check from a later commit 'rcar-vin: simplify how formats >> are set and reset' in the series. This is to avoid ignoring the field >> returned from the sensor if FIELD_ANY was requested by the user. This >> was only a problem between this change and a few patches later, but >> better to fix it now. Reported by Hans, thanks for spotting this. >> - Fix spelling. >> - Add review tags from Hans. >> >> * Changes since v11 >> - Rewrote commit message for '[PATCH v11 22/32] rcar-vin: force default >> colorspace for media centric mode'. Also set fixed values for >> xfer_func, quantization and ycbcr_enc. >> - Reorderd filed order in struct rvin_group_route. >> - Renamed chan to channel in struct rvin_group_route. >> - Rework 'rcar-vin: read subdevice format for crop only when >> needed' into 'rcar-vin: simplify how formats are set and reset'. >> - Keep caching the source dimensions and drop all changes to >> rvin_g_selection() and rvin_s_selection(). >> - Inline rvin_get_vin_format_from_source() into rvin_reset_format() >> which now is the only user left. >> - Add patch to cache the video standard instead of reading it at stream >> on. >> - Fix error labels in rvin_mc_open(). >> - Fixed spelling in commit messages and comment, thanks Laurent! >> - Added reviewed tags from Laurent, Thanks! >> >> * Changes since v10 >> - Corrected spelling in comments and commit messages. >> - Reworked 'rcar-vin: read subdevice format for crop only when needed' >> to only get the source format once per operation. >> - Moved some patches around to make it easier to review, moved: >> - rcar-vin: set a default field to fallback on >> - rcar-vin: fix handling of single field frames (top, bottom and >> alternate fields) >> - rcar-vin: update bytesperline and sizeimage calculation >> - rcar-vin: break out format alignment and checking >> - rcar-vin: update pixelformat check for M1 >> Before: >> - rcar-vin: read subdevice format for crop only when needed >> - Rename variable 'code' to 'mbus_code' in struct rvin_dev. >> - Add comment describing no locking is needed in >> rvin_set_channel_routing(). >> - Check return value of pm_runtime_get_sync() in >> rvin_set_channel_routing(). >> - Rework 'rcar-vin: add check for colorspace' to not try to check the >> format, instead force a default format. This should be revisited once >> either v4l2-compliance or v4l2 framework changes are worked out to >> allow for MC centric drivers to validate user supplied colorspace. >> - Add
Re: [PATCH v13 00/33] rcar-vin: Add Gen3 with media controller
On 26/03/18 23:44, Niklas Söderlund wrote: > Hi, > > This series adds Gen3 VIN support to rcar-vin driver for Renesas r8a7795, > r8a7796 and r8a77970. It is based on the media-tree and depends on > Fabrizio Castro patches as they touches the order of the compatible > strings in the documentation to reduce merge conflicts. The dependencies > are included in this series. Laurent, Kieran, Unless there are any objections I want to make a pull request for this series once 4.17-rc1 has been merged back into our master tree. It all looks good to me, and it will be nice to get this in (finally!). I don't want to postpone the pull request for small improvements, they can be applied later. But if there are more serious concerns, then let us know. Regards, Hans > > The driver is tested on Renesas H3 (r8a7795, ES2.0), > M3-W (r8a7796) together with the rcar-csi2 driver (posted separately and > not yet upstream) and the Salvator-X onboard ADV7482. It is also tested > on the V3M (r8a77970) on the Eagle board together with its expansion > board with a ADV7482 and out of tree patches for GMSL capture using the > max9286 and rdacm20 drivers. > > It is possible to capture both CVBS and HDMI video streams, > v4l2-compliance passes with no errors and media-ctl can be used to > change the routing and formats for the different entities in the media > graph. > > Gen2 compatibility is verified on Koelsch and no problems where found, > video can be captured just like before and v4l2-compliance passes > without errors or warnings just like before this series. > > For convenience the series can be fetched from: > > git://git.ragnatech.se/linux rcar/vin/mc-v13 > > I have started on a very basic test suite for the VIN driver at: > > https://git.ragnatech.se/vin-tests > > And as before the state of the driver and information about how to test > it can be found on the elinux wiki: > > http://elinux.org/R-Car/Tests:rcar-vin > > * Changes from v12 > - Rebase to latest media-tree/master changed a 'return ret' to a 'goto > out' in rvin_start_streaming() to take recent changes to the VIN > driver into account. > - Moved field != V4L2_FIELD_ANY in 'rcar-vin: set a default field to > fallback on' check from a later commit 'rcar-vin: simplify how formats > are set and reset' in the series. This is to avoid ignoring the field > returned from the sensor if FIELD_ANY was requested by the user. This > was only a problem between this change and a few patches later, but > better to fix it now. Reported by Hans, thanks for spotting this. > - Fix spelling. > - Add review tags from Hans. > > * Changes since v11 > - Rewrote commit message for '[PATCH v11 22/32] rcar-vin: force default > colorspace for media centric mode'. Also set fixed values for > xfer_func, quantization and ycbcr_enc. > - Reorderd filed order in struct rvin_group_route. > - Renamed chan to channel in struct rvin_group_route. > - Rework 'rcar-vin: read subdevice format for crop only when > needed' into 'rcar-vin: simplify how formats are set and reset'. > - Keep caching the source dimensions and drop all changes to > rvin_g_selection() and rvin_s_selection(). > - Inline rvin_get_vin_format_from_source() into rvin_reset_format() > which now is the only user left. > - Add patch to cache the video standard instead of reading it at stream > on. > - Fix error labels in rvin_mc_open(). > - Fixed spelling in commit messages and comment, thanks Laurent! > - Added reviewed tags from Laurent, Thanks! > > * Changes since v10 > - Corrected spelling in comments and commit messages. > - Reworked 'rcar-vin: read subdevice format for crop only when needed' > to only get the source format once per operation. > - Moved some patches around to make it easier to review, moved: > - rcar-vin: set a default field to fallback on > - rcar-vin: fix handling of single field frames (top, bottom and > alternate fields) > - rcar-vin: update bytesperline and sizeimage calculation > - rcar-vin: break out format alignment and checking > - rcar-vin: update pixelformat check for M1 > Before: > - rcar-vin: read subdevice format for crop only when needed > - Rename variable 'code' to 'mbus_code' in struct rvin_dev. > - Add comment describing no locking is needed in > rvin_set_channel_routing(). > - Check return value of pm_runtime_get_sync() in > rvin_set_channel_routing(). > - Rework 'rcar-vin: add check for colorspace' to not try to check the > format, instead force a default format. This should be revisited once > either v4l2-compliance or v4l2 framework changes are worked out to > allow for MC centric drivers to validate user supplied colorspace. > - Add error checking for pm_runtime_get_sync() and > v4l2_pipeline_pm_use(). > - Change mutex_lock() to mutex_lock_interruptible() in rvin_mc_open(). > - Rewrote documentation for struct rvin_group_route. > - Rename rvin_mc_parse_v4l2() to rvin_mc_parse_of_endpoint().
