Re: [PATCH v3 1/2] media: dt-bindings: bind nokia,n900-ir to generic pwm-ir-tx driver
On Fri, Aug 31, 2018 at 11:07:23AM +0300, Sakari Ailus wrote:
> Hi Sean,
>
> On Fri, Jul 13, 2018 at 01:22:29PM +0100, Sean Young wrote:
> > The generic pwm-ir-tx driver should work for the Nokia n900.
> >
> > Compile tested only.
> >
> > Cc: Rob Herring
> > Cc: Ivaylo Dimitrov
> > Cc: Pali Rohár
> > Cc: Pavel Machek
> > Cc: Timo Kokkonen
> > Cc: Tony Lindgren
> > Signed-off-by: Sean Young
> > ---
> > arch/arm/boot/dts/omap3-n900.dts | 2 +-
> > drivers/media/rc/pwm-ir-tx.c | 1 +
> > 2 files changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/boot/dts/omap3-n900.dts
> > b/arch/arm/boot/dts/omap3-n900.dts
> > index 182a53991c90..fd12dea15799 100644
> > --- a/arch/arm/boot/dts/omap3-n900.dts
> > +++ b/arch/arm/boot/dts/omap3-n900.dts
> > @@ -154,7 +154,7 @@
> > };
> >
> > ir: n900-ir {
> > - compatible = "nokia,n900-ir";
> > + compatible = "nokia,n900-ir", "pwm-ir-tx";
> > pwms = < 0 26316 0>; /* 38000 Hz */
> > };
> >
> > diff --git a/drivers/media/rc/pwm-ir-tx.c b/drivers/media/rc/pwm-ir-tx.c
> > index 27d0f5837a76..272947b430c8 100644
> > --- a/drivers/media/rc/pwm-ir-tx.c
> > +++ b/drivers/media/rc/pwm-ir-tx.c
> > @@ -30,6 +30,7 @@ struct pwm_ir {
> > };
> >
> > static const struct of_device_id pwm_ir_of_match[] = {
> > + { .compatible = "nokia,n900-ir" },
>
> Is this change needed as well? I suppose you could add it later if there's
> a need to e.g. do something differently for the N900 IR transmitter.
This is to ensure compatibility of a new kernel with an old board dtb.
> It'd be nice if someone tested it, too...
That would be nice, but I don't have the hardware and so far I there has
been noone willing/able to test it.
Sean
Re: [PATCH v3 1/2] media: dt-bindings: bind nokia,n900-ir to generic pwm-ir-tx driver
Hi Sean,
On Fri, Jul 13, 2018 at 01:22:29PM +0100, Sean Young wrote:
> The generic pwm-ir-tx driver should work for the Nokia n900.
>
> Compile tested only.
>
> Cc: Rob Herring
> Cc: Ivaylo Dimitrov
> Cc: Pali Rohár
> Cc: Pavel Machek
> Cc: Timo Kokkonen
> Cc: Tony Lindgren
> Signed-off-by: Sean Young
> ---
> arch/arm/boot/dts/omap3-n900.dts | 2 +-
> drivers/media/rc/pwm-ir-tx.c | 1 +
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/omap3-n900.dts
> b/arch/arm/boot/dts/omap3-n900.dts
> index 182a53991c90..fd12dea15799 100644
> --- a/arch/arm/boot/dts/omap3-n900.dts
> +++ b/arch/arm/boot/dts/omap3-n900.dts
> @@ -154,7 +154,7 @@
> };
>
> ir: n900-ir {
> - compatible = "nokia,n900-ir";
> + compatible = "nokia,n900-ir", "pwm-ir-tx";
> pwms = < 0 26316 0>; /* 38000 Hz */
> };
>
> diff --git a/drivers/media/rc/pwm-ir-tx.c b/drivers/media/rc/pwm-ir-tx.c
> index 27d0f5837a76..272947b430c8 100644
> --- a/drivers/media/rc/pwm-ir-tx.c
> +++ b/drivers/media/rc/pwm-ir-tx.c
> @@ -30,6 +30,7 @@ struct pwm_ir {
> };
>
> static const struct of_device_id pwm_ir_of_match[] = {
> + { .compatible = "nokia,n900-ir" },
Is this change needed as well? I suppose you could add it later if there's
a need to e.g. do something differently for the N900 IR transmitter.
It'd be nice if someone tested it, too...
> { .compatible = "pwm-ir-tx", },
> { },
> };
--
Sakari Ailus
e-mail: sakari.ai...@iki.fi
Re: [PATCH v3 1/2] media: dt-bindings: bind nokia,n900-ir to generic pwm-ir-tx driver
On 29.08.2018 20:07, Mauro Carvalho Chehab wrote:
Em Fri, 13 Jul 2018 13:22:29 +0100
Sean Young escreveu:
The generic pwm-ir-tx driver should work for the Nokia n900.
Compile tested only.
It would be good to have some tests...
Unfortunately, it turned out I won't be able to test soon, so please,
somebody else do it.
Cc: Rob Herring
Cc: Ivaylo Dimitrov
Cc: Pali Rohár
Cc: Pavel Machek
Cc: Timo Kokkonen
Cc: Tony Lindgren
And some acks
Before merging it.
Signed-off-by: Sean Young
---
arch/arm/boot/dts/omap3-n900.dts | 2 +-
drivers/media/rc/pwm-ir-tx.c | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/omap3-n900.dts b/arch/arm/boot/dts/omap3-n900.dts
index 182a53991c90..fd12dea15799 100644
--- a/arch/arm/boot/dts/omap3-n900.dts
+++ b/arch/arm/boot/dts/omap3-n900.dts
@@ -154,7 +154,7 @@
};
ir: n900-ir {
- compatible = "nokia,n900-ir";
+ compatible = "nokia,n900-ir", "pwm-ir-tx";
pwms = < 0 26316 0>; /* 38000 Hz */
};
diff --git a/drivers/media/rc/pwm-ir-tx.c b/drivers/media/rc/pwm-ir-tx.c
index 27d0f5837a76..272947b430c8 100644
--- a/drivers/media/rc/pwm-ir-tx.c
+++ b/drivers/media/rc/pwm-ir-tx.c
@@ -30,6 +30,7 @@ struct pwm_ir {
};
static const struct of_device_id pwm_ir_of_match[] = {
+ { .compatible = "nokia,n900-ir" },
{ .compatible = "pwm-ir-tx", },
{ },
};
Thanks,
Mauro
Re: [PATCH v3 1/2] media: dt-bindings: bind nokia,n900-ir to generic pwm-ir-tx driver
Em Fri, 13 Jul 2018 13:22:29 +0100
Sean Young escreveu:
> The generic pwm-ir-tx driver should work for the Nokia n900.
>
> Compile tested only.
It would be good to have some tests...
>
> Cc: Rob Herring
> Cc: Ivaylo Dimitrov
> Cc: Pali Rohár
> Cc: Pavel Machek
> Cc: Timo Kokkonen
> Cc: Tony Lindgren
And some acks
Before merging it.
> Signed-off-by: Sean Young
> ---
> arch/arm/boot/dts/omap3-n900.dts | 2 +-
> drivers/media/rc/pwm-ir-tx.c | 1 +
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/omap3-n900.dts
> b/arch/arm/boot/dts/omap3-n900.dts
> index 182a53991c90..fd12dea15799 100644
> --- a/arch/arm/boot/dts/omap3-n900.dts
> +++ b/arch/arm/boot/dts/omap3-n900.dts
> @@ -154,7 +154,7 @@
> };
>
> ir: n900-ir {
> - compatible = "nokia,n900-ir";
> + compatible = "nokia,n900-ir", "pwm-ir-tx";
> pwms = < 0 26316 0>; /* 38000 Hz */
> };
>
> diff --git a/drivers/media/rc/pwm-ir-tx.c b/drivers/media/rc/pwm-ir-tx.c
> index 27d0f5837a76..272947b430c8 100644
> --- a/drivers/media/rc/pwm-ir-tx.c
> +++ b/drivers/media/rc/pwm-ir-tx.c
> @@ -30,6 +30,7 @@ struct pwm_ir {
> };
>
> static const struct of_device_id pwm_ir_of_match[] = {
> + { .compatible = "nokia,n900-ir" },
> { .compatible = "pwm-ir-tx", },
> { },
> };
Thanks,
Mauro
