Re: [Patch 1/6] ARM: dts: DRA72: Add CAL dtsi node

2017-10-13 Thread Benoit Parrot 
Tony Lindgren  wrote on Fri [2017-Oct-13 09:54:09 -0700]:
> * Benoit Parrot  [171012 12:29]:
> > This patch adds the required dtsi node to support the Camera
> > Adaptation Layer (CAL) for the DRA72 family of devices.
> > 
> > - Added CAL entry in dra72x.dtsi.
> > 
> > Signed-off-by: Benoit Parrot 
> > ---
> >  arch/arm/boot/dts/dra72x.dtsi | 31 +++
> >  1 file changed, 31 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/dra72x.dtsi b/arch/arm/boot/dts/dra72x.dtsi
> > index 67107605fb4c..d0ba4f238084 100644
> > --- a/arch/arm/boot/dts/dra72x.dtsi
> > +++ b/arch/arm/boot/dts/dra72x.dtsi
> > @@ -17,6 +17,37 @@
> > interrupt-parent = <>;
> > interrupts = ;
> > };
> > +
> > +   ocp {
> > +   cal: cal@4845b000 {
> > +   compatible = "ti,dra72-cal";
> > +   ti,hwmods = "cal";
> > +   reg = <0x4845B000 0x400>,
> > + <0x4845B800 0x40>,
> > + <0x4845B900 0x40>,
> > + <0x4A002e94 0x4>;
> 
> Care to fix the cAmelcasing here? All lower case hex is pretty much the
> standard with linux, so might as well lower case them all while at it.

Sure thing, I'll fix it.

Benoit

> 
> Regards,
> 
> Tony

Re: [Patch 1/6] ARM: dts: DRA72: Add CAL dtsi node

2017-10-13 Thread Tony Lindgren 
* Benoit Parrot  [171012 12:29]:
> This patch adds the required dtsi node to support the Camera
> Adaptation Layer (CAL) for the DRA72 family of devices.
> 
> - Added CAL entry in dra72x.dtsi.
> 
> Signed-off-by: Benoit Parrot 
> ---
>  arch/arm/boot/dts/dra72x.dtsi | 31 +++
>  1 file changed, 31 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/dra72x.dtsi b/arch/arm/boot/dts/dra72x.dtsi
> index 67107605fb4c..d0ba4f238084 100644
> --- a/arch/arm/boot/dts/dra72x.dtsi
> +++ b/arch/arm/boot/dts/dra72x.dtsi
> @@ -17,6 +17,37 @@
>   interrupt-parent = <>;
>   interrupts = ;
>   };
> +
> + ocp {
> + cal: cal@4845b000 {
> + compatible = "ti,dra72-cal";
> + ti,hwmods = "cal";
> + reg = <0x4845B000 0x400>,
> +   <0x4845B800 0x40>,
> +   <0x4845B900 0x40>,
> +   <0x4A002e94 0x4>;

Care to fix the cAmelcasing here? All lower case hex is pretty much the
standard with linux, so might as well lower case them all while at it.

Regards,

Tony