Re: [REVIEW PATCH 0/6] s5p-tv: replace dv_preset by dv_timings

2013-03-20 Thread Tomasz Stanislawski
Hi everyone,
After successful testing (after applying use cap instead of 0 fix),
please add:

Tested-by: Tomasz Stanislawski t.stanisl...@samsung.com
Acked-by: Tomasz Stanislawski t.stanisl...@samsung.com

to the commit log.

Regards,
Tomasz Stanislawski

On 03/18/2013 03:24 PM, Hans Verkuil wrote:
 On Mon March 4 2013 14:02:00 Hans Verkuil wrote:
 Hi Tomasz,

 Here is what I hope is the final patch series for this. I've incorporated
 your suggestions and it's split off from the davinci/blackfin changes into
 its own patch series to keep things better organized.

 The changes since the previous version are:

 - changed the order of the first three patches as per your suggestion.
 - the patch named [RFC PATCH 08/18] s5p-tv: add dv_timings support for
   mixer_video. had two changes that rightfully belonged to the 'add
   dv_timings support for mixer_video.' patch. Moved them accordingly.
 - hdmiphy now also supports dv_timings_cap and sets the pixelclock range
   accordingly. The hdmi driver chains hdmiphy to get those values.
 - updating the minimum width to 720.

 I didn't add a comment to clarify the pixclk handling hdmiphy_s_dv_preset
 because 1) I forgot, 2) it's not a bug, and 3) that whole function is
 removed anyway a few patches later :-)

 The only functional change is the handling of dv_timings_cap. Can you
 verify that that works as it should?
 
 Tomasz,
 
 Should I wait for feedback from you, or can I go ahead and make a pull
 request for this?
 
 Regards,
 
   Hans
 

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [REVIEW PATCH 0/6] s5p-tv: replace dv_preset by dv_timings

2013-03-18 Thread Hans Verkuil
On Mon March 4 2013 14:02:00 Hans Verkuil wrote:
 Hi Tomasz,
 
 Here is what I hope is the final patch series for this. I've incorporated
 your suggestions and it's split off from the davinci/blackfin changes into
 its own patch series to keep things better organized.
 
 The changes since the previous version are:
 
 - changed the order of the first three patches as per your suggestion.
 - the patch named [RFC PATCH 08/18] s5p-tv: add dv_timings support for
   mixer_video. had two changes that rightfully belonged to the 'add
   dv_timings support for mixer_video.' patch. Moved them accordingly.
 - hdmiphy now also supports dv_timings_cap and sets the pixelclock range
   accordingly. The hdmi driver chains hdmiphy to get those values.
 - updating the minimum width to 720.
 
 I didn't add a comment to clarify the pixclk handling hdmiphy_s_dv_preset
 because 1) I forgot, 2) it's not a bug, and 3) that whole function is
 removed anyway a few patches later :-)
 
 The only functional change is the handling of dv_timings_cap. Can you
 verify that that works as it should?

Tomasz,

Should I wait for feedback from you, or can I go ahead and make a pull
request for this?

Regards,

Hans
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html