Re: bisected regression in tuner-xc2028 on DVICO dual digital 4

2009-11-08 Thread Devin Heitmueller
On Sat, Nov 7, 2009 at 9:40 PM, Devin Heitmueller
dheitmuel...@kernellabs.com wrote:
 Hello Vince,

 I think the next step at this point is for you to definitively find a
 use case that does not work with the latest v4l-dvb tip and Robert's
 patch, and include exactly what kernel you tested with and which board
 is having the problem (including the PCI or USB ID).

 At this point, your description seems a bit vague in terms of what is
 working and what is not.  If you do the additional testing to narrow
 down specifically the failure case you are experiencing, I will see
 what I can do.

 That said, I'm preparing a tree with Robert's patch since I am pretty
 confident at least his particular problem is now addressed.

 Thanks,

 Devin

Robert,

FYI:  this has been merged into my local tree (after fixing some
whitespace problems introduced by the inlining of the patch into the
email).  I'll issue a PULL request tonight.

Devin

-- 
Devin J. Heitmueller - Kernel Labs
http://www.kernellabs.com
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: bisected regression in tuner-xc2028 on DVICO dual digital 4

2009-11-08 Thread Vincent McIntyre
On 11/8/09, Devin Heitmueller dheitmuel...@kernellabs.com wrote:

 I think the next step at this point is for you to definitively find a
 use case that does not work with the latest v4l-dvb tip and Robert's
 patch, and include exactly what kernel you tested with and which board
 is having the problem (including the PCI or USB ID).

 At this point, your description seems a bit vague in terms of what is
 working and what is not.  If you do the additional testing to narrow
 down specifically the failure case you are experiencing, I will see
 what I can do.

I'm trying to be as clear as I can.

We can forget about setups 1 and 2, they no longer have the messages
from the cxusb module that I originally reported, I can tune and run
signal level tests like [1].

I'm now looking at setup 3.
 os: ubuntu karmic i386
 kernel: 2.6.31-14-generic
 v4l modules: hg identify returns 19c0469c02c3+ tip

 If I cold boot, I see no tuning issues at the kernel level. Details
of the test below.

 The failure I was attempting to report is that
 I am unable to tune with dvbscan or w_scan.
 I think it is due to changes in the V4L API with respect to the versions
 of these programs I have installed.

 However I am able to tune with 'tzap'. I'm not entirely sure why tzap works,
 but it does and it shows the v4l tip drivers are ok regarding the
issue originally
 reported.

 There are two further areas I am looking into.
 1. If I *warm* boot the same setup, I see dvb-usb: bulk message failed:
 in dmesg.
 I am working on this still to try to get a clear report for you of when
 and on which device it occurs. It will probably take me a week to get
 back to you.
 2. There may be differences in performance, in that:
 2.6.31-14-generic+v4l+Rob shows worse Bit Error Rates than
 2.6.31-14-generic+Rob
 Again I have some work to do to clarify this.
 It seems likely it is a separate issue from this thread.

 That said, I'm preparing a tree with Robert's patch since I am pretty
 confident at least his particular problem is now addressed.

I can see no obstacle to you going ahead with that. Thanks again.

Cheers
Vince

Test details:
 I tune like this:
   sudo strace -t -ff -F -o tzap.strace /usr/bin/tzap -a 0 -r -c
channels.conf 7 Digital(Seven Network)

 In dmesg I see the firmware being loaded but no other messages:
   [ 1232.684884] usb 3-1: firmware: requesting xc3028-v27.fw
   [ 1232.743698] xc2028 1-0061: Loading 80 firmware images from
xc3028-v27.fw, type: xc2028 firmware, ver 2.7
   [ 1232.756391] xc2028 1-0061: Loading firmware for type=BASE F8MHZ
(3), id .
   [ 1237.332511] xc2028 1-0061: Loading firmware for type=D2633 DTV7
(90), id .
   [ 1237.416510] xc2028 1-0061: Loading SCODE for type=SCODE
HAS_IF_5260 (6000), id .

 I can successfully tune each of the 4 tuners in this way. Each time I
run tzap on
 a tuner I've not used before, dmesg shows the firmware loading ok.


[1] http://linuxtv.org/wiki/index.php/Testing_reception_quality
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: bisected regression in tuner-xc2028 on DVICO dual digital 4

2009-11-08 Thread Devin Heitmueller
On Sun, Nov 8, 2009 at 6:46 PM, Barry Williams bazzaw...@gmail.com wrote:
 Where would I find your local tree as I can't seem to get the patch to
 apply and I would like to take advantage of this patch asap.
 Thanks
 Barry

I pushed out my tree with the fix:

http://kernellabs.com/hg/~dheitmueller/misc-fixes-4

I haven't issued a PULL yet to put it into the mainline since I have a
couple of other things pending.

Devin

-- 
Devin J. Heitmueller - Kernel Labs
http://www.kernellabs.com
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: bisected regression in tuner-xc2028 on DVICO dual digital 4

2009-11-08 Thread Barry Williams
Devin Heitmueller wrote:
 On Sun, Nov 8, 2009 at 6:46 PM, Barry Williams bazzaw...@gmail.com wrote:
 Where would I find your local tree as I can't seem to get the patch to
 apply and I would like to take advantage of this patch asap.
 Thanks
 Barry

 I pushed out my tree with the fix:

 http://kernellabs.com/hg/~dheitmueller/misc-fixes-4

 I haven't issued a PULL yet to put it into the mainline since I have a
 couple of other things pending.

 Devin


Hi Devin
I tried your tree and I seem to get the same problem on one box I get
the flood of 'dvb-usb: bulk message failed: -110 (1/0'.
Scan shows: 'ATAL: failed to open '/dev/dvb/adapter0/frontend0': 2 No
such file or directory on adapter0' and fails to tune adapter1 with :
scanning /usr/share/dvb/dvb-t/au-Adelaide
using '/dev/dvb/adapter1/frontend0' and '/dev/dvb/adapter1/demux0'
initial transponder 22650 1 3 9 3 1 1 0
initial transponder 17750 1 3 9 3 1 1 0
initial transponder 191625000 1 3 9 3 1 1 0
initial transponder 21950 1 3 9 3 1 1 0
initial transponder 56450 1 2 9 3 1 2 0
 tune to: 
 22650:INVERSION_AUTO:BANDWIDTH_7_MHZ:FEC_3_4:FEC_AUTO:QAM_64:TRANSMISSION_MODE_8K:GUARD_INTERVAL_1_16:HIERARCHY_NONE
WARNING:  tuning failed!!!
 tune to: 
 22650:INVERSION_AUTO:BANDWIDTH_7_MHZ:FEC_3_4:FEC_AUTO:QAM_64:TRANSMISSION_MODE_8K:GUARD_INTERVAL_1_16:HIERARCHY_NONE
  (tuning failed)
WARNING:  tuning failed!!!
 tune to: 
 17750:INVERSION_AUTO:BANDWIDTH_7_MHZ:FEC_3_4:FEC_AUTO:QAM_64:TRANSMISSION_MODE_8K:GUARD_INTERVAL_1_16:HIERARCHY_NONE
WARNING:  tuning failed!!!
 tune to: 
 17750:INVERSION_AUTO:BANDWIDTH_7_MHZ:FEC_3_4:FEC_AUTO:QAM_64:TRANSMISSION_MODE_8K:GUARD_INTERVAL_1_16:HIERARCHY_NONE
  (tuning failed)
WARNING:  tuning failed!!!
 tune to: 
 191625000:INVERSION_AUTO:BANDWIDTH_7_MHZ:FEC_3_4:FEC_AUTO:QAM_64:TRANSMISSION_MODE_8K:GUARD_INTERVAL_1_16:HIERARCHY_NONE
WARNING:  tuning failed!!!
 tune to: 
 191625000:INVERSION_AUTO:BANDWIDTH_7_MHZ:FEC_3_4:FEC_AUTO:QAM_64:TRANSMISSION_MODE_8K:GUARD_INTERVAL_1_16:HIERARCHY_NONE
  (tuning failed)
WARNING:  tuning failed!!!
 tune to: 
 21950:INVERSION_AUTO:BANDWIDTH_7_MHZ:FEC_3_4:FEC_AUTO:QAM_64:TRANSMISSION_MODE_8K:GUARD_INTERVAL_1_16:HIERARCHY_NONE
WARNING:  tuning failed!!!
 tune to: 
 21950:INVERSION_AUTO:BANDWIDTH_7_MHZ:FEC_3_4:FEC_AUTO:QAM_64:TRANSMISSION_MODE_8K:GUARD_INTERVAL_1_16:HIERARCHY_NONE
  (tuning failed)
WARNING:  tuning failed!!!
 tune to: 
 56450:INVERSION_AUTO:BANDWIDTH_7_MHZ:FEC_2_3:FEC_AUTO:QAM_64:TRANSMISSION_MODE_8K:GUARD_INTERVAL_1_8:HIERARCHY_NONE
WARNING:  tuning failed!!!
 tune to: 
 56450:INVERSION_AUTO:BANDWIDTH_7_MHZ:FEC_2_3:FEC_AUTO:QAM_64:TRANSMISSION_MODE_8K:GUARD_INTERVAL_1_8:HIERARCHY_NONE
  (tuning failed)
WARNING:  tuning failed!!!
ERROR: initial tuning failed
dumping lists (0 services)
Done.

On my second box with the same card I get a flood of :
[12341.364016] dvb-usb: bulk message failed: -2 (4/0)
[12341.364019] cxusb: i2c read failed
but similar results with scan.
Barry
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: bisected regression in tuner-xc2028 on DVICO dual digital 4

2009-11-08 Thread Devin Heitmueller
On Sun, Nov 8, 2009 at 8:43 PM, Barry Williams bazzaw...@gmail.com wrote:
 Hi Devin
 I tried your tree and I seem to get the same problem on one box I get
 the flood of 'dvb-usb: bulk message failed: -110 (1/0'.
snip

Can you please confirm the USB ID of the board you are having the
problem with (by running lsusb from a terminal window)?

Thanks,

Devin

-- 
Devin J. Heitmueller - Kernel Labs
http://www.kernellabs.com
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: bisected regression in tuner-xc2028 on DVICO dual digital 4

2009-11-08 Thread Barry Williams
On Mon, Nov 9, 2009 at 12:22 PM, Devin Heitmueller
dheitmuel...@kernellabs.com wrote:
 On Sun, Nov 8, 2009 at 8:43 PM, Barry Williams bazzaw...@gmail.com wrote:
 Hi Devin
 I tried your tree and I seem to get the same problem on one box I get
 the flood of 'dvb-usb: bulk message failed: -110 (1/0'.
 snip

 Can you please confirm the USB ID of the board you are having the
 problem with (by running lsusb from a terminal window)?

 Thanks,

 Devin
 --


On the first box I have
Bus 003 Device 003: ID 0fe9:db98 DVICO
Bus 003 Device 002: ID 0fe9:db98 DVICO

on the second
Bus 001 Device 003: ID 0fe9:db78 DVICO FusionHDTV DVB-T Dual Digital 4
(ZL10353+xc2028/xc3028) (initialized)
Bus 001 Device 002: ID 0fe9:db78 DVICO FusionHDTV DVB-T Dual Digital 4
(ZL10353+xc2028/xc3028) (initialized)
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: bisected regression in tuner-xc2028 on DVICO dual digital 4

2009-11-08 Thread Vincent McIntyre
Hi Barry,

did you try cold-booting either system?

how are you tuning? mythtv?

Cheers
Vince


On 11/9/09, Barry Williams bazzaw...@gmail.com wrote:
 On Mon, Nov 9, 2009 at 12:22 PM, Devin Heitmueller
 dheitmuel...@kernellabs.com wrote:
 On Sun, Nov 8, 2009 at 8:43 PM, Barry Williams bazzaw...@gmail.com
 wrote:
 Hi Devin
 I tried your tree and I seem to get the same problem on one box I get
 the flood of 'dvb-usb: bulk message failed: -110 (1/0'.
 snip

 Can you please confirm the USB ID of the board you are having the
 problem with (by running lsusb from a terminal window)?

 Thanks,

 Devin
 --


 On the first box I have
 Bus 003 Device 003: ID 0fe9:db98 DVICO
 Bus 003 Device 002: ID 0fe9:db98 DVICO

 on the second
 Bus 001 Device 003: ID 0fe9:db78 DVICO FusionHDTV DVB-T Dual Digital 4
 (ZL10353+xc2028/xc3028) (initialized)
 Bus 001 Device 002: ID 0fe9:db78 DVICO FusionHDTV DVB-T Dual Digital 4
 (ZL10353+xc2028/xc3028) (initialized)
 --
 To unsubscribe from this list: send the line unsubscribe linux-media in
 the body of a message to majord...@vger.kernel.org
 More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: bisected regression in tuner-xc2028 on DVICO dual digital 4

2009-11-08 Thread Devin Heitmueller
On Sun, Nov 8, 2009 at 9:01 PM, Barry Williams bazzaw...@gmail.com wrote:
 On the first box I have
 Bus 003 Device 003: ID 0fe9:db98 DVICO
 Bus 003 Device 002: ID 0fe9:db98 DVICO

 on the second
 Bus 001 Device 003: ID 0fe9:db78 DVICO FusionHDTV DVB-T Dual Digital 4
 (ZL10353+xc2028/xc3028) (initialized)
 Bus 001 Device 002: ID 0fe9:db78 DVICO FusionHDTV DVB-T Dual Digital 4
 (ZL10353+xc2028/xc3028) (initialized)

And on which of the two systems are you still having the tuning
problem with?  Also, did you reboot after you installed the patch?

Devin

-- 
Devin J. Heitmueller - Kernel Labs
http://www.kernellabs.com
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: bisected regression in tuner-xc2028 on DVICO dual digital 4

2009-11-08 Thread Robert Lowery
 On Mon, Nov 9, 2009 at 12:22 PM, Devin Heitmueller
 dheitmuel...@kernellabs.com wrote:
 On Sun, Nov 8, 2009 at 8:43 PM, Barry Williams bazzaw...@gmail.com
 wrote:
 Hi Devin
 I tried your tree and I seem to get the same problem on one box I get
 the flood of 'dvb-usb: bulk message failed: -110 (1/0'.
 snip

 Can you please confirm the USB ID of the board you are having the
 problem with (by running lsusb from a terminal window)?

 Thanks,

 Devin
 --


 On the first box I have
 Bus 003 Device 003: ID 0fe9:db98 DVICO
 Bus 003 Device 002: ID 0fe9:db98 DVICO

 on the second
 Bus 001 Device 003: ID 0fe9:db78 DVICO FusionHDTV DVB-T Dual Digital 4
 (ZL10353+xc2028/xc3028) (initialized)
 Bus 001 Device 002: ID 0fe9:db78 DVICO FusionHDTV DVB-T Dual Digital 4
 (ZL10353+xc2028/xc3028) (initialized)
 --
 To unsubscribe from this list: send the line unsubscribe linux-media in
 the body of a message to majord...@vger.kernel.org
 More majordomo info at  http://vger.kernel.org/majordomo-info.html

Barry,

I have the Dual Digital 4 rev1 card which corresponds to the 0fe9:db78
card.  0fe9:db98 is the Dual Digital 4 rev2 card which I believe uses
completely different hardware and it's behavior is unchanged by my patch
which only targets the rev1 card.

I suspect the problems you are still reporting are from the different
cards, completely unrelated to my fix.

Would you be able to retest after removing the rev2 cards from the machine?

-Rob


--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: bisected regression in tuner-xc2028 on DVICO dual digital 4

2009-11-08 Thread Devin Heitmueller
On Sun, Nov 8, 2009 at 9:54 PM, Robert Lowery rglow...@exemail.com.au wrote:
 On Mon, Nov 9, 2009 at 12:22 PM, Devin Heitmueller
 dheitmuel...@kernellabs.com wrote:
 On Sun, Nov 8, 2009 at 8:43 PM, Barry Williams bazzaw...@gmail.com
 wrote:
 Hi Devin
 I tried your tree and I seem to get the same problem on one box I get
 the flood of 'dvb-usb: bulk message failed: -110 (1/0'.
 snip

 Can you please confirm the USB ID of the board you are having the
 problem with (by running lsusb from a terminal window)?

 Thanks,

 Devin
 --


 On the first box I have
 Bus 003 Device 003: ID 0fe9:db98 DVICO
 Bus 003 Device 002: ID 0fe9:db98 DVICO

 on the second
 Bus 001 Device 003: ID 0fe9:db78 DVICO FusionHDTV DVB-T Dual Digital 4
 (ZL10353+xc2028/xc3028) (initialized)
 Bus 001 Device 002: ID 0fe9:db78 DVICO FusionHDTV DVB-T Dual Digital 4
 (ZL10353+xc2028/xc3028) (initialized)
 --
 To unsubscribe from this list: send the line unsubscribe linux-media in
 the body of a message to majord...@vger.kernel.org
 More majordomo info at  http://vger.kernel.org/majordomo-info.html

 Barry,

 I have the Dual Digital 4 rev1 card which corresponds to the 0fe9:db78
 card.  0fe9:db98 is the Dual Digital 4 rev2 card which I believe uses
 completely different hardware and it's behavior is unchanged by my patch
 which only targets the rev1 card.

 I suspect the problems you are still reporting are from the different
 cards, completely unrelated to my fix.

 Would you be able to retest after removing the rev2 cards from the machine?

 -Rob

Robert,

It's worth noting that the introduction of the i2c gate stuff in the
zl10353 broke essentially *all* cards that use that demod except for
the one that prompted the change.  I've been incrementally going
through the cards and fixing it as people report it.

Since both of his cards use the zl10353, it wouldn't surprise me that
his other board is broken for the same reason (which would require an
additional patch).

Devin

-- 
Devin J. Heitmueller - Kernel Labs
http://www.kernellabs.com
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: bisected regression in tuner-xc2028 on DVICO dual digital 4

2009-11-08 Thread Barry Williams
On Mon, Nov 9, 2009 at 1:04 PM, Devin Heitmueller
dheitmuel...@kernellabs.com wrote:
 On Sun, Nov 8, 2009 at 9:01 PM, Barry Williams bazzaw...@gmail.com wrote:
 On the first box I have
 Bus 003 Device 003: ID 0fe9:db98 DVICO
 Bus 003 Device 002: ID 0fe9:db98 DVICO

 on the second
 Bus 001 Device 003: ID 0fe9:db78 DVICO FusionHDTV DVB-T Dual Digital 4
 (ZL10353+xc2028/xc3028) (initialized)
 Bus 001 Device 002: ID 0fe9:db78 DVICO FusionHDTV DVB-T Dual Digital 4
 (ZL10353+xc2028/xc3028) (initialized)

 And on which of the two systems are you still having the tuning
 problem with?  Also, did you reboot after you installed the patch?

 Devin

 --
 Devin J. Heitmueller - Kernel Labs
 http://www.kernellabs.com


Hi Devin
I did not reboot after installing the patch somehow I thought simply
removing the module (as I had done to restore some stability to my
system) and reloading the module after the patch would be all I need.
Well I learned that is not the case my apologies for not trying that
first. So your tree fixed my second system with the rev 1 tuner.
However my first system with the rev 2 card while now stable with your
tree will not tune.
Barry
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: bisected regression in tuner-xc2028 on DVICO dual digital 4

2009-11-08 Thread Devin Heitmueller
On Sun, Nov 8, 2009 at 10:58 PM, Barry Williams bazzaw...@gmail.com wrote:
 Hi Devin
 I did not reboot after installing the patch somehow I thought simply
 removing the module (as I had done to restore some stability to my
 system) and reloading the module after the patch would be all I need.
 Well I learned that is not the case my apologies for not trying that
 first. So your tree fixed my second system with the rev 1 tuner.
 However my first system with the rev 2 card while now stable with your
 tree will not tune.
 Barry

Ok, good.  So now we just need to nail down why the 0fe9:db98 board
doesn't work.  Fortunately, I think I know what that bug is too.

Try this:

1.  Reboot the system.
2.  Perform a single tuning attempt.
3.  Send the full dmesg output starting at the time the box is booted.

If you're lucky, it's the issue I think it is, which will result in a
one-line patch.

Thanks,

Devin

-- 
Devin J. Heitmueller - Kernel Labs
http://www.kernellabs.com
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: bisected regression in tuner-xc2028 on DVICO dual digital 4

2009-11-08 Thread Devin Heitmueller
On Sun, Nov 8, 2009 at 11:35 PM, Barry Williams bazzaw...@gmail.com wrote:
 Devin
 Attached is the output from dmesg, I hope you're right
 Thanks
 Barry

Ah, based on the dmesg I can see it wasn't what I thought it was (I
saw it was dib7000 and improperly assumed it had an xc3028 tuner like
the rev1 board does).

You should probably start a new thread on the mailing list regarding
the problems you are having with this tuner.  And you will probably
need to bisect the v4l-dvb tree and see when the breakage was
introduced.

Devin

-- 
Devin J. Heitmueller - Kernel Labs
http://www.kernellabs.com
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: bisected regression in tuner-xc2028 on DVICO dual digital 4

2009-11-08 Thread Barry Williams
On Mon, Nov 9, 2009 at 3:17 PM, Devin Heitmueller
dheitmuel...@kernellabs.com wrote:
 On Sun, Nov 8, 2009 at 11:35 PM, Barry Williams bazzaw...@gmail.com wrote:
 Devin
 Attached is the output from dmesg, I hope you're right
 Thanks
 Barry

 Ah, based on the dmesg I can see it wasn't what I thought it was (I
 saw it was dib7000 and improperly assumed it had an xc3028 tuner like
 the rev1 board does).

 You should probably start a new thread on the mailing list regarding
 the problems you are having with this tuner.  And you will probably
 need to bisect the v4l-dvb tree and see when the breakage was
 introduced.

 Devin

 --
 Devin J. Heitmueller - Kernel Labs
 http://www.kernellabs.com


I'd be happy to help with that however I am unfamiliar with the
concept of bisecting a tree if you could provide more info that would
be helpful and then I will start a new thread with the information I
can gather.
Thanks
Barry
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: bisected regression in tuner-xc2028 on DVICO dual digital 4

2009-11-08 Thread Barry Williams
On Mon, Nov 9, 2009 at 3:47 PM, Barry Williams bazzaw...@gmail.com wrote:
 On Mon, Nov 9, 2009 at 3:17 PM, Devin Heitmueller
 dheitmuel...@kernellabs.com wrote:
 On Sun, Nov 8, 2009 at 11:35 PM, Barry Williams bazzaw...@gmail.com wrote:
 Devin
 Attached is the output from dmesg, I hope you're right
 Thanks
 Barry

 Ah, based on the dmesg I can see it wasn't what I thought it was (I
 saw it was dib7000 and improperly assumed it had an xc3028 tuner like
 the rev1 board does).

 You should probably start a new thread on the mailing list regarding
 the problems you are having with this tuner.  And you will probably
 need to bisect the v4l-dvb tree and see when the breakage was
 introduced.

 Devin

 --
 Devin J. Heitmueller - Kernel Labs
 http://www.kernellabs.com


 I'd be happy to help with that however I am unfamiliar with the
 concept of bisecting a tree if you could provide more info that would
 be helpful and then I will start a new thread with the information I
 can gather.
 Thanks
 Barry


I appear to be good at doing silly things I of course forgot I
unplugged the antenna cable from my first box to watch normal tv so
that is why it is not tuning. However now my rev 1 tuner appears to no
longer be working mythtv says it is asleep here is the output from
dmesg.

[0.00] Initializing cgroup subsys cpuset
[0.00] Initializing cgroup subsys cpu
[0.00] Linux version 2.6.31-14-generic (bui...@rothera) (gcc
version 4.4.1 (Ubuntu 4.4.1-4ubuntu8) ) #48-Ubuntu SMP Fri Oct 16
14:04:26 UTC 2009 (Ubuntu 2.6.31-14.48-generic)
[0.00] KERNEL supported cpus:
[0.00]   Intel GenuineIntel
[0.00]   AMD AuthenticAMD
[0.00]   NSC Geode by NSC
[0.00]   Cyrix CyrixInstead
[0.00]   Centaur CentaurHauls
[0.00]   Transmeta GenuineTMx86
[0.00]   Transmeta TransmetaCPU
[0.00]   UMC UMC UMC UMC
[0.00] BIOS-provided physical RAM map:
[0.00]  BIOS-e820:  - 0009fc00 (usable)
[0.00]  BIOS-e820: 0009fc00 - 000a (reserved)
[0.00]  BIOS-e820: 000f - 0010 (reserved)
[0.00]  BIOS-e820: 0010 - 3fff (usable)
[0.00]  BIOS-e820: 3fff - 3fff8000 (ACPI data)
[0.00]  BIOS-e820: 3fff8000 - 4000 (ACPI NVS)
[0.00]  BIOS-e820: fec0 - fec01000 (reserved)
[0.00]  BIOS-e820: fee0 - fee01000 (reserved)
[0.00]  BIOS-e820: fff8 - 0001 (reserved)
[0.00] DMI 2.3 present.
[0.00] AMI BIOS detected: BIOS may corrupt low RAM, working around it.
[0.00] e820 update range:  - 0001
(usable) == (reserved)
[0.00] last_pfn = 0x3fff0 max_arch_pfn = 0x10
[0.00] MTRR default type: uncachable
[0.00] MTRR fixed ranges enabled:
[0.00]   0-9 write-back
[0.00]   A-B uncachable
[0.00]   C-C7FFF write-protect
[0.00]   C8000-E uncachable
[0.00]   F-F write-protect
[0.00] MTRR variable ranges enabled:
[0.00]   0 base 0 mask FC000 write-back
[0.00]   1 disabled
[0.00]   2 disabled
[0.00]   3 disabled
[0.00]   4 disabled
[0.00]   5 base 0E000 mask FF800 write-combining
[0.00]   6 disabled
[0.00]   7 disabled
[0.00] x86 PAT enabled: cpu 0, old 0x7040600070406, new 0x7010600070106
[0.00] Scanning 0 areas for low memory corruption
[0.00] modified physical RAM map:
[0.00]  modified:  - 0001 (reserved)
[0.00]  modified: 0001 - 0009fc00 (usable)
[0.00]  modified: 0009fc00 - 000a (reserved)
[0.00]  modified: 000f - 0010 (reserved)
[0.00]  modified: 0010 - 3fff (usable)
[0.00]  modified: 3fff - 3fff8000 (ACPI data)
[0.00]  modified: 3fff8000 - 4000 (ACPI NVS)
[0.00]  modified: fec0 - fec01000 (reserved)
[0.00]  modified: fee0 - fee01000 (reserved)
[0.00]  modified: fff8 - 0001 (reserved)
[0.00] initial memory mapped : 0 - 00c0
[0.00] init_memory_mapping: -377fe000
[0.00] Using x86 segment limits to approximate NX protection
[0.00]  00 - 40 page 4k
[0.00]  40 - 003740 page 2M
[0.00]  003740 - 00377fe000 page 4k
[0.00] kernel direct mapping tables up to 377fe000 @ 1-15000
[0.00] RAMDISK: 2f8e8000 - 3003314d
[0.00] ACPI: RSDP 000fa9e0 00014 (v00 AMI   )
[0.00] ACPI: RSDT 3fff 0002C (v01 AMIINT VIA_K7   0010
MSFT 0097)
[   

Re: bisected regression in tuner-xc2028 on DVICO dual digital 4

2009-11-07 Thread Vincent McIntyre
Hi Devin

 please confirm exactly which of your boards is not working.

Sorry for being unclear.

I have three test setups I am working with, all on the same computer.
1. Ubuntu Hardy, kernel 2.6.24-23-rt and drivers from v4l-dvb tip.
2. Ubuntu Karmic, kernel 2.6.31-14-generic, stock Ubuntu drivers.
3. Ubuntu Karmic, kernel 2.6.31-14-generic, v4l-dvb tip.

Setups 2  3 are the same install, on a separate hard disk from setup 1.
I change between 2  3 by installing the v4l modules or restoring the
ubuntu stuff from backup. (rsync -av --delete).

The computer has two DVB-T cards.

First device is the same as Robert's, I believe. It has two tuners. lsusb gives:
Bus 003 Device 003: ID 0fe9:db78 DVICO FusionHDTV DVB-T Dual Digital 4
(ZL10353+xc2028/xc3028) (initialized)
Bus 003 Device 002: ID 0fe9:db78 DVICO FusionHDTV DVB-T Dual Digital 4
(ZL10353+xc2028/xc3028) (initialized)
I have a 'rev1' version of this board.


Second device is DViCO FusionHDTV Dual Digital Express, a PCIe card
based on cx23885[1] It also has two tuners. lspci gives:
04:00.0 Multimedia video controller [0400]: Conexant Systems, Inc.
CX23885 PCI Video and Audio Decoder [14f1:8852] (rev 02)
Subsystem: DViCO Corporation Device [18ac:db78]
Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr-
Stepping- SERR- FastB2B- DisINTx-
Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast TAbort-
TAbort- MAbort- SERR- PERR- INTx-
Latency: 0, Cache Line Size: 64 bytes
Interrupt: pin A routed to IRQ 19
Region 0: Memory at 9000 (64-bit, non-prefetchable) [size=2M]
Capabilities: access denied
Kernel driver in use: cx23885
Kernel modules: cx23885

With Robert's patch compiled in:
 * On setup 1
  I am able to tune both cards and there are no errors from the cxusb module
   or dvb-usb anymore.
   I tested each of the four tuners, by running dvbscan with
appropriate arguments to
   select the right /dev/dvb/adapterN.

   I just realised I should probably revert the patch and check which
tuners show the
   original problem. Before I was taking the default choice (adapter0,
I think) which is
one of lhe Dual Digital 4 tuners.

 * I have yet to test setup 2,
   I have built the patched kernel module but the box is back 'in
production' right now.
   I plan to test tomorrow.

 * On setup 3. I attempted to tune using dvbscan, w_scan and vlc.
   Again, I was not specific about which tuner the applications should use.
   So to answer your question, I think it is the lsusb id 0fe9:db78
that is unable to tune.
   I will check the tuners individually, tomorrow.

   My impression was that the failures were because of API differences
between the
   applications (all provided as part of the ubuntu install) and the
V4L modules. I have
   not tried to build v4l-apps from the mercurial tree.

So, I hope this makes things clearer. Happy to run tests if you have
any time to look at this.

Kind regards
Vince


[1] http://linuxtv.org/wiki/index.php/DViCO_FusionHDTV_DVB-T_Dual_Express

On 11/7/09, Devin Heitmueller dheitmuel...@kernellabs.com wrote:
 Please excuse the top post. This is coming from my phone.

 Vincent, please confirm exactly which of your boards is not working.
 Roberts patch is not a general fix and only applies to his EXACT
 product .

 please provide the pci/usb I'd in question.

 thanks,

 devin

 On 11/6/09, Vincent McIntyre vincent.mcint...@gmail.com wrote:
 I tried this patch, on 2.6.24-23-rt and 2.6.31-14-generic
 .
 On the first, it appears to work fine. Thanks again Rob!

 On the second, while the kernel seems happy I am unable to get any
 applications to tune the card, when I use the latest v4l tree + Rob's
 patch (40705fec2fb2 tip).

  * dvbscan fails with 'unable to query frontend status'

  * vlc is unable to tune as well
 [0x9c2cf50] dvb access error: DVB-T: setting frontend failed (-1):
 Invalid argument
 [0x9c2cf50] dvb access error: DVB-T: tuning failed
 [0xb7400c18] main input error: open of `dvb://frequency=177500' failed:
 (null)


  * w_scan fails a bit more informatively
 w_scan version 20090808 (compiled for DVB API 5.0)
 using settings for AUSTRALIA
 DVB aerial
 DVB-T AU
 frontend_type DVB-T, channellist 3
 output format vdr-1.6
 Info: using DVB adapter auto detection.
 /dev/dvb/adapter0/frontend0 - DVB-T Zarlink ZL10353 DVB-T: good
 :-)
 /dev/dvb/adapter1/frontend0 - DVB-T Zarlink ZL10353 DVB-T: good
 :-)
 /dev/dvb/adapter2/frontend0 - DVB-T Zarlink ZL10353 DVB-T: good
 :-)
 /dev/dvb/adapter3/frontend0 - DVB-T Zarlink ZL10353 DVB-T: good
 :-)
 Using DVB-T frontend (adapter /dev/dvb/adapter0/frontend0)
 -_-_-_-_ Getting frontend capabilities-_-_-_-_
 Using DVB API 5.1
 frontend Zarlink ZL10353 DVB-T supports
 INVERSION_AUTO
 QAM_AUTO
 TRANSMISSION_MODE_AUTO
 GUARD_INTERVAL_AUTO
 HIERARCHY_AUTO
 FEC_AUTO
 -_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_-_
 Scanning 7MHz frequencies...
 177500: (time: 00:00) 

Re: bisected regression in tuner-xc2028 on DVICO dual digital 4

2009-11-07 Thread Devin Heitmueller
On Sat, Nov 7, 2009 at 6:28 AM, Vincent McIntyre
vincent.mcint...@gmail.com wrote:
 Hi Devin

 please confirm exactly which of your boards is not working.

 Sorry for being unclear.

 I have three test setups I am working with, all on the same computer.
 1. Ubuntu Hardy, kernel 2.6.24-23-rt and drivers from v4l-dvb tip.
 2. Ubuntu Karmic, kernel 2.6.31-14-generic, stock Ubuntu drivers.
 3. Ubuntu Karmic, kernel 2.6.31-14-generic, v4l-dvb tip.

 Setups 2  3 are the same install, on a separate hard disk from setup 1.
 I change between 2  3 by installing the v4l modules or restoring the
 ubuntu stuff from backup. (rsync -av --delete).

 The computer has two DVB-T cards.

 First device is the same as Robert's, I believe. It has two tuners. lsusb 
 gives:
 Bus 003 Device 003: ID 0fe9:db78 DVICO FusionHDTV DVB-T Dual Digital 4
 (ZL10353+xc2028/xc3028) (initialized)
 Bus 003 Device 002: ID 0fe9:db78 DVICO FusionHDTV DVB-T Dual Digital 4
 (ZL10353+xc2028/xc3028) (initialized)
 I have a 'rev1' version of this board.


 Second device is DViCO FusionHDTV Dual Digital Express, a PCIe card
 based on cx23885[1] It also has two tuners. lspci gives:
 04:00.0 Multimedia video controller [0400]: Conexant Systems, Inc.
 CX23885 PCI Video and Audio Decoder [14f1:8852] (rev 02)
        Subsystem: DViCO Corporation Device [18ac:db78]
        Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr-
 Stepping- SERR- FastB2B- DisINTx-
        Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast TAbort-
 TAbort- MAbort- SERR- PERR- INTx-
        Latency: 0, Cache Line Size: 64 bytes
        Interrupt: pin A routed to IRQ 19
        Region 0: Memory at 9000 (64-bit, non-prefetchable) [size=2M]
        Capabilities: access denied
        Kernel driver in use: cx23885
        Kernel modules: cx23885

 With Robert's patch compiled in:
  * On setup 1
  I am able to tune both cards and there are no errors from the cxusb module
   or dvb-usb anymore.
   I tested each of the four tuners, by running dvbscan with
 appropriate arguments to
   select the right /dev/dvb/adapterN.

   I just realised I should probably revert the patch and check which
 tuners show the
   original problem. Before I was taking the default choice (adapter0,
 I think) which is
    one of lhe Dual Digital 4 tuners.

  * I have yet to test setup 2,
   I have built the patched kernel module but the box is back 'in
 production' right now.
   I plan to test tomorrow.

  * On setup 3. I attempted to tune using dvbscan, w_scan and vlc.
   Again, I was not specific about which tuner the applications should use.
   So to answer your question, I think it is the lsusb id 0fe9:db78
 that is unable to tune.
   I will check the tuners individually, tomorrow.

   My impression was that the failures were because of API differences
 between the
   applications (all provided as part of the ubuntu install) and the
 V4L modules. I have
   not tried to build v4l-apps from the mercurial tree.

 So, I hope this makes things clearer. Happy to run tests if you have
 any time to look at this.

Hello Vince,

I think the next step at this point is for you to definitively find a
use case that does not work with the latest v4l-dvb tip and Robert's
patch, and include exactly what kernel you tested with and which board
is having the problem (including the PCI or USB ID).

At this point, your description seems a bit vague in terms of what is
working and what is not.  If you do the additional testing to narrow
down specifically the failure case you are experiencing, I will see
what I can do.

That said, I'm preparing a tree with Robert's patch since I am pretty
confident at least his particular problem is now addressed.

Thanks,

Devin

-- 
Devin J. Heitmueller - Kernel Labs
http://www.kernellabs.com
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: bisected regression in tuner-xc2028 on DVICO dual digital 4

2009-11-05 Thread Vincent McIntyre
I have one of these too.

lsusb:
Bus 003 Device 003: ID 0fe9:db78 DVICO FusionHDTV DVB-T Dual Digital 4
(ZL10353+xc2028/xc3028) (initialized)
Bus 003 Device 002: ID 0fe9:db78 DVICO FusionHDTV DVB-T Dual Digital 4
(ZL10353+xc2028/xc3028) (initialized)

In addition I have a DViCO Dual Digital Express which is a PCIe card
based on Conexant, with the Zarlink frontend.
lspci:
04:00.0 Multimedia video controller [0400]: Conexant Systems, Inc.
CX23885 PCI Video and Audio Decoder [14f1:8852] (rev 02)
Subsystem: DViCO Corporation Device [18ac:db78]
Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr-
Stepping- SERR- FastB2B- DisINTx-
Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast TAbort-
TAbort- MAbort- SERR- PERR- INTx-
Latency: 0, Cache Line Size: 64 bytes
Interrupt: pin A routed to IRQ 19
Region 0: Memory at 9000 (64-bit, non-prefetchable) [size=2M]
Capabilities: access denied
Kernel driver in use: cx23885
Kernel modules: cx23885



More detail, including dmesg etc, at
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/459523

On 11/6/09, Devin Heitmueller dheitmuel...@kernellabs.com wrote:
 On Thu, Nov 5, 2009 at 12:23 AM, Robert Lowery rglow...@exemail.com.au
 wrote:
 Hi Devin,

 Thanks for your reply.

 I don't think your suggestion to use disable_power_mgmt will work as I
 already tried setting the no_poweroff=1 kernel module without success (and
 even tried recompiling with xc2028_sleep returning 0 immediately, but
 until I stopped the .sleep being set at all in xc2028_dvb_tuner_ops, the
 problem kept happening.

 The only thing that fixed it without code change was to set
 dvb_powerdown_on_sleep=0.

 Looking at the below code from dvb_frontend.c, the only difference I could
 see between setting no_poweroff=1 and not setting .sleep is the latter
 stops i2c_gate_ctrl being called.

        if (dvb_powerdown_on_sleep) {
                if (fe-ops.set_voltage)
                        fe-ops.set_voltage(fe, SEC_VOLTAGE_OFF);
                if (fe-ops.tuner_ops.sleep) {
                        if (fe-ops.i2c_gate_ctrl)
                                fe-ops.i2c_gate_ctrl(fe, 1);
                        fe-ops.tuner_ops.sleep(fe);
                        if (fe-ops.i2c_gate_ctrl)
                                fe-ops.i2c_gate_ctrl(fe, 0);
                }
                if (fe-ops.sleep)
                        fe-ops.sleep(fe);
        }

 I'm not very familiar with this code.  Am I missing something?

 -Rob

 Could you please clarify exactly which card you have (PCI/USB ID)?

 Devin

 --
 Devin J. Heitmueller - Kernel Labs
 http://www.kernellabs.com
 --
 To unsubscribe from this list: send the line unsubscribe linux-media in
 the body of a message to majord...@vger.kernel.org
 More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: bisected regression in tuner-xc2028 on DVICO dual digital 4

2009-11-05 Thread Devin Heitmueller
On Thu, Nov 5, 2009 at 3:57 PM, Vincent McIntyre
vincent.mcint...@gmail.com wrote:
 I have one of these too.

 lsusb:
 Bus 003 Device 003: ID 0fe9:db78 DVICO FusionHDTV DVB-T Dual Digital 4
 (ZL10353+xc2028/xc3028) (initialized)
 Bus 003 Device 002: ID 0fe9:db78 DVICO FusionHDTV DVB-T Dual Digital 4
 (ZL10353+xc2028/xc3028) (initialized)

 In addition I have a DViCO Dual Digital Express which is a PCIe card
 based on Conexant, with the Zarlink frontend.
 lspci:
 04:00.0 Multimedia video controller [0400]: Conexant Systems, Inc.
 CX23885 PCI Video and Audio Decoder [14f1:8852] (rev 02)
        Subsystem: DViCO Corporation Device [18ac:db78]
        Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr-
 Stepping- SERR- FastB2B- DisINTx-
        Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast TAbort-
 TAbort- MAbort- SERR- PERR- INTx-
        Latency: 0, Cache Line Size: 64 bytes
        Interrupt: pin A routed to IRQ 19
        Region 0: Memory at 9000 (64-bit, non-prefetchable) [size=2M]
        Capabilities: access denied
        Kernel driver in use: cx23885
        Kernel modules: cx23885

Crap.  This is the price I pay for not having noticed Robert included
a launchpad ticket with the dmesg output.

Yeah, it's a zl10353, so I know what the problem is.  Let me look at
the code and send you a patch for testing.  If you don't hear back
from me within 24 hours, ping me again.

Cheers,

Devin

-- 
Devin J. Heitmueller - Kernel Labs
http://www.kernellabs.com
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: bisected regression in tuner-xc2028 on DVICO dual digital 4

2009-11-05 Thread Robert Lowery
 On Thu, Nov 5, 2009 at 3:57 PM, Vincent McIntyre
 vincent.mcint...@gmail.com wrote:
 I have one of these too.

 lsusb:
 Bus 003 Device 003: ID 0fe9:db78 DVICO FusionHDTV DVB-T Dual Digital 4
 (ZL10353+xc2028/xc3028) (initialized)
 Bus 003 Device 002: ID 0fe9:db78 DVICO FusionHDTV DVB-T Dual Digital 4
 (ZL10353+xc2028/xc3028) (initialized)

 In addition I have a DViCO Dual Digital Express which is a PCIe card
 based on Conexant, with the Zarlink frontend.
 lspci:
 04:00.0 Multimedia video controller [0400]: Conexant Systems, Inc.
 CX23885 PCI Video and Audio Decoder [14f1:8852] (rev 02)
        Subsystem: DViCO Corporation Device [18ac:db78]
        Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop-
 ParErr-
 Stepping- SERR- FastB2B- DisINTx-
        Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast TAbort-
 TAbort- MAbort- SERR- PERR- INTx-
        Latency: 0, Cache Line Size: 64 bytes
        Interrupt: pin A routed to IRQ 19
        Region 0: Memory at 9000 (64-bit, non-prefetchable) [size=2M]
        Capabilities: access denied
        Kernel driver in use: cx23885
        Kernel modules: cx23885

 Crap.  This is the price I pay for not having noticed Robert included
 a launchpad ticket with the dmesg output.

 Yeah, it's a zl10353, so I know what the problem is.  Let me look at
 the code and send you a patch for testing.  If you don't hear back
 from me within 24 hours, ping me again.

Do you mean something like this (untested) patch?  I'll try it out tonight.

diff -r 43878f8dbfb0 linux/drivers/media/dvb/dvb-usb/cxusb.c
--- a/linux/drivers/media/dvb/dvb-usb/cxusb.c   Sun Nov 01 07:17:46 2009
-0200
+++ b/linux/drivers/media/dvb/dvb-usb/cxusb.c   Fri Nov 06 10:39:38 2009
+1100
@@ -666,6 +666,14 @@
.parallel_ts = 1,
 };

+static struct zl10353_config cxusb_zl10353_xc3028_config_no_i2c_gate = {
+   .demod_address = 0x0f,
+   .if2 = 45600,
+   .no_tuner = 1,
+   .parallel_ts = 1,
+   .disable_i2c_gate_ctrl = 1,
+};
+
 static struct mt352_config cxusb_mt352_xc3028_config = {
.demod_address = 0x0f,
.if2 = 4560,
@@ -897,7 +905,7 @@
cxusb_bluebird_gpio_pulse(adap-dev, 0x02, 1);

if ((adap-fe = dvb_attach(zl10353_attach,
-  cxusb_zl10353_xc3028_config,
+  cxusb_zl10353_xc3028_config_no_i2c_gate,
   adap-dev-i2c_adap)) == NULL)
return -EIO;


 Cheers,

 Devin

 --
 Devin J. Heitmueller - Kernel Labs
 http://www.kernellabs.com
 --
 To unsubscribe from this list: send the line unsubscribe linux-media in
 the body of a message to majord...@vger.kernel.org
 More majordomo info at  http://vger.kernel.org/majordomo-info.html



--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: bisected regression in tuner-xc2028 on DVICO dual digital 4

2009-11-05 Thread Devin Heitmueller
On Thu, Nov 5, 2009 at 6:45 PM, Robert Lowery rglow...@exemail.com.au wrote:
 Do you mean something like this (untested) patch?  I'll try it out tonight.

 diff -r 43878f8dbfb0 linux/drivers/media/dvb/dvb-usb/cxusb.c
 --- a/linux/drivers/media/dvb/dvb-usb/cxusb.c   Sun Nov 01 07:17:46 2009
 -0200
 +++ b/linux/drivers/media/dvb/dvb-usb/cxusb.c   Fri Nov 06 10:39:38 2009
 +1100
 @@ -666,6 +666,14 @@
        .parallel_ts = 1,
  };

 +static struct zl10353_config cxusb_zl10353_xc3028_config_no_i2c_gate = {
 +       .demod_address = 0x0f,
 +       .if2 = 45600,
 +       .no_tuner = 1,
 +       .parallel_ts = 1,
 +       .disable_i2c_gate_ctrl = 1,
 +};
 +
  static struct mt352_config cxusb_mt352_xc3028_config = {
        .demod_address = 0x0f,
        .if2 = 4560,
 @@ -897,7 +905,7 @@
        cxusb_bluebird_gpio_pulse(adap-dev, 0x02, 1);

        if ((adap-fe = dvb_attach(zl10353_attach,
 -                                  cxusb_zl10353_xc3028_config,
 +                                  cxusb_zl10353_xc3028_config_no_i2c_gate,
                                   adap-dev-i2c_adap)) == NULL)
                return -EIO;

Wow, that looks shockingly similar to the patch I did for an em28xx
boards a couple of months ago, even down to the part where you added
_no_i2c_gate to the end!  :-)

Yeah, that's the fix, although from the diff I can't tell if you're
doing it for all zl10353 boards in cxusb.c or just yours.  I would
have to see the source to know for sure.

Devin

-- 
Devin J. Heitmueller - Kernel Labs
http://www.kernellabs.com
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: bisected regression in tuner-xc2028 on DVICO dual digital 4

2009-11-05 Thread Robert Lowery
 On Thu, Nov 5, 2009 at 6:45 PM, Robert Lowery rglow...@exemail.com.au
 wrote:
 Do you mean something like this (untested) patch?  I'll try it out
 tonight.

 diff -r 43878f8dbfb0 linux/drivers/media/dvb/dvb-usb/cxusb.c
 --- a/linux/drivers/media/dvb/dvb-usb/cxusb.c   Sun Nov 01 07:17:46 2009
 -0200
 +++ b/linux/drivers/media/dvb/dvb-usb/cxusb.c   Fri Nov 06 10:39:38 2009
 +1100
 @@ -666,6 +666,14 @@
        .parallel_ts = 1,
  };

 +static struct zl10353_config cxusb_zl10353_xc3028_config_no_i2c_gate =
 {
 +       .demod_address = 0x0f,
 +       .if2 = 45600,
 +       .no_tuner = 1,
 +       .parallel_ts = 1,
 +       .disable_i2c_gate_ctrl = 1,
 +};
 +
  static struct mt352_config cxusb_mt352_xc3028_config = {
        .demod_address = 0x0f,
        .if2 = 4560,
 @@ -897,7 +905,7 @@
        cxusb_bluebird_gpio_pulse(adap-dev, 0x02, 1);

        if ((adap-fe = dvb_attach(zl10353_attach,
 -                                  cxusb_zl10353_xc3028_config,
 +                                
  cxusb_zl10353_xc3028_config_no_i2c_gate,
                                   adap-dev-i2c_adap)) == NULL)
                return -EIO;

 Wow, that looks shockingly similar to the patch I did for an em28xx
 boards a couple of months ago, even down to the part where you added
 _no_i2c_gate to the end!  :-)

I might have got some inspiration from somewhere :)


 Yeah, that's the fix, although from the diff I can't tell if you're
 doing it for all zl10353 boards in cxusb.c or just yours.  I would
 have to see the source to know for sure.

I only changed cxusb_dualdig4_frontend_attach() so it should be just my
board.  The only other board that was using cxusb_zl10353_xc3028_config
was cxusb_nano2_frontend_attach(), but I left that as is since I don't
know if that board is similarily affected.

I'l try it out tonight and confirm it fixes the problem

Thanks for your help

-Rob


 Devin

 --
 Devin J. Heitmueller - Kernel Labs
 http://www.kernellabs.com



--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: bisected regression in tuner-xc2028 on DVICO dual digital 4

2009-11-05 Thread Robert Lowery
 On Thu, Nov 5, 2009 at 6:45 PM, Robert Lowery rglow...@exemail.com.au
 wrote:
 Do you mean something like this (untested) patch?  I'll try it out
 tonight.

 diff -r 43878f8dbfb0 linux/drivers/media/dvb/dvb-usb/cxusb.c
 --- a/linux/drivers/media/dvb/dvb-usb/cxusb.c   Sun Nov 01 07:17:46
 2009
 -0200
 +++ b/linux/drivers/media/dvb/dvb-usb/cxusb.c   Fri Nov 06 10:39:38
 2009
 +1100
 @@ -666,6 +666,14 @@
        .parallel_ts = 1,
  };

 +static struct zl10353_config cxusb_zl10353_xc3028_config_no_i2c_gate =
 {
 +       .demod_address = 0x0f,
 +       .if2 = 45600,
 +       .no_tuner = 1,
 +       .parallel_ts = 1,
 +       .disable_i2c_gate_ctrl = 1,
 +};
 +
  static struct mt352_config cxusb_mt352_xc3028_config = {
        .demod_address = 0x0f,
        .if2 = 4560,
 @@ -897,7 +905,7 @@
        cxusb_bluebird_gpio_pulse(adap-dev, 0x02, 1);

        if ((adap-fe = dvb_attach(zl10353_attach,
 -                                  cxusb_zl10353_xc3028_config,
 +                                
  cxusb_zl10353_xc3028_config_no_i2c_gate,
                                   adap-dev-i2c_adap)) == NULL)
                return -EIO;

 Wow, that looks shockingly similar to the patch I did for an em28xx
 boards a couple of months ago, even down to the part where you added
 _no_i2c_gate to the end!  :-)

 I might have got some inspiration from somewhere :)


 Yeah, that's the fix, although from the diff I can't tell if you're
 doing it for all zl10353 boards in cxusb.c or just yours.  I would
 have to see the source to know for sure.

 I only changed cxusb_dualdig4_frontend_attach() so it should be just my
 board.  The only other board that was using cxusb_zl10353_xc3028_config
 was cxusb_nano2_frontend_attach(), but I left that as is since I don't
 know if that board is similarily affected.

 I'll try it out tonight and confirm it fixes the problem

Devin,

I have confirmed the patch below fixes my issue.  Could you please merge
it for me?

Thanks

-Rob

Fix hang on DViCO FusionHDTV DVB-T Dual Digital 4 (rev 1)
Signed Off: Robert Lowery rglow...@exemail.com.au

diff -r c57f47cfb0e8 linux/drivers/media/dvb/dvb-usb/cxusb.c
--- a/linux/drivers/media/dvb/dvb-usb/cxusb.c   Wed Nov 04 18:21:15 2009
-0200
+++ b/linux/drivers/media/dvb/dvb-usb/cxusb.c   Fri Nov 06 13:28:07 2009
+1100
@@ -666,6 +666,14 @@
.parallel_ts = 1,
 };

+static struct zl10353_config cxusb_zl10353_xc3028_config_no_i2c_gate = {
+   .demod_address = 0x0f,
+   .if2 = 45600,
+   .no_tuner = 1,
+   .parallel_ts = 1,
+   .disable_i2c_gate_ctrl = 1,
+};
+
 static struct mt352_config cxusb_mt352_xc3028_config = {
.demod_address = 0x0f,
.if2 = 4560,
@@ -897,7 +905,7 @@
cxusb_bluebird_gpio_pulse(adap-dev, 0x02, 1);

if ((adap-fe = dvb_attach(zl10353_attach,
-  cxusb_zl10353_xc3028_config,
+  cxusb_zl10353_xc3028_config_no_i2c_gate,
   adap-dev-i2c_adap)) == NULL)
return -EIO;


--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: bisected regression in tuner-xc2028 on DVICO dual digital 4

2009-11-05 Thread Devin Heitmueller
On Thu, Nov 5, 2009 at 9:31 PM, Robert Lowery rglow...@exemail.com.au wrote:
 Devin,

 I have confirmed the patch below fixes my issue.  Could you please merge
 it for me?

 Thanks

 -Rob

Sure.  I'm putting together a patch series for this weekend with a few
different misc fixes.

Devin

-- 
Devin J. Heitmueller - Kernel Labs
http://www.kernellabs.com
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html