Re: hg pull http://202.88.242.108:8000/hg/var/www/hg/v4l-dvb/

2010-11-22 Thread Mauro Carvalho Chehab
Em 17-11-2010 10:28, Manu Abraham escreveu:
 On Wed, Nov 17, 2010 at 7:48 AM, Mauro Carvalho Chehab
 mche...@redhat.com wrote:
 Em 14-11-2010 18:48, Manu Abraham escreveu:
 Mauro,

 Please pull from http://202.88.242.108:8000/hg/var/www/hg/v4l-dvb/

 for the following changes.


 changeset 15168:baa4e8008db5 Mantis, hopper: use MODULE_DEVICE_TABLE
 http://202.88.242.108:8000/hg/var/www/hg/v4l-dvb/rev/baa4e8008db5

 changeset 15169:f04605948fdc Mantis: append tasklet maintenance for
 DVB stream delivery
 http://202.88.242.108:8000/hg/var/www/hg/v4l-dvb/rev/f04605948fdc

 changeset 15170:ee7a63d70f94 Mantis: use dvb_attach to avoid double
 dereferencing on module removal
 http://202.88.242.108:8000/hg/var/www/hg/v4l-dvb/rev/ee7a63d70f94

 changeset 15171:3a2ece3bf184 Mantis: Rename gpio_set_bits to
 mantis_gpio_set_bits
 http://202.88.242.108:8000/hg/var/www/hg/v4l-dvb/rev/3a2ece3bf184

 changeset 15172:56c20de4f697 stb6100: Improve tuner performance
 http://202.88.242.108:8000/hg/var/www/hg/v4l-dvb/rev/56c20de4f697

 changeset 15173:5cc010e3a803 stb0899: fix diseqc messages getting lost
 http://202.88.242.108:8000/hg/var/www/hg/v4l-dvb/rev/5cc010e3a803

 Applied, thanks.

 A new warning appeared:

 drivers/media/dvb/frontends/stb6100.c:120: warning: ‘stb6100_normalise_regs’ 
 defined but not used
 
 
 Can you please enclose the function in a #if 0.since it is not being used.

The enclosed patch should fix the warning.

---


[media] stb6100: warning cleanup

drivers/media/dvb/frontends/stb6100.c:120: warning: ‘stb6100_normalise_regs’ 
defined but not used

Signed-off-by: Mauro Carvalho Chehab mche...@redhat.com

diff --git a/drivers/media/dvb/frontends/stb6100.c 
b/drivers/media/dvb/frontends/stb6100.c
index db66248..64673b8 100644
--- a/drivers/media/dvb/frontends/stb6100.c
+++ b/drivers/media/dvb/frontends/stb6100.c
@@ -117,7 +117,10 @@ static const struct stb6100_regmask stb6100_template[] = {
[STB6100_TEST3] = { 0x00, 0xde },
 };
 
-static void stb6100_normalise_regs(u8 regs[])
+/*
+ * Currently unused. Some boards might need it in the future
+ */
+static inline void stb6100_normalise_regs(u8 regs[])
 {
int i;
 
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: hg pull http://202.88.242.108:8000/hg/var/www/hg/v4l-dvb/

2010-11-22 Thread Manu Abraham
On Mon, Nov 22, 2010 at 9:55 PM, Mauro Carvalho Chehab
mche...@redhat.com wrote:
 Em 17-11-2010 10:28, Manu Abraham escreveu:
 On Wed, Nov 17, 2010 at 7:48 AM, Mauro Carvalho Chehab
 mche...@redhat.com wrote:
 Em 14-11-2010 18:48, Manu Abraham escreveu:
 Mauro,

 Please pull from http://202.88.242.108:8000/hg/var/www/hg/v4l-dvb/

 for the following changes.


 changeset 15168:baa4e8008db5 Mantis, hopper: use MODULE_DEVICE_TABLE
 http://202.88.242.108:8000/hg/var/www/hg/v4l-dvb/rev/baa4e8008db5

 changeset 15169:f04605948fdc Mantis: append tasklet maintenance for
 DVB stream delivery
 http://202.88.242.108:8000/hg/var/www/hg/v4l-dvb/rev/f04605948fdc

 changeset 15170:ee7a63d70f94 Mantis: use dvb_attach to avoid double
 dereferencing on module removal
 http://202.88.242.108:8000/hg/var/www/hg/v4l-dvb/rev/ee7a63d70f94

 changeset 15171:3a2ece3bf184 Mantis: Rename gpio_set_bits to
 mantis_gpio_set_bits
 http://202.88.242.108:8000/hg/var/www/hg/v4l-dvb/rev/3a2ece3bf184

 changeset 15172:56c20de4f697 stb6100: Improve tuner performance
 http://202.88.242.108:8000/hg/var/www/hg/v4l-dvb/rev/56c20de4f697

 changeset 15173:5cc010e3a803 stb0899: fix diseqc messages getting lost
 http://202.88.242.108:8000/hg/var/www/hg/v4l-dvb/rev/5cc010e3a803

 Applied, thanks.

 A new warning appeared:

 drivers/media/dvb/frontends/stb6100.c:120: warning: 
 ‘stb6100_normalise_regs’ defined but not used


 Can you please enclose the function in a #if 0.since it is not being used.

 The enclosed patch should fix the warning.

 ---


 [media] stb6100: warning cleanup

 drivers/media/dvb/frontends/stb6100.c:120: warning: ‘stb6100_normalise_regs’ 
 defined but not used

 Signed-off-by: Mauro Carvalho Chehab mche...@redhat.com

Acked-by: Manu Abraham m...@linuxtv.org


 diff --git a/drivers/media/dvb/frontends/stb6100.c 
 b/drivers/media/dvb/frontends/stb6100.c
 index db66248..64673b8 100644
 --- a/drivers/media/dvb/frontends/stb6100.c
 +++ b/drivers/media/dvb/frontends/stb6100.c
 @@ -117,7 +117,10 @@ static const struct stb6100_regmask stb6100_template[] = 
 {
        [STB6100_TEST3]         = { 0x00, 0xde },
  };

 -static void stb6100_normalise_regs(u8 regs[])
 +/*
 + * Currently unused. Some boards might need it in the future
 + */
 +static inline void stb6100_normalise_regs(u8 regs[])
  {
        int i;


--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: hg pull http://202.88.242.108:8000/hg/var/www/hg/v4l-dvb/

2010-11-17 Thread Manu Abraham
On Wed, Nov 17, 2010 at 7:48 AM, Mauro Carvalho Chehab
mche...@redhat.com wrote:
 Em 14-11-2010 18:48, Manu Abraham escreveu:
 Mauro,

 Please pull from http://202.88.242.108:8000/hg/var/www/hg/v4l-dvb/

 for the following changes.


 changeset 15168:baa4e8008db5 Mantis, hopper: use MODULE_DEVICE_TABLE
 http://202.88.242.108:8000/hg/var/www/hg/v4l-dvb/rev/baa4e8008db5

 changeset 15169:f04605948fdc Mantis: append tasklet maintenance for
 DVB stream delivery
 http://202.88.242.108:8000/hg/var/www/hg/v4l-dvb/rev/f04605948fdc

 changeset 15170:ee7a63d70f94 Mantis: use dvb_attach to avoid double
 dereferencing on module removal
 http://202.88.242.108:8000/hg/var/www/hg/v4l-dvb/rev/ee7a63d70f94

 changeset 15171:3a2ece3bf184 Mantis: Rename gpio_set_bits to
 mantis_gpio_set_bits
 http://202.88.242.108:8000/hg/var/www/hg/v4l-dvb/rev/3a2ece3bf184

 changeset 15172:56c20de4f697 stb6100: Improve tuner performance
 http://202.88.242.108:8000/hg/var/www/hg/v4l-dvb/rev/56c20de4f697

 changeset 15173:5cc010e3a803 stb0899: fix diseqc messages getting lost
 http://202.88.242.108:8000/hg/var/www/hg/v4l-dvb/rev/5cc010e3a803

 Applied, thanks.

 A new warning appeared:

 drivers/media/dvb/frontends/stb6100.c:120: warning: ‘stb6100_normalise_regs’ 
 defined but not used


Can you please enclose the function in a #if 0.since it is not being used.

Regards,
Manu
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: hg pull http://202.88.242.108:8000/hg/var/www/hg/v4l-dvb/

2010-11-16 Thread Mauro Carvalho Chehab
Em 14-11-2010 18:48, Manu Abraham escreveu:
 Mauro,
 
 Please pull from http://202.88.242.108:8000/hg/var/www/hg/v4l-dvb/
 
 for the following changes.
 
 
 changeset 15168:baa4e8008db5 Mantis, hopper: use MODULE_DEVICE_TABLE
 http://202.88.242.108:8000/hg/var/www/hg/v4l-dvb/rev/baa4e8008db5
 
 changeset 15169:f04605948fdc Mantis: append tasklet maintenance for
 DVB stream delivery
 http://202.88.242.108:8000/hg/var/www/hg/v4l-dvb/rev/f04605948fdc
 
 changeset 15170:ee7a63d70f94 Mantis: use dvb_attach to avoid double
 dereferencing on module removal
 http://202.88.242.108:8000/hg/var/www/hg/v4l-dvb/rev/ee7a63d70f94
 
 changeset 15171:3a2ece3bf184 Mantis: Rename gpio_set_bits to
 mantis_gpio_set_bits
 http://202.88.242.108:8000/hg/var/www/hg/v4l-dvb/rev/3a2ece3bf184
 
 changeset 15172:56c20de4f697 stb6100: Improve tuner performance
 http://202.88.242.108:8000/hg/var/www/hg/v4l-dvb/rev/56c20de4f697
 
 changeset 15173:5cc010e3a803 stb0899: fix diseqc messages getting lost
 http://202.88.242.108:8000/hg/var/www/hg/v4l-dvb/rev/5cc010e3a803

Applied, thanks.

A new warning appeared:

drivers/media/dvb/frontends/stb6100.c:120: warning: ‘stb6100_normalise_regs’ 
defined but not used

I tried to remove the applied patches from the patchwork queue. There are still 
a few patches
pending there. Not sure if they got obsoleted by the applied ones, or if they 
are still
relevant:

Jun,20 2010: [2/2] DVB/V4L: mantis: remove unused files 
http://patchwork.kernel.org/patch/107062  Bjørn Mork bj...@mork.no
Jul,10 2010: Mantis driver patch: use interrupt for I2C traffic instead of busy 
reg http://patchwork.kernel.org/patch/111245  Marko Ristola 
marko.rist...@kolumbus.fi
Jul,19 2010: Twinhan DTV Ter-CI (3030 mantis)   
http://patchwork.kernel.org/patch/112708  Niklas Claesson 
nicke.claes...@gmail.com
Aug, 7 2010: Refactor Mantis DMA transfer to deliver 16Kb TS data per interrupt 
http://patchwork.kernel.org/patch/118173  Marko Ristola 
marko.rist...@kolumbus.fi
Oct,10 2010: [v2] V4L/DVB: faster DVB-S lock for mantis cards using stb0899 
demod   http://patchwork.kernel.org/patch/244201  Tuxoholic 
tuxoho...@hotmail.de

Please take a look and give us some feedback.

Thanks,
Mauro.
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


hg pull http://202.88.242.108:8000/hg/var/www/hg/v4l-dvb/

2010-11-14 Thread Manu Abraham
Mauro,

Please pull from http://202.88.242.108:8000/hg/var/www/hg/v4l-dvb/

for the following changes.


changeset 15168:baa4e8008db5 Mantis, hopper: use MODULE_DEVICE_TABLE
http://202.88.242.108:8000/hg/var/www/hg/v4l-dvb/rev/baa4e8008db5

changeset 15169:f04605948fdc Mantis: append tasklet maintenance for
DVB stream delivery
http://202.88.242.108:8000/hg/var/www/hg/v4l-dvb/rev/f04605948fdc

changeset 15170:ee7a63d70f94 Mantis: use dvb_attach to avoid double
dereferencing on module removal
http://202.88.242.108:8000/hg/var/www/hg/v4l-dvb/rev/ee7a63d70f94

changeset 15171:3a2ece3bf184 Mantis: Rename gpio_set_bits to
mantis_gpio_set_bits
http://202.88.242.108:8000/hg/var/www/hg/v4l-dvb/rev/3a2ece3bf184

changeset 15172:56c20de4f697 stb6100: Improve tuner performance
http://202.88.242.108:8000/hg/var/www/hg/v4l-dvb/rev/56c20de4f697

changeset 15173:5cc010e3a803 stb0899: fix diseqc messages getting lost
http://202.88.242.108:8000/hg/var/www/hg/v4l-dvb/rev/5cc010e3a803


Regards,
Manu
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html