Re: [REVIEWv3 PATCH 00/13] vb2: various small fixes/improvements
On Fri, Apr 11, 2014 at 10:11:06AM +0200, Hans Verkuil wrote: > This is the third version of this review patch series. > The previous can be found here: > > http://www.spinics.net/lists/linux-media/msg75428.html > > Changes since v2: > > - Updated v4l2-pci-skeleton.c as well in patch 01/13 > - Dropped patch 10/13 as it is not needed > - Added comment to patch 06/13 as suggested by Pawel > - Added patch 13/13: fix HDTV interlaced handling in v4l2-pci-skeleton.c For patches 10--13, Acked-by: Sakari Ailus -- Sakari Ailus e-mail: sakari.ai...@iki.fi XMPP: sai...@retiisi.org.uk -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[REVIEWv3 PATCH 00/13] vb2: various small fixes/improvements
This is the third version of this review patch series. The previous can be found here: http://www.spinics.net/lists/linux-media/msg75428.html Changes since v2: - Updated v4l2-pci-skeleton.c as well in patch 01/13 - Dropped patch 10/13 as it is not needed - Added comment to patch 06/13 as suggested by Pawel - Added patch 13/13: fix HDTV interlaced handling in v4l2-pci-skeleton.c If there are no more comments, then I plan on posting a pull request on Monday. Regards, Hans -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: vb2: various small fixes/improvements
On Mon, Mar 10, 2014 at 10:20:47PM +0100, Hans Verkuil wrote: > This patch series contains a list of various vb2 fixes and improvements. > > These patches were originally part of this RFC patch series: > > http://www.spinics.net/lists/linux-media/msg73391.html > > They are now rebased and reordered a bit. It's little stuff for the > most part, although the first patch touches on more drivers since it > changes the return type of stop_streaming to void. The return value was > always ignored by vb2 and you really cannot do anything sensible with it. > In general resource allocations can return an error, but freeing up resources > should not. That should always succeed. For patches 1--10, with Pawel's comments addressed: Acked-by: Sakari Ailus -- Sakari Ailus e-mail: sakari.ai...@iki.fi XMPP: sai...@retiisi.org.uk -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[REVIEWv2 PATCH 00/13] vb2: various small fixes/improvements
This is the second version of this review patch series. The first can be found here: http://www.spinics.net/lists/linux-media/msg74220.html Changes since v2: - Rebased to latest master branch - Incorporated all suggestions/remarks from Pawel (patches 2, 4 and 7) - Added patch 12 (follow-up of patch 4) and 13 (suggested by Pawel) Regards, Hans -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: vb2: various small fixes/improvements
Can someone review this? That would be much appreciated! Regards, Hans On 03/10/2014 10:20 PM, Hans Verkuil wrote: > This patch series contains a list of various vb2 fixes and improvements. > > These patches were originally part of this RFC patch series: > > http://www.spinics.net/lists/linux-media/msg73391.html > > They are now rebased and reordered a bit. It's little stuff for the > most part, although the first patch touches on more drivers since it > changes the return type of stop_streaming to void. The return value was > always ignored by vb2 and you really cannot do anything sensible with it. > In general resource allocations can return an error, but freeing up resources > should not. That should always succeed. > > Regards, > > Hans > > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
vb2: various small fixes/improvements
This patch series contains a list of various vb2 fixes and improvements. These patches were originally part of this RFC patch series: http://www.spinics.net/lists/linux-media/msg73391.html They are now rebased and reordered a bit. It's little stuff for the most part, although the first patch touches on more drivers since it changes the return type of stop_streaming to void. The return value was always ignored by vb2 and you really cannot do anything sensible with it. In general resource allocations can return an error, but freeing up resources should not. That should always succeed. Regards, Hans -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
