Re: Creating directories with pkunzip, rar, et. al.
Bart Oldeman wrote: It's an internal DOSEMU problem, and an old one at that! The problem is that DOSEMU emulates the archive DOS attribute through the user x bit. Very few DOS programs attempt to set or reset the archive attribute on directories, but pkunzip 2.50 does. Would it make sense to use extended attributes for this where XA is available? Or am I misunderstanding something vital? -Alex Mauer hawke - To unsubscribe from this list: send the line unsubscribe linux-msdos in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Creating directories with pkunzip, rar, et. al.
On 5/7/07, Mike McCarty [EMAIL PROTECTED] wrote: How soon will this be folded into the standard release? it is already in the Subversion repository... as to when the next release is, I don't know. But there have been quite a few little post 1.4.0 fixes so perhaps 1.4.1 doesn't take very long. It all depends on time, I won't make any promises. Bart - To unsubscribe from this list: send the line unsubscribe linux-msdos in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Creating directories with pkunzip, rar, et. al.
Bart Oldeman wrote:
On 5/7/07, Mike McCarty [EMAIL PROTECTED] wrote:
How soon will this be folded into the standard release?
it is already in the Subversion repository... as to when the next
release is, I don't know.
Fair enough. Dunno yet.
But there have been quite a few little post 1.4.0 fixes so perhaps
1.4.1 doesn't take very long.
It all depends on time, I won't make any promises.
I wasn't expecting any. I was just wondering when it might be.
If you don't know yet, then that's fine.
Mike
--
p=p=%c%s%c;main(){printf(p,34,p,34);};main(){printf(p,34,p,34);}
Oppose globalization and One World Governments like the UN.
This message made from 100% recycled bits.
You have found the bank of Larn.
I can explain it for you, but I can't understand it for you.
I speak only for myself, and I am unanimous in that!
-
To unsubscribe from this list: send the line unsubscribe linux-msdos in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Creating directories with pkunzip, rar, et. al.
On 5/7/07, Joe Ripley [EMAIL PROTECTED] wrote: The problem I have is, when pkunzip (in my case, pkunzip 2.50) is ran with the '-d' switch (to automatically create the original directory structure of the archive) it fails. ... The reason that PKUNZIP 'can't create' the files, is because the directories (BIN, DATA, etc.) don't have the execute bit set on them. ... Anyway, I'm running DOSEMU 1.3.5. I've tried both MS-DOS 6.22 and FreeDOS 1.0 and the problem exists in both. Is there some kind of umask setting that will control this behavior, or is it an internal DOSEMU problem? It's an internal DOSEMU problem, and an old one at that! The problem is that DOSEMU emulates the archive DOS attribute through the user x bit. Very few DOS programs attempt to set or reset the archive attribute on directories, but pkunzip 2.50 does. The same problem happens with dosemu 1.2.2 (which crashes unless you use the -3 option of pkunzip). I'm going to fix it in DOSEMU by ignoring set attribute requests on directories but there are other workarounds, e.g. by using INFO-ZIP (for DOS or Linux) or older versions of pkunzip. On a mounted FAT partition the problem should not happen either. Bart - To unsubscribe from this list: send the line unsubscribe linux-msdos in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Creating directories with pkunzip, rar, et. al.
On 5/7/07, Bart Oldeman [EMAIL PROTECTED] wrote: It's an internal DOSEMU problem, and an old one at that! The problem is that DOSEMU emulates the archive DOS attribute through the user x bit. Very few DOS programs attempt to set or reset the archive attribute on directories, but pkunzip 2.50 does. The same problem happens with dosemu 1.2.2 (which crashes unless you use the -3 option of pkunzip). I'm going to fix it in DOSEMU by ignoring set attribute requests on directories but there are other workarounds, e.g. by using INFO-ZIP (for DOS or Linux) or older versions of pkunzip. On a mounted FAT partition the problem should not happen either. I thought it had to be some obscure detail... :) Thanks for the info. I'll take a look at some of the alternatives for now. -- Joe Ripley [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-msdos in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Creating directories with pkunzip, rar, et. al.
On 5/7/07, Joe Ripley [EMAIL PROTECTED] wrote: On 5/7/07, Bart Oldeman [EMAIL PROTECTED] wrote: It's an internal DOSEMU problem, and an old one at that! The problem is that DOSEMU emulates the archive DOS attribute through the user x bit. Very few DOS programs attempt to set or reset the archive attribute on directories, but pkunzip 2.50 does. Actually, I had some time to do some testing, and I found that it's not that pkunzip is attempting to set the archive attribute. When run with the debug messages turned on, pkunzip tries to create the directory with an attribute of 0x10 (i.e. a regular file) rather than 0x20 (a directory). As a hack to fix it, all I did was add one line to the beginning of the set_dos_attr() function in mfs.c: if (S_ISDIR(mode)) attr = DIRECTORY; pkunzip extracts with directories properly now: -- drwxr-xr-x 2 bbs users 240 2007-05-07 16:05 bin drwxr-xr-x 2 bbs users 208 2007-05-07 16:05 data drwxr-xr-x 2 bbs users 168 2007-05-07 16:06 docs drwxr-xr-x 2 bbs users 80 2007-05-07 16:05 language drwxr-xr-x 2 bbs users 584 2007-05-07 16:06 menus drwxr-xr-x 2 bbs users 144 2007-05-07 16:06 text -- -- Joe Ripley [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-msdos in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Creating directories with pkunzip, rar, et. al.
On 5/7/07, Joe Ripley [EMAIL PROTECTED] wrote: On 5/7/07, Joe Ripley [EMAIL PROTECTED] wrote: Actually, I had some time to do some testing, and I found that it's not that pkunzip is attempting to set the archive attribute. When run with the debug messages turned on, pkunzip tries to create the directory with an attribute of 0x10 (i.e. a regular file) rather than 0x20 (a directory). No, first of all creating a directory does not involve any attributes, and secondly 0x10=directory, and 0x20=archive. What you see in a -D+dD log with LFN's enabled is something like this: INT21 (0) at 02a8:3478: AX=7139, BX=caf4, CX=, DX=caf4, DS=0c28, ES=0c28 LFN: doing LFN!, AX=7139 DL=f4 LFN: mkdir DOC (...) INT21 (0) at 02a8:344b: AX=7143, BX=ca01, CX=0020, DX=caf4, DS=0c28, ES=0c28 LFN: doing LFN!, AX=7143 DL=f4 LFN: attribute DOC 1 the CX=20 here is the new attribute (ie. archive) As a hack to fix it, all I did was add one line to the beginning of the set_dos_attr() function in mfs.c: if (S_ISDIR(mode)) attr = DIRECTORY; This is correct, since the read-only attribute must also be ignored. However, there is also some FAT code that does not need the clearance. So I committed a similar check but in a different place, get_unix_attr(): --- src/dosext/mfs/mfs.c(revision 1784) +++ src/dosext/mfs/mfs.c(revision 1785) @@ -608,6 +608,12 @@ #if 0 #define S_IWRITEA (S_IWUSR | S_IWGRP | S_IWOTH) #endif + /* Do not make directories read-only as this has completely different + semantics in DOS (mostly ignore) than in Unix. + Also do not reflect the archive bit as clearing the x bit as that + can cause inaccessible directories */ + if (S_ISDIR(mode) || (attr DIRECTORY)) +attr = DIRECTORY; mode = ~(S_IFDIR | S_IWRITE | S_IEXEC); if (attr DIRECTORY) mode |= S_IFDIR; - To unsubscribe from this list: send the line unsubscribe linux-msdos in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Creating directories with pkunzip, rar, et. al.
On 5/7/07, Bart Oldeman [EMAIL PROTECTED] wrote: No, first of all creating a directory does not involve any attributes, and secondly 0x10=directory, and 0x20=archive. Woops... I guess that shows how much of a newbie I am. :) As a hack to fix it, all I did was add one line to the beginning of the set_dos_attr() function in mfs.c: if (S_ISDIR(mode)) attr = DIRECTORY; This is correct, since the read-only attribute must also be ignored. However, there is also some FAT code that does not need the clearance. So I committed a similar check but in a different place, get_unix_attr(): Cool, looks good. Thanks for looking into this! -- Joe Ripley [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-msdos in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
