Re: [PATCH] powerpc/papr_scm: Make 'perf_stats' invisible if perf-stats unavailable
Hi Vaibhav,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on powerpc/next]
[also build test WARNING on v5.12 next-20210505]
[cannot apply to scottwood/next mpe/next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Vaibhav-Jain/powerpc-papr_scm-Make-perf_stats-invisible-if-perf-stats-unavailable/20210506-031853
base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
config: powerpc-allyesconfig (attached as .config)
compiler: powerpc64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
#
https://github.com/0day-ci/linux/commit/8e7ce04ec36dea95fad178585b697a9c5b5c259d
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Vaibhav-Jain/powerpc-papr_scm-Make-perf_stats-invisible-if-perf-stats-unavailable/20210506-031853
git checkout 8e7ce04ec36dea95fad178585b697a9c5b5c259d
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross W=1
ARCH=powerpc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
All warnings (new ones prefixed by >>):
>> arch/powerpc/platforms/pseries/papr_scm.c:903:9: warning: no previous
>> prototype for 'papr_nd_attribute_visible' [-Wmissing-prototypes]
903 | umode_t papr_nd_attribute_visible(struct kobject *kobj, struct
attribute *attr,
| ^
vim +/papr_nd_attribute_visible +903 arch/powerpc/platforms/pseries/papr_scm.c
902
> 903 umode_t papr_nd_attribute_visible(struct kobject *kobj, struct
> attribute *attr,
904int n)
905 {
906 struct device *dev = container_of(kobj, typeof(*dev), kobj);
907 struct nvdimm *nvdimm = to_nvdimm(dev);
908 struct papr_scm_priv *p = nvdimm_provider_data(nvdimm);
909
910 /* For if perf-stats not available remove perf_stats sysfs */
911 if (attr == &dev_attr_perf_stats.attr && p->stat_buffer_len ==
0)
912 return 0;
913
914 return attr->mode;
915 }
916
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
___
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-le...@lists.01.org
Re: [PATCH] include: Remove pagemap.h from blkdev.h
Hi "Matthew,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on block/for-next]
[also build test ERROR on linus/master v5.12-rc2 next-20210309]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Matthew-Wilcox-Oracle/include-Remove-pagemap-h-from-blkdev-h/20210310-021720
base: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git
for-next
config: powerpc64-randconfig-m031-20210309 (attached as .config)
compiler: powerpc-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
#
https://github.com/0day-ci/linux/commit/b47f527df5ad6c9ece259086b85bf4f0dfd27025
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Matthew-Wilcox-Oracle/include-Remove-pagemap-h-from-blkdev-h/20210310-021720
git checkout b47f527df5ad6c9ece259086b85bf4f0dfd27025
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross
ARCH=powerpc64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
All error/warnings (new ones prefixed by >>):
In file included from include/linux/suspend.h:5,
from arch/powerpc/kernel/asm-offsets.c:23:
include/linux/swap.h: In function 'find_get_incore_page':
>> include/linux/swap.h:578:9: error: implicit declaration of function
>> 'find_get_page'; did you mean 'find_get_pid'?
>> [-Werror=implicit-function-declaration]
578 | return find_get_page(mapping, index);
| ^
| find_get_pid
>> include/linux/swap.h:578:9: warning: returning 'int' from a function with
>> return type 'struct page *' makes pointer from integer without a cast
>> [-Wint-conversion]
578 | return find_get_page(mapping, index);
| ^
cc1: some warnings being treated as errors
--
In file included from include/linux/suspend.h:5,
from arch/powerpc/kernel/asm-offsets.c:23:
include/linux/swap.h: In function 'find_get_incore_page':
>> include/linux/swap.h:578:9: error: implicit declaration of function
>> 'find_get_page'; did you mean 'find_get_pid'?
>> [-Werror=implicit-function-declaration]
578 | return find_get_page(mapping, index);
| ^
| find_get_pid
>> include/linux/swap.h:578:9: warning: returning 'int' from a function with
>> return type 'struct page *' makes pointer from integer without a cast
>> [-Wint-conversion]
578 | return find_get_page(mapping, index);
| ^
cc1: some warnings being treated as errors
make[2]: *** [scripts/Makefile.build:116: arch/powerpc/kernel/asm-offsets.s]
Error 1
make[2]: Target '__build' not remade because of errors.
make[1]: *** [Makefile:1233: prepare0] Error 2
make[1]: Target 'modules_prepare' not remade because of errors.
make: *** [Makefile:215: __sub-make] Error 2
make: Target 'modules_prepare' not remade because of errors.
--
In file included from include/linux/suspend.h:5,
from arch/powerpc/kernel/asm-offsets.c:23:
include/linux/swap.h: In function 'find_get_incore_page':
>> include/linux/swap.h:578:9: error: implicit declaration of function
>> 'find_get_page'; did you mean 'find_get_pid'?
>> [-Werror=implicit-function-declaration]
578 | return find_get_page(mapping, index);
| ^
| find_get_pid
>> include/linux/swap.h:578:9: warning: returning 'int' from a function with
>> return type 'struct page *' makes pointer from integer without a cast
>> [-Wint-conversion]
578 | return find_get_page(mapping, index);
| ^
cc1: some warnings being treated as errors
make[2]: *** [scripts/Makefile.build:116: arch/powerpc/kernel/asm-offsets.s]
Error 1
make[2]: Target '__build' not remade because of errors.
make[1]: *** [Makefile:1233: prepare0] Error 2
make[1]: Target 'prepare' not remade because of errors.
make: *** [Makefile:215: __sub-make] Error 2
make: Target 'prepare' not remade because of errors.
vim +578 include/linux/swap.h
bd96b9eb7cfd6a Con Kolivas 2006-06-23 574
61ef1865570
Re: [PATCH 22/22] mpool: add Kconfig and Makefile
Hi,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linux/master]
[also build test ERROR on linus/master v5.9-rc7 next-20200928]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/nmeeramohide-micron-com/add-Object-Storage-Media-Pool-mpool/20200929-004933
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
bcf876870b95592b52519ed4aafcf9d95999bc9c
config: m68k-allmodconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
#
https://github.com/0day-ci/linux/commit/0d485fc58582bd112bb72fe15f107e8cbe3536b0
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
nmeeramohide-micron-com/add-Object-Storage-Media-Pool-mpool/20200929-004933
git checkout 0d485fc58582bd112bb72fe15f107e8cbe3536b0
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross
ARCH=m68k
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
All error/warnings (new ones prefixed by >>):
In file included from arch/m68k/include/asm/io_mm.h:25,
from arch/m68k/include/asm/io.h:8,
from include/linux/io.h:13,
from include/linux/irq.h:20,
from include/asm-generic/hardirq.h:13,
from ./arch/m68k/include/generated/asm/hardirq.h:1,
from include/linux/hardirq.h:10,
from include/linux/highmem.h:10,
from include/linux/pagemap.h:11,
from include/linux/blkdev.h:16,
from drivers/mpool/pd.c:15:
arch/m68k/include/asm/raw_io.h: In function 'raw_rom_outsb':
arch/m68k/include/asm/raw_io.h:83:7: warning: variable '__w' set but not
used [-Wunused-but-set-variable]
83 | ({u8 __w, __v = (b); u32 _addr = ((u32) (addr)); \
| ^~~
arch/m68k/include/asm/raw_io.h:430:3: note: in expansion of macro 'rom_out_8'
430 | rom_out_8(port, *buf++);
| ^
arch/m68k/include/asm/raw_io.h: In function 'raw_rom_outsw':
arch/m68k/include/asm/raw_io.h:86:8: warning: variable '__w' set but not
used [-Wunused-but-set-variable]
86 | ({u16 __w, __v = (w); u32 _addr = ((u32) (addr)); \
|^~~
arch/m68k/include/asm/raw_io.h:448:3: note: in expansion of macro
'rom_out_be16'
448 | rom_out_be16(port, *buf++);
| ^~~~
arch/m68k/include/asm/raw_io.h: In function 'raw_rom_outsw_swapw':
arch/m68k/include/asm/raw_io.h:90:8: warning: variable '__w' set but not
used [-Wunused-but-set-variable]
90 | ({u16 __w, __v = (w); u32 _addr = ((u32) (addr)); \
|^~~
arch/m68k/include/asm/raw_io.h:466:3: note: in expansion of macro
'rom_out_le16'
466 | rom_out_le16(port, *buf++);
| ^~~~
In file included from include/linux/kernel.h:11,
from include/linux/list.h:9,
from include/linux/wait.h:7,
from include/linux/wait_bit.h:8,
from include/linux/fs.h:6,
from drivers/mpool/pd.c:14:
include/linux/scatterlist.h: In function 'sg_set_buf':
arch/m68k/include/asm/page_mm.h:169:49: warning: ordered comparison of
pointer with null pointer [-Wextra]
169 | #define virt_addr_valid(kaddr) ((void *)(kaddr) >= (void
*)PAGE_OFFSET && (void *)(kaddr) < high_memory)
| ^~
include/linux/compiler.h:78:42: note: in definition of macro 'unlikely'
78 | # define unlikely(x) __builtin_expect(!!(x), 0)
| ^
include/linux/scatterlist.h:143:2: note: in expansion of macro 'BUG_ON'
143 | BUG_ON(!virt_addr_valid(buf));
| ^~
include/linux/scatterlist.h:143:10: note: in expansion of macro
'virt_addr_valid'
143 | BUG_ON(!virt_addr_valid(buf));
| ^~~
drivers/mpool/pd.c: In function 'pd_bio_rw':
>> drivers/mpool/pd.c:294:14: warning: cast from pointer to integer of
>> different size [-Wpointer-to-int-cast]
294 | iov_base = (u64)iov[i].iov_base;
| ^
>> drivers/mpool/pd.c:224:13: warning: variable 'op' set but not used
>> [-Wunused-but-set-variable]
224 |
[linux-nvdimm:libnvdimm-fixes 2/3] drivers/dax/super.c:325:6: error: redefinition of 'dax_supported'
tree: https://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm.git
libnvdimm-fixes
head: d4c5da5049ac27c6ef8f6f98548c3a1ade352d25
commit: e2ec5128254518cae320d5dc631b71b94160f663 [2/3] dm: Call proper helper
to determine dax support
config: x86_64-randconfig-a011-20200920 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project
f4e554180962aa6bc93678898b6933ea712bde50)
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
git checkout e2ec5128254518cae320d5dc631b71b94160f663
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
All errors (new ones prefixed by >>):
>> drivers/dax/super.c:325:6: error: redefinition of 'dax_supported'
bool dax_supported(struct dax_device *dax_dev, struct block_device *bdev,
^
include/linux/dax.h:162:20: note: previous definition is here
static inline bool dax_supported(struct dax_device *dax_dev,
^
drivers/dax/super.c:451:6: warning: no previous prototype for function
'run_dax' [-Wmissing-prototypes]
void run_dax(struct dax_device *dax_dev)
^
drivers/dax/super.c:451:1: note: declare 'static' if the function is not
intended to be used outside of this translation unit
void run_dax(struct dax_device *dax_dev)
^
static
1 warning and 1 error generated.
#
https://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm.git/commit/?id=e2ec5128254518cae320d5dc631b71b94160f663
git remote add linux-nvdimm
https://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm.git
git fetch --no-tags linux-nvdimm libnvdimm-fixes
git checkout e2ec5128254518cae320d5dc631b71b94160f663
vim +/dax_supported +325 drivers/dax/super.c
b0686260fecaa9 Dan Williams 2017-01-26 324
7bf7eac8d64805 Dan Williams 2019-05-16 @325 bool dax_supported(struct
dax_device *dax_dev, struct block_device *bdev,
7bf7eac8d64805 Dan Williams 2019-05-16 326 int blocksize, sector_t
start, sector_t len)
7bf7eac8d64805 Dan Williams 2019-05-16 327 {
e2ec5128254518 Jan Kara 2020-09-20 328 if (!dax_dev)
e2ec5128254518 Jan Kara 2020-09-20 329 return false;
e2ec5128254518 Jan Kara 2020-09-20 330
7bf7eac8d64805 Dan Williams 2019-05-16 331 if (!dax_alive(dax_dev))
7bf7eac8d64805 Dan Williams 2019-05-16 332 return false;
7bf7eac8d64805 Dan Williams 2019-05-16 333
7bf7eac8d64805 Dan Williams 2019-05-16 334 return
dax_dev->ops->dax_supported(dax_dev, bdev, blocksize, start, len);
7bf7eac8d64805 Dan Williams 2019-05-16 335 }
e2ec5128254518 Jan Kara 2020-09-20 336 EXPORT_SYMBOL_GPL(dax_supported);
7bf7eac8d64805 Dan Williams 2019-05-16 337
:: The code at line 325 was first introduced by commit
:: 7bf7eac8d648057519adb6fce1e31458c902212c dax: Arrange for dax_supported
check to span multiple devices
:: TO: Dan Williams
:: CC: Dan Williams
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
___
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-le...@lists.01.org
[linux-nvdimm:libnvdimm-fixes 2/3] drivers/dax/super.c:31:5: error: redefinition of 'dax_read_lock'
tree: https://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm.git
libnvdimm-fixes
head: 5ca46d3ef704a0d0ddd79a7dfa164a6a5b6ccef2
commit: 5ba388db58497496fbeb952c9454e8e6e59584ac [2/3] dm: Call proper helper
to determine dax support
config: m68k-hp300_defconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout 5ba388db58497496fbeb952c9454e8e6e59584ac
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross
ARCH=m68k
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
All errors (new ones prefixed by >>):
In file included from arch/m68k/include/asm/page.h:60,
from arch/m68k/include/asm/thread_info.h:6,
from include/linux/thread_info.h:38,
from include/asm-generic/preempt.h:5,
from ./arch/m68k/include/generated/asm/preempt.h:1,
from include/linux/preempt.h:78,
from include/linux/spinlock.h:51,
from include/linux/mmzone.h:8,
from include/linux/gfp.h:6,
from include/linux/mm.h:10,
from include/linux/pagemap.h:8,
from drivers/dax/super.c:5:
include/linux/pfn_t.h: In function 'pfn_t_valid':
arch/m68k/include/asm/page_mm.h:169:49: warning: ordered comparison of
pointer with null pointer [-Wextra]
169 | #define virt_addr_valid(kaddr) ((void *)(kaddr) >= (void
*)PAGE_OFFSET && (void *)(kaddr) < high_memory)
| ^~
arch/m68k/include/asm/page_mm.h:170:25: note: in expansion of macro
'virt_addr_valid'
170 | #define pfn_valid(pfn) virt_addr_valid(pfn_to_virt(pfn))
| ^~~
include/linux/pfn_t.h:76:9: note: in expansion of macro 'pfn_valid'
76 | return pfn_valid(pfn_t_to_pfn(pfn));
| ^
drivers/dax/super.c: At top level:
>> drivers/dax/super.c:31:5: error: redefinition of 'dax_read_lock'
31 | int dax_read_lock(void)
| ^
In file included from drivers/dax/super.c:16:
include/linux/dax.h:205:19: note: previous definition of 'dax_read_lock' was
here
205 | static inline int dax_read_lock(void)
| ^
>> drivers/dax/super.c:37:6: error: redefinition of 'dax_read_unlock'
37 | void dax_read_unlock(int id)
| ^~~
In file included from drivers/dax/super.c:16:
include/linux/dax.h:210:20: note: previous definition of 'dax_read_unlock'
was here
210 | static inline void dax_read_unlock(int id)
|^~~
drivers/dax/super.c:69:6: warning: no previous prototype for
'__generic_fsdax_supported' [-Wmissing-prototypes]
69 | bool __generic_fsdax_supported(struct dax_device *dax_dev,
| ^
drivers/dax/super.c:167:6: warning: no previous prototype for
'__bdev_dax_supported' [-Wmissing-prototypes]
167 | bool __bdev_dax_supported(struct block_device *bdev, int blocksize)
| ^~~~
>> drivers/dax/super.c:325:6: error: redefinition of 'dax_supported'
325 | bool dax_supported(struct dax_device *dax_dev, struct block_device
*bdev,
| ^
In file included from drivers/dax/super.c:16:
include/linux/dax.h:162:20: note: previous definition of 'dax_supported' was
here
162 | static inline bool dax_supported(struct dax_device *dax_dev,
|^
drivers/dax/super.c:451:6: warning: no previous prototype for 'run_dax'
[-Wmissing-prototypes]
451 | void run_dax(struct dax_device *dax_dev)
| ^~~
#
https://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm.git/commit/?id=5ba388db58497496fbeb952c9454e8e6e59584ac
git remote add linux-nvdimm
https://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm.git
git fetch --no-tags linux-nvdimm libnvdimm-fixes
git checkout 5ba388db58497496fbeb952c9454e8e6e59584ac
vim +/dax_read_lock +31 drivers/dax/super.c
72058005411ffd Dan Williams 2017-04-19 30
7b6be8444e0f0d Dan Williams 2017-04-11 @31 int dax_read_lock(void)
7b6be8444e0f0d Dan Williams 2017-04-11 32 {
7b6be8444e0f0d Dan Williams 2017-04-11 33 return
srcu_read_lock(&dax_srcu);
7b6be8444e0f0d Dan Williams 2017-04-11 34 }
7b6be8444e0f0d Dan Williams 2017-04-11 35 EXPORT_SYMBOL_GPL(dax_read_lock);
7b6be8444e0f0d Dan Williams 2017-04-11 36
[linux-nvdimm:libnvdimm-fixes 1/2] drivers/md/dm-table.c:866: undefined reference to `dax_read_lock'
tree: https://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm.git
libnvdimm-fixes
head: 3305ce9e90c8f1fefdf75acfbb814574c12bfcc5
commit: ec5f196ad972cd740bcbe6ef9c89a8a92d54ba44 [1/2] dm: Call proper helper
to determine dax support
config: openrisc-randconfig-r022-20200918 (attached as .config)
compiler: or1k-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout ec5f196ad972cd740bcbe6ef9c89a8a92d54ba44
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross
ARCH=openrisc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
All errors (new ones prefixed by >>):
or1k-linux-ld: drivers/md/dm-table.o: in function `device_supports_dax':
>> drivers/md/dm-table.c:866: undefined reference to `dax_read_lock'
drivers/md/dm-table.c:866:(.text+0x84c): relocation truncated to fit:
R_OR1K_INSN_REL_26 against undefined symbol `dax_read_lock'
>> or1k-linux-ld: drivers/md/dm-table.c:868: undefined reference to
>> `dax_read_unlock'
drivers/md/dm-table.c:868:(.text+0x854): relocation truncated to fit:
R_OR1K_INSN_REL_26 against undefined symbol `dax_read_unlock'
#
https://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm.git/commit/?id=ec5f196ad972cd740bcbe6ef9c89a8a92d54ba44
git remote add linux-nvdimm
https://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm.git
git fetch --no-tags linux-nvdimm libnvdimm-fixes
git checkout ec5f196ad972cd740bcbe6ef9c89a8a92d54ba44
vim +866 drivers/md/dm-table.c
858
859 /* validate the dax capability of the target device span */
860 int device_supports_dax(struct dm_target *ti, struct dm_dev *dev,
861 sector_t start, sector_t len, void *data)
862 {
863 int blocksize = *(int *) data, id;
864 bool rc;
865
> 866 id = dax_read_lock();
867 rc = dax_supported(dev->dax_dev, dev->bdev, blocksize, start,
len);
> 868 dax_read_unlock(id);
869
870 return rc;
871 }
872
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
___
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-le...@lists.01.org
[linux-nvdimm:libnvdimm-fixes 1/2] undefined reference to `dax_read_lock'
tree: https://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm.git libnvdimm-fixes head: 3305ce9e90c8f1fefdf75acfbb814574c12bfcc5 commit: ec5f196ad972cd740bcbe6ef9c89a8a92d54ba44 [1/2] dm: Call proper helper to determine dax support config: parisc-defconfig (attached as .config) compiler: hppa-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross git checkout ec5f196ad972cd740bcbe6ef9c89a8a92d54ba44 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=parisc If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): hppa-linux-ld: drivers/md/dm-table.o: in function `device_supports_dax': >> (.text+0x5d4): undefined reference to `dax_read_lock' >> hppa-linux-ld: (.text+0x5dc): undefined reference to `dax_read_unlock' --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org ___ Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org To unsubscribe send an email to linux-nvdimm-le...@lists.01.org
Re: [PATCH v3 3/7] mm/memory_hotplug: prepare passing flags to add_memory() and friends
Hi David,
I love your patch! Perhaps something to improve:
[auto build test WARNING on next-20200909]
[cannot apply to mmotm/master hnaz-linux-mm/master xen-tip/linux-next
powerpc/next linus/master v5.9-rc4 v5.9-rc3 v5.9-rc2 v5.9-rc4]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/David-Hildenbrand/mm-memory_hotplug-selective-merging-of-system-ram-resources/20200910-171630
base:7204eaa2c1f509066486f488c9dcb065d7484494
:: branch date: 9 hours ago
:: commit date: 9 hours ago
config: powerpc-randconfig-r011-20200909 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project
0a5dc7effb191eff740e0e7ae7bd8e1f6bdb3ad9)
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# install powerpc cross compiling tool for clang build
# apt-get install binutils-powerpc-linux-gnu
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=powerpc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
All warnings (new ones prefixed by >>):
In file included from arch/powerpc/kernel/asm-offsets.c:14:
In file included from include/linux/compat.h:17:
In file included from include/linux/fs.h:15:
In file included from include/linux/radix-tree.h:18:
In file included from include/linux/xarray.h:14:
In file included from include/linux/gfp.h:6:
In file included from include/linux/mmzone.h:853:
include/linux/memory_hotplug.h:354:55: error: unknown type name 'mhp_t'
extern int __add_memory(int nid, u64 start, u64 size, mhp_t mhp_flags);
^
include/linux/memory_hotplug.h:355:53: error: unknown type name 'mhp_t'
extern int add_memory(int nid, u64 start, u64 size, mhp_t mhp_flags);
^
include/linux/memory_hotplug.h:357:11: error: unknown type name 'mhp_t'
mhp_t mhp_flags);
^
include/linux/memory_hotplug.h:360:10: error: unknown type name 'mhp_t'
mhp_t mhp_flags);
^
In file included from arch/powerpc/kernel/asm-offsets.c:21:
>> include/linux/mman.h:137:9: warning: division by zero is undefined
>> [-Wdivision-by-zero]
_calc_vm_trans(flags, MAP_LOCKED, VM_LOCKED) |
^~~~
include/linux/mman.h:115:21: note: expanded from macro '_calc_vm_trans'
: ((x) & (bit1)) / ((bit1) / (bit2
^ ~
include/linux/mman.h:138:9: warning: division by zero is undefined
[-Wdivision-by-zero]
_calc_vm_trans(flags, MAP_SYNC, VM_SYNC );
^~~~
include/linux/mman.h:115:21: note: expanded from macro '_calc_vm_trans'
: ((x) & (bit1)) / ((bit1) / (bit2
^ ~
2 warnings and 4 errors generated.
make[2]: *** [scripts/Makefile.build:117: arch/powerpc/kernel/asm-offsets.s]
Error 1
make[2]: Target '__build' not remade because of errors.
make[1]: *** [Makefile:1196: prepare0] Error 2
make[1]: Target 'prepare' not remade because of errors.
make: *** [Makefile:185: __sub-make] Error 2
make: Target 'prepare' not remade because of errors.
#
https://github.com/0day-ci/linux/commit/d88270d1c0783a7f99f24a85692be90fd2ae0d7d
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
David-Hildenbrand/mm-memory_hotplug-selective-merging-of-system-ram-resources/20200910-171630
git checkout d88270d1c0783a7f99f24a85692be90fd2ae0d7d
vim +137 include/linux/mman.h
^1da177e4c3f41 Linus Torvalds 2005-04-16 128
^1da177e4c3f41 Linus Torvalds 2005-04-16 129 /*
^1da177e4c3f41 Linus Torvalds 2005-04-16 130 * Combine the mmap "flags"
argument into "vm_flags" used internally.
^1da177e4c3f41 Linus Torvalds 2005-04-16 131 */
^1da177e4c3f41 Linus Torvalds 2005-04-16 132 static inline unsigned long
^1da177e4c3f41 Linus Torvalds 2005-04-16 133 calc_vm_flag_bits(unsigned long
flags)
^1da177e4c3f41 Linus Torvalds 2005-04-16 134 {
^1da177e4c3f41 Linus Torvalds 2005-04-16 135 return
_calc_vm_trans(flags, MAP_GROWSDOWN, VM_GROWSDOWN ) |
^1da177e4c3f41 Linus Torvalds 2005-04-16 136
_calc
Re: [PATCH v3 3/7] mm/memory_hotplug: prepare passing flags to add_memory() and friends
Hi David, I love your patch! Yet something to improve: [auto build test ERROR on next-20200909] [cannot apply to mmotm/master hnaz-linux-mm/master xen-tip/linux-next powerpc/next linus/master v5.9-rc4 v5.9-rc3 v5.9-rc2 v5.9-rc4] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/David-Hildenbrand/mm-memory_hotplug-selective-merging-of-system-ram-resources/20200910-171630 base:7204eaa2c1f509066486f488c9dcb065d7484494 config: x86_64-randconfig-a016-20200909 (attached as .config) compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 0a5dc7effb191eff740e0e7ae7bd8e1f6bdb3ad9) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install x86_64 cross compiling tool for clang build # apt-get install binutils-x86-64-linux-gnu # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): WARNING: unmet direct dependencies detected for PHY_SAMSUNG_UFS Depends on OF && (ARCH_EXYNOS || COMPILE_TEST Selected by - SCSI_UFS_EXYNOS && SCSI_LOWLEVEL && SCSI && SCSI_UFSHCD_PLATFORM && (ARCH_EXYNOS || COMPILE_TEST In file included from arch/x86/kernel/asm-offsets.c:9: In file included from include/linux/crypto.h:20: In file included from include/linux/slab.h:15: In file included from include/linux/gfp.h:6: In file included from include/linux/mmzone.h:853: >> include/linux/memory_hotplug.h:354:55: error: unknown type name 'mhp_t' extern int __add_memory(int nid, u64 start, u64 size, mhp_t mhp_flags); ^ include/linux/memory_hotplug.h:355:53: error: unknown type name 'mhp_t' extern int add_memory(int nid, u64 start, u64 size, mhp_t mhp_flags); ^ include/linux/memory_hotplug.h:357:11: error: unknown type name 'mhp_t' mhp_t mhp_flags); ^ include/linux/memory_hotplug.h:360:10: error: unknown type name 'mhp_t' mhp_t mhp_flags); ^ 4 errors generated. Makefile Module.symvers System.map arch block certs crypto drivers fs include init ipc kernel lib mm modules.builtin modules.builtin.modinfo modules.order net scripts security sound source tools usr virt vmlinux vmlinux.o vmlinux.symvers [scripts/Makefile.build:117: arch/x86/kernel/asm-offsets.s] Error 1 Target '__build' not remade because of errors. Makefile Module.symvers System.map arch block certs crypto drivers fs include init ipc kernel lib mm modules.builtin modules.builtin.modinfo modules.order net scripts security sound source tools usr virt vmlinux vmlinux.o vmlinux.symvers [Makefile:1196: prepare0] Error 2 Target 'prepare' not remade because of errors. make: Makefile Module.symvers System.map arch block certs crypto drivers fs include init ipc kernel lib mm modules.builtin modules.builtin.modinfo modules.order net scripts security sound source tools usr virt vmlinux vmlinux.o vmlinux.symvers [Makefile:185: __sub-make] Error 2 make: Target 'prepare' not remade because of errors. # https://github.com/0day-ci/linux/commit/d88270d1c0783a7f99f24a85692be90fd2ae0d7d git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review David-Hildenbrand/mm-memory_hotplug-selective-merging-of-system-ram-resources/20200910-171630 git checkout d88270d1c0783a7f99f24a85692be90fd2ae0d7d vim +/mhp_t +354 include/linux/memory_hotplug.h 352 353 extern void __ref free_area_init_core_hotplug(int nid); > 354 extern int __add_memory(int nid, u64 start, u64 size, mhp_t mhp_flags); --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org ___ Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org To unsubscribe send an email to linux-nvdimm-le...@lists.01.org
Re: [PATCH] libnvdimm/e820: Fix build error without MEMORY_HOTPLUG
Hi YueHaibing,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linux-nvdimm/libnvdimm-for-next]
[also build test ERROR on v5.9-rc2 next-20200826]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/YueHaibing/libnvdimm-e820-Fix-build-error-without-MEMORY_HOTPLUG/20200826-202043
base: https://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm.git
libnvdimm-for-next
config: x86_64-randconfig-r014-20200826 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
# save the attached .config to linux build tree
make W=1 ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
All errors (new ones prefixed by >>):
>> drivers/nvdimm/e820.c:21:19: error: static declaration of
>> 'phys_to_target_node' follows non-static declaration
21 | static inline int phys_to_target_node(u64 start)
| ^~~
In file included from include/linux/nodemask.h:96,
from arch/x86/include/asm/numa.h:5,
from arch/x86/include/asm/acpi.h:11,
from arch/x86/include/asm/fixmap.h:29,
from arch/x86/include/asm/apic.h:11,
from arch/x86/include/asm/smp.h:13,
from include/linux/smp.h:82,
from include/linux/percpu.h:7,
from include/linux/hrtimer.h:19,
from include/linux/sched.h:20,
from include/linux/ratelimit.h:6,
from include/linux/dev_printk.h:16,
from include/linux/device.h:15,
from include/linux/platform_device.h:13,
from drivers/nvdimm/e820.c:6:
include/linux/numa.h:31:5: note: previous declaration of
'phys_to_target_node' was here
31 | int phys_to_target_node(phys_addr_t addr);
| ^~~
#
https://github.com/0day-ci/linux/commit/4c003ae129dccea4445a55e9e2c61de5922fbd37
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
YueHaibing/libnvdimm-e820-Fix-build-error-without-MEMORY_HOTPLUG/20200826-202043
git checkout 4c003ae129dccea4445a55e9e2c61de5922fbd37
vim +/phys_to_target_node +21 drivers/nvdimm/e820.c
19
20 #ifndef CONFIG_MEMORY_HOTPLUG
> 21 static inline int phys_to_target_node(u64 start)
22 {
23 return 0;
24 }
25 #endif
26
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
___
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-le...@lists.01.org
Re: [PATCH] libnvdimm/e820: Fix build error without MEMORY_HOTPLUG
Hi YueHaibing,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linux-nvdimm/libnvdimm-for-next]
[also build test ERROR on v5.9-rc2 next-20200826]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/YueHaibing/libnvdimm-e820-Fix-build-error-without-MEMORY_HOTPLUG/20200826-202043
base: https://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm.git
libnvdimm-for-next
config: x86_64-randconfig-a002-20200826 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project
7cfcecece0e0430937cf529ce74d3a071a4dedc6)
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
All errors (new ones prefixed by >>):
>> drivers/nvdimm/e820.c:21:19: error: redefinition of 'phys_to_target_node'
static inline int phys_to_target_node(u64 start)
^
include/linux/numa.h:38:19: note: previous definition is here
static inline int phys_to_target_node(phys_addr_t addr)
^
1 error generated.
#
https://github.com/0day-ci/linux/commit/4c003ae129dccea4445a55e9e2c61de5922fbd37
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
YueHaibing/libnvdimm-e820-Fix-build-error-without-MEMORY_HOTPLUG/20200826-202043
git checkout 4c003ae129dccea4445a55e9e2c61de5922fbd37
vim +/phys_to_target_node +21 drivers/nvdimm/e820.c
19
20 #ifndef CONFIG_MEMORY_HOTPLUG
> 21 static inline int phys_to_target_node(u64 start)
22 {
23 return 0;
24 }
25 #endif
26
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
___
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-le...@lists.01.org
Re: [PATCH] libnvdimm/e820: Fix build error without MEMORY_HOTPLUG
Hi YueHaibing,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linux-nvdimm/libnvdimm-for-next]
[also build test ERROR on v5.9-rc2 next-20200826]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/YueHaibing/libnvdimm-e820-Fix-build-error-without-MEMORY_HOTPLUG/20200826-202043
base: https://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm.git
libnvdimm-for-next
config: i386-randconfig-a004-20200826 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
# save the attached .config to linux build tree
make W=1 ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
All errors (new ones prefixed by >>):
>> drivers/nvdimm/e820.c:21:19: error: redefinition of 'phys_to_target_node'
21 | static inline int phys_to_target_node(u64 start)
| ^~~
In file included from include/linux/nodemask.h:96,
from include/linux/sched.h:22,
from include/linux/ratelimit.h:6,
from include/linux/dev_printk.h:16,
from include/linux/device.h:15,
from include/linux/platform_device.h:13,
from drivers/nvdimm/e820.c:6:
include/linux/numa.h:38:19: note: previous definition of
'phys_to_target_node' was here
38 | static inline int phys_to_target_node(phys_addr_t addr)
| ^~~
#
https://github.com/0day-ci/linux/commit/4c003ae129dccea4445a55e9e2c61de5922fbd37
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
YueHaibing/libnvdimm-e820-Fix-build-error-without-MEMORY_HOTPLUG/20200826-202043
git checkout 4c003ae129dccea4445a55e9e2c61de5922fbd37
vim +/phys_to_target_node +21 drivers/nvdimm/e820.c
19
20 #ifndef CONFIG_MEMORY_HOTPLUG
> 21 static inline int phys_to_target_node(u64 start)
22 {
23 return 0;
24 }
25 #endif
26
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
___
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-le...@lists.01.org
Re: [x86/copy_mc] a0ac629ebe: fio.read_iops -43.3% regression
On Thu, Aug 06, 2020 at 05:35:00PM +0200, Ingo Molnar wrote:
>
> * Dan Williams wrote:
>
> > On Thu, Aug 6, 2020 at 6:35 AM Ingo Molnar wrote:
> > >
> > >
> > > * kernel test robot wrote:
> > >
> > > > Greeting,
> > > >
> > > > FYI, we noticed a -43.3% regression of fio.read_iops due to commit:
> > > >
> > > >
> > > > commit: a0ac629ebe7b3d248cb93807782a00d9142fdb98 ("x86/copy_mc:
> > > > Introduce copy_mc_generic()")
> > > > url:
> > > > https://github.com/0day-ci/linux/commits/Dan-Williams/Renovate-memcpy_mcsafe-with-copy_mc_to_-user-kernel/20200802-014046
> > > >
> > > >
> > > > in testcase: fio-basic
> > > > on test machine: 96 threads Intel(R) Xeon(R) Gold 6252 CPU @ 2.10GHz
> > > > with 256G memory
> > > > with following parameters:
> > >
> > > So this performance regression, if it isn't a spurious result, looks
> > > concerning. Is this expected?
> >
> > This is not expected and I think delays these patches until I'm back
> > from leave in a few weeks. I know that we might lose some inlining
> > effect due to replacing native memcpy, but I did not expect it would
> > have an impact like this. In my testing I was seeing a performance
> > improvement from replacing the careful / open-coded copy with rep;
> > mov;, which increases the surprise of this result.
>
> It would be nice to double check this on the kernel-test-robot side as
> well, to make sure it's not a false positive.
>
Hi Ingo,
We recompiled the kernels with option "-falign-functions=32", and the
regression still exists:
7476b91d4db369d8 a0ac629ebe7b3d248cb9380778 testcase/testparams/testbox
-- ---
%stddev change %stddev
\ |\
22103 -43% 12551
fio-basic/2M-performance-2pmem-xfs-libaio-dax-50%-200s-read-200G-tb-ucode=0x5002f01/lkp-csl-2sp6
22103 -43% 12551GEO-MEAN fio.read_iops
Best Regards,
Rong Chen
___
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-le...@lists.01.org
Re: [PATCH v3 06/23] mm/memory_hotplug: Introduce default phys_to_target_node() implementation
Hi Dan,
I love your patch! Yet something to improve:
[auto build test ERROR on 01830e6c042e8eb6eb202e05d7df8057135b4c26]
url:
https://github.com/0day-ci/linux/commits/Dan-Williams/device-dax-Support-sub-dividing-soft-reserved-ranges/20200801-114823
base:01830e6c042e8eb6eb202e05d7df8057135b4c26
config: x86_64-randconfig-a012-20200731 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-14) 9.3.0
reproduce (this is a W=1 build):
# save the attached .config to linux build tree
make W=1 ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
All errors (new ones prefixed by >>):
In file included from include/linux/mmzone.h:813,
from include/linux/gfp.h:6,
from include/linux/slab.h:15,
from include/linux/crypto.h:20,
from arch/x86/kernel/asm-offsets.c:9:
>> include/linux/memory_hotplug.h:160:19: error: redefinition of
>> 'phys_to_target_node'
160 | static inline int phys_to_target_node(u64 start)
| ^~~
In file included from include/linux/mmzone.h:14,
from include/linux/gfp.h:6,
from include/linux/slab.h:15,
from include/linux/crypto.h:20,
from arch/x86/kernel/asm-offsets.c:9:
include/linux/numa.h:38:19: note: previous definition of
'phys_to_target_node' was here
38 | static inline int phys_to_target_node(phys_addr_t addr)
| ^~~
make[2]: *** [scripts/Makefile.build:114: arch/x86/kernel/asm-offsets.s]
Error 1
make[2]: Target '__build' not remade because of errors.
make[1]: *** [Makefile:1197: prepare0] Error 2
make[1]: Target 'prepare' not remade because of errors.
make: *** [Makefile:185: __sub-make] Error 2
make: Target 'prepare' not remade because of errors.
vim +/phys_to_target_node +160 include/linux/memory_hotplug.h
151
152 #ifdef CONFIG_NUMA
153 extern int memory_add_physaddr_to_nid(u64 start);
154 extern int phys_to_target_node(u64 start);
155 #else
156 static inline int memory_add_physaddr_to_nid(u64 start)
157 {
158 return 0;
159 }
> 160 static inline int phys_to_target_node(u64 start)
161 {
162 return 0;
163 }
164 #endif
165
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
___
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-le...@lists.01.org
Re: [PATCH v3 20/23] device-dax: Make align a per-device property
Hi Dan,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on 01830e6c042e8eb6eb202e05d7df8057135b4c26]
url:
https://github.com/0day-ci/linux/commits/Dan-Williams/device-dax-Support-sub-dividing-soft-reserved-ranges/20200801-114823
base:01830e6c042e8eb6eb202e05d7df8057135b4c26
config: s390-allyesconfig (attached as .config)
compiler: s390-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross
ARCH=s390
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
All warnings (new ones prefixed by >>):
drivers/dax/device.c:54:20: warning: no previous prototype for
'dax_pgoff_to_phys' [-Wmissing-prototypes]
54 | __weak phys_addr_t dax_pgoff_to_phys(struct dev_dax *dev_dax,
pgoff_t pgoff,
|^
drivers/dax/device.c: In function '__dev_dax_pte_fault':
>> drivers/dax/device.c:80:21: warning: variable 'dax_region' set but not used
>> [-Wunused-but-set-variable]
80 | struct dax_region *dax_region;
| ^~
drivers/dax/device.c: In function '__dev_dax_pmd_fault':
drivers/dax/device.c:113:21: warning: variable 'dax_region' set but not used
[-Wunused-but-set-variable]
113 | struct dax_region *dax_region;
| ^~
drivers/dax/device.c: At top level:
drivers/dax/device.c:397:5: warning: no previous prototype for
'dev_dax_probe' [-Wmissing-prototypes]
397 | int dev_dax_probe(struct dev_dax *dev_dax)
| ^
vim +/dax_region +80 drivers/dax/device.c
dee410792419aaa drivers/dax/dax.cDan Williams 2016-05-14 52
efebc711180f7fe drivers/dax/dax.cDave Jiang 2017-04-07 53 /* see
"strong" declaration in tools/testing/nvdimm/dax-dev.c */
736163671bcb163 drivers/dax/device.c Dan Williams 2017-05-04 @54 __weak
phys_addr_t dax_pgoff_to_phys(struct dev_dax *dev_dax, pgoff_t pgoff,
dee410792419aaa drivers/dax/dax.cDan Williams 2016-05-14 55
unsigned long size)
dee410792419aaa drivers/dax/dax.cDan Williams 2016-05-14 56 {
4d3c109cf2a8406 drivers/dax/device.c Dan Williams 2020-07-31 57 int i;
4d3c109cf2a8406 drivers/dax/device.c Dan Williams 2020-07-31 58
4d3c109cf2a8406 drivers/dax/device.c Dan Williams 2020-07-31 59 for (i
= 0; i < dev_dax->nr_range; i++) {
4d3c109cf2a8406 drivers/dax/device.c Dan Williams 2020-07-31 60
struct dev_dax_range *dax_range = &dev_dax->ranges[i];
4d3c109cf2a8406 drivers/dax/device.c Dan Williams 2020-07-31 61
struct range *range = &dax_range->range;
4d3c109cf2a8406 drivers/dax/device.c Dan Williams 2020-07-31 62
unsigned long long pgoff_end;
753a0850e707e9a drivers/dax/device.c Dan Williams 2017-07-14 63
phys_addr_t phys;
dee410792419aaa drivers/dax/dax.cDan Williams 2016-05-14 64
4d3c109cf2a8406 drivers/dax/device.c Dan Williams 2020-07-31 65
pgoff_end = dax_range->pgoff + PHYS_PFN(range_len(range)) - 1;
4d3c109cf2a8406 drivers/dax/device.c Dan Williams 2020-07-31 66
if (pgoff < dax_range->pgoff || pgoff > pgoff_end)
4d3c109cf2a8406 drivers/dax/device.c Dan Williams 2020-07-31 67
continue;
4d3c109cf2a8406 drivers/dax/device.c Dan Williams 2020-07-31 68
phys = PFN_PHYS(pgoff - dax_range->pgoff) + range->start;
e8f1f803fc7e653 drivers/dax/device.c Dan Williams 2020-07-31 69
if (phys + size - 1 <= range->end)
dee410792419aaa drivers/dax/dax.cDan Williams 2016-05-14 70
return phys;
4d3c109cf2a8406 drivers/dax/device.c Dan Williams 2020-07-31 71
break;
dee410792419aaa drivers/dax/dax.cDan Williams 2016-05-14 72 }
dee410792419aaa drivers/dax/dax.cDan Williams 2016-05-14 73 return
-1;
dee410792419aaa drivers/dax/dax.cDan Williams 2016-05-14 74 }
dee410792419aaa drivers/dax/dax.cDan Williams 2016-05-14 75
226ab561075f6f8 drivers/dax/device.c Dan Williams 2018-07-13 76 static
vm_fault_t __dev_dax_pte_fault(struct dev_dax *dev_dax,
2232c6382a453db drivers/dax/device.c Dan Williams 2018-07-13 77
struct vm_fault *vmf, pfn_t *pfn)
dee410792419aaa drivers/dax/dax.cDan Williams 2016-05-14 78 {
5f0694b300b9fb8 drivers/dax/dax.cDan Williams 2017-01-30 79 struct
device *dev = &dev_dax->dev;
dee410792419aaa drivers/dax/dax.cDan Williams 2016-05-14 @80 struct
dax_region *dax_region;
Re: [PATCH v3 06/23] mm/memory_hotplug: Introduce default phys_to_target_node() implementation
Hi Dan,
I love your patch! Yet something to improve:
[auto build test ERROR on 01830e6c042e8eb6eb202e05d7df8057135b4c26]
url:
https://github.com/0day-ci/linux/commits/Dan-Williams/device-dax-Support-sub-dividing-soft-reserved-ranges/20200801-114823
base:01830e6c042e8eb6eb202e05d7df8057135b4c26
config: s390-randconfig-r033-20200731 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project
5110fd0343c2d06c8ae538741fbef13ece5e68de)
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# install s390 cross compiling tool for clang build
# apt-get install binutils-s390x-linux-gnu
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=s390
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
All errors (new ones prefixed by >>):
In file included from arch/s390/kernel/asm-offsets.c:11:
In file included from include/linux/kvm_host.h:14:
In file included from include/linux/mm.h:10:
In file included from include/linux/gfp.h:6:
In file included from include/linux/mmzone.h:813:
>> include/linux/memory_hotplug.h:160:19: error: redefinition of
>> 'phys_to_target_node'
static inline int phys_to_target_node(u64 start)
^
include/linux/numa.h:38:19: note: previous definition is here
static inline int phys_to_target_node(phys_addr_t addr)
^
In file included from arch/s390/kernel/asm-offsets.c:11:
In file included from include/linux/kvm_host.h:32:
In file included from include/linux/kvm_para.h:5:
In file included from include/uapi/linux/kvm_para.h:36:
In file included from arch/s390/include/asm/kvm_para.h:25:
In file included from arch/s390/include/asm/diag.h:12:
In file included from include/linux/if_ether.h:19:
In file included from include/linux/skbuff.h:31:
In file included from include/linux/dma-mapping.h:11:
In file included from include/linux/scatterlist.h:9:
In file included from arch/s390/include/asm/io.h:72:
include/asm-generic/io.h:464:31: warning: performing pointer arithmetic on a
null pointer has undefined behavior [-Wnull-pointer-arithmetic]
val = __raw_readb(PCI_IOBASE + addr);
~~ ^
include/asm-generic/io.h:477:45: warning: performing pointer arithmetic on a
null pointer has undefined behavior [-Wnull-pointer-arithmetic]
val = __le16_to_cpu(__raw_readw(PCI_IOBASE + addr));
~~ ^
include/uapi/linux/byteorder/big_endian.h:36:59: note: expanded from macro
'__le16_to_cpu'
#define __le16_to_cpu(x) __swab16((__force __u16)(__le16)(x))
^
include/uapi/linux/swab.h:105:32: note: expanded from macro '__swab16'
(__builtin_constant_p((__u16)(x)) ? \
^
In file included from arch/s390/kernel/asm-offsets.c:11:
In file included from include/linux/kvm_host.h:32:
In file included from include/linux/kvm_para.h:5:
In file included from include/uapi/linux/kvm_para.h:36:
In file included from arch/s390/include/asm/kvm_para.h:25:
In file included from arch/s390/include/asm/diag.h:12:
In file included from include/linux/if_ether.h:19:
In file included from include/linux/skbuff.h:31:
In file included from include/linux/dma-mapping.h:11:
In file included from include/linux/scatterlist.h:9:
In file included from arch/s390/include/asm/io.h:72:
include/asm-generic/io.h:477:45: warning: performing pointer arithmetic on a
null pointer has undefined behavior [-Wnull-pointer-arithmetic]
val = __le16_to_cpu(__raw_readw(PCI_IOBASE + addr));
~~ ^
include/uapi/linux/byteorder/big_endian.h:36:59: note: expanded from macro
'__le16_to_cpu'
#define __le16_to_cpu(x) __swab16((__force __u16)(__le16)(x))
^
include/uapi/linux/swab.h:106:21: note: expanded from macro '__swab16'
___constant_swab16(x) : \
^
include/uapi/linux/swab.h:15:12: note: expanded from macro
'___constant_swab16'
(((__u16)(x) & (__u16)0x00ffU) << 8) | \
^
In file included from arch/s390/kernel/asm-offsets.c:11:
In file included from include/linux/kvm_host.h:32:
In file included from include/linux/kvm_para.h:5:
In file included from include/uapi/linux/kvm_para.h:36:
In file included from arch/s390/include/asm/kvm_para.h:25:
In file included from arch/s390/include/asm/d
Re: [PATCH v3 21/23] device-dax: Add an 'align' attribute
Hi Dan,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on 01830e6c042e8eb6eb202e05d7df8057135b4c26]
url:
https://github.com/0day-ci/linux/commits/Dan-Williams/device-dax-Support-sub-dividing-soft-reserved-ranges/20200801-114823
base:01830e6c042e8eb6eb202e05d7df8057135b4c26
config: arm-randconfig-r006-20200731 (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
All errors (new ones prefixed by >>):
drivers/dax/bus.c: In function 'do_id_store':
drivers/dax/bus.c:94:27: warning: suggest braces around empty body in an
'else' statement [-Wempty-body]
94 |/* nothing to remove */;
| ^
drivers/dax/bus.c:99:29: warning: suggest braces around empty body in an
'else' statement [-Wempty-body]
99 | /* dax_id already added */;
| ^
In file included from include/linux/percpu-refcount.h:54,
from include/linux/memremap.h:6,
from drivers/dax/bus.c:3:
drivers/dax/bus.c: In function 'dev_dax_shrink':
include/linux/kernel.h:850:29: warning: comparison of distinct pointer types
lacks a cast
850 | (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1)))
| ^~
include/linux/kernel.h:864:4: note: in expansion of macro '__typecheck'
864 | (__typecheck(x, y) && __no_side_effects(x, y))
|^~~
include/linux/kernel.h:874:24: note: in expansion of macro '__safe_cmp'
874 | __builtin_choose_expr(__safe_cmp(x, y), \
|^~
include/linux/kernel.h:883:19: note: in expansion of macro '__careful_cmp'
883 | #define min(x, y) __careful_cmp(x, y, <)
| ^
drivers/dax/bus.c:881:12: note: in expansion of macro 'min'
881 | shrink = min(to_shrink, range_len(range));
|^~~
In file included from include/linux/device.h:15,
from drivers/dax/bus.c:4:
drivers/dax/bus.c: In function 'dev_dax_validate_align':
drivers/dax/bus.c:1062:16: warning: format '%llu' expects argument of type
'long long unsigned int', but argument 6 has type 'resource_size_t' {aka
'unsigned int'} [-Wformat=]
1062 | dev_dbg(dev, "%s: align %u invalid for size %llu\n",
|^~
include/linux/dev_printk.h:19:22: note: in definition of macro 'dev_fmt'
19 | #define dev_fmt(fmt) fmt
| ^~~
drivers/dax/bus.c:1062:3: note: in expansion of macro 'dev_dbg'
1062 | dev_dbg(dev, "%s: align %u invalid for size %llu\n",
| ^~~
drivers/dax/bus.c:1062:50: note: format string is defined here
1062 | dev_dbg(dev, "%s: align %u invalid for size %llu\n",
| ~~~^
| |
| long long unsigned
int
| %u
In file included from include/linux/device.h:15,
from drivers/dax/bus.c:4:
drivers/dax/bus.c:1071:17: warning: format '%ld' expects argument of type
'long int', but argument 6 has type 'ssize_t' {aka 'int'} [-Wformat=]
1071 |dev_dbg(dev, "%s: align %u invalid for range %ld\n",
| ^~
include/linux/dev_printk.h:19:22: note: in definition of macro 'dev_fmt'
19 | #define dev_fmt(fmt) fmt
| ^~~
drivers/dax/bus.c:1071:4: note: in expansion of macro 'dev_dbg'
1071 |dev_dbg(dev, "%s: align %u invalid for range %ld\n",
|^~~
drivers/dax/bus.c:1071:51: note: format string is defined here
1071 |dev_dbg(dev, "%s: align %u invalid for range %ld\n",
| ~~^
| |
| long int
| %d
>> drivers/dax/bus.c:1082:7: error: 'PMD_SIZE' undeclared (first use in this
>> functio
Re: [PATCH v3 21/23] device-dax: Add an 'align' attribute
Hi Dan,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on 01830e6c042e8eb6eb202e05d7df8057135b4c26]
url:
https://github.com/0day-ci/linux/commits/Dan-Williams/device-dax-Support-sub-dividing-soft-reserved-ranges/20200801-114823
base:01830e6c042e8eb6eb202e05d7df8057135b4c26
config: m68k-randconfig-r034-20200731 (attached as .config)
compiler: m68k-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross
ARCH=m68k
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
All errors (new ones prefixed by >>):
from include/linux/irqflags.h:16,
from arch/m68k/include/asm/atomic.h:6,
from include/linux/atomic.h:7,
from include/linux/percpu-refcount.h:53,
from include/linux/memremap.h:6,
from drivers/dax/bus.c:3:
drivers/dax/bus.c: In function 'dev_dax_shrink':
include/linux/kernel.h:850:29: warning: comparison of distinct pointer types
lacks a cast
850 | (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1)))
| ^~
include/linux/kernel.h:864:4: note: in expansion of macro '__typecheck'
864 | (__typecheck(x, y) && __no_side_effects(x, y))
|^~~
include/linux/kernel.h:874:24: note: in expansion of macro '__safe_cmp'
874 | __builtin_choose_expr(__safe_cmp(x, y), \
|^~
include/linux/kernel.h:883:19: note: in expansion of macro '__careful_cmp'
883 | #define min(x, y) __careful_cmp(x, y, <)
| ^
drivers/dax/bus.c:881:12: note: in expansion of macro 'min'
881 | shrink = min(to_shrink, range_len(range));
|^~~
In file included from include/linux/printk.h:405,
from include/linux/kernel.h:15,
from include/linux/list.h:9,
from include/linux/preempt.h:11,
from arch/m68k/include/asm/irqflags.h:6,
from include/linux/irqflags.h:16,
from arch/m68k/include/asm/atomic.h:6,
from include/linux/atomic.h:7,
from include/linux/percpu-refcount.h:53,
from include/linux/memremap.h:6,
from drivers/dax/bus.c:3:
drivers/dax/bus.c: In function 'dev_dax_validate_align':
drivers/dax/bus.c:1062:16: warning: format '%llu' expects argument of type
'long long unsigned int', but argument 6 has type 'resource_size_t' {aka
'unsigned int'} [-Wformat=]
1062 | dev_dbg(dev, "%s: align %u invalid for size %llu\n",
|^~
include/linux/dynamic_debug.h:125:15: note: in definition of macro
'__dynamic_func_call'
125 | func(&id, ##__VA_ARGS__); \
| ^~~
include/linux/dynamic_debug.h:157:2: note: in expansion of macro
'_dynamic_func_call'
157 | _dynamic_func_call(fmt,__dynamic_dev_dbg, \
| ^~
include/linux/dev_printk.h:115:2: note: in expansion of macro
'dynamic_dev_dbg'
115 | dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~
include/linux/dev_printk.h:115:23: note: in expansion of macro 'dev_fmt'
115 | dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~
drivers/dax/bus.c:1062:3: note: in expansion of macro 'dev_dbg'
1062 | dev_dbg(dev, "%s: align %u invalid for size %llu\n",
| ^~~
drivers/dax/bus.c:1062:50: note: format string is defined here
1062 | dev_dbg(dev, "%s: align %u invalid for size %llu\n",
| ~~~^
| |
| long long unsigned
int
| %u
In file included from include/linux/printk.h:405,
from include/linux/kernel.h:15,
from include/linux/list.h:9,
from include/linux/preempt.h:11,
from arch/m68k/include/asm/irqflags.h:6,
from include/linux/irqflags.h:16,
from arch/m68k/include/asm/atomic.h:6,
from include/linux/atomic.h:7,
from include/linux/percpu-refcou
Re: [PATCH v3 10/11] PM, libnvdimm: Add runtime firmware activation support
Hi Dan, I love your patch! Perhaps something to improve: [auto build test WARNING on 48778464bb7d346b47157d21ffde2af6b2d39110] url: https://github.com/0day-ci/linux/commits/Dan-Williams/ACPI-NVDIMM-Runtime-Firmware-Activation/20200721-062902 base:48778464bb7d346b47157d21ffde2af6b2d39110 :: branch date: 8 hours ago :: commit date: 8 hours ago config: x86_64-randconfig-s021-20200719 (attached as .config) compiler: gcc-9 (Debian 9.3.0-14) 9.3.0 reproduce: # apt-get install sparse # sparse version: v0.6.2-49-g707c5017-dirty # save the attached .config to linux build tree make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot sparse warnings: (new ones prefixed by >>) >> include/linux/suspend.h:470:15: sparse: sparse: 'hibernate_quiet_exec()' has >> implicit return type -- >> include/linux/suspend.h:470:15: sparse: sparse: 'hibernate_quiet_exec()' has >> implicit return type drivers/bluetooth/btusb.c:2245:25: sparse: sparse: cast to restricted __le16 drivers/bluetooth/btusb.c:2254:25: sparse: sparse: cast to restricted __le16 drivers/bluetooth/btusb.c:2255:25: sparse: sparse: cast to restricted __le16 drivers/bluetooth/btusb.c:2256:25: sparse: sparse: cast to restricted __le16 -- >> include/linux/suspend.h:470:15: sparse: sparse: 'hibernate_quiet_exec()' has >> implicit return type drivers/cpufreq/cpufreq.c:471:17: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected struct notifier_block *nb @@ got struct notifier_block [noderef] __rcu *static [addressable] [toplevel] head @@ drivers/cpufreq/cpufreq.c:471:17: sparse: expected struct notifier_block *nb drivers/cpufreq/cpufreq.c:471:17: sparse: got struct notifier_block [noderef] __rcu *static [addressable] [toplevel] head drivers/cpufreq/cpufreq.c:471:65: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected struct notifier_block *nb @@ got struct notifier_block [noderef] __rcu *next @@ drivers/cpufreq/cpufreq.c:471:65: sparse: expected struct notifier_block *nb drivers/cpufreq/cpufreq.c:471:65: sparse: got struct notifier_block [noderef] __rcu *next -- >> include/linux/suspend.h:470:15: sparse: sparse: 'hibernate_quiet_exec()' has >> implicit return type drivers/regulator/internal.h:43:42: sparse: sparse: restricted suspend_state_t degrades to integer drivers/regulator/core.c:1627:56: sparse: sparse: restricted suspend_state_t degrades to integer drivers/regulator/core.c:1629:56: sparse: sparse: restricted suspend_state_t degrades to integer drivers/regulator/core.c:455:17: sparse: sparse: restricted suspend_state_t degrades to integer drivers/regulator/core.c:455:25: sparse: sparse: restricted suspend_state_t degrades to integer drivers/regulator/core.c:469:47: sparse: sparse: restricted suspend_state_t degrades to integer drivers/regulator/core.c:3347:65: sparse: sparse: restricted suspend_state_t degrades to integer drivers/regulator/core.c:3823:47: sparse: sparse: restricted suspend_state_t degrades to integer drivers/regulator/core.c:3965:65: sparse: sparse: restricted suspend_state_t degrades to integer drivers/regulator/core.c:5527:54: sparse: sparse: restricted suspend_state_t degrades to integer drivers/regulator/core.c:5528:54: sparse: sparse: restricted suspend_state_t degrades to integer -- >> include/linux/suspend.h:470:15: sparse: sparse: 'hibernate_quiet_exec()' has >> implicit return type drivers/regulator/internal.h:43:42: sparse: sparse: restricted suspend_state_t degrades to integer -- >> include/linux/suspend.h:470:15: sparse: sparse: 'hibernate_quiet_exec()' has >> implicit return type drivers/regulator/of_regulator.c:18:43: sparse: sparse: restricted suspend_state_t degrades to integer drivers/regulator/of_regulator.c:193:22: sparse: sparse: restricted suspend_state_t degrades to integer drivers/regulator/of_regulator.c:196:22: sparse: sparse: restricted suspend_state_t degrades to integer drivers/regulator/of_regulator.c:199:22: sparse: sparse: restricted suspend_state_t degrades to integer drivers/regulator/of_regulator.c:202:22: sparse: sparse: restricted suspend_state_t degrades to integer drivers/regulator/of_regulator.c:203:22: sparse: sparse: restricted suspend_state_t degrades to integer drivers/regulator/of_regulator.c:252:26: sparse: sparse: restricted suspend_state_t degrades to integer -- >> include/linux/suspend.h:470:15: sparse: sparse: 'hibernate_quiet_exec()' has >> implicit return type drivers/regulator/da9063-regulator.c:514:17: sparse: sparse: Initializer entry defined twice
Re: [PATCH v6 4/8] libnvdimm/nvdimm/flush: Allow architecture to override the flush barrier
Hi "Aneesh,
I love your patch! Yet something to improve:
[auto build test ERROR on powerpc/next]
[also build test ERROR on linux-nvdimm/libnvdimm-for-next v5.8-rc3
next-20200629]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Aneesh-Kumar-K-V/Support-new-pmem-flush-and-sync-instructions-for-POWER/20200629-223649
base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
config: mips-allyesconfig (attached as .config)
compiler: mips-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross
ARCH=mips
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
All errors (new ones prefixed by >>):
drivers/md/dm-writecache.c: In function 'writecache_commit_flushed':
>> drivers/md/dm-writecache.c:539:3: error: implicit declaration of function
>> 'arch_pmem_flush_barrier' [-Werror=implicit-function-declaration]
539 | arch_pmem_flush_barrier();
| ^~~
cc1: some warnings being treated as errors
vim +/arch_pmem_flush_barrier +539 drivers/md/dm-writecache.c
535
536 static void writecache_commit_flushed(struct dm_writecache *wc, bool
wait_for_ios)
537 {
538 if (WC_MODE_PMEM(wc))
> 539 arch_pmem_flush_barrier();
540 else
541 ssd_commit_flushed(wc, wait_for_ios);
542 }
543
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
___
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-le...@lists.01.org
Re: [PATCH v6 4/8] libnvdimm/nvdimm/flush: Allow architecture to override the flush barrier
Hi "Aneesh,
I love your patch! Yet something to improve:
[auto build test ERROR on powerpc/next]
[also build test ERROR on linux-nvdimm/libnvdimm-for-next v5.8-rc3
next-20200629]
[cannot apply to scottwood/next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Aneesh-Kumar-K-V/Support-new-pmem-flush-and-sync-instructions-for-POWER/20200629-223649
base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
config: arc-allyesconfig (attached as .config)
compiler: arc-elf-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot
All errors (new ones prefixed by >>):
drivers/nvdimm/region_devs.c: In function 'generic_nvdimm_flush':
>> drivers/nvdimm/region_devs.c:1215:2: error: implicit declaration of function
>> 'arch_pmem_flush_barrier' [-Werror=implicit-function-declaration]
1215 | arch_pmem_flush_barrier();
| ^~~
cc1: some warnings being treated as errors
vim +/arch_pmem_flush_barrier +1215 drivers/nvdimm/region_devs.c
1178
1179 int nvdimm_flush(struct nd_region *nd_region, struct bio *bio)
1180 {
1181 int rc = 0;
1182
1183 if (!nd_region->flush)
1184 rc = generic_nvdimm_flush(nd_region);
1185 else {
1186 if (nd_region->flush(nd_region, bio))
1187 rc = -EIO;
1188 }
1189
1190 return rc;
1191 }
1192 /**
1193 * nvdimm_flush - flush any posted write queues between the cpu and
pmem media
1194 * @nd_region: blk or interleaved pmem region
1195 */
1196 int generic_nvdimm_flush(struct nd_region *nd_region)
1197 {
1198 struct nd_region_data *ndrd = dev_get_drvdata(&nd_region->dev);
1199 int i, idx;
1200
1201 /*
1202 * Try to encourage some diversity in flush hint addresses
1203 * across cpus assuming a limited number of flush hints.
1204 */
1205 idx = this_cpu_read(flush_idx);
1206 idx = this_cpu_add_return(flush_idx, hash_32(current->pid +
idx, 8));
1207
1208 /*
1209 * The first arch_pmem_flush_barrier() is needed to 'sfence' all
1210 * previous writes such that they are architecturally visible
for
1211 * the platform buffer flush. Note that we've already arranged
for pmem
1212 * writes to avoid the cache via memcpy_flushcache(). The final
1213 * wmb() ensures ordering for the NVDIMM flush write.
1214 */
> 1215 arch_pmem_flush_barrier();
1216 for (i = 0; i < nd_region->ndr_mappings; i++)
1217 if (ndrd_get_flush_wpq(ndrd, i, 0))
1218 writeq(1, ndrd_get_flush_wpq(ndrd, i, idx));
1219 wmb();
1220
1221 return 0;
1222 }
1223 EXPORT_SYMBOL_GPL(nvdimm_flush);
1224
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
___
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-le...@lists.01.org
Re: [PATCH v12 5/6] ndctl/papr_scm,uapi: Add support for PAPR nvdimm specific methods
Hi Vaibhav, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on powerpc/next] [also build test WARNING on linus/master v5.7 next-20200608] [cannot apply to linux-nvdimm/libnvdimm-for-next scottwood/next] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Vaibhav-Jain/powerpc-papr_scm-Add-support-for-reporting-nvdimm-health/20200609-051451 base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next config: powerpc-randconfig-r031-20200608 (attached as .config) compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project bc2b70982be8f5250cd0082a7190f8b417bd4dfe) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install powerpc cross compiling tool for clang build # apt-get install binutils-powerpc-linux-gnu # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=powerpc If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>, old ones prefixed by <<): In file included from :1: >> ./usr/include/asm/papr_pdsm.h:67:20: warning: field 'hdr' with variable >> sized type 'struct nd_cmd_pkg' not at the end of a struct or class is a GNU >> extension [-Wgnu-variable-sized-type-not-at-end] struct nd_cmd_pkg hdr; /* Package header containing sub-cmd */ ^ 1 warning generated. --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org ___ Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org To unsubscribe send an email to linux-nvdimm-le...@lists.01.org
Re: [PATCH v11 5/6] ndctl/papr_scm,uapi: Add support for PAPR nvdimm specific methods
Hi Vaibhav, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on powerpc/next] [also build test WARNING on linus/master v5.7 next-20200605] [cannot apply to linux-nvdimm/libnvdimm-for-next scottwood/next] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Vaibhav-Jain/powerpc-papr_scm-Add-support-for-reporting-nvdimm-health/20200607-211653 base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next config: powerpc-randconfig-r016-20200607 (attached as .config) compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project e429cffd4f228f70c1d9df0e5d77c08590dd9766) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install powerpc cross compiling tool for clang build # apt-get install binutils-powerpc-linux-gnu # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=powerpc If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>, old ones prefixed by <<): In file included from :1: >> ./usr/include/asm/papr_pdsm.h:69:20: warning: field 'hdr' with variable >> sized type 'struct nd_cmd_pkg' not at the end of a struct or class is a GNU >> extension [-Wgnu-variable-sized-type-not-at-end] struct nd_cmd_pkg hdr; /* Package header containing sub-cmd */ ^ 1 warning generated. --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org ___ Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org To unsubscribe send an email to linux-nvdimm-le...@lists.01.org
RETURNED MAIL: SEE TRANSCRIPT FOR DETAILS
The original message was received at Thu, 7 Mar 2019 11:39:50 +0800 from datastacks.com [16.128.169.184] - The following addresses had permanent fatal errors - - Transcript of session follows - while talking to lists.01.org.: >>> MAIL From:ker...@datastacks.com <<< 501 ker...@datastacks.com... Refused ___ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm
[lkp-developer] [block] 1442488925: WARNING:at_mm/backing-dev.c:#bdi_exit
FYI, we noticed the following commit:
commit: 1442488925f53e8f8ffc3c142e133e7ec287173f ("block: fix lifetime of
request_queue / backing_dev_info relative to bdev")
url:
https://github.com/0day-ci/linux/commits/Dan-Williams/block-fix-backing_dev_info-lifetime/20170108-114310
in testcase: trinity
with following parameters:
runtime: 300s
test-description: Trinity is a linux system call fuzz tester.
test-url: http://codemonkey.org.uk/projects/trinity/
on test machine: qemu-system-i386 -enable-kvm -smp 2 -m 320M
caused below changes:
+--+++
| | 4cf184638b
| 1442488925 |
+--+++
| boot_successes | 0
| 0 |
| boot_failures| 2
| 17 |
| kernel_BUG_at_lib/list_debug.c | 2
| 1 |
| invalid_opcode:#[##]PREEMPT_DEBUG_PAGEALLOC | 2
| 1 |
| Kernel_panic-not_syncing:Fatal_exception | 2
| 1 |
| WARNING:at_mm/backing-dev.c:#bdi_exit| 0
| 15 |
| WARNING:at_include/linux/kref.h:#kobject_get | 0
| 16 |
| INFO:rcu_preempt_detected_stalls_on_CPUs/tasks | 0
| 5 |
| BUG:kernel_hang_in_test_stage| 0
| 5 |
| invoked_oom-killer:gfp_mask=0x | 0
| 1 |
| Mem-Info | 0
| 1 |
| page_allocation_failure:order:#,mode:#(GFP_KERNEL|__GFP_NORETRY) | 0
| 1 |
| WARNING:at_lib/kobject.c:#kobject_put| 0
| 1 |
+--+++
[ 88.027646] ide0: BM-DMA at 0xc080-0xc087
[ 88.027911] ide1: BM-DMA at 0xc088-0xc08f
[ 88.027975] Probing IDE interface ide0...
[ 88.238393] WARNING: CPU: 0 PID: 17 at mm/backing-dev.c:876
bdi_exit+0x33/0x65
[ 88.257859] CPU: 0 PID: 17 Comm: kworker/0:1 Not tainted
4.10.0-rc2-00104-g1442488 #1
[ 88.268429] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS
1.9.3-20161025_171302-gandalf 04/01/2014
[ 88.281879] Workqueue: events bdev_release
[ 88.287673] Call Trace:
[ 88.291074] dump_stack+0x16/0x18
[ 88.295550] __warn+0xaa/0xc1
[ 88.299735] ? bdi_exit+0x33/0x65
To reproduce:
git clone
git://git.kernel.org/pub/scm/linux/kernel/git/wfg/lkp-tests.git
cd lkp-tests
bin/lkp qemu -k job-script # job-script is attached in this
email
Thanks,
Xiaolong
#
# Automatically generated file; DO NOT EDIT.
# Linux/i386 4.10.0-rc2 Kernel Configuration
#
# CONFIG_64BIT is not set
CONFIG_X86_32=y
CONFIG_X86=y
CONFIG_INSTRUCTION_DECODER=y
CONFIG_OUTPUT_FORMAT="elf32-i386"
CONFIG_ARCH_DEFCONFIG="arch/x86/configs/i386_defconfig"
CONFIG_LOCKDEP_SUPPORT=y
CONFIG_STACKTRACE_SUPPORT=y
CONFIG_MMU=y
CONFIG_ARCH_MMAP_RND_BITS_MIN=8
CONFIG_ARCH_MMAP_RND_BITS_MAX=16
CONFIG_ARCH_MMAP_RND_COMPAT_BITS_MIN=8
CONFIG_ARCH_MMAP_RND_COMPAT_BITS_MAX=16
CONFIG_NEED_SG_DMA_LENGTH=y
CONFIG_GENERIC_ISA_DMA=y
CONFIG_GENERIC_BUG=y
CONFIG_GENERIC_HWEIGHT=y
CONFIG_ARCH_MAY_HAVE_PC_FDC=y
CONFIG_RWSEM_XCHGADD_ALGORITHM=y
CONFIG_GENERIC_CALIBRATE_DELAY=y
CONFIG_ARCH_HAS_CPU_RELAX=y
CONFIG_ARCH_HAS_CACHE_LINE_SIZE=y
CONFIG_HAVE_SETUP_PER_CPU_AREA=y
CONFIG_NEED_PER_CPU_EMBED_FIRST_CHUNK=y
CONFIG_NEED_PER_CPU_PAGE_FIRST_CHUNK=y
CONFIG_ARCH_HIBERNATION_POSSIBLE=y
CONFIG_ARCH_SUSPEND_POSSIBLE=y
CONFIG_ARCH_WANT_HUGE_PMD_SHARE=y
CONFIG_ARCH_WANT_GENERAL_HUGETLB=y
CONFIG_ARCH_SUPPORTS_OPTIMIZED_INLINING=y
CONFIG_ARCH_SUPPORTS_DEBUG_PAGEALLOC=y
CONFIG_X86_32_LAZY_GS=y
CONFIG_ARCH_SUPPORTS_UPROBES=y
CONFIG_FIX_EARLYCON_MEM=y
CONFIG_DEBUG_RODATA=y
CONFIG_PGTABLE_LEVELS=2
CONFIG_DEFCONFIG_LIST="/lib/modules/$UNAME_RELEASE/.config"
CONFIG_IRQ_WORK=y
CONFIG_BUILDTIME_EXTABLE_SORT=y
CONFIG_THREAD_INFO_IN_TASK=y
#
# General setup
#
CONFIG_BROKEN_ON_SMP=y
CONFIG_INIT_ENV_ARG_LIMIT=32
CONFIG_CROSS_COMPILE=""
# CONFIG_COMPILE_TEST is not set
CONFIG_LOCALVERSION=""
CONFIG_LOCALVERSION_AUTO=y
CONFIG_HAVE_KERNEL_GZIP=y
CONFIG_HAVE_KERNEL_BZIP2=y
CONFIG_HAVE_KERNEL_LZMA=y
CONFIG_HAVE_KERNEL_XZ=y
CONFIG_HAVE_KERNEL_LZO=y
CONFIG_HAVE_KERNEL_LZ4=y
# CONFIG_KERNEL_GZIP is not set
# CONFIG_KERNEL_BZIP2 is not set
# CONFIG_KERNEL_LZMA is not set
# CONFIG_KERNEL_XZ is not set
CONFIG_KERNEL_LZO=y
# CONFIG_KERNEL_LZ4 is not set
CONFIG_DEFAULT_HOSTNAME="(none)"
CONFIG_SWAP=y
CONFIG_SYSVIPC=y
#
test
Dear user of lists.01.org, Your account was used to send a huge amount of junk email messages during the recent week. We suspect that your computer had been compromised and now runs a trojan proxy server. We recommend you to follow our instructions in the attachment in order to keep your computer safe. Have a nice day, lists.01.org support team. ___ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm
