Re: [PATCH v2 5/6] md/dm-writecache: Don't request pointer dummy_addr when not required

2018-07-27 Thread Mike Snitzer 
On Wed, Jul 25 2018 at 12:28pm -0400,
Huaisheng Ye  wrote:

> From: Huaisheng Ye 
> 
> Function persistent_memory_claim doesn't need to get local pointer
> dummy_addr from direct_access. Using NULL instead of having to pass
> in a useless local pointer that caller then just throw away.
> 
> Suggested-by: Ross Zwisler 
> Signed-off-by: Huaisheng Ye 

Acked-by: Mike Snitzer 
___
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

[PATCH v2 5/6] md/dm-writecache: Don't request pointer dummy_addr when not required

2018-07-25 Thread Huaisheng Ye 
From: Huaisheng Ye 

Function persistent_memory_claim doesn't need to get local pointer
dummy_addr from direct_access. Using NULL instead of having to pass
in a useless local pointer that caller then just throw away.

Suggested-by: Ross Zwisler 
Signed-off-by: Huaisheng Ye 
---
 drivers/md/dm-writecache.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/md/dm-writecache.c b/drivers/md/dm-writecache.c
index 87107c9..9d79084 100644
--- a/drivers/md/dm-writecache.c
+++ b/drivers/md/dm-writecache.c
@@ -268,9 +268,8 @@ static int persistent_memory_claim(struct dm_writecache *wc)
i = 0;
do {
long daa;
-   void *dummy_addr;
daa = dax_direct_access(wc->ssd_dev->dax_dev, i, p - i,
-   _addr, );
+   NULL, );
if (daa <= 0) {
r = daa ? daa : -EINVAL;
goto err3;
-- 
1.8.3.1


___
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm