Re: [PATCH v6 03/15] block, dax: remove dead code in blkdev_writepages()

2018-03-16 Thread Christoph Hellwig
Looks good,

Reviewed-by: Christoph Hellwig 
___
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm


[PATCH v6 03/15] block, dax: remove dead code in blkdev_writepages()

2018-03-15 Thread Dan Williams
Block device inodes never have S_DAX set, so kill the check for DAX and
diversion to dax_writeback_mapping_range().

Cc: Jeff Moyer 
Cc: Ross Zwisler 
Cc: Matthew Wilcox 
Cc: Jan Kara 
Cc: Christoph Hellwig 
Cc: Dave Chinner 
Signed-off-by: Dan Williams 
---
 fs/block_dev.c |5 -
 1 file changed, 5 deletions(-)

diff --git a/fs/block_dev.c b/fs/block_dev.c
index fe09ef9c21f3..846ee2d31781 100644
--- a/fs/block_dev.c
+++ b/fs/block_dev.c
@@ -1946,11 +1946,6 @@ static int blkdev_releasepage(struct page *page, gfp_t 
wait)
 static int blkdev_writepages(struct address_space *mapping,
 struct writeback_control *wbc)
 {
-   if (dax_mapping(mapping)) {
-   struct block_device *bdev = I_BDEV(mapping->host);
-
-   return dax_writeback_mapping_range(mapping, bdev, wbc);
-   }
return generic_writepages(mapping, wbc);
 }
 

___
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm