Re: [ndctl PATCH 2/2] ndctl: Add 'list' verbose documentation

2018-06-26 Thread Dan Williams 
On Tue, Jun 26, 2018 at 3:59 PM, Verma, Vishal L
 wrote:
> On Tue, 2018-06-26 at 14:46 -0600, Keith Busch wrote:
>> Signed-off-by: Keith Busch 
>> ---
>>  Documentation/ndctl/ndctl-list.txt | 12 
>>  1 file changed, 12 insertions(+)
>>
>
> I think this can all just go in the first patch?
>
>> diff --git a/Documentation/ndctl/ndctl-list.txt
>> b/Documentation/ndctl/ndctl-list.txt
>> index 13ebdcd..791638c 100644
>> --- a/Documentation/ndctl/ndctl-list.txt
>> +++ b/Documentation/ndctl/ndctl-list.txt
>> @@ -200,6 +200,18 @@ include::xable-region-options.txt[]
>>]
>>  }
>>
>> +-v::
>> +--verbose::
>> + Increase verbosity of the output. This can be specified
>> + multiple times to be even more verbose on the informational and
>> + miscellaneous output, and can be used to override the flags for
>> + showing specific information.
>
> Should we detail here what verbosity level enables which flags? Or is that
> too much upkeep in case things change..

Hopefully does not change too much. We've had some contention about
which fields are available in the listing, so it would be nice to give
a heads up when people say "hey! where did my numa node and
sector_size fields go?".
___
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

Re: [ndctl PATCH 2/2] ndctl: Add 'list' verbose documentation

2018-06-26 Thread Verma, Vishal L 
On Tue, 2018-06-26 at 14:46 -0600, Keith Busch wrote:
> Signed-off-by: Keith Busch 
> ---
>  Documentation/ndctl/ndctl-list.txt | 12 
>  1 file changed, 12 insertions(+)
> 

I think this can all just go in the first patch?

> diff --git a/Documentation/ndctl/ndctl-list.txt
> b/Documentation/ndctl/ndctl-list.txt
> index 13ebdcd..791638c 100644
> --- a/Documentation/ndctl/ndctl-list.txt
> +++ b/Documentation/ndctl/ndctl-list.txt
> @@ -200,6 +200,18 @@ include::xable-region-options.txt[]
>]
>  }
>  
> +-v::
> +--verbose::
> + Increase verbosity of the output. This can be specified
> + multiple times to be even more verbose on the informational and
> + miscellaneous output, and can be used to override the flags for
> + showing specific information.

Should we detail here what verbosity level enables which flags? Or is that
too much upkeep in case things change..

> +
> +[verse]
> +ndctl list -v
> +ndctl list -vv
> +ndctl list -vvv
> +
>  include::human-option.txt[]
>  
>  
___
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm