Re: [PATCH] PRCM: Combine 34xx l3_icks and l4_icks
ext Felipe Balbi [EMAIL PROTECTED] writes:
On Mon, 28 Apr 2008 11:29:53 +0300, [EMAIL PROTECTED] (Högander
Jouni) wrote:
E.g dss_l3_ick and dss_l4_ick have same gating control. Having own
clock for both of them causes race condition between enable / disable.
This patch combines this kind of clocks and names new clock as
module_ick.
Signed-off-by: Jouni Hogander [EMAIL PROTECTED]
Good, the following patch fixes ehci-omap.c after clock name change
:-)
Sorry, I should have used grep here. I did it now. There are no
other references to changed clock names than this you pointed out. I
checked caḿ_l3_ick, cam_l4_ick, usbhost_l3_ick, usbhost_l4_ick.
Yes, your patch needs to be applied if [PATCH] PRCM: Combine 34xx
l3_icks and l4_icks is applied.
Could you check, please:
From 4102f3ad5db10e662633c0f9ddee6aca43fec8e6 Mon Sep 17 00:00:00 2001
From: Felipe Balbi [EMAIL PROTECTED]
Date: Mon, 28 Apr 2008 13:45:49 +0300
Subject: [PATCH] USB: EHCI: Fix clock name for ehci-omap.c
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Patch from Jouni Högander changed usbhost_l4_ick to
usbhost_ick, fixing in ehci-omap.c
Signed-off-by: Felipe Balbi [EMAIL PROTECTED]
Cc: Jouni Högander [EMAIL PROTECTED]
---
drivers/usb/host/ehci-omap.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/usb/host/ehci-omap.c b/drivers/usb/host/ehci-omap.c
index 495c979..be93c69 100644
--- a/drivers/usb/host/ehci-omap.c
+++ b/drivers/usb/host/ehci-omap.c
@@ -73,7 +73,7 @@ struct ehci_omap_clock_defs {
};
/* Clock names as per clock framework: May change so keep as #defs */
-#define USBHOST_ICKL usbhost_l4_ick
+#define USBHOST_ICKL usbhost_ick
#define USBHOST_120M_FCLKusbhost_120m_fck
#define USBHOST_48M_FCLK usbhost_48m_fck
#define USBHOST_TLL_ICKL usbtll_ick
--
1.5.5.1.57.g5909c
--
Best Regards,
Felipe Balbi
http://felipebalbi.com
[EMAIL PROTECTED]
--
Jouni Högander
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] PRCM: Combine 34xx l3_icks and l4_icks
On Mon, 28 Apr 2008, Högander Jouni wrote: E.g dss_l3_ick and dss_l4_ick have same gating control. Having own clock for both of them causes race condition between enable / disable. This patch combines this kind of clocks and names new clock as module_ick. Signed-off-by: Jouni Hogander [EMAIL PROTECTED] Acked-by: Paul Walmsley [EMAIL PROTECTED] although it's less of a race issue, than it is a convenience issue for OMAP2/3 device driver folks... - Paul
RE: [RFC/PATCH] BQ27000/BQ27200 battery monitoring driver for OMAP34xx
-Original Message- From: Felipe Balbi [mailto:[EMAIL PROTECTED] Sent: Monday, April 28, 2008 5:17 PM To: Madhusudhan Chikkature Rajashekar Cc: Tony Lindgren; linux-omap@vger.kernel.org Subject: RE: [RFC/PATCH] BQ27000/BQ27200 battery monitoring driver for OMAP34xx On Mon, 28 Apr 2008 17:11:51 +0530, Madhusudhan Chikkature Rajashekar [EMAIL PROTECTED] wrote: Hi Felipe, Thanks for the comments. I will fix them and resend the patch. Please note my view on the below point. -pdev = platform_device_alloc(omap-bq2700-battery, id); +pdev = platform_device_alloc(bq27000-bat, id); do you really need to change the name here? It seems that this change doesn't belong to this patch. I will make this as a separate patch.As BQ27000 chip is not omap specific, I guess the above name is not correct. Hence I intend to make that change. Ok, works for me :-) I guess bq2700-battery is ok, just remove omap- from the previous name?? Yes. I will correct the name and resend the patch. I will send this one as a separate patch and followed by it will be the battery driver patch. -- Best Regards, Felipe Balbi http://felipebalbi.com [EMAIL PROTECTED] -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Resending: [PATCH] BQ27000/BQ27200 battery monitoring driver for OMAP34xx
Hi,
I am resending the patch after fixing the comments provided by Felipe.
Regards,
Madhu
This patch provides the battery driver to support BQ27000 and BQ27200 chips.
Signed-off-by: Madhusudhan Chikkature[EMAIL PROTECTED]
---
drivers/power/Kconfig | 21 +
drivers/power/Makefile |1
drivers/power/bq27x00_battery.c | 564
3 files changed, 586 insertions(+)
Index: linux-omap-2.6/drivers/power/bq27x00_battery.c
===
--- /dev/null 1970-01-01 00:00:00.0 +
+++ linux-omap-2.6/drivers/power/bq27x00_battery.c 2008-04-29
11:27:42.962321458 +0530
@@ -0,0 +1,564 @@
+/*
+ * linux/drivers/power/bq27x00_battery.c
+ *
+ * BQ27000/BQ27200 battery driver
+ *
+ * Copyright (C) 2008 Texas Instruments, Inc.
+ *
+ * Author: Texas Instruments
+ *
+ * This package is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ *
+ * THIS PACKAGE IS PROVIDED ``AS IS'' AND WITHOUT ANY EXPRESS OR
+ * IMPLIED WARRANTIES, INCLUDING, WITHOUT LIMITATION, THE IMPLIED
+ * WARRANTIES OF MERCHANTIBILITY AND FITNESS FOR A PARTICULAR PURPOSE.
+ *
+ */
+#include linux/module.h
+#include linux/param.h
+#include linux/jiffies.h
+#include linux/workqueue.h
+#include linux/delay.h
+#include linux/platform_device.h
+#include linux/power_supply.h
+
+#ifdef CONFIG_BATTERY_BQ27000
+#include ../w1/w1.h
+#endif
+#ifdef CONFIG_BATTERY_BQ27200
+#include linux/i2c.h
+#endif
+
+#define BQ27x00_REG_TEMP 0x06
+#define BQ27x00_REG_VOLT 0x08
+#define BQ27x00_REG_RSOC 0x0B /* Relative State-of-Charge */
+#define BQ27x00_REG_AI 0x14
+#define BQ27x00_REG_FLAGS 0x0A
+#define HIGH_BYTE(A) ((A) 8)
+
+#ifdef CONFIG_BATTERY_BQ27000
+extern int w1_bq27000_read(struct device *dev, u8 reg);
+#endif
+
+struct bq27x00_device_info;
+struct bq27x00_access_methods {
+ int (*read)(u8 reg, int *rt_value, int b_single,
+ struct bq27x00_device_info *di);
+};
+
+struct bq27x00_device_info {
+ struct device *dev;
+#ifdef CONFIG_BATTERY_BQ27000
+ struct device *w1_dev;
+#endif
+#ifdef CONFIG_BATTERY_BQ27200
+ struct i2c_client *client;
+#endif
+ unsigned long update_time;
+ int voltage_uV;
+ int current_uA;
+ int temp_C;
+ int charge_rsoc;
+ struct bq27x00_access_methods *bus;
+ struct power_supply bat;
+ struct delayed_work monitor_work;
+};
+
+static unsigned int cache_time = 6;
+module_param(cache_time, uint, 0644);
+MODULE_PARM_DESC(cache_time, cache time in milliseconds);
+
+static enum power_supply_property bq27x00_battery_props[] = {
+ POWER_SUPPLY_PROP_PRESENT,
+ POWER_SUPPLY_PROP_VOLTAGE_NOW,
+ POWER_SUPPLY_PROP_CURRENT_NOW,
+ POWER_SUPPLY_PROP_CHARGE_NOW,
+ POWER_SUPPLY_PROP_CAPACITY,
+ POWER_SUPPLY_PROP_TEMP,
+};
+
+static int bq27x00_read(u8 reg, int *rt_value, int b_single,
+ struct bq27x00_device_info *di);
+
+#ifdef CONFIG_BATTERY_BQ27000
+static int bq27000_battery_probe(struct platform_device *dev);
+static int bq27000_battery_remove(struct platform_device *dev);
+#ifdef CONFIG_PM
+static int bq27000_battery_suspend(struct platform_device *dev,
+ pm_message_t state);
+static int bq27000_battery_resume(struct platform_device *dev);
+#endif /* CONFIG_PM */
+
+static struct platform_driver bq27000_battery_driver = {
+ .probe = bq27000_battery_probe,
+ .remove = bq27000_battery_remove,
+#ifdef CONFIG_PM
+ .suspend = bq27000_battery_suspend,
+ .resume = bq27000_battery_resume,
+#endif /* CONFIG_PM */
+ .driver = {
+ .name = bq27000-battery,
+ },
+};
+#endif /* CONFIG_BATTERY_BQ27000 */
+
+#ifdef CONFIG_BATTERY_BQ27200
+static int bq27200_battery_probe(struct i2c_client *client);
+static int bq27200_battery_remove(struct i2c_client *client);
+#ifdef CONFIG_PM
+static int bq27200_battery_suspend(struct i2c_client *client,
+ pm_message_t mesg);
+static int bq27200_battery_resume(struct i2c_client *client);
+#endif /* CONFIG_PM */
+static struct i2c_driver bq27200_battery_driver = {
+ .driver = {
+ .name = bq27200-bat,
+ },
+ .probe = bq27200_battery_probe,
+ .remove = bq27200_battery_remove,
+#ifdef CONFIG_PM
+ .suspend = bq27200_battery_suspend,
+ .resume = bq27200_battery_resume,
+#endif /* CONFIG_PM */
+};
+#endif /* CONFIG_BATTERY_BQ27200 */
+
+/*
+ * Return the battery temperature in Celcius degrees
+ * Or 0 if something fails.
+ */
+static int bq27x00_battery_temperature(struct
Re: Android on N810 File System Problem
[Tony Lindgren [EMAIL PROTECTED]] I've merged Jarkko's asoc patch to linux-omap for testing. Have not gotten any sound out of it on my n810 though.. Maybe some alsamixer settings issue? Kalle, do you have any tips on getting WLAN to work on n8x0? This was the show-stopper for me. When I last got things hobbling along on n8x0, the binary-only wlan module was incompatible with newer kernels than 2.6.21 (changes in some network data structures). The newer android builds expect 2.6.24 or more recent. I'm hoping that Nokia will release a newer build of the wlan module for 2.6.24 at some point. That'd be a big motivator for me to spend time hacking on the platform again. The other thing I'd like to sort out is how to interact with the battery charging and status without needing proprietary userspace code. Probably a lot easier to reverse engineer than the wlan driver at least. Brian -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
[RFC PATCH 1/1] OMAP: V4L: Update videobuf-dma-sg usage on omap camera drivers
Update videobuf-dma-sg usage on omap camera drivers Signed-off-by: Francisco Alecrim [EMAIL PROTECTED] --- drivers/media/video/omap/camera_core.c |2 +- drivers/media/video/omap24xxcam.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/video/omap/camera_core.c b/drivers/media/video/omap/camera_core.c index dce47fc..eeedb36 100644 --- a/drivers/media/video/omap/camera_core.c +++ b/drivers/media/video/omap/camera_core.c @@ -916,7 +916,7 @@ static int camera_core_open(struct inode *inode, struct file *file) vidioc_int_g_fmt_cap(cam-sdev, format); spin_unlock(cam-img_lock); - videobuf_queue_pci_init(fh-vbq, cam-vbq_ops, NULL, cam-vbq_lock, + videobuf_queue_sg_init(fh-vbq, cam-vbq_ops, NULL, cam-vbq_lock, fh-type, V4L2_FIELD_NONE, sizeof(struct videobuf_buffer), fh); diff --git a/drivers/media/video/omap24xxcam.c b/drivers/media/video/omap24xxcam.c index 4308fec..dfd3479 100644 --- a/drivers/media/video/omap24xxcam.c +++ b/drivers/media/video/omap24xxcam.c @@ -1493,7 +1493,7 @@ static int omap24xxcam_open(struct inode *inode, struct file *file) spin_lock_init(fh-vbq_lock); - videobuf_queue_pci_init(fh-vbq, omap24xxcam_vbq_ops, NULL, + videobuf_queue_sg_init(fh-vbq, omap24xxcam_vbq_ops, NULL, fh-vbq_lock, V4L2_BUF_TYPE_VIDEO_CAPTURE, V4L2_FIELD_NONE, sizeof(struct videobuf_buffer), fh); -- 1.5.4.4 -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
[RFC PATCH 0/1] V4L changes
Based on commit 0705135e59f8503e4dade4b3580fed77b1743b7c. -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Android on N810 File System Problem
[Jonathan Herriott [EMAIL PROTECTED]]
I had it confirmed in another thread that the issue is that the local
filesystem for the N810 is jffs, which is unsupported and I need to
install it on an mini SD card with ext2/ext3 on it.
I think what you're seeing here is the property service in init
failing to create and mmap it's arena, which it tries to do in /,
which in our world is initramfs. The android init/boot model is a
little different in that we don't pivot over to a root filesystem,
we mount the system, data, etc partitions under the ramfs on /
You might be able to hack around this by editing the string
/system_properties to /tmp/em_properties or something like
that, assuming you have tmpfs mounted on /tmp.
Brian
On 4/26/08, Dirk Behme [EMAIL PROTECTED] wrote:
Jonathan Herriott wrote:
I'm using vanilla Kernel 2.6.21.0 with the patch from
http://android-on-n8xx.googlecode.com/files/linux-2.6.21_rx-34_android-m5-rc14.bz2.
I was told in another thread that I need to use the m3 userspace
files, but when trying to use those, I have the same issue.
I'm assuming you want the strace when running init:
\h:\w\$ strace -f -ff -tt -s 200 /init
04:02:38.896362 execve(/init, [/init], [/* 59 vars */]) = 0
04:02:38.909790 gettid()= 1464
04:02:38.912689 syscall_983045(0xbea0d614, 0, 0x20, 0, 0xbe9ee000,
0xbea0d6d0, 0xbea0d720, 0xf0005, 0xbea0d720, 0, 0x80b8, 0x80b4, 0,
0xbea0d608, 0x17c77, 0x17f2c, 0x6010, 0xbea0d614, 0, 0, 0xc764, 0,
0, 0, 0, 0, 0, 0, 0, 0, 0, 0) = 0
04:02:38.916168 socket(PF_FILE, SOCK_STREAM, 0) = 3
04:02:38.919250 connect(3, {sa_family=AF_FILE,
[EMAIL PROTECTED], 19) = -1 ECONNREFUSED (Connection refused)
04:02:38.923248 close(3)= 0
04:02:38.926208 sigaction(SIGCHLD, {0x8211, [], SA_NOCLDSTOP}, NULL,
0xc0fb8) = 0
04:02:38.929718 umask(0)= 022
04:02:38.932373 ioctl(1, SNDCTL_TMR_TIMEBASE or TCGETS, {B38400 opost
isig icanon echo ...}) = 0
04:02:38.936523 dup(1) = 3
04:02:38.939422 write(3, init: HOW ARE YOU GENTLEMEN\n, 28init: HOW
ARE YOU GENTLEMEN
) = 28
04:02:38.943328 close(0)= 0
04:02:38.945983 close(1)= 0
04:02:38.948577 close(2)= 0
04:02:38.951202 open(/dev/null, O_RDWR|O_LARGEFILE) = 0
04:02:38.954345 dup2(0, 1) = 1
04:02:38.956939 dup2(0, 2) = 2
04:02:38.959625 write(3, init: reading config file\n, 26init:
reading config file
) = 26
04:02:38.963592 brk(0) = 0x2
04:02:38.966217 brk(0x2)= 0x2
04:02:38.968994 brk(0x21000)= 0x21000
04:02:38.971832 open(/etc/init.rc, O_RDONLY|O_LARGEFILE) = 4
04:02:38.975006 lseek(4, 0, SEEK_END) = 5746
04:02:38.991088 lseek(4, 0, SEEK_SET) = 0
04:02:38.993286 brk(0x22000)= 0x22000
04:02:38.998413 read(4, ## Global environment setup\n##\nenv {\n
PATH /sbin:/system/sbin:/system/bin\nLD_LIBRARY_PATH
/system/lib
\nANDROID_BOOTLOGO 1\nANDROID_ROOT /system\n
ANDROID_ASSETS /system/app\n ANDROID_..., 5746) = 5746
04:02:39.002288 close(4)= 0
04:02:39.003845 brk(0x23000)= 0x23000
04:02:39.005310 mkdir(/proc, 0755)= -1 EEXIST (File exists)
04:02:39.006622 mkdir(/dev, 0755) = -1 EEXIST (File exists)
04:02:39.007843 mkdir(/dev/pts, 0755) = -1 EEXIST (File exists)
04:02:39.009368 mkdir(/sys, 0755) = -1 EEXIST (File exists)
04:02:39.011230 mkdir(/d, 0755) = -1 EEXIST (File exists)
04:02:39.012451 mount(/dev/pts, /dev/pts, devpts, 0, NULL) = -1
EBUSY (Device or resource busy)
04:02:39.017883 mount(/proc, /proc, proc, 0, NULL) = -1 EBUSY
(Device or resource busy)
04:02:39.026428 mount(/sys, /sys, sysfs, 0, NULL) = -1 EBUSY
(Device or resource busy)
04:02:39.033416 mount(/d, /d, debugfs, 0, NULL) = -1 EBUSY
(Device or resource busy)
04:02:39.038238 mount(/tmp, /tmp, tmpfs, 0, NULL) = 0
04:02:39.043457 open(/proc/cmdline, O_RDONLY|O_LARGEFILE) = 4
04:02:39.046417 read(4, root=1f03 rootfstype=jffs2 ro\n, 1023) = 30
04:02:39.048187 close(4)= 0
04:02:39.049346 chmod(/proc/cmdline, 0400) = 0
04:02:39.050689 open(/system_properties, O_RDWR|O_CREAT|O_EXCL|
O_LARGEFILE, 0600) = 4
04:02:39.052368 ftruncate(4, 32768) = 0
04:02:39.053588 open(/system_properties, O_RDONLY|O_LARGEFILE) = 5
04:02:39.056884 unlink(/system_properties) = 0
04:02:39.058624 mmap2(NULL, 32768, PROT_READ|PROT_WRITE, MAP_SHARED,
4, 0) = -1 EINVAL (Invalid argument)
04:02:39.059997 close(5)= 0
04:02:39.061096 close(4)= 0
04:02:39.063110 open(/etc/default.prop, O_RDONLY|O_LARGEFILE) = 4
04:02:39.064422 lseek(4, 0, SEEK_END) = 130
04:02:39.065521 lseek(4, 0, SEEK_SET) = 0
04:02:39.066619 read(4, # default system properties\n# these may be
Re: Android on N810 File System Problem
On Mon, 28 Apr 2008 16:38:28 -0700 ext Tony Lindgren [EMAIL PROTECTED] wrote: I've merged Jarkko's asoc patch to linux-omap for testing. Have not gotten any sound out of it on my n810 though.. Maybe some alsamixer settings issue? Have you set CONFIG_OMAP_MUX? Otherwise McBSP2 pins are muxed for EAC block by the bootloader. Jarkko -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Questions on Android
[Anil S [EMAIL PROTECTED]] Hello Brian, It would be really great if you could share thoughts on the questions given here on Android: I was able to add support for the keypad, touch and network in Android, however the interfaces like GPS, Accelerometer, vibrator, hardware 3D acceleration, battery etc. are not integrated with Android right now. I would appreciate if you could throw some light on these open issues. How exactly can these interfaces be integrated with Android? We're trying to use the standard kernel/driver interfaces when possible, but for things that may have a good deal of variation in implementation, we're looking to provide a very thin hardware interface library layer to adapt between the bottom of the userspace stack and the drivers or whatnot for specific hardware platforms. We'll continue to adopt standardized kernel solutions as they become available -- We're now using the power supply framework in 2.6.24 for monitoring battery/charge state (post M5 SDK -- it'll be in the next release), for example. Brian -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFC PATCH 1/1] OMAP: V4L: Update videobuf-dma-sg usage on omap camera drivers
Hi folks, We found a similar patch sent by Tony on thread Re: linux-omap vs N810 a few hours ago. Sorry, Alecrim. Francisco Alecrim wrote: Update videobuf-dma-sg usage on omap camera drivers Signed-off-by: Francisco Alecrim [EMAIL PROTECTED] --- drivers/media/video/omap/camera_core.c |2 +- drivers/media/video/omap24xxcam.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/video/omap/camera_core.c b/drivers/media/video/omap/camera_core.c index dce47fc..eeedb36 100644 --- a/drivers/media/video/omap/camera_core.c +++ b/drivers/media/video/omap/camera_core.c @@ -916,7 +916,7 @@ static int camera_core_open(struct inode *inode, struct file *file) vidioc_int_g_fmt_cap(cam-sdev, format); spin_unlock(cam-img_lock); - videobuf_queue_pci_init(fh-vbq, cam-vbq_ops, NULL, cam-vbq_lock, + videobuf_queue_sg_init(fh-vbq, cam-vbq_ops, NULL, cam-vbq_lock, fh-type, V4L2_FIELD_NONE, sizeof(struct videobuf_buffer), fh); diff --git a/drivers/media/video/omap24xxcam.c b/drivers/media/video/omap24xxcam.c index 4308fec..dfd3479 100644 --- a/drivers/media/video/omap24xxcam.c +++ b/drivers/media/video/omap24xxcam.c @@ -1493,7 +1493,7 @@ static int omap24xxcam_open(struct inode *inode, struct file *file) spin_lock_init(fh-vbq_lock); - videobuf_queue_pci_init(fh-vbq, omap24xxcam_vbq_ops, NULL, + videobuf_queue_sg_init(fh-vbq, omap24xxcam_vbq_ops, NULL, fh-vbq_lock, V4L2_BUF_TYPE_VIDEO_CAPTURE, V4L2_FIELD_NONE, sizeof(struct videobuf_buffer), fh); -- Francisco Keppler Silva Alecrim - INdT Phone: +55 92 2126-1017 -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] USB: MUSB: Better sysconf reg settings on PM point of view
The following patch is needed because usb is preventing core powerdomain to enter sleep state. Thanks to Jouni Högander for pointing this Signed-off-by: Felipe Balbi [EMAIL PROTECTED] Signed-off-by: Jouni Högander [EMAIL PROTECTED] --- drivers/usb/musb/omap2430.c | 23 --- 1 files changed, 12 insertions(+), 11 deletions(-) diff --git a/drivers/usb/musb/omap2430.c b/drivers/usb/musb/omap2430.c index e092393..36f1739 100644 --- a/drivers/usb/musb/omap2430.c +++ b/drivers/usb/musb/omap2430.c @@ -224,6 +224,14 @@ int __init musb_platform_init(struct musb *musb) musb-xceiv = *xceiv; musb_platform_resume(musb); + OTG_SYSCONFIG_REG = ~ENABLEWAKEUP; /* disable wakeup */ + OTG_SYSCONFIG_REG = ~NOSTDBY; /* remove possible nostdby */ + OTG_SYSCONFIG_REG |= SMARTSTDBY;/* enable smart standby */ + OTG_SYSCONFIG_REG = ~AUTOIDLE; /* disable auto idle */ + OTG_SYSCONFIG_REG = ~NOIDLE; /* remove possible noidle */ + OTG_SYSCONFIG_REG |= SMARTIDLE; /* enable smart idle */ + OTG_SYSCONFIG_REG |= AUTOIDLE; /* enable auto idle */ + OTG_INTERFSEL_REG |= ULPI_12PIN; pr_debug(HS USB OTG: revision 0x%x, sysconfig 0x%02x, @@ -250,12 +258,8 @@ int musb_platform_suspend(struct musb *musb) return 0; /* in any role */ - OTG_FORCESTDBY_REG = ~ENABLEFORCE; /* disable MSTANDBY */ - OTG_SYSCONFIG_REG = FORCESTDBY;/* enable force standby */ - OTG_SYSCONFIG_REG = ~AUTOIDLE; /* disable auto idle */ - OTG_SYSCONFIG_REG |= SMARTIDLE; /* enable smart idle */ - OTG_FORCESTDBY_REG |= ENABLEFORCE; /* enable MSTANDBY */ - OTG_SYSCONFIG_REG |= AUTOIDLE; /* enable auto idle */ + OTG_FORCESTDBY_REG |= ENABLEFORCE; /* enable MSTANDBY */ + OTG_SYSCONFIG_REG |= ENABLEWAKEUP; /* enable wakeup */ if (musb-xceiv.set_suspend) musb-xceiv.set_suspend(musb-xceiv, 1); @@ -281,11 +285,8 @@ int musb_platform_resume(struct musb *musb) else clk_enable(musb-clock); - OTG_FORCESTDBY_REG = ~ENABLEFORCE; /* disable MSTANDBY */ - OTG_SYSCONFIG_REG |= SMARTSTDBY;/* enable smart standby */ - OTG_SYSCONFIG_REG = ~AUTOIDLE; /* disable auto idle */ - OTG_SYSCONFIG_REG |= SMARTIDLE; /* enable smart idle */ - OTG_SYSCONFIG_REG |= AUTOIDLE; /* enable auto idle */ + OTG_SYSCONFIG_REG = ~ENABLEWAKEUP; /* disable wakeup */ + OTG_FORCESTDBY_REG = ~ENABLEFORCE; /* disable MSTANDBY */ return 0; } -- 1.5.5.1.99.gf0ec4 -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH]Correction to BQ27000 battery device name
On Tue, 29 Apr 2008 14:26:58 +0530, Madhusudhan Chikkature Rajashekar
[EMAIL PROTECTED] wrote:
This patch changes the device name as the bq27000 chip is not omap
specific.
Sure this is not omap-specific. A more generic name is better ;-)
Signed-off-by: Madhusudhan Chikkature[EMAIL PROTECTED]
Acked-by: Felipe Balbi [EMAIL PROTECTED]
---
drivers/w1/slaves/w1_bq27000.c |2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
Index: linux-omap-2.6/drivers/w1/slaves/w1_bq27000.c
===
--- linux-omap-2.6.orig/drivers/w1/slaves/w1_bq27000.c2008-04-29
11:22:42.0 +0530
+++ linux-omap-2.6/drivers/w1/slaves/w1_bq27000.c 2008-04-29
11:25:17.963079042 +0530
@@ -59,7 +59,7 @@
int id = 1;
struct platform_device *pdev;
- pdev = platform_device_alloc(omap-bq2700-battery, id);
+ pdev = platform_device_alloc(bq27000-battery, id);
if (!pdev) {
ret = -ENOMEM;
return ret;
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Best Regards,
Felipe Balbi
http://felipebalbi.com
[EMAIL PROTECTED]
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH 0/7] OMAP3 EVM: series of patches to add additional hw support
Thanks Steve! -Original Message- From: [EMAIL PROTECTED] [mailto:linux-omap- [EMAIL PROTECTED] On Behalf Of Steve Sakoman Sent: Monday, April 28, 2008 6:27 PM To: linux-omap@vger.kernel.org Subject: [PATCH 0/7] OMAP3 EVM: series of patches to add additional hw support This series of patches adds support for mmc, usb, onenand, lcd, and rtc on the OMAP3 EVM. The first patch (mmc) was submitted individually a couple of days ago -- I'm resubmitting it as part of this group since the usb, onenand, lcd, and rtc patches assume that the mmc patch has been applied first. I have tested the resulting kernel on my OMAP 35XX EVM. Steve -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFC/PATCH] OMAP PM interface
Paul Walmsley [EMAIL PROTECTED] writes: Linux PM QOS parameters: As of February, the mainline Linux kernel contains code that is somewhat similar to the SRF: the Linux PM QOS parameters code, located in kernel/pm_qos_params.c. (This code replaced the latency management code that was present in earlier kernels.) Ideally, OMAP drivers would be able to use this Linux PM QOS code directly, but the current PM QOS code has some drawbacks: - It combines some power management parameters that should be kept separate for maximum power savings on OMAP3. For example, in the PM QOS code, CPU and DMA wakeup latency are combined into one parameter; but on OMAP3, these are distinct parameters. The Linux PM QOS code also combines all network power management knobs into two non-device-specific parameters. OMAP2/3 systems can have different network devices with different power management requirements - for example, a wired Ethernet interface may have different latency and throughput constraints than a wireless Ethernet interface. - It does not yet cover all of the power management capabilities of the OMAP3 architecture. It does not express latency constraints on a per-device or per-powerdomain basis; it only covers cpu_dma_latency and network throughput and latency, which would not cover most of the OMAP3 devices. The result is that drivers using the current Linux PM QOS layer directly are unlikely to reach the same level of power efficiency as driver code using the Shared Resource Framework. Paul, First, thanks for working on this. This is a huge step in the right direction in my opinon. Thanks! I've only given a quick glance so far at the actual patch, but my first comments are regarding the dismissal of the PM QoS framework. I totally agree that the QoS framework in its current form has several drawbacks and limitations. However, instead of re-designing something new, I think maybe we should first try to extend the QoS framework. I've had a few conversations with the Intel folks who worked on PM QoS and got it into mainline, especially Mark Gross. He is quite aware that it is only the very beginnings of a framework. He is also very interested in potential users and their concerns about limitations of the framework. Since it came out of Intel, PM QoS definitely has a PC/UMPC focus, but this is a perfect opportunity to help extend the framework to be useful in embedded systems. I'm sure the Intel guys will be happy to hear about potential users and use cases for the framework and why it should be extended/updated to work well in embedded. For starters, we could just use the existing PM QoS framework as it is and just add a new set of parameters. Then begin dissucions with the PM QoS folks as to how they could be generalized and unified with the existing ones. Thoughts? Kevin -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/1] MMC: OMAP: Remove unnecessary extern sdp_mmc_init
* Francisco Alecrim [EMAIL PROTECTED] [080425 12:27]: From: Francisco Alecrim [EMAIL PROTECTED] Remove unnecessary extern sdp_mmc_init() at board header. New extern hsmmc_init() defined include/asm-arm/arch-omap/hsmmc.h. Pushing today. Tony Signed-off-by: Francisco Alecrim [EMAIL PROTECTED] Acked-by: Carlos Eduardo Aguiar [EMAIL PROTECTED] --- include/asm-arm/arch-omap/board-2430sdp.h |1 - include/asm-arm/arch-omap/board-3430sdp.h |1 - include/asm-arm/arch-omap/board-omap3beagle.h |2 -- 3 files changed, 0 insertions(+), 4 deletions(-) diff --git a/include/asm-arm/arch-omap/board-2430sdp.h b/include/asm-arm/arch-omap/board-2430sdp.h index ad682c5..b308e88 100644 --- a/include/asm-arm/arch-omap/board-2430sdp.h +++ b/include/asm-arm/arch-omap/board-2430sdp.h @@ -39,6 +39,5 @@ /* Function prototypes */ extern void sdp2430_flash_init(void); extern void sdp2430_usb_init(void); -extern void sdp_mmc_init(void); #endif /* __ASM_ARCH_OMAP_2430SDP_H */ diff --git a/include/asm-arm/arch-omap/board-3430sdp.h b/include/asm-arm/arch-omap/board-3430sdp.h index 34e878a..77f8647 100644 --- a/include/asm-arm/arch-omap/board-3430sdp.h +++ b/include/asm-arm/arch-omap/board-3430sdp.h @@ -30,7 +30,6 @@ #define __ASM_ARCH_OMAP_3430SDP_H extern void sdp3430_usb_init(void); -extern void sdp_mmc_init(void); #define DEBUG_BASE 0x0800 /* debug board */ diff --git a/include/asm-arm/arch-omap/board-omap3beagle.h b/include/asm-arm/arch-omap/board-omap3beagle.h index 782e2e5..14db589 100644 --- a/include/asm-arm/arch-omap/board-omap3beagle.h +++ b/include/asm-arm/arch-omap/board-omap3beagle.h @@ -29,8 +29,6 @@ #ifndef __ASM_ARCH_OMAP3_BEAGLE_H #define __ASM_ARCH_OMAP3_BEAGLE_H -extern void sdp_mmc_init(void); - #define TWL4030_IRQNUM INT_34XX_SYS_NIRQ #endif /* __ASM_ARCH_OMAP3_BEAGLE_H */ -- 1.5.4.4 -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] OMAP: EHCI: Wrong ehci init for 2430
* Felipe Balbi [EMAIL PROTECTED] [080428 03:37]: On Mon, Apr 28, 2008 at 03:51:11PM +0530, ext Pandita, Vikram wrote: OMAP2430 does not have USB EHCI controller. EHCI core was introduced with OMAP3430 ES2.0 onwards. The ehci_init() call has been wrongly introduced for OMAP2430, so removing it. Good, I was unsure about it and that's why I asked people to give the original patch a good review. Seems that this one came too late. Anyway, good that you saw it :-) Pushing today. Tony Signed-off-by: Vikram Pandita [EMAIL PROTECTED] --- arch/arm/mach-omap2/board-2430sdp.c |2 -- 1 file changed, 2 deletions(-) Index: linux-omap-2.6/arch/arm/mach-omap2/board-2430sdp.c === --- linux-omap-2.6.orig/arch/arm/mach-omap2/board-2430sdp.c 2008-04-28 14:27:26.0 +0530 +++ linux-omap-2.6/arch/arm/mach-omap2/board-2430sdp.c 2008-04-28 15:05:34.0 +0530 @@ -36,7 +36,6 @@ #include asm/arch/mux.h #include asm/arch/board.h #include asm/arch/usb-musb.h -#include asm/arch/usb-ehci.h #include asm/arch/hsmmc.h #include asm/arch/common.h #include asm/arch/keypad.h @@ -394,7 +393,6 @@ static void __init omap_2430sdp_init(voi sdp2430_flash_init(); usb_musb_init(); - usb_ehci_init(); spi_register_board_info(sdp2430_spi_board_info, ARRAY_SIZE(sdp2430_spi_board_info)); -- - Balbi -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] PRCM: Combine 34xx l3_icks and l4_icks
* Paul Walmsley [EMAIL PROTECTED] [080428 23:58]: On Mon, 28 Apr 2008, Högander Jouni wrote: E.g dss_l3_ick and dss_l4_ick have same gating control. Having own clock for both of them causes race condition between enable / disable. This patch combines this kind of clocks and names new clock as module_ick. Signed-off-by: Jouni Hogander [EMAIL PROTECTED] Acked-by: Paul Walmsley [EMAIL PROTECTED] although it's less of a race issue, than it is a convenience issue for OMAP2/3 device driver folks... Pushing today, with Felipe's fix merged into this. Tony -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] OMAP: EHCI: Adding back Copyright
* Pandita, Vikram [EMAIL PROTECTED] [080428 04:53]: Adding back Copyright notice that was not carried forward by a patch from Felipe. Copyrights should be retained without fail. Pushing today. Tony Signed-off-by: Vikram Pandita [EMAIL PROTECTED] --- arch/arm/mach-omap2/usb-ehci.c |7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) Index: linux-omap-2.6/arch/arm/mach-omap2/usb-ehci.c === --- linux-omap-2.6.orig/arch/arm/mach-omap2/usb-ehci.c 2008-04-28 16:39:18.0 +0530 +++ linux-omap-2.6/arch/arm/mach-omap2/usb-ehci.c 2008-04-28 16:44:48.0 +0530 @@ -4,8 +4,11 @@ * This file will contain the board specific details for the * Synopsys EHCI host controller on OMAP3430 * - * Copyright (C) 2008 Nokia Corporation - * Author: Felipe Balbi [EMAIL PROTECTED] + * Copyright (C) 2007 Texas Instruments + * Author: Vikram Pandita [EMAIL PROTECTED] + * + * Generalization by: + * Felipe Balbi [EMAIL PROTECTED] * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License version 2 as -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: linux-omap vs N810
* Tony Lindgren [EMAIL PROTECTED] [080428 16:30]:
Hi,
* Jarkko Nikula [EMAIL PROTECTED] [080427 23:26]:
On Mon, 28 Apr 2008 00:01:09 +0200 (CEST)
ext [EMAIL PROTECTED] [EMAIL PROTECTED] wrote:
Hello,
I'm having a major problem running linux-omap kernel on Nokia N810.
After correct build and flashing (tested by the use of self-built
patched Nokia kernel) the device seems to hang before framebuffer
initialization, then is rebooted by the watchdog. Manual FB update is
disabled, I've checked the configuration in many possible ways.
I'd like to hear about possible causes of that.
Most probably reason is development time machine id passed by the
bootloader where linux-omap is using official id of 1548. This will be
corrected in our future SW releases.
Try to hack change N810 machine id in arch/arm/tools/mach-types from
1548 to .
Attached are some patches to boot N810 with current linux-omap kernel and
mount root on the internal MMC. I'm currently booting to Debian sid
created with debootstrap, but this should work for any distro.
I also put up a page for it with more notes:
http://www.muru.com/linux/n8x0/
Only the first few patches are ready for merging, hopefully we can get
all the attached hacks worked away soon..
Tony
I've pushed the camera fix, bluetooth and mmc patches below I've
updated the remaining hacks on my website.
Tony
From 19e546ef60e84692e8c357e092a03365993e1552 Mon Sep 17 00:00:00 2001
From: Tony Lindgren [EMAIL PROTECTED]
Date: Mon, 28 Apr 2008 14:55:27 -0700
Subject: [PATCH] V4L: Fix compile for 24xx camera
Fix compile for 24xx camera
Signed-off-by: Tony Lindgren [EMAIL PROTECTED]
---
drivers/media/video/omap/camera_core.c |2 +-
drivers/media/video/omap24xxcam.c |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/video/omap/camera_core.c
b/drivers/media/video/omap/camera_core.c
index dce47fc..eeedb36 100644
--- a/drivers/media/video/omap/camera_core.c
+++ b/drivers/media/video/omap/camera_core.c
@@ -916,7 +916,7 @@ static int camera_core_open(struct inode *inode, struct
file *file)
vidioc_int_g_fmt_cap(cam-sdev, format);
spin_unlock(cam-img_lock);
- videobuf_queue_pci_init(fh-vbq, cam-vbq_ops, NULL, cam-vbq_lock,
+ videobuf_queue_sg_init(fh-vbq, cam-vbq_ops, NULL, cam-vbq_lock,
fh-type, V4L2_FIELD_NONE,
sizeof(struct videobuf_buffer), fh);
diff --git a/drivers/media/video/omap24xxcam.c
b/drivers/media/video/omap24xxcam.c
index 4308fec..dfd3479 100644
--- a/drivers/media/video/omap24xxcam.c
+++ b/drivers/media/video/omap24xxcam.c
@@ -1493,7 +1493,7 @@ static int omap24xxcam_open(struct inode *inode, struct
file *file)
spin_lock_init(fh-vbq_lock);
- videobuf_queue_pci_init(fh-vbq, omap24xxcam_vbq_ops, NULL,
+ videobuf_queue_sg_init(fh-vbq, omap24xxcam_vbq_ops, NULL,
fh-vbq_lock, V4L2_BUF_TYPE_VIDEO_CAPTURE,
V4L2_FIELD_NONE,
sizeof(struct videobuf_buffer), fh);
--
1.5.3.6
From 74c922e92ccaf702baf04eb72c93c25c4f4fea09 Mon Sep 17 00:00:00 2001
From: Tony Lindgren [EMAIL PROTECTED]
Date: Wed, 23 Apr 2008 16:39:36 -0700
Subject: [PATCH] BT: Sync hcih4p with Nokia N810 driver and fix compile
Sync hcih4p with kernel-source-rx-34-2.6.21.0 and fix compile.
Signed-off-by: Tony Lindgren [EMAIL PROTECTED]
---
drivers/bluetooth/hci_h4p/core.c| 19 ---
drivers/bluetooth/hci_h4p/hci_h4p.h |1 +
drivers/bluetooth/hci_h4p/uart.c| 11 ++-
3 files changed, 19 insertions(+), 12 deletions(-)
diff --git a/drivers/bluetooth/hci_h4p/core.c
b/drivers/bluetooth/hci_h4p/core.c
index 09c1f93..7fb5d12 100644
--- a/drivers/bluetooth/hci_h4p/core.c
+++ b/drivers/bluetooth/hci_h4p/core.c
@@ -144,7 +144,7 @@ static void hci_h4p_enable_rx(struct hci_h4p_info *info)
if (info-rx_pm_enabled) {
hci_h4p_set_clk(info, info-rx_clocks_en, 1);
hci_h4p_outb(info, UART_IER, hci_h4p_inb(info, UART_IER) |
UART_IER_RDI);
- hci_h4p_set_auto_ctsrts(info, 1, UART_EFR_RTS);
+ __hci_h4p_set_auto_ctsrts(info, 1, UART_EFR_RTS);
info-rx_pm_enabled = 0;
}
spin_unlock_irqrestore(info-lock, flags);
@@ -157,7 +157,7 @@ static void hci_h4p_rx_pm_timer(unsigned long data)
spin_lock_irqsave(info-lock, flags);
if (!(hci_h4p_inb(info, UART_LSR) UART_LSR_DR)) {
- hci_h4p_set_auto_ctsrts(info, 0, UART_EFR_RTS);
+ __hci_h4p_set_auto_ctsrts(info, 0, UART_EFR_RTS);
hci_h4p_set_rts(info, 0);
hci_h4p_outb(info, UART_IER, hci_h4p_inb(info, UART_IER)
~UART_IER_RDI);
hci_h4p_set_clk(info, info-rx_clocks_en, 0);
@@ -231,7 +231,6 @@ static void
Re: PM Issues after Android bootup on 2430
On 4/29/08, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote: omapfb omapfb: irq error status 00e2 omapfb omapfb: irq error status 0040 omapfb omapfb: irq error status 0040 omapfb omapfb: irq error status 0040 omapfb omapfb: irq error status 0040 omapfb omapfb: irq error status 0040 omapfb omapfb: irq error status 0040 omapfb omapfb: irq error status 0040 omapfb omapfb: irq error status 0040 omapfb omapfb: irq error status 0040 This does look suspiciously like the thread http://linux.omap.com/pipermail/linux-omap-open-source/2007-July/010566.html Interesting... ;)... I never got the chance to debug this issue.. Kevin, Khasim, did u guys get a chance to look at this later?? I dont recollect hearing any one saying the same for 3430 though.. Regards, Nishanth Menon -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH 0/7] OMAP3 EVM: series of patches to add additional hw support
-Original Message- From: [EMAIL PROTECTED] [mailto:linux-omap- [EMAIL PROTECTED] On Behalf Of Steve Sakoman Sent: Tuesday, April 29, 2008 4:57 AM To: linux-omap@vger.kernel.org Subject: [PATCH 0/7] OMAP3 EVM: series of patches to add additional hw support This series of patches adds support for mmc, usb, onenand, lcd, and rtc on the OMAP3 EVM. The first patch (mmc) was submitted individually a couple of days ago -- I'm resubmitting it as part of this group since the usb, onenand, lcd, and rtc patches assume that the mmc patch has been applied first. I have tested the resulting kernel on my OMAP 35XX EVM. I have reviewed all these patches, didn't find any issues as such. Acked-by: Syed Mohammed Khasim [EMAIL PROTECTED] Regards, Khasim -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 6/7] OMAP3 EVM: add lcd support
On Tue, Apr 29, 2008 at 5:00 AM, Steve Sakoman [EMAIL PROTECTED] wrote: From: Steve Sakoman [EMAIL PROTECTED] Add LCD support for OMAP3 EVM Signed-off-by: Steve Sakoman [EMAIL PROTECTED] --- @@ -0,0 +1,168 @@ +/* + * LCD panel support for the TI OMAP3 EVM board + * + * Author: Steve Sakoman [EMAIL PROTECTED] + * + * Derived from drivers/video/omap/lcd-apollon.c + * + * This program is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License as published by the + * Free Software Foundation; either version 2 of the License, or (at your + * option) any later version. + * + * This program is distributed in the hope that it will be useful, but + * WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * General Public License for more details. + * + * You should have received a copy of the GNU General Public License along + * with this program; if not, write to the Free Software Foundation, Inc., + * 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. + */ + +#include linux/module.h +#include linux/platform_device.h +#include linux/i2c/twl4030.h + +#include asm/arch/gpio.h +#include asm/arch/mux.h +#include asm/arch/omapfb.h +#include asm/mach-types.h + +#define LCD_PANEL_ENABLE_GPIO 153 +#define LCD_PANEL_LR2 +#define LCD_PANEL_UD3 +#define LCD_PANEL_INI 152 +#define LCD_PANEL_QVGA 154 +#define LCD_PANEL_RESB 155 + +#define LCD_XRES 480 +#define LCD_YRES 640 +#define LCD_PIXCLOCK_MAX 41700 /* in pico seconds */ +#define LCD_PIXCLOCK_MIN 38000 /* in pico seconds */ + +#define ENABLE_VDAC_DEDICATED 0x03 +#define ENABLE_VDAC_DEV_GRP0x20 +#define ENABLE_VPLL2_DEDICATED 0x05 +#define ENABLE_VPLL2_DEV_GRP 0xE0 + I did not see you calling the below function any ware in this file, does this definition really required? +extern void omap2_disp_replication_enable (void); Regards, Arun C -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
