RE: [PATCH] OMAP2/3/4: DSS2: Enable Display SubSystem as modules
Hi, Valkeinen, Tomi wrote: > Hi, > > On Wed, 2011-02-23 at 06:22 -0600, Nilofer, Samreen wrote: >> Enabling Display options to be built as modules Also, the generic dpi, >> sharp & nec panels are also enabled as modules. > > I've just posted a patch which fixes the problem with the > regulators in DSS. With that patch we can safely enable all DSS interfaces > (and thus panels) and the resulting binary will work on all boards. > > So can you make one more version which enables all the > interfaces and panels as modules, based on > git://gitorious.org/linux-omap-dss2/linux.git master > [samreen] Sure. Will post out the next version soon. > Tomi-- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH v4] OMAP3: DSS: Kconfig changes to enable display options on OMAP3
Hi, Any more comments on this patch? Warm Regards, Samreen Nilofer, Samreen wrote: > The defconfig options for display are taken in the respective > Kconfig to enable display by default on OMAP3 platforms > > Signed-off-by: Samreen > --- > Version4: >Remove the enabling of the display panels by default. > > Version3: >Eliminate the separate default number of FBs for > different architecture. Keeping default FBs as 3 as before. > > Version2: > Enables by default NEC panel used in zoom2/3/3630sdp, > instead of Sharp LQ043T1DG01 panel enabled in previous > version of this patch. > > drivers/video/omap2/dss/Kconfig|6 -- > drivers/video/omap2/omapfb/Kconfig |1 + > 2 files changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/video/omap2/dss/Kconfig > b/drivers/video/omap2/dss/Kconfig index 43b6440..f3244a2 100644 > --- a/drivers/video/omap2/dss/Kconfig > +++ b/drivers/video/omap2/dss/Kconfig > @@ -1,6 +1,7 @@ > menuconfig OMAP2_DSS > tristate "OMAP2/3 Display Subsystem support (EXPERIMENTAL)" > depends on ARCH_OMAP2 || ARCH_OMAP3 > + default y > help >OMAP2/3 Display Subsystem support. > > @@ -9,7 +10,7 @@ if OMAP2_DSS > config OMAP2_VRAM_SIZE > int "VRAM size (MB)" > range 0 32 > - default 0 > + default 4 > help > The amount of SDRAM to reserve at boot time for video RAM use. > This VRAM will be used by omapfb and other drivers > that need @@ -102,7 +103,8 @@ config OMAP2_DSS_FAKE_VSYNC > config OMAP2_DSS_MIN_FCK_PER_PCK > int "Minimum FCK/PCK ratio (for scaling)" > range 0 32 > - default 0 > + default 4 if ARCH_OMAP2 || ARCH_OMAP3 > + default 0 if ARCH_OMAP4 > help > This can be used to adjust the minimum FCK/PCK ratio. > > diff --git a/drivers/video/omap2/omapfb/Kconfig > b/drivers/video/omap2/omapfb/Kconfig > index 65149b2..923bf48 100644 > --- a/drivers/video/omap2/omapfb/Kconfig > +++ b/drivers/video/omap2/omapfb/Kconfig > @@ -1,6 +1,7 @@ > menuconfig FB_OMAP2 > tristate "OMAP2/3 frame buffer support (EXPERIMENTAL)" > depends on FB && OMAP2_DSS > + default y > > select OMAP2_VRAM > select OMAP2_VRFB if ARCH_OMAP2 || ARCH_OMAP3-- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH v3 0/2] OMAP3: Display Support
Tony Lindgren wrote: > * Tomi Valkeinen [101115 06:32]: >> On Mon, 2010-11-15 at 07:09 +0100, ext Samreen wrote: >>> This patch series adds the Display Support for OMAP3 platforms and >>> the corresponding changes in the board files. >>> >>> Version3: >>>- Rebase to the latest LO >>> Version2: >>>- Optimised to configure INTBR from gpio to PWM1 mode setting and >>>enabling of the PWM1 mode only when its not in PWM1 mode. >>> >>> Kishore Y (2): >>> OMAP3: ZOOM2/3/3630SDP: Add display board file for OMAP3 >>> OMAP3: Enable display on ZOOM2/3/3630SDP >>> >>> arch/arm/mach-omap2/Makefile |3 + >>> arch/arm/mach-omap2/board-3630sdp.c |1 + >>> arch/arm/mach-omap2/board-zoom-display.c | 168 >>> + arch/arm/mach-omap2/board-zoom-peripherals.c | >>> 49 +++- arch/arm/mach-omap2/board-zoom2.c |1 + >>> arch/arm/mach-omap2/board-zoom3.c |1 + >>> arch/arm/mach-omap2/include/mach/board-zoom.h |3 + >>> 7 files changed, 224 insertions(+), 2 deletions(-) create mode >>> 100644 arch/arm/mach-omap2/board-zoom-display.c >> >> Thanks, applied. > > This series needs to be posted to linux-arm-kernel list also > for review. Samreen, can you please repost? > > Tony [Samreen] Sure Tony, Will post it right away. Warm Regards, Samreen-- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH] OMAP: DSS2: OMAPFB: Fix null pointer check
Ville Syrjälä wrote: > On Fri, Nov 12, 2010 at 12:47:15PM +0100, ext Samreen wrote: >> A null pointer check added. >> >> Signed-off-by: Samreen >> --- >> drivers/video/omap2/omapfb/omapfb-main.c |2 ++ >> 1 files changed, 2 insertions(+), 0 deletions(-) >> >> diff --git a/drivers/video/omap2/omapfb/omapfb-main.c >> b/drivers/video/omap2/omapfb/omapfb-main.c >> index 6a704f1..55bed89 100644 >> --- a/drivers/video/omap2/omapfb/omapfb-main.c >> +++ b/drivers/video/omap2/omapfb/omapfb-main.c >> @@ -2133,6 +2133,8 @@ static int > omapfb_parse_def_modes(struct omapfb2_device *fbdev) >> int r = 0; >> >> str = kmalloc(strlen(def_mode) + 1, GFP_KERNEL); >> +if (str == NULL) >> +return -EINVAL; >> strcpy(str, def_mode); > > While you're at it you could change the code to use kstrdup(). [Samreen] Will use kstrdup() and post the patch soon. Warm Regards, Samreen-- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH] OMAP: DSS2: OMAPFB: Fix null pointer check
Belisko Marek wrote: > On Fri, Nov 12, 2010 at 12:47 PM, Samreen wrote: >> A null pointer check added. >> >> Signed-off-by: Samreen >> --- >> drivers/video/omap2/omapfb/omapfb-main.c | 2 ++ >> 1 files changed, 2 insertions(+), 0 deletions(-) >> >> diff --git a/drivers/video/omap2/omapfb/omapfb-main.c >> b/drivers/video/omap2/omapfb/omapfb-main.c >> index 6a704f1..55bed89 100644 >> --- a/drivers/video/omap2/omapfb/omapfb-main.c >> +++ b/drivers/video/omap2/omapfb/omapfb-main.c >> @@ -2133,6 +2133,8 @@ static int omapfb_parse_def_modes(struct >> omapfb2_device *fbdev) int r = 0; >> >> str = kmalloc(strlen(def_mode) + 1, GFP_KERNEL); + if (str == >> NULL) + return -EINVAL; > Shouldn't be rerutn _ENNOMEM; instead to get correct error code? [Samreen] Will fix this. >> strcpy(str, def_mode); >> options = str; >> >> -- >> 1.5.6.3 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-omap" >> in the body of a message to majord...@vger.kernel.org More majordomo >> info at http://vger.kernel.org/majordomo-info.html >> > thank, > > marek-- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH v2 0/2] OMAP3: Display Support
Tomi Valkeinen wrote: > Hi, > > On Tue, 2010-10-26 at 06:28 +0200, ext Samreen wrote: >> This patch series adds the Display Support for OMAP3 platforms and the >> corresponding changes in the board files. >> >> Version2: >>- Optimised to configure INTBR from gpio to PWM1 mode setting and >>enabling of the PWM1 mode only when its not in PWM1 mode. > > This patch set doesn't seem to apply to the latest kernel, > conflicts in arch/arm/mach-omap2/board-zoom-peripherals.c and > arch/arm/mach-omap2/include/mach/board-zoom.h. Can you rebase and resend? > > Tomi Sure, Will rebase and post it out soon. Warm Regards, Samreen-- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH] OMAP3630: DSS2: Enable Pre-Multiplied Alpha Support
Hi,
Taneja, Archit wrote:
> Hi,
>
> Tomi Valkeinen wrote:
>> On Wed, 2010-11-03 at 08:57 +0100, ext Taneja, Archit wrote:
>>> Hi,
>>>
>>> linux-omap-ow...@vger.kernel.org wrote:
Alpha Support
>>>
>>> [snip]
>>>
>
> +static void _dispc_set_pre_mult_alpha(enum omap_plane plane, bool
> +enable) { + if (!dss_has_feature(FEAT_PREMUL_ALPHA)) +
> return;
> +
> + BUG_ON(!dss_has_feature(FEAT_GLOBAL_ALPHA_VID1) &&
> + plane == OMAP_DSS_VIDEO1);
What is the rationale for having the function return, if
FEAT_PREMUL_ALPHA is not supported, but BUG if plane is video1 and
GLOBAL_ALPHA_VID1 is not supported?
>>>
>>> Premultiplied alpha is available on omap36xx and above, but on 36xx
>>> since global alpha itself isn't supported for video1 then writing to
>>> the pre multiplied alpha bit is incorrect.
>>>
>>> It could have been possible to make a new feature like
>>> FEAT_PRE_MULT_VID1 but I think its redundant as
>>> FEAT_GLOBAL_ALPHA_VID1 is enough to determine if we should set the
>>> pre multiplied
>> alpha bit for video1 plane or not.
>>
>> I was referring to the first check using return, and the second using
>> BUG(). If nobody is supposed to call that function when
>>
>> !dss_has_feature(FEAT_GLOBAL_ALPHA_VID1) && plane == OMAP_DSS_VIDEO1)
>>
>> then why is it ok to call that function when
>>
>> !dss_has_feature(FEAT_PREMUL_ALPHA)
>>
>> Shouldn't they both be either returns or BUGs?
>>
>
> If you see the current code, _dispc_setup_global_alpha() does
> the same thing, and in the call to it in _dispc_setup_plane() is:
>
> ...
> ...
> if (plane != OMAP_DSS_VIDEO1)
> _dispc_setup_global_alpha(plane, global_alpha); ... ...
>
> So, I guess this BUG_ON is probably not required for both
> setup_global_alpha and setup_pre_multiplied_alpha if you take
> care while calling these functions from _dispc_setup_plane().
>
> But this is the same with _dispc_set_scaling(),
> _dispc_set_vid_size() etc where we have a BUG_ON(plane ==
> OMAP_DSS_GFX) even when we take care of not calling it for
> the GFX pipe.
>
> Archit
[Samreen]
If this clarification is aligned, should I go ahead and post the patch
with the remaining review comments
Regards,
Samreen--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH 1/2] OMAP3: ZOOM2/3/3630SDP: Add display board file for OMAP3
Hiremath, Vaibhav wrote:
>> -Original Message-
>> From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap-
>> ow...@vger.kernel.org] On Behalf Of Nilofer, Samreen
>> Sent: Thursday, October 14, 2010 4:57 PM
>> To: linux-omap@vger.kernel.org
>> Cc: Kishore Y; Mittal, Mukund; Rajkumar N; Nilofer, Samreen
>> Subject: [PATCH 1/2] OMAP3: ZOOM2/3/3630SDP: Add display board file for
>> OMAP3
>>
>> From: Kishore Y
>>
>> Board-zoom-display.c added as a common file for display functionality
>> on boards zoom2, zoom3 and 3630sdp
>>
>> Signed-off-by: Mukund Mittal
>> Signed-off-by: Kishore Y
>> Signed-off-by: Rajkumar N
>> Signed-off-by: Samreen
>> ---
>> arch/arm/mach-omap2/Makefile |3 +
>> arch/arm/mach-omap2/board-zoom-display.c | 165
>> + arch/arm/mach-omap2/board-zoom-peripherals.c |
>> 49 +++- arch/arm/mach-omap2/include/mach/board-zoom.h |2 +
>> 4 files changed, 217 insertions(+), 2 deletions(-) create mode
>> 100644 arch/arm/mach-omap2/board-zoom-display.c
>>
>> diff --git a/arch/arm/mach-omap2/Makefile
>> b/arch/arm/mach-omap2/Makefile index 88d3a1e..95e0ecf 100644
>> --- a/arch/arm/mach-omap2/Makefile
>> +++ b/arch/arm/mach-omap2/Makefile
>> @@ -132,16 +132,19 @@ obj-$(CONFIG_MACH_NOKIA_RX51) += board- rx51.o \
>> hsmmc.o
>> obj-$(CONFIG_MACH_OMAP_ZOOM2) += board-zoom2.o \
>> board-zoom-peripherals.o \
>> + board-zoom-display.o \
>> board-flash.o \
>> hsmmc.o \
>> board-zoom-debugboard.o
>> obj-$(CONFIG_MACH_OMAP_ZOOM3) += board-zoom3.o \
>> board-zoom-peripherals.o \
>> + board-zoom-display.o \
>> board-flash.o \
>> hsmmc.o \
>> board-zoom-debugboard.o
>> obj-$(CONFIG_MACH_OMAP_3630SDP) += board-3630sdp.o \
>> board-zoom-peripherals.o \
>> + board-zoom-display.o \
>> board-flash.o \
>> hsmmc.o
>> obj-$(CONFIG_MACH_CM_T35) += board-cm-t35.o \
>> diff --git a/arch/arm/mach-omap2/board-zoom-display.c b/arch/arm/mach-
>> omap2/board-zoom-display.c new file mode 100644 index 000..1e0b3da ---
>> /dev/null +++ b/arch/arm/mach-omap2/board-zoom-display.c
>> @@ -0,0 +1,165 @@
>> +/*
>> + * Copyright (C) 2010 Texas Instruments Inc.
>> + *
>> + * Modified from mach-omap2/board-zoom-peripherals.c + *
>> + * This program is free software; you can redistribute it and/or +modify
>> + * it under the terms of the GNU General Public License version 2 as
>> + * published by the Free Software Foundation.
>> + */
>> +
>> +#include
>> +#include
>> +#include
>> +#include
>> +#include
>> +#include
>> +#include
>> +#include
>> +
>> +#define LCD_PANEL_ENABLE_GPIO (7 +
> OMAP_MAX_GPIO_LINES)
> [Hiremath, Vaibhav] Are you sure that you don't want to use
> this GPIO in your enable/disable callback API?
>
[Samreen]
This will be taken care through the Backlight function,
Where it would be enabled/disabled accordingly.
I will remove this define from this file as it is not used.
>> +#define LCD_PANEL_RESET_GPIO_PROD 96
>> +#define LCD_PANEL_RESET_GPIO_PILOT 55
>> +#define LCD_PANEL_QVGA_GPIO 56
>> +
>> +static void zoom_lcd_panel_init(void) {
>> +int ret;
>> +unsigned char lcd_panel_reset_gpio;
>> +
>> +lcd_panel_reset_gpio = (omap_rev() > OMAP3430_REV_ES3_0) ?
>> +LCD_PANEL_RESET_GPIO_PROD :
>> +LCD_PANEL_RESET_GPIO_PILOT;
>> +
>> +ret = gpio_request(lcd_panel_reset_gpio, "lcd reset"); +if
>> (ret) {
>> +pr_err("Failed to get LCD reset GPIO (gpio%d).\n",
>> +lcd_panel_reset_gpio); +return;
>> +}
>> +gpio_direction_output(lcd_panel_reset_gpio, 1);
>> +
>> +ret = gpio_request(LCD_PANEL_QVGA_GPIO, "lcd qvga"); + if (ret) {
>> +pr_err(&quo
RE: [PATCH v3] OMAP3: DSS: Kconfig changes to enable display options on OMAP3
Nilofer, Samreen wrote: > Hi, > > Hiremath, Vaibhav wrote: >>> -Original Message- >>> From: Tomi Valkeinen [mailto:tomi.valkei...@nokia.com] >>> Sent: Wednesday, October 20, 2010 6:22 PM >>> To: Nilofer, Samreen >>> Cc: Grazvydas Ignotas; Hiremath, Vaibhav; Quadros Roger (Nokia- >>> MS/Helsinki); Guruswamy, Senthilvadivu; linux-omap@vger.kernel.org; >>> linux- fb...@vger.kernel.org Subject: Re: [PATCH v3] OMAP3: DSS: >>> Kconfig changes to enable display options on OMAP3 >>> >>> Hi, >>> >>> On Wed, 2010-10-20 at 14:04 +0200, ext Samreen wrote: >>>> The defconfig options for display are taken in the respective >>>> Kconfig to enable display by default on OMAP3 platforms >>>> >>>> Signed-off-by: Samreen >>>> --- >>>> Version3: >>>>Eliminate the separate default number of FBs for different >>>> architecture. Keeping default FBs as 3 as before. >>>> >>>> Version2: >>>> Enables by default NEC panel used in zoom2/3/3630sdp, >>>> instead of Sharp LQ043T1DG01 panel enabled in previous version of this >>>> patch >>>> >>>> drivers/video/omap2/displays/Kconfig |3 +++ >>>> drivers/video/omap2/dss/Kconfig |6 -- >>>> drivers/video/omap2/omapfb/Kconfig |1 + >>>> 3 files changed, 8 insertions(+), 2 deletions(-) >>>> >>>> diff --git a/drivers/video/omap2/displays/Kconfig >>> b/drivers/video/omap2/displays/Kconfig >>>> index f8152cf..d818e44 100644 >>>> --- a/drivers/video/omap2/displays/Kconfig >>>> +++ b/drivers/video/omap2/displays/Kconfig >>>> @@ -3,6 +3,7 @@ menu "OMAP2/3 Display Device Drivers" >>>> >>>> config PANEL_GENERIC >>>> tristate "Generic Panel" >>>> + default y >>>> help >>>> Generic panel driver. >>>> Used for DVI output for Beagle and OMAP3 SDP. >>>> @@ -10,6 +11,7 @@ config PANEL_GENERIC config >>>> PANEL_SHARP_LS037V7DW01 >>>> tristate "Sharp LS037V7DW01 LCD Panel" >>>> depends on OMAP2_DSS >>>> + default y >>>> select BACKLIGHT_CLASS_DEVICE >>>> help >>>>LCD Panel used in TI's SDP3430 and EVM boards @@ -23,6 >>>> +25,7 @@ config PANEL_SHARP_LQ043T1DG01 config >>>> PANEL_NEC_NL8048HL11_01B >>>>tristate "NEC NL8048HL11-01B Panel" >>>>depends on OMAP2_DSS >>>> + default y >>>>help >>>>This NEC NL8048HL11-01B panel is TFT LCD >>>>used in the Zoom2/3/3630 sdp boards. >>> >>> What kernel is this based on? There's no Nec driver on my or Linus' tree. >>> >>> If you enable those panels by default, why not enable all the rest of >>> the panels also? And should DSI/SDI/RFBI be enabled also by default, >>> and all the panels that require those? Where do we draw the line? >>> >>> I feel the only sane options are to keep everything off by default, >>> or all on by default. And setting all on by default doesn't sound too good >>> either... >>> >> >> [Hiremath, Vaibhav] I agree with Tomi here. >> >> Thanks, >> Vaibhav > [Samreen] > Tomi, > I have sent a separate patch "OMAP: DSS2: Add NEC > NL8048HL11-01B display panel" that adds the nec panel to L-O > mailing list. On top of which I have sent these patches. I am > using the LO-dss2 tree to verify my patches. [Samreen] With the patch link for reference: http://marc.info/?t=12876643612&r=1&w=2 Warm Regards, Samreen > > Tomi/Vaibav, > As keeping the panel disable by default is a better > idea, I will rework my patches accordingly. >> >>>> diff --git a/drivers/video/omap2/dss/Kconfig >>> b/drivers/video/omap2/dss/Kconfig >>>> index 43b6440..f3244a2 100644 >>>> --- a/drivers/video/omap2/dss/Kconfig >>>> +++ b/drivers/video/omap2/dss/Kconfig >>>> @@ -1,6 +1,7 @@ >>>> menuconfig OMAP2_DSS >>>> tristate "OMAP2/3 Display Subsystem support (EXPERIMENTAL)" >>>> depends on ARCH_OMAP2 || ARCH_OMAP3 >>>> + default y >>>> help >>>>OMAP2/3 Display Subsystem support. >>>> >>>> @@ -9,7 +10,7 @@ if OMAP2_DSS >>>> config OMAP2_VRAM_SIZE >>>>int "VRAM size (MB)" >>>>range 0 32 >>>> - default 0 >>>> + default 4 >>>>help >>>> The amount of SDRAM to reserve at boot time for video RAM use. >>>> This VRAM will be used by omapfb and other drivers that need @@ >>>> -102,7 +103,8 @@ config OMAP2_DSS_FAKE_VSYNC config >>>>OMAP2_DSS_MIN_FCK_PER_PCK int "Minimum FCK/PCK ratio (for scaling)" >>>> range 0 32 - default 0 >>>> + default 4 if ARCH_OMAP2 || ARCH_OMAP3 >>>> + default 0 if ARCH_OMAP4 >>> >>> Why is the ratio set to 4 on all OMAP2/3 boards? >>> >>> Tomi > [Samreen] > With the ratio as 4, a downscaling of 1/4 & 1/8 is > achieved with RGB & Yuv formats. > This is would be optimal value to achieve both upscaling and downscale > together. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH v3] OMAP3: DSS: Kconfig changes to enable display options on OMAP3
Hi, Hiremath, Vaibhav wrote: >> -Original Message- >> From: Tomi Valkeinen [mailto:tomi.valkei...@nokia.com] >> Sent: Wednesday, October 20, 2010 6:22 PM >> To: Nilofer, Samreen >> Cc: Grazvydas Ignotas; Hiremath, Vaibhav; Quadros Roger (Nokia- >> MS/Helsinki); Guruswamy, Senthilvadivu; linux-omap@vger.kernel.org; linux- >> fb...@vger.kernel.org Subject: Re: [PATCH v3] OMAP3: DSS: Kconfig changes to >> enable display options on OMAP3 >> >> Hi, >> >> On Wed, 2010-10-20 at 14:04 +0200, ext Samreen wrote: >>> The defconfig options for display are taken in the respective >>> Kconfig to enable display by default on OMAP3 platforms >>> >>> Signed-off-by: Samreen >>> --- >>> Version3: >>>Eliminate the separate default number of FBs for different >>> architecture. Keeping default FBs as 3 as before. >>> >>> Version2: >>> Enables by default NEC panel used in zoom2/3/3630sdp, >>> instead of Sharp LQ043T1DG01 panel enabled in previous version of this >>> patch >>> >>> drivers/video/omap2/displays/Kconfig |3 +++ >>> drivers/video/omap2/dss/Kconfig |6 -- >>> drivers/video/omap2/omapfb/Kconfig |1 + >>> 3 files changed, 8 insertions(+), 2 deletions(-) >>> >>> diff --git a/drivers/video/omap2/displays/Kconfig >> b/drivers/video/omap2/displays/Kconfig >>> index f8152cf..d818e44 100644 >>> --- a/drivers/video/omap2/displays/Kconfig >>> +++ b/drivers/video/omap2/displays/Kconfig >>> @@ -3,6 +3,7 @@ menu "OMAP2/3 Display Device Drivers" >>> >>> config PANEL_GENERIC >>> tristate "Generic Panel" >>> + default y >>> help >>> Generic panel driver. >>> Used for DVI output for Beagle and OMAP3 SDP. >>> @@ -10,6 +11,7 @@ config PANEL_GENERIC config >>> PANEL_SHARP_LS037V7DW01 >>> tristate "Sharp LS037V7DW01 LCD Panel" >>> depends on OMAP2_DSS >>> + default y >>> select BACKLIGHT_CLASS_DEVICE >>> help >>>LCD Panel used in TI's SDP3430 and EVM boards @@ -23,6 >>> +25,7 @@ config PANEL_SHARP_LQ043T1DG01 config >>> PANEL_NEC_NL8048HL11_01B >>> tristate "NEC NL8048HL11-01B Panel" >>> depends on OMAP2_DSS >>> + default y >>> help >>> This NEC NL8048HL11-01B panel is TFT LCD >>> used in the Zoom2/3/3630 sdp boards. >> >> What kernel is this based on? There's no Nec driver on my or Linus' tree. >> >> If you enable those panels by default, why not enable all the rest of >> the panels also? And should DSI/SDI/RFBI be enabled also by default, >> and all the panels that require those? Where do we draw the line? >> >> I feel the only sane options are to keep everything off by default, or >> all on by default. And setting all on by default doesn't sound too good >> either... >> > > [Hiremath, Vaibhav] I agree with Tomi here. > > Thanks, > Vaibhav [Samreen] Tomi, I have sent a separate patch "OMAP: DSS2: Add NEC NL8048HL11-01B display panel" that adds the nec panel to L-O mailing list. On top of which I have sent these patches. I am using the LO-dss2 tree to verify my patches. Tomi/Vaibav, As keeping the panel disable by default is a better idea, I will rework my patches accordingly. > >>> diff --git a/drivers/video/omap2/dss/Kconfig >> b/drivers/video/omap2/dss/Kconfig >>> index 43b6440..f3244a2 100644 >>> --- a/drivers/video/omap2/dss/Kconfig >>> +++ b/drivers/video/omap2/dss/Kconfig >>> @@ -1,6 +1,7 @@ >>> menuconfig OMAP2_DSS >>> tristate "OMAP2/3 Display Subsystem support (EXPERIMENTAL)" >>> depends on ARCH_OMAP2 || ARCH_OMAP3 >>> + default y >>> help >>>OMAP2/3 Display Subsystem support. >>> >>> @@ -9,7 +10,7 @@ if OMAP2_DSS >>> config OMAP2_VRAM_SIZE >>> int "VRAM size (MB)" >>> range 0 32 >>> - default 0 >>> + default 4 >>> help >>> The amount of SDRAM to reserve at boot time for video RAM use. >>> This VRAM will be used by omapfb and other drivers that need @@ >>> -102,7 +103,8 @@ config OMAP2_DSS_FAKE_VSYNC config >>> OMAP2_DSS_MIN_FCK_PER_PCK int "Minimum FCK/PCK ratio (for scaling)" >>> range 0 32 >>> - default 0 >>> + default 4 if ARCH_OMAP2 || ARCH_OMAP3 >>> + default 0 if ARCH_OMAP4 >> >> Why is the ratio set to 4 on all OMAP2/3 boards? >> >> Tomi [Samreen] With the ratio as 4, a downscaling of 1/4 & 1/8 is achieved with RGB & Yuv formats. This is would be optimal value to achieve both upscaling and downscale together. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH v2] OMAP: DSS2: Add NEC NL8048HL11-01B display panel
Grazvydas Ignotas wrote:
> On Thu, Oct 21, 2010 at 3:25 PM, Samreen wrote:
>> From: Erik Gilling
>>
>> NEC WVGA LCD NL8048HL11-01B panel support has been added.
>> This panel is being used in zoom2/zoom3/3630 sdp boards.
>>
>
>
>
>> diff --git
> a/drivers/video/omap2/displays/panel-nec-nl8048hl11-01b.c
>> b/drivers/video/omap2/displays/panel-nec-nl8048hl11-01b.c
>> new file mode 100644
>> index 000..0327731
>> --- /dev/null
>> +++ b/drivers/video/omap2/displays/panel-nec-nl8048hl11-01b.c
>
>
>
>> +static int spi_send(struct spi_device *spi, unsigned char reg_addr,
>> + unsigned char reg_data)
>
> you could be more consistent and name it nec_8048_spi_send.
[Samreen]
Will take care of this.
>
>> +{
>> + int ret = 0;
>> + unsigned int cmd = 0, data = 0;
>> +
>> + cmd = 0x | reg_addr; /* register address write */
>> + data = 0x0100 | reg_data ; /* register data write */
>> + data = (cmd << 16) | data;
>> +
>> + ret = spi_write(spi, (unsigned char *)&data, 4); + if (ret)
>> + pr_err("error in spi_write %x\n", data); +
>> + return ret;
>> +}
>> +
>> +
>
> one blank line is enough
[Samreen]
Will fix this
>
>> +static int init_nec_8048_wvga_lcd(struct spi_device *spi) {
>> + /* Initialization Sequence */
>> + /* spi_send(spi, REG, VAL) */
>> + spi_send(spi, 3, 0x01);
>> + spi_send(spi, 0, 0x00);
>> + spi_send(spi, 1, 0x01); /* R1 = 0x01 (normal), 0x03 +(reversed) */
>> + spi_send(spi, 4, 0x00);
>> + spi_send(spi, 5, 0x14);
>> + spi_send(spi, 6, 0x24);
>
> This code wastes quite a bit of space (at least 3 mov and one
> bl instruction for every such write on ARM), you could better do something
> like:
>
> static const struct {
> u8 address;
> u8 value;
> } nec_8048_init_seq[] = {
> { 3, 0x01 },
> { 0, 0x00 },
> { 1, 0x01 },
> ...
> };
[Samreen]
Agree, I'll surely take this more optimized approach
>
> static int init_nec_8048_wvga_lcd(struct spi_device *spi) { int i, ret;
> for (i = 0; i < ARRAY_SIZE(nec_8048_init_seq); i++) {
> ret = nec_8048_spi_send(spi,
> nec_8048_init_seq[i].address, nec_8048_init_seq[i].value); if (ret < 0)
> break;
> }
> udelay(20);
> nec_8048_spi_send(spi, 2, 0x00);
> }
>
>
>> +MODULE_DESCRIPTION("Nec Driver");
>
> could use more complete description here.
[Samreen]
Sure..--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH 1/1] OMAP: DSS2: Add NEC NL8048HL11-01B display panel
> -Original Message- > From: Hiremath, Vaibhav > Sent: Wednesday, October 20, 2010 5:57 PM > To: Nilofer, Samreen; linux-omap@vger.kernel.org > Cc: Erik Gilling; Subbu Venkatesh; Mittal, Mukund; Rajkumar N > Subject: RE: [PATCH 1/1] OMAP: DSS2: Add NEC NL8048HL11-01B > display panel > > > -Original Message- > > From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- > > ow...@vger.kernel.org] On Behalf Of Nilofer, Samreen > > Sent: Thursday, October 14, 2010 4:55 PM > > To: linux-omap@vger.kernel.org > > Cc: Erik Gilling; Subbu Venkatesh; Mittal, Mukund; Rajkumar N; > > Nilofer, Samreen > > Subject: [PATCH 1/1] OMAP: DSS2: Add NEC NL8048HL11-01B > display panel > > > > From: Erik Gilling > > > > NEC WVGA LCD NL8048HL11-01B panel support has been added. > > This panel is being used in zoom2/zoom3/3630 sdp boards. > > > > Signed-off-by: Mukund Mittal > > Signed-off-by: Rajkumar N > > Signed-off-by: Samreen > > CC: Subbu Venkatesh > > CC: Erik Gilling > > --- > > This panel driver has orginated from panel-zoom2 from the L25.x > > releases.Refer Commit: > > > > > http://git.omapzoom.org/?p=kernel/omap.git;a=commit;h=75fc121865125d9e > > 3ca3 > > b36f1f19f86b394e1f6b > > > [Hiremath, Vaibhav] Does this cleanly apply on > linux-omap/master branch or tomi's dss2 repo? > You should not be generating patches from any local/custom > repositories. [Samreen] These patch cleanly applies on Tomi' dss2 tree. I have tested and validated this patch on tomi's tree. > > > drivers/video/omap2/displays/Kconfig |7 + > > drivers/video/omap2/displays/Makefile |1 + > > .../omap2/displays/panel-nec-nl8048hl11-01b.c | 381 > > > > 3 files changed, 389 insertions(+), 0 deletions(-) create mode > > 100644 drivers/video/omap2/displays/panel-nec-nl8048hl11- > > 01b.c > > > > diff --git a/drivers/video/omap2/displays/Kconfig > > b/drivers/video/omap2/displays/Kconfig > > index 12327bb..f8152cf 100644 > > --- a/drivers/video/omap2/displays/Kconfig > > +++ b/drivers/video/omap2/displays/Kconfig > > @@ -20,6 +20,13 @@ config PANEL_SHARP_LQ043T1DG01 > > help > >LCD Panel used in TI's OMAP3517 EVM boards > > > > +config PANEL_NEC_NL8048HL11_01B > > + tristate "NEC NL8048HL11-01B Panel" > > + depends on OMAP2_DSS > > + help > > + This NEC NL8048HL11-01B panel is TFT LCD > > + used in the Zoom2/3/3630 sdp boards. > > + > > config PANEL_TAAL > > tristate "Taal DSI Panel" > > depends on OMAP2_DSS_DSI > > diff --git a/drivers/video/omap2/displays/Makefile > > b/drivers/video/omap2/displays/Makefile > > index aa38609..8ece91c 100644 > > --- a/drivers/video/omap2/displays/Makefile > > +++ b/drivers/video/omap2/displays/Makefile > > @@ -1,6 +1,7 @@ > > obj-$(CONFIG_PANEL_GENERIC) += panel-generic.o > > obj-$(CONFIG_PANEL_SHARP_LS037V7DW01) += panel-sharp-ls037v7dw01.o > > obj-$(CONFIG_PANEL_SHARP_LQ043T1DG01) += panel-sharp-lq043t1dg01.o > > +obj-$(CONFIG_PANEL_NEC_NL8048HL11_01B) += > panel-nec-nl8048hl11-01b.o > > > > obj-$(CONFIG_PANEL_TAAL) += panel-taal.o > > obj-$(CONFIG_PANEL_TOPPOLY_TDO35S) += panel-toppoly-tdo35s.o diff > > --git a/drivers/video/omap2/displays/panel-nec-nl8048hl11-01b.c > > b/drivers/video/omap2/displays/panel-nec-nl8048hl11-01b.c > > new file mode 100644 > > index 000..cdc0d8f > > --- /dev/null > > +++ b/drivers/video/omap2/displays/panel-nec-nl8048hl11-01b.c > > @@ -0,0 +1,381 @@ > > +/* > > + * Support for NEC-nl8048hl11-01b panel driver > > + * > > + * Copyright (C) 2010 Texas Instruments Inc. > > + * Author: Erik Gilling > > + * This program is free software; you can redistribute it and/or > > +modify > > it > > + * under the terms of the GNU General Public License version 2 as > > published by > > + * the Free Software Foundation. > > + * > > + * This program is distributed in the hope that it will be useful, > > + but > > WITHOUT > > + * ANY WARRANTY; without even the implied warranty of > MERCHANTABILITY > > + or > > + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public > > + License > > for > > + * more details. > > + * > > + * You should have received a copy of the GNU General > Public License > > along with > > + * this program. If not, see <http://www
RE: [PATCH v2] OMAP3: DSS: Kconfig changes to enable display options on OMAP3
Grazvydas Ignotas wrote: > On Mon, Oct 18, 2010 at 12:37 PM, Felipe Contreras > wrote: >> On Mon, Oct 18, 2010 at 8:55 AM, Samreen wrote: >>> The defconfig options for display are taken in the respective Kconfig >>> to enable display by default on OMAP3 platforms >> >> >>> config FB_OMAP2_NUM_FBS >>> int "Number of framebuffers" >>> range 1 10 >>> - default 3 >>> + default 1 if ARCH_OMAP2 || ARCH_OMAP3 >>> + default 3 if ARCH_OMAP4 >>> depends on FB_OMAP2 >>> help >>> Select the number of framebuffers created. OMAP2/3 has 3 >>> overlays >> >> I think this should be 3 also for OMAP3. > > Right, please don't change defaults out of the blue like this. > > Also when sending DSS patches, please CC linux-fbdev and DSS > maintainer (Tomi), run ./scripts/get_maintainer.pl for > maintainers. Will fix this, and will make sure to include the right maintainers While posting the patches. -Samreen -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
