RE: [PATCH] usb:gadget: use min_t() macro instead of min()

[Tanya Brokhman]

 
 On Sun, Jun 12, 2011 at 02:14:46PM +0300, Tatyana Brokhman wrote:
  Signed-off-by: Tatyana Brokhman tlin...@codeaurora.org
 
 I need a sensible commit log for this. Why do we need to change all
 min() to min_t() ?
 

Actually, Alan asked me to make this change in one place in dummy_hcd. I
wasn't aware of the min_t macro before that. So when I searched the code for
other places I found quite a few and just thought that it would be nicer
to use min_t() instead of min() with casting. 
So we don't need to make this change. Everything works as is. This patch
only makes the code look nicer, nothing more.
I can elaborate the above in the commit log if you want.


Thanks,
Tanya Brokhman
---
Sent by an consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.




--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH] usb:gadget: use min_t() macro instead of min()

[Tanya Brokhman]

 
 The change I suggested involved replacing two typecasts with a single
 min_t.  All (or almost all) the places this patch touches currently
 contain only one typecast, so the motivation for changing them is a lot
 weaker.
 
You're right. So what's the final call on this one? Do you think it can be
merged or you prefer not change anything? I personally think the code looks
nicer using min_t instead of min with casting but that's just my opinion and
of course there are arguments against this patch.


Thanks,
Tanya Brokhman
---
Sent by an consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.





--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html