Re: [PATCH] ARM: OMAP: mcbsp: Fix possible memory corruption

2011-12-14 Thread Ramirez Luna, Omar 
On Mon, Dec 12, 2011 at 12:33 PM, Tony Lindgren t...@atomide.com wrote:
 Applying into fixes.

FWIW, I was bisecting this issue, the patch fixes the following slab
corruptions on boot log:

...
hw-breakpoint: found 5 (+1 reserved) breakpoint and 1 watchpoint registers.
hw-breakpoint: maximum watchpoint size is 4 bytes.
Slab corruption: size-32 start=eea66740, len=32
010: d8 9d 02 c0 04 9d 02 c0 6b 6b 6b 6b 6b 6b 6b a5  kkk.
Prev obj: start=eea66720, len=32
000: 6f 6d 61 70 32 5f 6d 63 73 70 69 2e 31 00 5a 5a  omap2_mcspi.1.ZZ
010: 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a a5  ZZZ.
Next obj: start=eea66760, len=32
000: 70 6f 77 65 72 00 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a  power.ZZ
010: 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a a5  ZZZ.
Slab corruption: size-32 start=eea66740, len=32
010: d8 9d 02 c0 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b a5  kkk.
Prev obj: start=eea66720, len=32
000: 6f 6d 61 70 32 5f 6d 63 73 70 69 2e 31 00 5a 5a  omap2_mcspi.1.ZZ
010: 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a a5  ZZZ.
Next obj: start=eea66760, len=32
000: 70 6f 77 65 72 00 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a  power.ZZ
010: 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a a5  ZZZ.
Slab corruption: size-32 start=eea66740, len=32
010: d8 9d 02 c0 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b a5  kkk.
Prev obj: start=eea66720, len=32
000: 6f 6d 61 70 32 5f 6d 63 73 70 69 2e 31 00 5a 5a  omap2_mcspi.1.ZZ
010: 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a a5  ZZZ.
Next obj: start=eea66760, len=32
000: 70 6f 77 65 72 00 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a  power.ZZ
010: 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a a5  ZZZ.
Slab corruption: size-32 start=eea66740, len=32
010: d8 9d 02 c0 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b a5  kkk.
Prev obj: start=eea66720, len=32
000: 6f 6d 61 70 32 5f 6d 63 73 70 69 2e 31 00 5a 5a  omap2_mcspi.1.ZZ
010: 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a a5  ZZZ.
Next obj: start=eea66760, len=32
000: 70 6f 77 65 72 00 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a  power.ZZ
010: 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a a5  ZZZ.
OMAP DMA hardware revision 0.0
...

Regards,

Omar
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ARM: OMAP: mcbsp: Fix possible memory corruption

2011-12-14 Thread Tony Lindgren 
* Ramirez Luna, Omar omar.rami...@ti.com [111214 12:18]:
 On Mon, Dec 12, 2011 at 12:33 PM, Tony Lindgren t...@atomide.com wrote:
  Applying into fixes.
 
 FWIW, I was bisecting this issue, the patch fixes the following slab
 corruptions on boot log:

Thanks for the info, I've sent the pull request for the two patches
in fixes branch.

Regards,

Tony

 
 hw-breakpoint: found 5 (+1 reserved) breakpoint and 1 watchpoint registers.
 hw-breakpoint: maximum watchpoint size is 4 bytes.
 Slab corruption: size-32 start=eea66740, len=32
 010: d8 9d 02 c0 04 9d 02 c0 6b 6b 6b 6b 6b 6b 6b a5  kkk.
 Prev obj: start=eea66720, len=32
 000: 6f 6d 61 70 32 5f 6d 63 73 70 69 2e 31 00 5a 5a  omap2_mcspi.1.ZZ
 010: 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a a5  ZZZ.
 Next obj: start=eea66760, len=32
 000: 70 6f 77 65 72 00 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a  power.ZZ
 010: 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a a5  ZZZ.
 Slab corruption: size-32 start=eea66740, len=32
 010: d8 9d 02 c0 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b a5  kkk.
 Prev obj: start=eea66720, len=32
 000: 6f 6d 61 70 32 5f 6d 63 73 70 69 2e 31 00 5a 5a  omap2_mcspi.1.ZZ
 010: 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a a5  ZZZ.
 Next obj: start=eea66760, len=32
 000: 70 6f 77 65 72 00 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a  power.ZZ
 010: 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a a5  ZZZ.
 Slab corruption: size-32 start=eea66740, len=32
 010: d8 9d 02 c0 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b a5  kkk.
 Prev obj: start=eea66720, len=32
 000: 6f 6d 61 70 32 5f 6d 63 73 70 69 2e 31 00 5a 5a  omap2_mcspi.1.ZZ
 010: 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a a5  ZZZ.
 Next obj: start=eea66760, len=32
 000: 70 6f 77 65 72 00 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a  power.ZZ
 010: 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a a5  ZZZ.
 Slab corruption: size-32 start=eea66740, len=32
 010: d8 9d 02 c0 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b 6b a5  kkk.
 Prev obj: start=eea66720, len=32
 000: 6f 6d 61 70 32 5f 6d 63 73 70 69 2e 31 00 5a 5a  omap2_mcspi.1.ZZ
 010: 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a a5  ZZZ.
 Next obj: start=eea66760, len=32
 000: 70 6f 77 65 72 00 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a  power.ZZ
 010: 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a 5a a5  ZZZ.
 OMAP DMA hardware revision 0.0
 ...
 
 Regards,
 
 Omar
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] ARM: OMAP: mcbsp: Fix possible memory corruption

2011-12-12 Thread Jarkko Nikula 
Commits 09d28d (ARM: OMAP: mcbsp: Start generalize omap2_mcbsp_set_clks_src)
and 7bc0c4 (ARM: OMAP: mcbsp: Start generalize signal muxing functions)
incorrectly set two struct omap_mcbsp_platform_data fields after
omap_device_build_ss and kfree calls.

Fix this by moving these pdata assignments before those calls.

Signed-off-by: Jarkko Nikula jarkko.nik...@bitmer.com
Reported-by: ne...@suse.de
---
For 3.2, 3.1 is ok.
---
 arch/arm/mach-omap2/mcbsp.c |6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm/mach-omap2/mcbsp.c b/arch/arm/mach-omap2/mcbsp.c
index 292eee3..28fcb27 100644
--- a/arch/arm/mach-omap2/mcbsp.c
+++ b/arch/arm/mach-omap2/mcbsp.c
@@ -145,6 +145,9 @@ static int omap_init_mcbsp(struct omap_hwmod *oh, void 
*unused)
pdata-reg_size = 4;
pdata-has_ccr = true;
}
+   pdata-set_clk_src = omap2_mcbsp_set_clk_src;
+   if (id == 1)
+   pdata-mux_signal = omap2_mcbsp1_mux_rx_clk;
 
if (oh-class-rev == MCBSP_CONFIG_TYPE3) {
if (id == 2)
@@ -174,9 +177,6 @@ static int omap_init_mcbsp(struct omap_hwmod *oh, void 
*unused)
name, oh-name);
return PTR_ERR(pdev);
}
-   pdata-set_clk_src = omap2_mcbsp_set_clk_src;
-   if (id == 1)
-   pdata-mux_signal = omap2_mcbsp1_mux_rx_clk;
omap_mcbsp_count++;
return 0;
 }
-- 
1.7.7.3

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ARM: OMAP: mcbsp: Fix possible memory corruption

2011-12-12 Thread Igor Grinberg 
On 12/12/11 10:38, Jarkko Nikula wrote:
 Commits 09d28d (ARM: OMAP: mcbsp: Start generalize omap2_mcbsp_set_clks_src)
 and 7bc0c4 (ARM: OMAP: mcbsp: Start generalize signal muxing functions)
 incorrectly set two struct omap_mcbsp_platform_data fields after
 omap_device_build_ss and kfree calls.
 
 Fix this by moving these pdata assignments before those calls.
 
 Signed-off-by: Jarkko Nikula jarkko.nik...@bitmer.com
 Reported-by: ne...@suse.de

Perhaps, should be:
Reported-by: NeilBrown ne...@suse.de
and
Cc: sta...@vger.kernel.org[3.1]
as for below.

 ---
 For 3.2, 3.1 is ok.
 ---
  arch/arm/mach-omap2/mcbsp.c |6 +++---
  1 files changed, 3 insertions(+), 3 deletions(-)
 
 diff --git a/arch/arm/mach-omap2/mcbsp.c b/arch/arm/mach-omap2/mcbsp.c
 index 292eee3..28fcb27 100644
 --- a/arch/arm/mach-omap2/mcbsp.c
 +++ b/arch/arm/mach-omap2/mcbsp.c
 @@ -145,6 +145,9 @@ static int omap_init_mcbsp(struct omap_hwmod *oh, void 
 *unused)
   pdata-reg_size = 4;
   pdata-has_ccr = true;
   }
 + pdata-set_clk_src = omap2_mcbsp_set_clk_src;
 + if (id == 1)
 + pdata-mux_signal = omap2_mcbsp1_mux_rx_clk;
  
   if (oh-class-rev == MCBSP_CONFIG_TYPE3) {
   if (id == 2)
 @@ -174,9 +177,6 @@ static int omap_init_mcbsp(struct omap_hwmod *oh, void 
 *unused)
   name, oh-name);
   return PTR_ERR(pdev);
   }
 - pdata-set_clk_src = omap2_mcbsp_set_clk_src;
 - if (id == 1)
 - pdata-mux_signal = omap2_mcbsp1_mux_rx_clk;
   omap_mcbsp_count++;
   return 0;
  }

-- 
Regards,
Igor.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ARM: OMAP: mcbsp: Fix possible memory corruption

2011-12-12 Thread Jarkko Nikula 
Hi

On 12/12/2011 12:23 PM, Igor Grinberg wrote:
 On 12/12/11 10:38, Jarkko Nikula wrote:
 Commits 09d28d (ARM: OMAP: mcbsp: Start generalize 
 omap2_mcbsp_set_clks_src)
 and 7bc0c4 (ARM: OMAP: mcbsp: Start generalize signal muxing functions)
 incorrectly set two struct omap_mcbsp_platform_data fields after
 omap_device_build_ss and kfree calls.

 Fix this by moving these pdata assignments before those calls.

 Signed-off-by: Jarkko Nikula jarkko.nik...@bitmer.com
 Reported-by: ne...@suse.de
 Perhaps, should be:
 Reported-by: NeilBrown ne...@suse.de
 and
 Cc: sta...@vger.kernel.org  [3.1]
 as for below.
 ---
 For 3.2, 3.1 is ok.
 ---
No need to cc stable since the issue is not in stable kernels.

-- 
Jarkko
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ARM: OMAP: mcbsp: Fix possible memory corruption

2011-12-12 Thread Igor Grinberg 
On 12/12/11 13:22, Jarkko Nikula wrote:
 Hi
 
 On 12/12/2011 12:23 PM, Igor Grinberg wrote:
 On 12/12/11 10:38, Jarkko Nikula wrote:
 Commits 09d28d (ARM: OMAP: mcbsp: Start generalize 
 omap2_mcbsp_set_clks_src)
 and 7bc0c4 (ARM: OMAP: mcbsp: Start generalize signal muxing functions)
 incorrectly set two struct omap_mcbsp_platform_data fields after
 omap_device_build_ss and kfree calls.

 Fix this by moving these pdata assignments before those calls.

 Signed-off-by: Jarkko Nikula jarkko.nik...@bitmer.com
 Reported-by: ne...@suse.de
 Perhaps, should be:
 Reported-by: NeilBrown ne...@suse.de
 and
 Cc: sta...@vger.kernel.org [3.1]
 as for below.
 ---
 For 3.2, 3.1 is ok.
 ---
 No need to cc stable since the issue is not in stable kernels.

Ah, so I've misunderstood what was that about...
So it has been introduced in 3.2-rc cycle.
Ok. Then now it is the perfect time to fix this ;)


-- 
Regards,
Igor.
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ARM: OMAP: mcbsp: Fix possible memory corruption

2011-12-12 Thread Tony Lindgren 
* Igor Grinberg grinb...@compulab.co.il [111212 03:25]:
 On 12/12/11 13:22, Jarkko Nikula wrote:
  Hi
  
  On 12/12/2011 12:23 PM, Igor Grinberg wrote:
  On 12/12/11 10:38, Jarkko Nikula wrote:
  Commits 09d28d (ARM: OMAP: mcbsp: Start generalize 
  omap2_mcbsp_set_clks_src)
  and 7bc0c4 (ARM: OMAP: mcbsp: Start generalize signal muxing functions)
  incorrectly set two struct omap_mcbsp_platform_data fields after
  omap_device_build_ss and kfree calls.
 
  Fix this by moving these pdata assignments before those calls.
 
  Signed-off-by: Jarkko Nikula jarkko.nik...@bitmer.com
  Reported-by: ne...@suse.de
  Perhaps, should be:
  Reported-by: NeilBrown ne...@suse.de
  and
  Cc: sta...@vger.kernel.org   [3.1]
  as for below.
  ---
  For 3.2, 3.1 is ok.
  ---
  No need to cc stable since the issue is not in stable kernels.
 
 Ah, so I've misunderstood what was that about...
 So it has been introduced in 3.2-rc cycle.
 Ok. Then now it is the perfect time to fix this ;)

Applying into fixes.

Regards,

Tony
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html