Re: [PATCH] OMAP34xx: Add padconfig offsets for GPIOs 126-129

2011-04-03 Thread Matthias Kaehlcke
Hi Felipe,

El Sun, Apr 03, 2011 at 02:06:31PM +0300 Felipe Balbi ha dit:

 On Fri, Apr 01, 2011 at 10:23:30PM +0200, Matthias Kaehlcke wrote:
  Add OMAP3_CONTROL_PADCONF_GPIOxxx_OFFSET constants for GPIOs 126-129
  
  Signed-off-by: Matthias Kaehlcke matth...@tomtom.com
  ---
   arch/arm/mach-omap2/mux34xx.h |4 
   1 files changed, 4 insertions(+), 0 deletions(-)
  
  diff --git a/arch/arm/mach-omap2/mux34xx.h b/arch/arm/mach-omap2/mux34xx.h
  index 6543ebf..70d2b8d 100644
  --- a/arch/arm/mach-omap2/mux34xx.h
  +++ b/arch/arm/mach-omap2/mux34xx.h
  @@ -393,6 +393,10 @@
   #define OMAP3_CONTROL_PADCONF_SAD2D_SWAKEUP_OFFSET 0xa1c
   #define OMAP3_CONTROL_PADCONF_JTAG_RTCK_OFFSET 0xa1e
   #define OMAP3_CONTROL_PADCONF_JTAG_TDO_OFFSET  0xa20
  +#define OMAP3_CONTROL_PADCONF_GPIO127_OFFSET   0xa24
  +#define OMAP3_CONTROL_PADCONF_GPIO126_OFFSET   0xa26
  +#define OMAP3_CONTROL_PADCONF_GPIO128_OFFSET   0xa28
  +#define OMAP3_CONTROL_PADCONF_GPIO129_OFFSET   0xa2a
 
 no users for these ?

we use these on a custom board whose board specific code won't be
mainlined. i think it still makes sense to have the constants in
mainline for the sake of completeness

kind regards

-- 
Matthias Kaehlcke
Embedded Linux Developer
Amsterdam

 La libertad es como la maƱana. Hay quienes esperan dormidos a que
   llegue, pero hay quienes desvelan y caminan la noche para alcanzarla
(Subcomandante Marcos)
 .''`.
using free software / Debian GNU/Linux | http://debian.org  : :'  :
`. `'`
gpg --keyserver pgp.mit.edu --recv-keys 47D8E5D4  `-
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH] OMAP34xx: Add padconfig offsets for GPIOs 126-129

2011-04-03 Thread Felipe Balbi
On Sun, Apr 03, 2011 at 01:33:28PM +0200, Matthias Kaehlcke wrote:
 Hi Felipe,
 
 El Sun, Apr 03, 2011 at 02:06:31PM +0300 Felipe Balbi ha dit:
 
  On Fri, Apr 01, 2011 at 10:23:30PM +0200, Matthias Kaehlcke wrote:
   Add OMAP3_CONTROL_PADCONF_GPIOxxx_OFFSET constants for GPIOs 126-129
   
   Signed-off-by: Matthias Kaehlcke matth...@tomtom.com
   ---
arch/arm/mach-omap2/mux34xx.h |4 
1 files changed, 4 insertions(+), 0 deletions(-)
   
   diff --git a/arch/arm/mach-omap2/mux34xx.h b/arch/arm/mach-omap2/mux34xx.h
   index 6543ebf..70d2b8d 100644
   --- a/arch/arm/mach-omap2/mux34xx.h
   +++ b/arch/arm/mach-omap2/mux34xx.h
   @@ -393,6 +393,10 @@
#define OMAP3_CONTROL_PADCONF_SAD2D_SWAKEUP_OFFSET   0xa1c
#define OMAP3_CONTROL_PADCONF_JTAG_RTCK_OFFSET   0xa1e
#define OMAP3_CONTROL_PADCONF_JTAG_TDO_OFFSET0xa20
   +#define OMAP3_CONTROL_PADCONF_GPIO127_OFFSET 0xa24
   +#define OMAP3_CONTROL_PADCONF_GPIO126_OFFSET 0xa26
   +#define OMAP3_CONTROL_PADCONF_GPIO128_OFFSET 0xa28
   +#define OMAP3_CONTROL_PADCONF_GPIO129_OFFSET 0xa2a
  
  no users for these ?
 
 we use these on a custom board whose board specific code won't be
 mainlined. i think it still makes sense to have the constants in
 mainline for the sake of completeness

I'll leave that decision to Tony. I agree that, for the sake of
completeness, we should have those. But OTOH, not having any in tree
users is kinda of a bummer.

It would be nice to see TomTom's devices in tree. Maybe after the kernel
sources is released to the public we could that in tree for the sake of
completeness :-)

-- 
balbi
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH] OMAP34xx: Add padconfig offsets for GPIOs 126-129

2011-04-01 Thread Matthias Kaehlcke

Add OMAP3_CONTROL_PADCONF_GPIOxxx_OFFSET constants for GPIOs 126-129

Signed-off-by: Matthias Kaehlcke matth...@tomtom.com
---
 arch/arm/mach-omap2/mux34xx.h |4 
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-omap2/mux34xx.h b/arch/arm/mach-omap2/mux34xx.h
index 6543ebf..70d2b8d 100644
--- a/arch/arm/mach-omap2/mux34xx.h
+++ b/arch/arm/mach-omap2/mux34xx.h
@@ -393,6 +393,10 @@
 #define OMAP3_CONTROL_PADCONF_SAD2D_SWAKEUP_OFFSET 0xa1c
 #define OMAP3_CONTROL_PADCONF_JTAG_RTCK_OFFSET 0xa1e
 #define OMAP3_CONTROL_PADCONF_JTAG_TDO_OFFSET  0xa20
+#define OMAP3_CONTROL_PADCONF_GPIO127_OFFSET   0xa24
+#define OMAP3_CONTROL_PADCONF_GPIO126_OFFSET   0xa26
+#define OMAP3_CONTROL_PADCONF_GPIO128_OFFSET   0xa28
+#define OMAP3_CONTROL_PADCONF_GPIO129_OFFSET   0xa2a

 #define OMAP3_CONTROL_PADCONF_MUX_SIZE \
(OMAP3_CONTROL_PADCONF_JTAG_TDO_OFFSET + 0x2)
--
1.7.1

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html