[3.19.y-ckt stable] Patch "clk: ti: fix dual-registration of uart4_ick" has been added to staging queue
This is a note to let you know that I have just added a patch titled clk: ti: fix dual-registration of uart4_ick to the linux-3.19.y-queue branch of the 3.19.y-ckt extended stable tree which can be found at: http://kernel.ubuntu.com/git/ubuntu/linux.git/log/?h=linux-3.19.y-queue This patch is scheduled to be released in version 3.19.8-ckt10. If you, or anyone else, feels it should not be added to this tree, please reply to this email. For more information about the 3.19.y-ckt tree, see https://wiki.ubuntu.com/Kernel/Dev/ExtendedStable Thanks. -Kamal -- >From da8f142b680efa5a8b8d746719c08a8486506837 Mon Sep 17 00:00:00 2001 From: Ben Dooks Date: Tue, 29 Sep 2015 15:01:08 +0100 Subject: [PATCH 014/120] clk: ti: fix dual-registration of uart4_ick commit 19e79687de22f23bcfb5e79cce3daba20af228d1 upstream. On the OMAP AM3517 platform the uart4_ick gets registered twice, causing any power management to /dev/ttyO3 to fail when trying to wake the device up. This solves the following oops: [] Unhandled fault: external abort on non-linefetch (0x1028) at 0xfa09e008 [] PC is at serial_omap_pm+0x48/0x15c [] LR is at _raw_spin_unlock_irqrestore+0x30/0x5c Fixes: aafd900cab87 ("CLK: TI: add omap3 clock init file") Cc: mturque...@baylibre.com Cc: sb...@codeaurora.org Cc: linux-...@vger.kernel.org Cc: linux-omap@vger.kernel.org Cc: linux-ker...@lists.codethink.co.uk Signed-off-by: Ben Dooks Signed-off-by: Tero Kristo Signed-off-by: Kamal Mostafa --- drivers/clk/ti/clk-3xxx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/ti/clk-3xxx.c b/drivers/clk/ti/clk-3xxx.c index 0d1750a..088930c 100644 --- a/drivers/clk/ti/clk-3xxx.c +++ b/drivers/clk/ti/clk-3xxx.c @@ -170,7 +170,6 @@ static struct ti_dt_clk omap3xxx_clks[] = { DT_CLK(NULL, "gpio2_ick", "gpio2_ick"), DT_CLK(NULL, "wdt3_ick", "wdt3_ick"), DT_CLK(NULL, "uart3_ick", "uart3_ick"), - DT_CLK(NULL, "uart4_ick", "uart4_ick"), DT_CLK(NULL, "gpt9_ick", "gpt9_ick"), DT_CLK(NULL, "gpt8_ick", "gpt8_ick"), DT_CLK(NULL, "gpt7_ick", "gpt7_ick"), @@ -313,6 +312,7 @@ static struct ti_dt_clk am35xx_clks[] = { static struct ti_dt_clk omap36xx_clks[] = { DT_CLK(NULL, "omap_192m_alwon_fck", "omap_192m_alwon_fck"), DT_CLK(NULL, "uart4_fck", "uart4_fck"), + DT_CLK(NULL, "uart4_ick", "uart4_ick"), { .node_name = NULL }, }; -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[3.16.y-ckt stable] Patch "clk: ti: fix dual-registration of uart4_ick" has been added to staging queue
This is a note to let you know that I have just added a patch titled clk: ti: fix dual-registration of uart4_ick to the linux-3.16.y-queue branch of the 3.16.y-ckt extended stable tree which can be found at: http://kernel.ubuntu.com/git/ubuntu/linux.git/log/?h=linux-3.16.y-queue This patch is scheduled to be released in version 3.16.7-ckt20. If you, or anyone else, feels it should not be added to this tree, please reply to this email. For more information about the 3.16.y-ckt tree, see https://wiki.ubuntu.com/Kernel/Dev/ExtendedStable Thanks. -Luis -- >From 30b9c68b905ec04f247510518022db8faec47292 Mon Sep 17 00:00:00 2001 From: Ben Dooks Date: Tue, 29 Sep 2015 15:01:08 +0100 Subject: clk: ti: fix dual-registration of uart4_ick commit 19e79687de22f23bcfb5e79cce3daba20af228d1 upstream. On the OMAP AM3517 platform the uart4_ick gets registered twice, causing any power management to /dev/ttyO3 to fail when trying to wake the device up. This solves the following oops: [] Unhandled fault: external abort on non-linefetch (0x1028) at 0xfa09e008 [] PC is at serial_omap_pm+0x48/0x15c [] LR is at _raw_spin_unlock_irqrestore+0x30/0x5c Fixes: aafd900cab87 ("CLK: TI: add omap3 clock init file") Cc: mturque...@baylibre.com Cc: sb...@codeaurora.org Cc: linux-...@vger.kernel.org Cc: linux-omap@vger.kernel.org Cc: linux-ker...@lists.codethink.co.uk Signed-off-by: Ben Dooks Signed-off-by: Tero Kristo Signed-off-by: Luis Henriques --- drivers/clk/ti/clk-3xxx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/ti/clk-3xxx.c b/drivers/clk/ti/clk-3xxx.c index 0d1750a8aea4..088930c3ee4b 100644 --- a/drivers/clk/ti/clk-3xxx.c +++ b/drivers/clk/ti/clk-3xxx.c @@ -170,7 +170,6 @@ static struct ti_dt_clk omap3xxx_clks[] = { DT_CLK(NULL, "gpio2_ick", "gpio2_ick"), DT_CLK(NULL, "wdt3_ick", "wdt3_ick"), DT_CLK(NULL, "uart3_ick", "uart3_ick"), - DT_CLK(NULL, "uart4_ick", "uart4_ick"), DT_CLK(NULL, "gpt9_ick", "gpt9_ick"), DT_CLK(NULL, "gpt8_ick", "gpt8_ick"), DT_CLK(NULL, "gpt7_ick", "gpt7_ick"), @@ -313,6 +312,7 @@ static struct ti_dt_clk am35xx_clks[] = { static struct ti_dt_clk omap36xx_clks[] = { DT_CLK(NULL, "omap_192m_alwon_fck", "omap_192m_alwon_fck"), DT_CLK(NULL, "uart4_fck", "uart4_fck"), + DT_CLK(NULL, "uart4_ick", "uart4_ick"), { .node_name = NULL }, }; -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] clk: ti: fix dual-registration of uart4_ick
* Tero Kristo [151005 05:39]: > On 10/05/2015 01:17 PM, Tony Lindgren wrote: > >* Ben Dooks [150929 06:14]: > >>On 25/09/15 06:42, Tero Kristo wrote: > >>>On 09/23/2015 08:30 PM, Tony Lindgren wrote: > * Ben Dooks [150923 07:53]: > >On the OMAP AM3517 platform the uart4_ick gets registered > >twice, causing any power managment to /dev/ttyO3 to fail > >when trying to wake the device up. > > > >This solves the following oops: > > > >[] Unhandled fault: external abort on non-linefetch (0x1028) at > >0xfa09e008 > >[] PC is at serial_omap_pm+0x48/0x15c > >[] LR is at _raw_spin_unlock_irqrestore+0x30/0x5c > > No uart4 on 34xx/35xx, that got introduced with 36xx so: > > Acked-by: Tony Lindgren > > >Signed-off-by: Ben Dooks > >--- > > drivers/clk/ti/clk-3xxx.c | 1 - > > 1 file changed, 1 deletion(-) > > > >diff --git a/drivers/clk/ti/clk-3xxx.c b/drivers/clk/ti/clk-3xxx.c > >index 5e12f32..2e7ef1f 100644 > >--- a/drivers/clk/ti/clk-3xxx.c > >+++ b/drivers/clk/ti/clk-3xxx.c > >@@ -374,7 +374,6 @@ static struct ti_dt_clk omap3xxx_clks[] = { > > DT_CLK(NULL, "gpio2_ick", "gpio2_ick"), > > DT_CLK(NULL, "wdt3_ick", "wdt3_ick"), > > DT_CLK(NULL, "uart3_ick", "uart3_ick"), > >-DT_CLK(NULL, "uart4_ick", "uart4_ick"), > > DT_CLK(NULL, "gpt9_ick", "gpt9_ick"), > > DT_CLK(NULL, "gpt8_ick", "gpt8_ick"), > > DT_CLK(NULL, "gpt7_ick", "gpt7_ick"), > >>> > >>>NAK. > >>> > >>>This patch is actually only partially correct, it removes the uart4_ick > >>>alias for omap36xx also. It should be added back to the omap36xx clks > >>>array. Care to post a v2? > >> > >>Thankyou for the feedback. I'll update, but do not have a device to test. > > > >Hmm but isn't that entry already there for 36xx? So this just removes > >a duplicate for 36xx.. Tero, can you please check again, maybe I'm > >confused. > > uart4_ick wasn't there, we only had uart4_fck listed for omap36xx. OK thanks for checking. Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] clk: ti: fix dual-registration of uart4_ick
On 10/05/2015 01:17 PM, Tony Lindgren wrote: * Ben Dooks [150929 06:14]: On 25/09/15 06:42, Tero Kristo wrote: On 09/23/2015 08:30 PM, Tony Lindgren wrote: * Ben Dooks [150923 07:53]: On the OMAP AM3517 platform the uart4_ick gets registered twice, causing any power managment to /dev/ttyO3 to fail when trying to wake the device up. This solves the following oops: [] Unhandled fault: external abort on non-linefetch (0x1028) at 0xfa09e008 [] PC is at serial_omap_pm+0x48/0x15c [] LR is at _raw_spin_unlock_irqrestore+0x30/0x5c No uart4 on 34xx/35xx, that got introduced with 36xx so: Acked-by: Tony Lindgren Signed-off-by: Ben Dooks --- drivers/clk/ti/clk-3xxx.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/clk/ti/clk-3xxx.c b/drivers/clk/ti/clk-3xxx.c index 5e12f32..2e7ef1f 100644 --- a/drivers/clk/ti/clk-3xxx.c +++ b/drivers/clk/ti/clk-3xxx.c @@ -374,7 +374,6 @@ static struct ti_dt_clk omap3xxx_clks[] = { DT_CLK(NULL, "gpio2_ick", "gpio2_ick"), DT_CLK(NULL, "wdt3_ick", "wdt3_ick"), DT_CLK(NULL, "uart3_ick", "uart3_ick"), -DT_CLK(NULL, "uart4_ick", "uart4_ick"), DT_CLK(NULL, "gpt9_ick", "gpt9_ick"), DT_CLK(NULL, "gpt8_ick", "gpt8_ick"), DT_CLK(NULL, "gpt7_ick", "gpt7_ick"), NAK. This patch is actually only partially correct, it removes the uart4_ick alias for omap36xx also. It should be added back to the omap36xx clks array. Care to post a v2? Thankyou for the feedback. I'll update, but do not have a device to test. Hmm but isn't that entry already there for 36xx? So this just removes a duplicate for 36xx.. Tero, can you please check again, maybe I'm confused. uart4_ick wasn't there, we only had uart4_fck listed for omap36xx. -Tero Regars, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] clk: ti: fix dual-registration of uart4_ick
* Ben Dooks [150929 06:14]: > On 25/09/15 06:42, Tero Kristo wrote: > > On 09/23/2015 08:30 PM, Tony Lindgren wrote: > >> * Ben Dooks [150923 07:53]: > >>> On the OMAP AM3517 platform the uart4_ick gets registered > >>> twice, causing any power managment to /dev/ttyO3 to fail > >>> when trying to wake the device up. > >>> > >>> This solves the following oops: > >>> > >>> [] Unhandled fault: external abort on non-linefetch (0x1028) at > >>> 0xfa09e008 > >>> [] PC is at serial_omap_pm+0x48/0x15c > >>> [] LR is at _raw_spin_unlock_irqrestore+0x30/0x5c > >> > >> No uart4 on 34xx/35xx, that got introduced with 36xx so: > >> > >> Acked-by: Tony Lindgren > >> > >>> Signed-off-by: Ben Dooks > >>> --- > >>> drivers/clk/ti/clk-3xxx.c | 1 - > >>> 1 file changed, 1 deletion(-) > >>> > >>> diff --git a/drivers/clk/ti/clk-3xxx.c b/drivers/clk/ti/clk-3xxx.c > >>> index 5e12f32..2e7ef1f 100644 > >>> --- a/drivers/clk/ti/clk-3xxx.c > >>> +++ b/drivers/clk/ti/clk-3xxx.c > >>> @@ -374,7 +374,6 @@ static struct ti_dt_clk omap3xxx_clks[] = { > >>> DT_CLK(NULL, "gpio2_ick", "gpio2_ick"), > >>> DT_CLK(NULL, "wdt3_ick", "wdt3_ick"), > >>> DT_CLK(NULL, "uart3_ick", "uart3_ick"), > >>> -DT_CLK(NULL, "uart4_ick", "uart4_ick"), > >>> DT_CLK(NULL, "gpt9_ick", "gpt9_ick"), > >>> DT_CLK(NULL, "gpt8_ick", "gpt8_ick"), > >>> DT_CLK(NULL, "gpt7_ick", "gpt7_ick"), > > > > NAK. > > > > This patch is actually only partially correct, it removes the uart4_ick > > alias for omap36xx also. It should be added back to the omap36xx clks > > array. Care to post a v2? > > Thankyou for the feedback. I'll update, but do not have a device to test. Hmm but isn't that entry already there for 36xx? So this just removes a duplicate for 36xx.. Tero, can you please check again, maybe I'm confused. Regars, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] clk: ti: fix dual-registration of uart4_ick
On 25/09/15 06:42, Tero Kristo wrote: > On 09/23/2015 08:30 PM, Tony Lindgren wrote: >> * Ben Dooks [150923 07:53]: >>> On the OMAP AM3517 platform the uart4_ick gets registered >>> twice, causing any power managment to /dev/ttyO3 to fail >>> when trying to wake the device up. >>> >>> This solves the following oops: >>> >>> [] Unhandled fault: external abort on non-linefetch (0x1028) at >>> 0xfa09e008 >>> [] PC is at serial_omap_pm+0x48/0x15c >>> [] LR is at _raw_spin_unlock_irqrestore+0x30/0x5c >> >> No uart4 on 34xx/35xx, that got introduced with 36xx so: >> >> Acked-by: Tony Lindgren >> >>> Signed-off-by: Ben Dooks >>> --- >>> drivers/clk/ti/clk-3xxx.c | 1 - >>> 1 file changed, 1 deletion(-) >>> >>> diff --git a/drivers/clk/ti/clk-3xxx.c b/drivers/clk/ti/clk-3xxx.c >>> index 5e12f32..2e7ef1f 100644 >>> --- a/drivers/clk/ti/clk-3xxx.c >>> +++ b/drivers/clk/ti/clk-3xxx.c >>> @@ -374,7 +374,6 @@ static struct ti_dt_clk omap3xxx_clks[] = { >>> DT_CLK(NULL, "gpio2_ick", "gpio2_ick"), >>> DT_CLK(NULL, "wdt3_ick", "wdt3_ick"), >>> DT_CLK(NULL, "uart3_ick", "uart3_ick"), >>> -DT_CLK(NULL, "uart4_ick", "uart4_ick"), >>> DT_CLK(NULL, "gpt9_ick", "gpt9_ick"), >>> DT_CLK(NULL, "gpt8_ick", "gpt8_ick"), >>> DT_CLK(NULL, "gpt7_ick", "gpt7_ick"), > > NAK. > > This patch is actually only partially correct, it removes the uart4_ick > alias for omap36xx also. It should be added back to the omap36xx clks > array. Care to post a v2? Thankyou for the feedback. I'll update, but do not have a device to test. -- Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink - Providing Genius -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] clk: ti: fix dual-registration of uart4_ick
On 09/23/2015 08:30 PM, Tony Lindgren wrote: * Ben Dooks [150923 07:53]: On the OMAP AM3517 platform the uart4_ick gets registered twice, causing any power managment to /dev/ttyO3 to fail when trying to wake the device up. This solves the following oops: [] Unhandled fault: external abort on non-linefetch (0x1028) at 0xfa09e008 [] PC is at serial_omap_pm+0x48/0x15c [] LR is at _raw_spin_unlock_irqrestore+0x30/0x5c No uart4 on 34xx/35xx, that got introduced with 36xx so: Acked-by: Tony Lindgren Signed-off-by: Ben Dooks --- drivers/clk/ti/clk-3xxx.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/clk/ti/clk-3xxx.c b/drivers/clk/ti/clk-3xxx.c index 5e12f32..2e7ef1f 100644 --- a/drivers/clk/ti/clk-3xxx.c +++ b/drivers/clk/ti/clk-3xxx.c @@ -374,7 +374,6 @@ static struct ti_dt_clk omap3xxx_clks[] = { DT_CLK(NULL, "gpio2_ick", "gpio2_ick"), DT_CLK(NULL, "wdt3_ick", "wdt3_ick"), DT_CLK(NULL, "uart3_ick", "uart3_ick"), - DT_CLK(NULL, "uart4_ick", "uart4_ick"), DT_CLK(NULL, "gpt9_ick", "gpt9_ick"), DT_CLK(NULL, "gpt8_ick", "gpt8_ick"), DT_CLK(NULL, "gpt7_ick", "gpt7_ick"), NAK. This patch is actually only partially correct, it removes the uart4_ick alias for omap36xx also. It should be added back to the omap36xx clks array. Care to post a v2? -Tero -- 2.5.1 -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] clk: ti: fix dual-registration of uart4_ick
* Ben Dooks [150923 07:53]: > On the OMAP AM3517 platform the uart4_ick gets registered > twice, causing any power managment to /dev/ttyO3 to fail > when trying to wake the device up. > > This solves the following oops: > > [] Unhandled fault: external abort on non-linefetch (0x1028) at 0xfa09e008 > [] PC is at serial_omap_pm+0x48/0x15c > [] LR is at _raw_spin_unlock_irqrestore+0x30/0x5c No uart4 on 34xx/35xx, that got introduced with 36xx so: Acked-by: Tony Lindgren > Signed-off-by: Ben Dooks > --- > drivers/clk/ti/clk-3xxx.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/clk/ti/clk-3xxx.c b/drivers/clk/ti/clk-3xxx.c > index 5e12f32..2e7ef1f 100644 > --- a/drivers/clk/ti/clk-3xxx.c > +++ b/drivers/clk/ti/clk-3xxx.c > @@ -374,7 +374,6 @@ static struct ti_dt_clk omap3xxx_clks[] = { > DT_CLK(NULL, "gpio2_ick", "gpio2_ick"), > DT_CLK(NULL, "wdt3_ick", "wdt3_ick"), > DT_CLK(NULL, "uart3_ick", "uart3_ick"), > - DT_CLK(NULL, "uart4_ick", "uart4_ick"), > DT_CLK(NULL, "gpt9_ick", "gpt9_ick"), > DT_CLK(NULL, "gpt8_ick", "gpt8_ick"), > DT_CLK(NULL, "gpt7_ick", "gpt7_ick"), > -- > 2.5.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] clk: ti: fix dual-registration of uart4_ick
On Wed, Sep 23, 2015 at 03:48:34PM +0100, Ben Dooks wrote: > On the OMAP AM3517 platform the uart4_ick gets registered > twice, causing any power managment to /dev/ttyO3 to fail > when trying to wake the device up. > > This solves the following oops: > > [] Unhandled fault: external abort on non-linefetch (0x1028) at 0xfa09e008 > [] PC is at serial_omap_pm+0x48/0x15c > [] LR is at _raw_spin_unlock_irqrestore+0x30/0x5c > > Signed-off-by: Ben Dooks > --- > drivers/clk/ti/clk-3xxx.c | 1 - > 1 file changed, 1 deletion(-) This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read Documentation/stable_kernel_rules.txt for how to do this properly. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] clk: ti: fix dual-registration of uart4_ick
On the OMAP AM3517 platform the uart4_ick gets registered twice, causing any power managment to /dev/ttyO3 to fail when trying to wake the device up. This solves the following oops: [] Unhandled fault: external abort on non-linefetch (0x1028) at 0xfa09e008 [] PC is at serial_omap_pm+0x48/0x15c [] LR is at _raw_spin_unlock_irqrestore+0x30/0x5c Signed-off-by: Ben Dooks --- drivers/clk/ti/clk-3xxx.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/clk/ti/clk-3xxx.c b/drivers/clk/ti/clk-3xxx.c index 5e12f32..2e7ef1f 100644 --- a/drivers/clk/ti/clk-3xxx.c +++ b/drivers/clk/ti/clk-3xxx.c @@ -374,7 +374,6 @@ static struct ti_dt_clk omap3xxx_clks[] = { DT_CLK(NULL, "gpio2_ick", "gpio2_ick"), DT_CLK(NULL, "wdt3_ick", "wdt3_ick"), DT_CLK(NULL, "uart3_ick", "uart3_ick"), - DT_CLK(NULL, "uart4_ick", "uart4_ick"), DT_CLK(NULL, "gpt9_ick", "gpt9_ick"), DT_CLK(NULL, "gpt8_ick", "gpt8_ick"), DT_CLK(NULL, "gpt7_ick", "gpt7_ick"), -- 2.5.1 -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html