Re: [PATCH 0/3] OMAPDSS: HDMI: Interrupt and PHY state handling support

2012-03-27 Thread Tomi Valkeinen
On Tue, 2012-03-20 at 18:45 +0530, mythr...@ti.com wrote:
 From: Mythri P K mythr...@ti.com
 
 Add support for handling the DSS_HDMI interrupt in HDMI, A line that serves to
 notify HDMI of status change in PHY, PLL and CORE based on the registration.
 Also logic to support enabling of the PHY in TX_ON state only when a 
 PHY_CONNECT
 which would make sure that TMDS lines are high before putting it in TX_ON 
 state.
 
 Mythri P K (3):
   OMAPDSS: HDMI: support for interrupt enabling
   OMAPDSS: HDMI: Add support for DSS_HDMI Interrupt
   OMAPDSS: HDMI: wait for TMDS to be high before putting phy in TX_ON

Sorry, but this patch set is quite bad.

First of all, the subject on your third patch is again cut short. How do
you even do that? The subject seems to be fine above. I've never seen
other people do that, but you somehow manage to do it all the time. So,
please, read the git manual, fix your environment, your way of working,
or whatever is causing this so that we'll never see it again.

Then, the intro text above is rather confusing. Are there words missing
around the part with PHY_CONNECT? Please spend more time on the
descriptions, and possibly ask someone to proof-read them so that at
least there aren't words missing and they are somehow understandable.

I'll comment on other things in later mails.

 Tomi



signature.asc
Description: This is a digitally signed message part


[PATCH 0/3] OMAPDSS: HDMI: Interrupt and PHY state handling support

2012-03-20 Thread mythripk
From: Mythri P K mythr...@ti.com

Add support for handling the DSS_HDMI interrupt in HDMI, A line that serves to
notify HDMI of status change in PHY, PLL and CORE based on the registration.
Also logic to support enabling of the PHY in TX_ON state only when a PHY_CONNECT
which would make sure that TMDS lines are high before putting it in TX_ON state.

Mythri P K (3):
  OMAPDSS: HDMI: support for interrupt enabling
  OMAPDSS: HDMI: Add support for DSS_HDMI Interrupt
  OMAPDSS: HDMI: wait for TMDS to be high before putting phy in TX_ON

 drivers/video/omap2/dss/dss_features.c|1 +
 drivers/video/omap2/dss/hdmi.c|   21 +
 drivers/video/omap2/dss/ti_hdmi.h |   20 +
 drivers/video/omap2/dss/ti_hdmi_4xxx_ip.c |  117 +++-
 drivers/video/omap2/dss/ti_hdmi_4xxx_ip.h |3 +
 5 files changed, 157 insertions(+), 5 deletions(-)

-- 
1.7.5.4

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html