Re: [PATCH 0/4] Updates on mcbsp driver (take #2)
Jarkko, I've been using this patch with good results while developing an alsa soc driver for the 35XX EVM and beagleboard. Do you have plans to to officially submit this patch (or a more recent version of it)? Steve On Tue, May 20, 2008 at 4:21 AM, Jarkko Nikula [EMAIL PROTECTED] wrote: On Mon, 19 May 2008 11:09:43 -0400 ext Eduardo Valentin [EMAIL PROTECTED] wrote: Hi Steve, This series is basically a simple transformation of currect mcbsp code to a platform driver and a separation of machine specific code. It should work for omap1 and omap2 (what is currently supported). But it should add basic support for omap3 mcbps 1 and 2. Chandra will send his patches on top of this series to add more features for omap3. For those who are keen to try ASoC on OMAP3 might want to try attached patch on top of Eduardo's set. I'll prepare better one when there are more ports defined. E.g. there is no need to separe omap34xx_dma_regs table since request numbers are the same between OMAP2 and OMAP3. Jarkko -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH 0/4] Updates on mcbsp driver (take #2)
Acking mcbsp patch which transforms cureent mcbsp into a platform driver. Regards, Chandra -Original Message- From: Eduardo Valentin [mailto:[EMAIL PROTECTED] Sent: Tuesday, May 06, 2008 2:53 AM To: linux-omap@vger.kernel.org Cc: Tony Lindgren; Chandra shekhar; Eduardo Valentin Subject: [PATCH 0/4] Updates on mcbsp driver (take #2) From: Eduardo Valentin [EMAIL PROTECTED] Hi Tony, Here is the updated version of my previous patches. DMA and IRQ definitions were left as they are. Chandra is going to send his work on top of this series. This patch series updates mcbsp driver by transforming it into a platform driver. This is a very initial implementation. Basically it moves machine specific code to their correct place and creates the platform driver necessary structures. It must be working for previous boards. For omap34xx it should work for mcbsp 1 and 2. In order to do not break other places, I tryied to do not change previous API. But future improvements are needed. Clock definitions for mcbsp 1 and 2 were also modified to add correct support for omap34xx. Comments are wellcome. Cheers, Eduardo Valentin (4): PLAT-OMAP: MCBSP: Tranform into platform driver MACH-OMAP1: MCBSP: Add support for mcbsp on mach-omap1 Fix mcbsp clock definition on clock34xx.h MACH-OMAP2: MCBSP: Add support for mcbsp on mach-omap2 arch/arm/mach-omap1/Makefile |2 + arch/arm/mach-omap1/mcbsp.c | 165 + arch/arm/mach-omap2/Makefile |2 + arch/arm/mach-omap2/clock34xx.h | 30 ++- arch/arm/mach-omap2/mcbsp.c | 105 ++ arch/arm/plat-omap/devices.c | 45 +++ arch/arm/plat-omap/mcbsp.c| 660 ++--- include/asm-arm/arch-omap/mcbsp.h | 73 - 8 files changed, 661 insertions(+), 421 deletions(-) create mode 100644 arch/arm/mach-omap1/mcbsp.c create mode 100644 arch/arm/mach-omap2/mcbsp.c -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/4] Updates on mcbsp driver (take #2)
On Mon, 19 May 2008 11:09:43 -0400
ext Eduardo Valentin [EMAIL PROTECTED] wrote:
Hi Steve,
This series is basically a simple transformation of currect mcbsp code
to a platform
driver and a separation of machine specific code.
It should work for omap1 and omap2 (what is currently supported). But
it should add basic support for omap3
mcbps 1 and 2. Chandra will send his patches on top of this series to
add more features for omap3.
For those who are keen to try ASoC on OMAP3 might want to try attached
patch on top of Eduardo's set.
I'll prepare better one when there are more ports defined. E.g.
there is no need to separe omap34xx_dma_regs table since request
numbers are the same between OMAP2 and OMAP3.
Jarkko
From a1dbb6dd28e9815a307b87b8d96dcf371d6cfd58 Mon Sep 17 00:00:00 2001
From: Jarkko Nikula [EMAIL PROTECTED]
Date: Mon, 19 May 2008 13:24:41 +0300
Subject: [PATCH] ASoC: OMAP: Add basic support for OMAP34xx in McBSP DAI driver
This adds support for OMAP34xx McBSP port 1 and 2.
Signed-off-by: Jarkko Nikula [EMAIL PROTECTED]
---
sound/soc/omap/omap-mcbsp.c | 20 +++-
1 files changed, 19 insertions(+), 1 deletions(-)
diff --git a/sound/soc/omap/omap-mcbsp.c b/sound/soc/omap/omap-mcbsp.c
index 40d87e6..8e6ec9d 100644
--- a/sound/soc/omap/omap-mcbsp.c
+++ b/sound/soc/omap/omap-mcbsp.c
@@ -99,6 +99,21 @@ static const unsigned long omap2420_mcbsp_port[][2] = {
static const int omap2420_dma_reqs[][2] = {};
static const unsigned long omap2420_mcbsp_port[][2] = {};
#endif
+#if defined(CONFIG_ARCH_OMAP34XX)
+static const int omap34xx_dma_reqs[][2] = {
+ { OMAP24XX_DMA_MCBSP1_TX, OMAP24XX_DMA_MCBSP1_RX },
+ { OMAP24XX_DMA_MCBSP2_TX, OMAP24XX_DMA_MCBSP2_RX },
+};
+static const unsigned long omap34xx_mcbsp_port[][2] = {
+ { OMAP34XX_MCBSP1_BASE + OMAP_MCBSP_REG_DXR2,
+ OMAP34XX_MCBSP1_BASE + OMAP_MCBSP_REG_DRR2 },
+ { OMAP34XX_MCBSP2_BASE + OMAP_MCBSP_REG_DXR2,
+ OMAP34XX_MCBSP2_BASE + OMAP_MCBSP_REG_DRR2 },
+};
+#else
+static const int omap34xx_dma_reqs[][2] = {};
+static const unsigned long omap34xx_mcbsp_port[][2] = {};
+#endif
static int omap_mcbsp_dai_startup(struct snd_pcm_substream *substream)
{
@@ -169,9 +184,12 @@ static int omap_mcbsp_dai_hw_params(struct snd_pcm_substream *substream,
} else if (cpu_is_omap2420()) {
dma = omap2420_dma_reqs[bus_id][substream-stream];
port = omap2420_mcbsp_port[bus_id][substream-stream];
+ } else if (cpu_is_omap343x()) {
+ dma = omap34xx_dma_reqs[bus_id][substream-stream];
+ port = omap34xx_mcbsp_port[bus_id][substream-stream];
} else {
/*
- * TODO: Add support for 2430 and 3430
+ * TODO: Add support for 2430
*/
return -ENODEV;
}
--
1.5.5.1
Re: [PATCH 0/4] Updates on mcbsp driver (take #2)
Hi Steve, This series is basically a simple transformation of currect mcbsp code to a platform driver and a separation of machine specific code. It should work for omap1 and omap2 (what is currently supported). But it should add basic support for omap3 mcbps 1 and 2. Chandra will send his patches on top of this series to add more features for omap3. On Mon, May 19, 2008 at 10:26 AM, Steve Sakoman [EMAIL PROTECTED] wrote: What's the current status of this patch series? Haven't seen too much discussion. I've started work on a SoC driver for the OMAP3 EVM and want to make sure I'm using the latest. Regards, Steve On Mon, May 5, 2008 at 2:23 PM, Eduardo Valentin [EMAIL PROTECTED] wrote: From: Eduardo Valentin [EMAIL PROTECTED] Hi Tony, Here is the updated version of my previous patches. DMA and IRQ definitions were left as they are. Chandra is going to send his work on top of this series. This patch series updates mcbsp driver by transforming it into a platform driver. This is a very initial implementation. Basically it moves machine specific code to their correct place and creates the platform driver necessary structures. It must be working for previous boards. For omap34xx it should work for mcbsp 1 and 2. In order to do not break other places, I tryied to do not change previous API. But future improvements are needed. Clock definitions for mcbsp 1 and 2 were also modified to add correct support for omap34xx. Comments are wellcome. Cheers, Eduardo Valentin (4): PLAT-OMAP: MCBSP: Tranform into platform driver MACH-OMAP1: MCBSP: Add support for mcbsp on mach-omap1 Fix mcbsp clock definition on clock34xx.h MACH-OMAP2: MCBSP: Add support for mcbsp on mach-omap2 arch/arm/mach-omap1/Makefile |2 + arch/arm/mach-omap1/mcbsp.c | 165 + arch/arm/mach-omap2/Makefile |2 + arch/arm/mach-omap2/clock34xx.h | 30 ++- arch/arm/mach-omap2/mcbsp.c | 105 ++ arch/arm/plat-omap/devices.c | 45 +++ arch/arm/plat-omap/mcbsp.c| 660 ++--- include/asm-arm/arch-omap/mcbsp.h | 73 - 8 files changed, 661 insertions(+), 421 deletions(-) create mode 100644 arch/arm/mach-omap1/mcbsp.c create mode 100644 arch/arm/mach-omap2/mcbsp.c -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html -- Eduardo Bezerra Valentin -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/4] Updates on mcbsp driver (take #2)
Hi, * Eduardo Valentin [EMAIL PROTECTED] [080505 14:24]: From: Eduardo Valentin [EMAIL PROTECTED] Hi Tony, Here is the updated version of my previous patches. DMA and IRQ definitions were left as they are. Chandra is going to send his work on top of this series. This patch series updates mcbsp driver by transforming it into a platform driver. This is a very initial implementation. Basically it moves machine specific code to their correct place and creates the platform driver necessary structures. It must be working for previous boards. For omap34xx it should work for mcbsp 1 and 2. In order to do not break other places, I tryied to do not change previous API. But future improvements are needed. Clock definitions for mcbsp 1 and 2 were also modified to add correct support for omap34xx. Comments are wellcome. Chandra, do these patches look OK to you from your patches point of view? Tony Cheers, Eduardo Valentin (4): PLAT-OMAP: MCBSP: Tranform into platform driver MACH-OMAP1: MCBSP: Add support for mcbsp on mach-omap1 Fix mcbsp clock definition on clock34xx.h MACH-OMAP2: MCBSP: Add support for mcbsp on mach-omap2 arch/arm/mach-omap1/Makefile |2 + arch/arm/mach-omap1/mcbsp.c | 165 + arch/arm/mach-omap2/Makefile |2 + arch/arm/mach-omap2/clock34xx.h | 30 ++- arch/arm/mach-omap2/mcbsp.c | 105 ++ arch/arm/plat-omap/devices.c | 45 +++ arch/arm/plat-omap/mcbsp.c| 660 ++--- include/asm-arm/arch-omap/mcbsp.h | 73 - 8 files changed, 661 insertions(+), 421 deletions(-) create mode 100644 arch/arm/mach-omap1/mcbsp.c create mode 100644 arch/arm/mach-omap2/mcbsp.c -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 0/4] Updates on mcbsp driver (take #2)
From: Eduardo Valentin [EMAIL PROTECTED] Hi Tony, Here is the updated version of my previous patches. DMA and IRQ definitions were left as they are. Chandra is going to send his work on top of this series. This patch series updates mcbsp driver by transforming it into a platform driver. This is a very initial implementation. Basically it moves machine specific code to their correct place and creates the platform driver necessary structures. It must be working for previous boards. For omap34xx it should work for mcbsp 1 and 2. In order to do not break other places, I tryied to do not change previous API. But future improvements are needed. Clock definitions for mcbsp 1 and 2 were also modified to add correct support for omap34xx. Comments are wellcome. Cheers, Eduardo Valentin (4): PLAT-OMAP: MCBSP: Tranform into platform driver MACH-OMAP1: MCBSP: Add support for mcbsp on mach-omap1 Fix mcbsp clock definition on clock34xx.h MACH-OMAP2: MCBSP: Add support for mcbsp on mach-omap2 arch/arm/mach-omap1/Makefile |2 + arch/arm/mach-omap1/mcbsp.c | 165 + arch/arm/mach-omap2/Makefile |2 + arch/arm/mach-omap2/clock34xx.h | 30 ++- arch/arm/mach-omap2/mcbsp.c | 105 ++ arch/arm/plat-omap/devices.c | 45 +++ arch/arm/plat-omap/mcbsp.c| 660 ++--- include/asm-arm/arch-omap/mcbsp.h | 73 - 8 files changed, 661 insertions(+), 421 deletions(-) create mode 100644 arch/arm/mach-omap1/mcbsp.c create mode 100644 arch/arm/mach-omap2/mcbsp.c -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
