Re: [PATCH 0/5] staging: tidspbridge: for 3.9
On Mon, Jan 21, 2013 at 10:25:24AM +0300, Dan Carpenter wrote: On Thu, Jan 17, 2013 at 04:47:46PM -0800, Greg Kroah-Hartman wrote: On Thu, Jan 10, 2013 at 03:36:57AM -0600, Omar Ramirez Luna wrote: Patches for staging-next, fixing comments and suggestions provided by Chen Gang. There is an additional scm patch, that removes hardcoded defines related to direct register handling for SCM, it was dependent on changes that already made it to mainline. What is the status on getting this out of the staging tree? What needs to be done still? Why can't tidspbridge be built as a module? The Kconfig help files aren't very informative. Huh. Ignore me. I don't know what I was looking at before. Both the things I said were wrong. Sorry for the noise. regards, dan carpenter -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/5] staging: tidspbridge: for 3.9
Hi Greg, On Thu, Jan 17, 2013 at 6:47 PM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Thu, Jan 10, 2013 at 03:36:57AM -0600, Omar Ramirez Luna wrote: Patches for staging-next, fixing comments and suggestions provided by Chen Gang. There is an additional scm patch, that removes hardcoded defines related to direct register handling for SCM, it was dependent on changes that already made it to mainline. What is the status on getting this out of the staging tree? I'm currently working to do this. What needs to be done still? - There is a tasklet that I'm working to remove. - Some portions could be fitted into remoteproc (as Tony mentions). - Migration to generic iommu framework. - Need to rework patches to use request_firmware. - And a thorough cleanup to get rid of if-else nesting. At some point I should be able to work on all the items (since I have the time), but any help is appreciated. Cheers, Omar -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/5] staging: tidspbridge: for 3.9
Hi Tony, On Thu, Jan 17, 2013 at 8:01 PM, Tony Lindgren t...@atomide.com wrote: * Greg Kroah-Hartman gre...@linuxfoundation.org [130117 16:51]: On Thu, Jan 10, 2013 at 03:36:57AM -0600, Omar Ramirez Luna wrote: Patches for staging-next, fixing comments and suggestions provided by Chen Gang. There is an additional scm patch, that removes hardcoded defines related to direct register handling for SCM, it was dependent on changes that already made it to mainline. What is the status on getting this out of the staging tree? What needs to be done still? Omar, please correct me if I'm wrong. This thing should be reimplemented using remoteproc AFAIK. tidspbridge might be able to use remoteproc, however it can't get rid of all the infrastructure to support the SN interface, given that the SN and firmware are distributed as binaries. OTOH, remoteproc can also implement support for omap3 dsp, but the major drawback is that we will lose the distributed codecs along with gst-dsp support. But I doubt that anybody is working on making it happen? I'm not aware of anybody working on remoteproc for omap3 (eventually I could pick it up) but I'm more focused on getting tidspbridge out of staging right now. Cheers, Omar -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/5] staging: tidspbridge: for 3.9
On Sun, Jan 20, 2013 at 05:45:16PM -0600, Omar Ramirez Luna wrote: Hi Greg, On Thu, Jan 17, 2013 at 6:47 PM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Thu, Jan 10, 2013 at 03:36:57AM -0600, Omar Ramirez Luna wrote: Patches for staging-next, fixing comments and suggestions provided by Chen Gang. There is an additional scm patch, that removes hardcoded defines related to direct register handling for SCM, it was dependent on changes that already made it to mainline. What is the status on getting this out of the staging tree? I'm currently working to do this. What needs to be done still? - There is a tasklet that I'm working to remove. - Some portions could be fitted into remoteproc (as Tony mentions). - Migration to generic iommu framework. - Need to rework patches to use request_firmware. - And a thorough cleanup to get rid of if-else nesting. That looks good, care to update the TODO file for the driver in the kernel to reflect this? thanks, greg k-h -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/5] staging: tidspbridge: for 3.9
On Sun, Jan 20, 2013 at 5:51 PM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: That looks good, care to update the TODO file for the driver in the kernel to reflect this? I'll update it. Cheers, Omar -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/5] staging: tidspbridge: for 3.9
On Thu, Jan 17, 2013 at 04:47:46PM -0800, Greg Kroah-Hartman wrote: On Thu, Jan 10, 2013 at 03:36:57AM -0600, Omar Ramirez Luna wrote: Patches for staging-next, fixing comments and suggestions provided by Chen Gang. There is an additional scm patch, that removes hardcoded defines related to direct register handling for SCM, it was dependent on changes that already made it to mainline. What is the status on getting this out of the staging tree? What needs to be done still? Why can't tidspbridge be built as a module? The Kconfig help files aren't very informative. regards, dan carpenter -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/5] staging: tidspbridge: for 3.9
On Thu, Jan 10, 2013 at 03:36:57AM -0600, Omar Ramirez Luna wrote: Patches for staging-next, fixing comments and suggestions provided by Chen Gang. There is an additional scm patch, that removes hardcoded defines related to direct register handling for SCM, it was dependent on changes that already made it to mainline. What is the status on getting this out of the staging tree? What needs to be done still? thanks, greg k-h -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/5] staging: tidspbridge: for 3.9
* Greg Kroah-Hartman gre...@linuxfoundation.org [130117 16:51]: On Thu, Jan 10, 2013 at 03:36:57AM -0600, Omar Ramirez Luna wrote: Patches for staging-next, fixing comments and suggestions provided by Chen Gang. There is an additional scm patch, that removes hardcoded defines related to direct register handling for SCM, it was dependent on changes that already made it to mainline. What is the status on getting this out of the staging tree? What needs to be done still? Omar, please correct me if I'm wrong. This thing should be reimplemented using remoteproc AFAIK. But I doubt that anybody is working on making it happen? Regards, Tony -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 0/5] staging: tidspbridge: for 3.9
Patches for staging-next, fixing comments and suggestions provided by Chen Gang. There is an additional scm patch, that removes hardcoded defines related to direct register handling for SCM, it was dependent on changes that already made it to mainline. Omar Ramirez Luna (5): staging: tidspbridge: fix potential array out of bounds write staging: tidspbridge: fix memory corruption on long string names staging: tidspbridge: fix uninitialized variable sym_name staging: tidspbridge: use scm functions to set boot address and mode staging: tidspbridge: remove unused code to handle iva_img drivers/staging/tidspbridge/core/tiomap3430.c | 34 --- .../staging/tidspbridge/include/dspbridge/proc.h |2 - drivers/staging/tidspbridge/rmgr/dbdcd.c |3 +- drivers/staging/tidspbridge/rmgr/drv_interface.c |1 - drivers/staging/tidspbridge/rmgr/nldr.c|6 ++- drivers/staging/tidspbridge/rmgr/node.c| 12 +++--- drivers/staging/tidspbridge/rmgr/proc.c|6 +--- 7 files changed, 19 insertions(+), 45 deletions(-) -- 1.7.4.4 -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
