Re: [PATCH 0/7] crypto: omap-sham updates
On Sat, Oct 20, 2012 at 07:34:51PM +, Paul Walmsley wrote: On Fri, 19 Oct 2012, Mark A. Greer wrote: From: Mark A. Greer mgr...@animalcreek.com This series updates the crypto omap-sham driver and supporting infrastructure. Looks pretty good; this will make it easier for us to migrate the omap_hwmod code to a LDM bus. Will reply to the original patches with a few comments and questions. One general comment - for us to merge these through the OMAP tree, we'll need acks from the hardware crypto folks. AFAIK they are: CRYPTO API M: Herbert Xu herb...@gondor.apana.org.au M: David S. Miller da...@davemloft.net L: linux-cry...@vger.kernel.org T: git git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6.git S: Maintained F: Documentation/crypto/ F: arch/*/crypto/ F: crypto/ F: drivers/crypto/ F: include/crypto/ So it would be helpful if you could send those patches along to those people and lists too, and ask them for acks. I will do that. Thanks for your feedback. Mark -- -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/7] crypto: omap-sham updates
On Sun, Oct 21, 2012 at 11:58:36AM +0530, Santosh Shilimkar wrote: Mark, Hi Santosh. On Saturday 20 October 2012 03:23 AM, Mark A. Greer wrote: From: Mark A. Greer mgr...@animalcreek.com This series updates the crypto omap-sham driver and supporting infrastructure. Notes: a) Based on current k.o. c9623de (Merge branch 'v4l_for_linus' of git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media) b) These have only been tested on an omap2420 h4 and an am37x evm. If you have different hardware available and a few minutes, please test them. A quick and easy test is to enable tcrypt as a module (CONFIG_CRYPTO_TEST=m), boot, then run 'modprobe tcrypt sec=2 mode=403'. 'CONFIG_CRYPTO_SHA1' and 'CONFIG_CRYPTO_DEV_OMAP_SHAM' also have to be enabled. A quick 'grep omap-sham /proc/interrupts' will tell you if the omap-sham driver was really used. c) To test these patches, you will likely need... i) The patch included here: http://marc.info/?l=kernel-janitorsm=134910841909057w=2 ii) This patch from linux-omap/master: 27615a9 (ARM: OMAP: Trivial driver changes to remove include plat/cpu.h) iii) This patch from Paul Walmsley: http://www.spinics.net/lists/linux-omap/msg79436.html d) If you prefer, a version you can test is available at g...@github.com:mgreeraz/linux-mag.git mag/wip/crypto-test e) There is a reduction in DMA performance after switching to dmaengine (see http://www.spinics.net/lists/linux-omap/msg79855.html) f) Many thanks to Jon Hunter for testing on his omap2420 h4. Mark A. Greer (7): ARM: OMAP2xxx: hwmod: Convert SHAM crypto device data to hwmod ARM: OMAP2xxx: hwmod: Add DMA information for SHAM module ARM: OMAP3xxx: hwmod: Convert SHAM crypto device data to hwmod ARM: OMAP2+: Remove unnecessary message when no SHA IP is present crypto: omap-sham: Convert to use pm_runtime API crypto: omap-sham: Add code to use dmaengine API crypto: omap_sham: Remove usage of private DMA API Thanks for the series and oveall its looks pretty good to me. The DMA performance is understandable with need of PREFETCH support in OMAP DMA engine driver. IIRC, crypto was the only driver used this feature. That's correct. From the history mostly we need to restrict the prefetch usage to applicable client driver like crypto and hence adding such parameter/api support might be the direction to go forward. Lets see what Peter reports for audio as discussed on other thread. I agree. I'm looking forward to hearing from Peter on this too. Mark -- -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/7] crypto: omap-sham updates
Mark, On Saturday 20 October 2012 03:23 AM, Mark A. Greer wrote: From: Mark A. Greer mgr...@animalcreek.com This series updates the crypto omap-sham driver and supporting infrastructure. Notes: a) Based on current k.o. c9623de (Merge branch 'v4l_for_linus' of git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media) b) These have only been tested on an omap2420 h4 and an am37x evm. If you have different hardware available and a few minutes, please test them. A quick and easy test is to enable tcrypt as a module (CONFIG_CRYPTO_TEST=m), boot, then run 'modprobe tcrypt sec=2 mode=403'. 'CONFIG_CRYPTO_SHA1' and 'CONFIG_CRYPTO_DEV_OMAP_SHAM' also have to be enabled. A quick 'grep omap-sham /proc/interrupts' will tell you if the omap-sham driver was really used. c) To test these patches, you will likely need... i) The patch included here: http://marc.info/?l=kernel-janitorsm=134910841909057w=2 ii) This patch from linux-omap/master: 27615a9 (ARM: OMAP: Trivial driver changes to remove include plat/cpu.h) iii) This patch from Paul Walmsley: http://www.spinics.net/lists/linux-omap/msg79436.html d) If you prefer, a version you can test is available at g...@github.com:mgreeraz/linux-mag.git mag/wip/crypto-test e) There is a reduction in DMA performance after switching to dmaengine (see http://www.spinics.net/lists/linux-omap/msg79855.html) f) Many thanks to Jon Hunter for testing on his omap2420 h4. Mark A. Greer (7): ARM: OMAP2xxx: hwmod: Convert SHAM crypto device data to hwmod ARM: OMAP2xxx: hwmod: Add DMA information for SHAM module ARM: OMAP3xxx: hwmod: Convert SHAM crypto device data to hwmod ARM: OMAP2+: Remove unnecessary message when no SHA IP is present crypto: omap-sham: Convert to use pm_runtime API crypto: omap-sham: Add code to use dmaengine API crypto: omap_sham: Remove usage of private DMA API Thanks for the series and oveall its looks pretty good to me. The DMA performance is understandable with need of PREFETCH support in OMAP DMA engine driver. IIRC, crypto was the only driver used this feature. From the history mostly we need to restrict the prefetch usage to applicable client driver like crypto and hence adding such parameter/api support might be the direction to go forward. Lets see what Peter reports for audio as discussed on other thread. Regards Santosh -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/7] crypto: omap-sham updates
On Fri, 19 Oct 2012, Mark A. Greer wrote: From: Mark A. Greer mgr...@animalcreek.com This series updates the crypto omap-sham driver and supporting infrastructure. Looks pretty good; this will make it easier for us to migrate the omap_hwmod code to a LDM bus. Will reply to the original patches with a few comments and questions. One general comment - for us to merge these through the OMAP tree, we'll need acks from the hardware crypto folks. AFAIK they are: CRYPTO API M: Herbert Xu herb...@gondor.apana.org.au M: David S. Miller da...@davemloft.net L: linux-cry...@vger.kernel.org T: git git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6.git S: Maintained F: Documentation/crypto/ F: arch/*/crypto/ F: crypto/ F: drivers/crypto/ F: include/crypto/ So it would be helpful if you could send those patches along to those people and lists too, and ask them for acks. - Paul -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 0/7] crypto: omap-sham updates
From: Mark A. Greer mgr...@animalcreek.com This series updates the crypto omap-sham driver and supporting infrastructure. Notes: a) Based on current k.o. c9623de (Merge branch 'v4l_for_linus' of git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media) b) These have only been tested on an omap2420 h4 and an am37x evm. If you have different hardware available and a few minutes, please test them. A quick and easy test is to enable tcrypt as a module (CONFIG_CRYPTO_TEST=m), boot, then run 'modprobe tcrypt sec=2 mode=403'. 'CONFIG_CRYPTO_SHA1' and 'CONFIG_CRYPTO_DEV_OMAP_SHAM' also have to be enabled. A quick 'grep omap-sham /proc/interrupts' will tell you if the omap-sham driver was really used. c) To test these patches, you will likely need... i) The patch included here: http://marc.info/?l=kernel-janitorsm=134910841909057w=2 ii) This patch from linux-omap/master: 27615a9 (ARM: OMAP: Trivial driver changes to remove include plat/cpu.h) iii) This patch from Paul Walmsley: http://www.spinics.net/lists/linux-omap/msg79436.html d) If you prefer, a version you can test is available at g...@github.com:mgreeraz/linux-mag.git mag/wip/crypto-test e) There is a reduction in DMA performance after switching to dmaengine (see http://www.spinics.net/lists/linux-omap/msg79855.html) f) Many thanks to Jon Hunter for testing on his omap2420 h4. Mark A. Greer (7): ARM: OMAP2xxx: hwmod: Convert SHAM crypto device data to hwmod ARM: OMAP2xxx: hwmod: Add DMA information for SHAM module ARM: OMAP3xxx: hwmod: Convert SHAM crypto device data to hwmod ARM: OMAP2+: Remove unnecessary message when no SHA IP is present crypto: omap-sham: Convert to use pm_runtime API crypto: omap-sham: Add code to use dmaengine API crypto: omap_sham: Remove usage of private DMA API arch/arm/mach-omap2/clock2420_data.c | 1 + arch/arm/mach-omap2/clock2430_data.c | 1 + arch/arm/mach-omap2/clock3xxx_data.c | 1 + arch/arm/mach-omap2/devices.c | 81 +++-- arch/arm/mach-omap2/omap_hwmod_2420_data.c | 1 + arch/arm/mach-omap2/omap_hwmod_2430_data.c | 1 + .../mach-omap2/omap_hwmod_2xxx_interconnect_data.c | 18 ++ arch/arm/mach-omap2/omap_hwmod_2xxx_ipblock_data.c | 43 + arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 60 +++ arch/arm/mach-omap2/omap_hwmod_common_data.h | 2 + drivers/crypto/omap-sham.c | 192 +++-- 11 files changed, 250 insertions(+), 151 deletions(-) -- 1.7.12 -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
