Re: [PATCH 00/50] staging: omap-thermal: several code refactoring
Greg, Dan, On 16-03-2013 12:16, Greg KH wrote: On Sat, Mar 16, 2013 at 08:46:03AM -0400, Eduardo Valentin wrote: Hello Dan, On 16-03-2013 05:05, Dan Carpenter wrote: I've reviewed this set. I hate to make people redo whole patchset sets, and I hate re-reviewing code. Obviously, I don't really like the bunny hop patches and I'm trying to discourage that going forward. ;P But I wouldn't say it's a Redo the whole thing kind of problem. Could just resend patch 33 and 47? You should probably be able to redo those without changing the rest. I could of course change them if the comment is better clarified. As I mentioned as reply to one of your comments, those changes are following what is suggested in CodingStyle file. I can of course send a diff on top of 33, to fix the introduce bug. For 47, I'm not sure the comment is fully applicable. As I've taken all of these already (sorry Dan, I was fast and I didn't review them as well as you did), you will have to just send incremental patches on top of the whole series in order for me to be able to apply them. No issues here, I am going to send soon incremental patches, copying Dan, to fix the above mentioned issues on 33 and 47. thanks, greg k-h -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 00/50] staging: omap-thermal: several code refactoring
I've reviewed this set. I hate to make people redo whole patchset sets, and I hate re-reviewing code. Obviously, I don't really like the bunny hop patches and I'm trying to discourage that going forward. ;P But I wouldn't say it's a Redo the whole thing kind of problem. Could just resend patch 33 and 47? You should probably be able to redo those without changing the rest. regards, dan carpenter -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 00/50] staging: omap-thermal: several code refactoring
Hello Dan, On 16-03-2013 05:05, Dan Carpenter wrote: I've reviewed this set. I hate to make people redo whole patchset sets, and I hate re-reviewing code. Obviously, I don't really like the bunny hop patches and I'm trying to discourage that going forward. ;P But I wouldn't say it's a Redo the whole thing kind of problem. Could just resend patch 33 and 47? You should probably be able to redo those without changing the rest. I could of course change them if the comment is better clarified. As I mentioned as reply to one of your comments, those changes are following what is suggested in CodingStyle file. I can of course send a diff on top of 33, to fix the introduce bug. For 47, I'm not sure the comment is fully applicable. regards, dan carpenter -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 00/50] staging: omap-thermal: several code refactoring
On Sat, Mar 16, 2013 at 08:46:03AM -0400, Eduardo Valentin wrote: Hello Dan, On 16-03-2013 05:05, Dan Carpenter wrote: I've reviewed this set. I hate to make people redo whole patchset sets, and I hate re-reviewing code. Obviously, I don't really like the bunny hop patches and I'm trying to discourage that going forward. ;P But I wouldn't say it's a Redo the whole thing kind of problem. Could just resend patch 33 and 47? You should probably be able to redo those without changing the rest. I could of course change them if the comment is better clarified. As I mentioned as reply to one of your comments, those changes are following what is suggested in CodingStyle file. I can of course send a diff on top of 33, to fix the introduce bug. For 47, I'm not sure the comment is fully applicable. As I've taken all of these already (sorry Dan, I was fast and I didn't review them as well as you did), you will have to just send incremental patches on top of the whole series in order for me to be able to apply them. thanks, greg k-h -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 00/50] staging: omap-thermal: several code refactoring
Hello Greg, Here is a series of patches improving the way the omap-thermal driver is written. There is a mix of added documentation, with functions rewrites and cleanups regarding coding style. I am also adding myself as maintainer of this driver. Next I will be still improving the code in this way, but also working on the policy readiness and testing on other devices. I will probably rename the driver also to something that reflect the support to AMxx devices as well. Hopefully, it should be soon ready for moving to drivers/thermal/. All these are based on your staging/staging-next branch. For those interested in testing and trying the driver, these patches are also available, as usual, here: g...@gitorious.org:thermal-framework/thermal-framework.git thermal_work/omap/omap-thermal-optimizations https://git.gitorious.org/thermal-framework/thermal-framework.git thermal_work/omap/omap-thermal-optimizations For lo guys, I will appreciate your testing results on other devices. Cheers, Eduardo Valentin (50): staging: omap-thermal: use BIT() macro staging: omap-thermal: remove unused _SHIFT macros staging: omap-thermal: create header for register, bitfields and definitions staging: omap-thermal: update documentation of omap-bandgap.h staging: omap-thermal: style cleanup on omap-bandgap.c staging: omap-thermal: fix error checking staging: omap-thermal: introduce RMW_BITS macro staging: omap-thermal: add documentation for register access functions staging: omap-thermal: make a omap_bandgap_power with only one exit point staging: omap-thermal: add documentation for omap_bandgap_power staging: omap-thermal: add documentation for omap_bandgap_read_temp staging: omap-thermal: rename talert handler staging: omap-thermal: update documentation for talert irq handler staging: omap-thermal: update tshut IRQ handler documentation staging: omap-thermal: remove duplicated code staging: omap-thermal: read status only once inside alert IRQ staging: omap-thermal: add a section of register manipulation staging: omap-thermal: section of basic helpers staging: omap-thermal: IRQ handler section staging: omap-thermal: ADC section staging: omap-thermal: name adc_to_temp_conversion in a better way staging: omap-thermal: rewrite omap_bandgap_adc_to_mcelsius on kernel coding style staging: omap-thermal: add documentation for omap_bandgap_adc_to_mcelsius staging: omap-thermal: name temp_to_adc_conversion in a better way staging: omap-thermal: rewrite omap_bandgap_mcelsius_to_adc on kernel coding style staging: omap-thermal: move conv table limits out of sensor data staging: omap-thermal: add documentation for omap_bandgap_mcelsius_to_adc staging: omap-thermal: rename add_hyst to omap_bandgap_add_hyst staging: omap-thermal: document omap_bandgap_add_hyst function staging: omap-thermal: threshold manipulation section staging: omap-thermal: refactor temp_sensor_unmask_interrupts staging: omap-thermal: update omap_bandgap_unmask_interrupts documentation staging: omap-thermal: refactor APIs handling threshold values staging: omap-thermal: device initialization section staging: omap-thermal: section of device driver callbacks staging: omap-thermal: rename enable_continuous_mode staging: omap-thermal: update omap_bandgap_set_continous_mode documentation staging: omap-thermal: document omap_bandgap_force_single_read staging: omap-thermal: document omap_bandgap_update_alert_threshold function staging: omap-thermal: document _omap_bandgap_write_threshold function staging: omap-thermal: document _omap_bandgap_read_threshold function staging: omap-thermal: document omap_bandgap_tshut_init function staging: omap-thermal: document omap_bandgap_alert_init function staging: omap-thermal: document omap_bandgap_build function staging: omap-thermal: change Kconfig dependency method staging: Add a MAINTAINERS entry for TI bandgap and thermal driver staging: omap-thermal: switch mutex to spinlock inside omap-bandgap staging: omap-thermal: remove TODO entry suggesting regmap usage staging: omap-thermal: remove TODO entry for exposed APIs staging: omap-thermal: add documentation for omap_bandgap_validate MAINTAINERS|6 + drivers/staging/omap-thermal/Kconfig |2 +- drivers/staging/omap-thermal/TODO |4 - drivers/staging/omap-thermal/omap-bandgap.c| 793 +++- drivers/staging/omap-thermal/omap-bandgap.h| 498 + drivers/staging/omap-thermal/omap-thermal-common.c |4 +- drivers/staging/omap-thermal/omap4-thermal-data.c | 11 +- drivers/staging/omap-thermal/omap4xxx-bandgap.h| 175 + drivers/staging/omap-thermal/omap5-thermal-data.c |9 +- drivers/staging/omap-thermal/omap5xxx-bandgap.h| 199 + 10 files changed, 1030 insertions(+), 671 deletions(-)
