Re: [PATCH 01/11] ARM: AM43xx: hwmod: add DSS hwmod data

2014-05-27 Thread Tomi Valkeinen
Hi Paul,

On 19/05/14 14:10, Tomi Valkeinen wrote:
 On 19/05/14 13:28, Rajendra Nayak wrote:
 
 Yeah, thats what it looks like to me. l3_gclk is the 200Mhz clock derived 
 from 
 core-m4 post divider and l3s_gclk/l4ls_gclk are half of that at 100Mhz, 
 derived
 using a fixed divider of 2.
 
 Here's an updated patch, with the sdma entry removed and the ocp clock
 changed to l3_gclk.

Can we get this to 3.16?

 Tomi

 From bfaf0fafb21c698c86640764c1aa62d6fc73992a Mon Sep 17 00:00:00 2001
 From: Sathya Prakash M R sath...@ti.com
 Date: Mon, 24 Mar 2014 16:31:53 +0530
 Subject: [PATCH] ARM: AM43xx: hwmod: add DSS hwmod data
 
 Add DSS hwmod data for AM43xx.
 
 Signed-off-by: Sathya Prakash M R sath...@ti.com
 Signed-off-by: Tomi Valkeinen tomi.valkei...@ti.com
 ---
  arch/arm/mach-omap2/omap_hwmod_43xx_data.c | 98 
 ++
  arch/arm/mach-omap2/prcm43xx.h |  1 +
  2 files changed, 99 insertions(+)
 
 diff --git a/arch/arm/mach-omap2/omap_hwmod_43xx_data.c 
 b/arch/arm/mach-omap2/omap_hwmod_43xx_data.c
 index 5c2cc8083fdd..d2a7b6dc36f2 100644
 --- a/arch/arm/mach-omap2/omap_hwmod_43xx_data.c
 +++ b/arch/arm/mach-omap2/omap_hwmod_43xx_data.c
 @@ -19,6 +19,8 @@
  #include omap_hwmod.h
  #include omap_hwmod_33xx_43xx_common_data.h
  #include prcm43xx.h
 +#include omap_hwmod_common_data.h
 +
  
  /* IP blocks */
  static struct omap_hwmod am43xx_l4_hs_hwmod = {
 @@ -415,6 +417,70 @@ static struct omap_hwmod am43xx_qspi_hwmod = {
   },
  };
  
 +/* Display sub system - DSS */
 +
 +struct omap_dss_dispc_dev_attr am43xx_dss_dispc_dev_attr = {
 + .manager_count  = 1,
 + .has_framedonetv_irq= 0
 +};
 +
 +
 +static struct omap_hwmod_class_sysconfig am43xx_dispc_sysc = {
 + .rev_offs   = 0x,
 + .sysc_offs  = 0x0010,
 + .syss_offs  = 0x0014,
 + .sysc_flags = (SYSC_HAS_SIDLEMODE | SYSC_HAS_MIDLEMODE),
 + .idlemodes  = (SIDLE_FORCE | SIDLE_NO | SIDLE_SMART),
 + .sysc_fields= omap_hwmod_sysc_type1,
 +};
 +
 +static struct omap_hwmod_class am43xx_dispc_hwmod_class = {
 + .name   = dispc,
 + .sysc   = am43xx_dispc_sysc,
 +};
 +
 +static struct omap_hwmod am43xx_dss_core_hwmod = {
 + .name   = dss_core,
 + .class  = omap2_dss_hwmod_class,
 + .clkdm_name = dss_clkdm,
 + .main_clk   = disp_clk,
 + .prcm = {
 + .omap4 = {
 + .clkctrl_offs = AM43XX_CM_PER_DSS_CLKCTRL_OFFSET,
 + .modulemode   = MODULEMODE_SWCTRL,
 + },
 + },
 +};
 +
 +/* display controller -dispc*/
 +
 +static struct omap_hwmod am43xx_dss_dispc_hwmod = {
 + .name   = dss_dispc,
 + .class  = am43xx_dispc_hwmod_class,
 + .clkdm_name = dss_clkdm,
 + .main_clk   = disp_clk,
 + .prcm = {
 + .omap4 = {
 + .clkctrl_offs = AM43XX_CM_PER_DSS_CLKCTRL_OFFSET,
 + },
 + },
 + .dev_attr   = am43xx_dss_dispc_dev_attr,
 +};
 +
 +/*RFBI*/
 +
 +static struct omap_hwmod am43xx_dss_rfbi_hwmod = {
 + .name   = dss_rfbi,
 + .class  = omap2_rfbi_hwmod_class,
 + .clkdm_name = dss_clkdm,
 + .main_clk   = disp_clk,
 + .prcm = {
 + .omap4 = {
 + .clkctrl_offs = AM43XX_CM_PER_DSS_CLKCTRL_OFFSET,
 + },
 + },
 +};
 +
  /* Interfaces */
  static struct omap_hwmod_ocp_if am43xx_l3_main__l4_hs = {
   .master = am33xx_l3_main_hwmod,
 @@ -654,6 +720,34 @@ static struct omap_hwmod_ocp_if am43xx_l3_s__qspi = {
   .user   = OCP_USER_MPU | OCP_USER_SDMA,
  };
  
 +static struct omap_hwmod_ocp_if am43xx_dss__l3_main = {
 + .master = am43xx_dss_core_hwmod,
 + .slave  = am33xx_l3_main_hwmod,
 + .clk= l3_gclk,
 + .user   = OCP_USER_MPU | OCP_USER_SDMA,
 +};
 +
 +static struct omap_hwmod_ocp_if am43xx_l4_ls__dss = {
 + .master = am33xx_l4_ls_hwmod,
 + .slave  = am43xx_dss_core_hwmod,
 + .clk= l4ls_gclk,
 + .user   = OCP_USER_MPU | OCP_USER_SDMA,
 +};
 +
 +static struct omap_hwmod_ocp_if am43xx_l4_ls__dss_dispc = {
 + .master = am33xx_l4_ls_hwmod,
 + .slave  = am43xx_dss_dispc_hwmod,
 + .clk= l4ls_gclk,
 + .user   = OCP_USER_MPU | OCP_USER_SDMA,
 +};
 +
 +static struct omap_hwmod_ocp_if am43xx_l4_ls__dss_rfbi = {
 + .master = am33xx_l4_ls_hwmod,
 + .slave  = am43xx_dss_rfbi_hwmod,
 + .clk= l4ls_gclk,
 + .user   = OCP_USER_MPU | OCP_USER_SDMA,
 +};
 +
  static struct omap_hwmod_ocp_if *am43xx_hwmod_ocp_ifs[] __initdata = {
   am33xx_l4_wkup__synctimer,
   am43xx_l4_ls__timer8,
 @@ -748,6 +842,10 @@ static struct omap_hwmod_ocp_if *am43xx_hwmod_ocp_ifs[] 
 __initdata = {
   am43xx_l4_ls__ocp2scp1,
   am43xx_l3_s__usbotgss0,
   

Re: [PATCH 01/11] ARM: AM43xx: hwmod: add DSS hwmod data

2014-05-19 Thread Rajendra Nayak
On Friday 09 May 2014 05:26 PM, Tomi Valkeinen wrote:
 From: Sathya Prakash M R sath...@ti.com
 
 Add DSS hwmod data for AM43xx.
 
 Signed-off-by: Sathya Prakash M R sath...@ti.com
 Signed-off-by: Tomi Valkeinen tomi.valkei...@ti.com
 ---
  arch/arm/mach-omap2/omap_hwmod_43xx_data.c | 104 
 +
  arch/arm/mach-omap2/prcm43xx.h |   1 +
  2 files changed, 105 insertions(+)
 
 diff --git a/arch/arm/mach-omap2/omap_hwmod_43xx_data.c 
 b/arch/arm/mach-omap2/omap_hwmod_43xx_data.c
 index 5c2cc8083fdd..8c14db2e1e47 100644
 --- a/arch/arm/mach-omap2/omap_hwmod_43xx_data.c
 +++ b/arch/arm/mach-omap2/omap_hwmod_43xx_data.c
 @@ -19,6 +19,8 @@
  #include omap_hwmod.h
  #include omap_hwmod_33xx_43xx_common_data.h
  #include prcm43xx.h
 +#include omap_hwmod_common_data.h
 +
  
  /* IP blocks */
  static struct omap_hwmod am43xx_l4_hs_hwmod = {
 @@ -415,6 +417,76 @@ static struct omap_hwmod am43xx_qspi_hwmod = {
   },
  };
  
 +/* Display sub system - DSS */
 +
 +static struct omap_hwmod_dma_info am43xx_dss_sdma_chs[] = {
 + { .name = dispc, .dma_req = 5 },
 + { .dma_req = -1 },
 +};

the dma info needs to come in from DT. Besides these are edma
request lines and not sdma.

 +
 +struct omap_dss_dispc_dev_attr am43xx_dss_dispc_dev_attr = {
 + .manager_count  = 1,
 + .has_framedonetv_irq= 0
 +};
 +
 +
[]..

 +
  /* Interfaces */
  static struct omap_hwmod_ocp_if am43xx_l3_main__l4_hs = {
   .master = am33xx_l3_main_hwmod,
 @@ -654,6 +726,34 @@ static struct omap_hwmod_ocp_if am43xx_l3_s__qspi = {
   .user   = OCP_USER_MPU | OCP_USER_SDMA,
  };
  
 +static struct omap_hwmod_ocp_if am43xx_dss__l3_main = {
 + .master = am43xx_dss_core_hwmod,
 + .slave  = am33xx_l3_main_hwmod,
 + .clk= disp_clk,

Isn't l3_gclk that clocks the l3 OCP master port?

regards,
Rajendra

 + .user   = OCP_USER_MPU | OCP_USER_SDMA,
 +};
 +
 +static struct omap_hwmod_ocp_if am43xx_l4_ls__dss = {
 + .master = am33xx_l4_ls_hwmod,
 + .slave  = am43xx_dss_core_hwmod,
 + .clk= l4ls_gclk,
 + .user   = OCP_USER_MPU | OCP_USER_SDMA,
 +};
 +
 +static struct omap_hwmod_ocp_if am43xx_l4_ls__dss_dispc = {
 + .master = am33xx_l4_ls_hwmod,
 + .slave  = am43xx_dss_dispc_hwmod,
 + .clk= l4ls_gclk,
 + .user   = OCP_USER_MPU | OCP_USER_SDMA,
 +};
 +
 +static struct omap_hwmod_ocp_if am43xx_l4_ls__dss_rfbi = {
 + .master = am33xx_l4_ls_hwmod,
 + .slave  = am43xx_dss_rfbi_hwmod,
 + .clk= l4ls_gclk,
 + .user   = OCP_USER_MPU | OCP_USER_SDMA,
 +};
 +
  static struct omap_hwmod_ocp_if *am43xx_hwmod_ocp_ifs[] __initdata = {
   am33xx_l4_wkup__synctimer,
   am43xx_l4_ls__timer8,
 @@ -748,6 +848,10 @@ static struct omap_hwmod_ocp_if *am43xx_hwmod_ocp_ifs[] 
 __initdata = {
   am43xx_l4_ls__ocp2scp1,
   am43xx_l3_s__usbotgss0,
   am43xx_l3_s__usbotgss1,
 + am43xx_dss__l3_main,
 + am43xx_l4_ls__dss,
 + am43xx_l4_ls__dss_dispc,
 + am43xx_l4_ls__dss_rfbi,
   NULL,
  };
  
 diff --git a/arch/arm/mach-omap2/prcm43xx.h b/arch/arm/mach-omap2/prcm43xx.h
 index 7785be984edd..ad7b3e9977f8 100644
 --- a/arch/arm/mach-omap2/prcm43xx.h
 +++ b/arch/arm/mach-omap2/prcm43xx.h
 @@ -142,5 +142,6 @@
  #define AM43XX_CM_PER_USBPHYOCP2SCP0_CLKCTRL_OFFSET  0x05B8
  #define AM43XX_CM_PER_USB_OTG_SS1_CLKCTRL_OFFSET0x0268
  #define AM43XX_CM_PER_USBPHYOCP2SCP1_CLKCTRL_OFFSET  0x05C0
 +#define AM43XX_CM_PER_DSS_CLKCTRL_OFFSET 0x0a20
  
  #endif
 

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH 01/11] ARM: AM43xx: hwmod: add DSS hwmod data

2014-05-19 Thread Tomi Valkeinen
On 19/05/14 12:24, Rajendra Nayak wrote:
 On Friday 09 May 2014 05:26 PM, Tomi Valkeinen wrote:
 From: Sathya Prakash M R sath...@ti.com

 Add DSS hwmod data for AM43xx.

 Signed-off-by: Sathya Prakash M R sath...@ti.com
 Signed-off-by: Tomi Valkeinen tomi.valkei...@ti.com
 ---
  arch/arm/mach-omap2/omap_hwmod_43xx_data.c | 104 
 +
  arch/arm/mach-omap2/prcm43xx.h |   1 +
  2 files changed, 105 insertions(+)

 diff --git a/arch/arm/mach-omap2/omap_hwmod_43xx_data.c 
 b/arch/arm/mach-omap2/omap_hwmod_43xx_data.c
 index 5c2cc8083fdd..8c14db2e1e47 100644
 --- a/arch/arm/mach-omap2/omap_hwmod_43xx_data.c
 +++ b/arch/arm/mach-omap2/omap_hwmod_43xx_data.c
 @@ -19,6 +19,8 @@
  #include omap_hwmod.h
  #include omap_hwmod_33xx_43xx_common_data.h
  #include prcm43xx.h
 +#include omap_hwmod_common_data.h
 +
  
  /* IP blocks */
  static struct omap_hwmod am43xx_l4_hs_hwmod = {
 @@ -415,6 +417,76 @@ static struct omap_hwmod am43xx_qspi_hwmod = {
  },
  };
  
 +/* Display sub system - DSS */
 +
 +static struct omap_hwmod_dma_info am43xx_dss_sdma_chs[] = {
 +{ .name = dispc, .dma_req = 5 },
 +{ .dma_req = -1 },
 +};
 
 the dma info needs to come in from DT. Besides these are edma
 request lines and not sdma.

Right, the sdma information is not needed anymore.

 +
 +struct omap_dss_dispc_dev_attr am43xx_dss_dispc_dev_attr = {
 +.manager_count  = 1,
 +.has_framedonetv_irq= 0
 +};
 +
 +
 []..
 
 +
  /* Interfaces */
  static struct omap_hwmod_ocp_if am43xx_l3_main__l4_hs = {
  .master = am33xx_l3_main_hwmod,
 @@ -654,6 +726,34 @@ static struct omap_hwmod_ocp_if am43xx_l3_s__qspi = {
  .user   = OCP_USER_MPU | OCP_USER_SDMA,
  };
  
 +static struct omap_hwmod_ocp_if am43xx_dss__l3_main = {
 +.master = am43xx_dss_core_hwmod,
 +.slave  = am33xx_l3_main_hwmod,
 +.clk= disp_clk,
 
 Isn't l3_gclk that clocks the l3 OCP master port?

Hmm, possibly... dispc_clk looks a bit odd there. It's been very
difficult to figure out things like that, with the not-so-good am43xx
documentation.

The documentation mentions L3 Fast Interconnect and LCDL3OCPIFCLK
related to DSS's OCP master, but searching for those in the TRM doesn't
reveal much.

Would the l3_gclk match the L3 Fast Interconnect and l3s_gclk match
the L3 Slow Interconnect.

 Tomi




signature.asc
Description: OpenPGP digital signature


Re: [PATCH 01/11] ARM: AM43xx: hwmod: add DSS hwmod data

2014-05-19 Thread Rajendra Nayak
On Monday 19 May 2014 03:42 PM, Tomi Valkeinen wrote:
 On 19/05/14 12:24, Rajendra Nayak wrote:
 On Friday 09 May 2014 05:26 PM, Tomi Valkeinen wrote:
 From: Sathya Prakash M R sath...@ti.com

 Add DSS hwmod data for AM43xx.

 Signed-off-by: Sathya Prakash M R sath...@ti.com
 Signed-off-by: Tomi Valkeinen tomi.valkei...@ti.com
 ---
  arch/arm/mach-omap2/omap_hwmod_43xx_data.c | 104 
 +
  arch/arm/mach-omap2/prcm43xx.h |   1 +
  2 files changed, 105 insertions(+)

 diff --git a/arch/arm/mach-omap2/omap_hwmod_43xx_data.c 
 b/arch/arm/mach-omap2/omap_hwmod_43xx_data.c
 index 5c2cc8083fdd..8c14db2e1e47 100644
 --- a/arch/arm/mach-omap2/omap_hwmod_43xx_data.c
 +++ b/arch/arm/mach-omap2/omap_hwmod_43xx_data.c
 @@ -19,6 +19,8 @@
  #include omap_hwmod.h
  #include omap_hwmod_33xx_43xx_common_data.h
  #include prcm43xx.h
 +#include omap_hwmod_common_data.h
 +
  
  /* IP blocks */
  static struct omap_hwmod am43xx_l4_hs_hwmod = {
 @@ -415,6 +417,76 @@ static struct omap_hwmod am43xx_qspi_hwmod = {
 },
  };
  
 +/* Display sub system - DSS */
 +
 +static struct omap_hwmod_dma_info am43xx_dss_sdma_chs[] = {
 +   { .name = dispc, .dma_req = 5 },
 +   { .dma_req = -1 },
 +};

 the dma info needs to come in from DT. Besides these are edma
 request lines and not sdma.
 
 Right, the sdma information is not needed anymore.
 
 +
 +struct omap_dss_dispc_dev_attr am43xx_dss_dispc_dev_attr = {
 +   .manager_count  = 1,
 +   .has_framedonetv_irq= 0
 +};
 +
 +
 []..

 +
  /* Interfaces */
  static struct omap_hwmod_ocp_if am43xx_l3_main__l4_hs = {
 .master = am33xx_l3_main_hwmod,
 @@ -654,6 +726,34 @@ static struct omap_hwmod_ocp_if am43xx_l3_s__qspi = {
 .user   = OCP_USER_MPU | OCP_USER_SDMA,
  };
  
 +static struct omap_hwmod_ocp_if am43xx_dss__l3_main = {
 +   .master = am43xx_dss_core_hwmod,
 +   .slave  = am33xx_l3_main_hwmod,
 +   .clk= disp_clk,

 Isn't l3_gclk that clocks the l3 OCP master port?
 
 Hmm, possibly... dispc_clk looks a bit odd there. It's been very
 difficult to figure out things like that, with the not-so-good am43xx
 documentation.
 
 The documentation mentions L3 Fast Interconnect and LCDL3OCPIFCLK
 related to DSS's OCP master, but searching for those in the TRM doesn't
 reveal much.
 
 Would the l3_gclk match the L3 Fast Interconnect and l3s_gclk match
 the L3 Slow Interconnect.

Yeah, thats what it looks like to me. l3_gclk is the 200Mhz clock derived from 
core-m4 post divider and l3s_gclk/l4ls_gclk are half of that at 100Mhz, derived
using a fixed divider of 2.

regards,
Rajendra

 
  Tomi
 
 

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH 01/11] ARM: AM43xx: hwmod: add DSS hwmod data

2014-05-19 Thread Tomi Valkeinen
On 19/05/14 13:28, Rajendra Nayak wrote:

 Yeah, thats what it looks like to me. l3_gclk is the 200Mhz clock derived 
 from 
 core-m4 post divider and l3s_gclk/l4ls_gclk are half of that at 100Mhz, 
 derived
 using a fixed divider of 2.

Here's an updated patch, with the sdma entry removed and the ocp clock
changed to l3_gclk.

From bfaf0fafb21c698c86640764c1aa62d6fc73992a Mon Sep 17 00:00:00 2001
From: Sathya Prakash M R sath...@ti.com
Date: Mon, 24 Mar 2014 16:31:53 +0530
Subject: [PATCH] ARM: AM43xx: hwmod: add DSS hwmod data

Add DSS hwmod data for AM43xx.

Signed-off-by: Sathya Prakash M R sath...@ti.com
Signed-off-by: Tomi Valkeinen tomi.valkei...@ti.com
---
 arch/arm/mach-omap2/omap_hwmod_43xx_data.c | 98 ++
 arch/arm/mach-omap2/prcm43xx.h |  1 +
 2 files changed, 99 insertions(+)

diff --git a/arch/arm/mach-omap2/omap_hwmod_43xx_data.c 
b/arch/arm/mach-omap2/omap_hwmod_43xx_data.c
index 5c2cc8083fdd..d2a7b6dc36f2 100644
--- a/arch/arm/mach-omap2/omap_hwmod_43xx_data.c
+++ b/arch/arm/mach-omap2/omap_hwmod_43xx_data.c
@@ -19,6 +19,8 @@
 #include omap_hwmod.h
 #include omap_hwmod_33xx_43xx_common_data.h
 #include prcm43xx.h
+#include omap_hwmod_common_data.h
+
 
 /* IP blocks */
 static struct omap_hwmod am43xx_l4_hs_hwmod = {
@@ -415,6 +417,70 @@ static struct omap_hwmod am43xx_qspi_hwmod = {
},
 };
 
+/* Display sub system - DSS */
+
+struct omap_dss_dispc_dev_attr am43xx_dss_dispc_dev_attr = {
+   .manager_count  = 1,
+   .has_framedonetv_irq= 0
+};
+
+
+static struct omap_hwmod_class_sysconfig am43xx_dispc_sysc = {
+   .rev_offs   = 0x,
+   .sysc_offs  = 0x0010,
+   .syss_offs  = 0x0014,
+   .sysc_flags = (SYSC_HAS_SIDLEMODE | SYSC_HAS_MIDLEMODE),
+   .idlemodes  = (SIDLE_FORCE | SIDLE_NO | SIDLE_SMART),
+   .sysc_fields= omap_hwmod_sysc_type1,
+};
+
+static struct omap_hwmod_class am43xx_dispc_hwmod_class = {
+   .name   = dispc,
+   .sysc   = am43xx_dispc_sysc,
+};
+
+static struct omap_hwmod am43xx_dss_core_hwmod = {
+   .name   = dss_core,
+   .class  = omap2_dss_hwmod_class,
+   .clkdm_name = dss_clkdm,
+   .main_clk   = disp_clk,
+   .prcm = {
+   .omap4 = {
+   .clkctrl_offs = AM43XX_CM_PER_DSS_CLKCTRL_OFFSET,
+   .modulemode   = MODULEMODE_SWCTRL,
+   },
+   },
+};
+
+/* display controller -dispc*/
+
+static struct omap_hwmod am43xx_dss_dispc_hwmod = {
+   .name   = dss_dispc,
+   .class  = am43xx_dispc_hwmod_class,
+   .clkdm_name = dss_clkdm,
+   .main_clk   = disp_clk,
+   .prcm = {
+   .omap4 = {
+   .clkctrl_offs = AM43XX_CM_PER_DSS_CLKCTRL_OFFSET,
+   },
+   },
+   .dev_attr   = am43xx_dss_dispc_dev_attr,
+};
+
+/*RFBI*/
+
+static struct omap_hwmod am43xx_dss_rfbi_hwmod = {
+   .name   = dss_rfbi,
+   .class  = omap2_rfbi_hwmod_class,
+   .clkdm_name = dss_clkdm,
+   .main_clk   = disp_clk,
+   .prcm = {
+   .omap4 = {
+   .clkctrl_offs = AM43XX_CM_PER_DSS_CLKCTRL_OFFSET,
+   },
+   },
+};
+
 /* Interfaces */
 static struct omap_hwmod_ocp_if am43xx_l3_main__l4_hs = {
.master = am33xx_l3_main_hwmod,
@@ -654,6 +720,34 @@ static struct omap_hwmod_ocp_if am43xx_l3_s__qspi = {
.user   = OCP_USER_MPU | OCP_USER_SDMA,
 };
 
+static struct omap_hwmod_ocp_if am43xx_dss__l3_main = {
+   .master = am43xx_dss_core_hwmod,
+   .slave  = am33xx_l3_main_hwmod,
+   .clk= l3_gclk,
+   .user   = OCP_USER_MPU | OCP_USER_SDMA,
+};
+
+static struct omap_hwmod_ocp_if am43xx_l4_ls__dss = {
+   .master = am33xx_l4_ls_hwmod,
+   .slave  = am43xx_dss_core_hwmod,
+   .clk= l4ls_gclk,
+   .user   = OCP_USER_MPU | OCP_USER_SDMA,
+};
+
+static struct omap_hwmod_ocp_if am43xx_l4_ls__dss_dispc = {
+   .master = am33xx_l4_ls_hwmod,
+   .slave  = am43xx_dss_dispc_hwmod,
+   .clk= l4ls_gclk,
+   .user   = OCP_USER_MPU | OCP_USER_SDMA,
+};
+
+static struct omap_hwmod_ocp_if am43xx_l4_ls__dss_rfbi = {
+   .master = am33xx_l4_ls_hwmod,
+   .slave  = am43xx_dss_rfbi_hwmod,
+   .clk= l4ls_gclk,
+   .user   = OCP_USER_MPU | OCP_USER_SDMA,
+};
+
 static struct omap_hwmod_ocp_if *am43xx_hwmod_ocp_ifs[] __initdata = {
am33xx_l4_wkup__synctimer,
am43xx_l4_ls__timer8,
@@ -748,6 +842,10 @@ static struct omap_hwmod_ocp_if *am43xx_hwmod_ocp_ifs[] 
__initdata = {
am43xx_l4_ls__ocp2scp1,
am43xx_l3_s__usbotgss0,
am43xx_l3_s__usbotgss1,
+   am43xx_dss__l3_main,
+   am43xx_l4_ls__dss,
+   am43xx_l4_ls__dss_dispc,
+   

Re: [PATCH 01/11] ARM: AM43xx: hwmod: add DSS hwmod data

2014-05-19 Thread Rajendra Nayak
On Monday 19 May 2014 04:40 PM, Tomi Valkeinen wrote:
 On 19/05/14 13:28, Rajendra Nayak wrote:
 
 Yeah, thats what it looks like to me. l3_gclk is the 200Mhz clock derived 
 from 
 core-m4 post divider and l3s_gclk/l4ls_gclk are half of that at 100Mhz, 
 derived
 using a fixed divider of 2.
 
 Here's an updated patch, with the sdma entry removed and the ocp clock
 changed to l3_gclk.
 
 From bfaf0fafb21c698c86640764c1aa62d6fc73992a Mon Sep 17 00:00:00 2001
 From: Sathya Prakash M R sath...@ti.com
 Date: Mon, 24 Mar 2014 16:31:53 +0530
 Subject: [PATCH] ARM: AM43xx: hwmod: add DSS hwmod data
 
 Add DSS hwmod data for AM43xx.
 
 Signed-off-by: Sathya Prakash M R sath...@ti.com
 Signed-off-by: Tomi Valkeinen tomi.valkei...@ti.com

Looks good to me, feel free to add
Acked-by: Rajendra Nayak rna...@ti.com

 ---
  arch/arm/mach-omap2/omap_hwmod_43xx_data.c | 98 
 ++
  arch/arm/mach-omap2/prcm43xx.h |  1 +
  2 files changed, 99 insertions(+)
 
 diff --git a/arch/arm/mach-omap2/omap_hwmod_43xx_data.c 
 b/arch/arm/mach-omap2/omap_hwmod_43xx_data.c
 index 5c2cc8083fdd..d2a7b6dc36f2 100644
 --- a/arch/arm/mach-omap2/omap_hwmod_43xx_data.c
 +++ b/arch/arm/mach-omap2/omap_hwmod_43xx_data.c
 @@ -19,6 +19,8 @@
  #include omap_hwmod.h
  #include omap_hwmod_33xx_43xx_common_data.h
  #include prcm43xx.h
 +#include omap_hwmod_common_data.h
 +
  
  /* IP blocks */
  static struct omap_hwmod am43xx_l4_hs_hwmod = {
 @@ -415,6 +417,70 @@ static struct omap_hwmod am43xx_qspi_hwmod = {
   },
  };
  
 +/* Display sub system - DSS */
 +
 +struct omap_dss_dispc_dev_attr am43xx_dss_dispc_dev_attr = {
 + .manager_count  = 1,
 + .has_framedonetv_irq= 0
 +};
 +
 +
 +static struct omap_hwmod_class_sysconfig am43xx_dispc_sysc = {
 + .rev_offs   = 0x,
 + .sysc_offs  = 0x0010,
 + .syss_offs  = 0x0014,
 + .sysc_flags = (SYSC_HAS_SIDLEMODE | SYSC_HAS_MIDLEMODE),
 + .idlemodes  = (SIDLE_FORCE | SIDLE_NO | SIDLE_SMART),
 + .sysc_fields= omap_hwmod_sysc_type1,
 +};
 +
 +static struct omap_hwmod_class am43xx_dispc_hwmod_class = {
 + .name   = dispc,
 + .sysc   = am43xx_dispc_sysc,
 +};
 +
 +static struct omap_hwmod am43xx_dss_core_hwmod = {
 + .name   = dss_core,
 + .class  = omap2_dss_hwmod_class,
 + .clkdm_name = dss_clkdm,
 + .main_clk   = disp_clk,
 + .prcm = {
 + .omap4 = {
 + .clkctrl_offs = AM43XX_CM_PER_DSS_CLKCTRL_OFFSET,
 + .modulemode   = MODULEMODE_SWCTRL,
 + },
 + },
 +};
 +
 +/* display controller -dispc*/
 +
 +static struct omap_hwmod am43xx_dss_dispc_hwmod = {
 + .name   = dss_dispc,
 + .class  = am43xx_dispc_hwmod_class,
 + .clkdm_name = dss_clkdm,
 + .main_clk   = disp_clk,
 + .prcm = {
 + .omap4 = {
 + .clkctrl_offs = AM43XX_CM_PER_DSS_CLKCTRL_OFFSET,
 + },
 + },
 + .dev_attr   = am43xx_dss_dispc_dev_attr,
 +};
 +
 +/*RFBI*/
 +
 +static struct omap_hwmod am43xx_dss_rfbi_hwmod = {
 + .name   = dss_rfbi,
 + .class  = omap2_rfbi_hwmod_class,
 + .clkdm_name = dss_clkdm,
 + .main_clk   = disp_clk,
 + .prcm = {
 + .omap4 = {
 + .clkctrl_offs = AM43XX_CM_PER_DSS_CLKCTRL_OFFSET,
 + },
 + },
 +};
 +
  /* Interfaces */
  static struct omap_hwmod_ocp_if am43xx_l3_main__l4_hs = {
   .master = am33xx_l3_main_hwmod,
 @@ -654,6 +720,34 @@ static struct omap_hwmod_ocp_if am43xx_l3_s__qspi = {
   .user   = OCP_USER_MPU | OCP_USER_SDMA,
  };
  
 +static struct omap_hwmod_ocp_if am43xx_dss__l3_main = {
 + .master = am43xx_dss_core_hwmod,
 + .slave  = am33xx_l3_main_hwmod,
 + .clk= l3_gclk,
 + .user   = OCP_USER_MPU | OCP_USER_SDMA,
 +};
 +
 +static struct omap_hwmod_ocp_if am43xx_l4_ls__dss = {
 + .master = am33xx_l4_ls_hwmod,
 + .slave  = am43xx_dss_core_hwmod,
 + .clk= l4ls_gclk,
 + .user   = OCP_USER_MPU | OCP_USER_SDMA,
 +};
 +
 +static struct omap_hwmod_ocp_if am43xx_l4_ls__dss_dispc = {
 + .master = am33xx_l4_ls_hwmod,
 + .slave  = am43xx_dss_dispc_hwmod,
 + .clk= l4ls_gclk,
 + .user   = OCP_USER_MPU | OCP_USER_SDMA,
 +};
 +
 +static struct omap_hwmod_ocp_if am43xx_l4_ls__dss_rfbi = {
 + .master = am33xx_l4_ls_hwmod,
 + .slave  = am43xx_dss_rfbi_hwmod,
 + .clk= l4ls_gclk,
 + .user   = OCP_USER_MPU | OCP_USER_SDMA,
 +};
 +
  static struct omap_hwmod_ocp_if *am43xx_hwmod_ocp_ifs[] __initdata = {
   am33xx_l4_wkup__synctimer,
   am43xx_l4_ls__timer8,
 @@ -748,6 +842,10 @@ static struct omap_hwmod_ocp_if *am43xx_hwmod_ocp_ifs[] 
 __initdata = {
   am43xx_l4_ls__ocp2scp1,
   

[PATCH 01/11] ARM: AM43xx: hwmod: add DSS hwmod data

2014-05-09 Thread Tomi Valkeinen
From: Sathya Prakash M R sath...@ti.com

Add DSS hwmod data for AM43xx.

Signed-off-by: Sathya Prakash M R sath...@ti.com
Signed-off-by: Tomi Valkeinen tomi.valkei...@ti.com
---
 arch/arm/mach-omap2/omap_hwmod_43xx_data.c | 104 +
 arch/arm/mach-omap2/prcm43xx.h |   1 +
 2 files changed, 105 insertions(+)

diff --git a/arch/arm/mach-omap2/omap_hwmod_43xx_data.c 
b/arch/arm/mach-omap2/omap_hwmod_43xx_data.c
index 5c2cc8083fdd..8c14db2e1e47 100644
--- a/arch/arm/mach-omap2/omap_hwmod_43xx_data.c
+++ b/arch/arm/mach-omap2/omap_hwmod_43xx_data.c
@@ -19,6 +19,8 @@
 #include omap_hwmod.h
 #include omap_hwmod_33xx_43xx_common_data.h
 #include prcm43xx.h
+#include omap_hwmod_common_data.h
+
 
 /* IP blocks */
 static struct omap_hwmod am43xx_l4_hs_hwmod = {
@@ -415,6 +417,76 @@ static struct omap_hwmod am43xx_qspi_hwmod = {
},
 };
 
+/* Display sub system - DSS */
+
+static struct omap_hwmod_dma_info am43xx_dss_sdma_chs[] = {
+   { .name = dispc, .dma_req = 5 },
+   { .dma_req = -1 },
+};
+
+struct omap_dss_dispc_dev_attr am43xx_dss_dispc_dev_attr = {
+   .manager_count  = 1,
+   .has_framedonetv_irq= 0
+};
+
+
+static struct omap_hwmod_class_sysconfig am43xx_dispc_sysc = {
+   .rev_offs   = 0x,
+   .sysc_offs  = 0x0010,
+   .syss_offs  = 0x0014,
+   .sysc_flags = (SYSC_HAS_SIDLEMODE | SYSC_HAS_MIDLEMODE),
+   .idlemodes  = (SIDLE_FORCE | SIDLE_NO | SIDLE_SMART),
+   .sysc_fields= omap_hwmod_sysc_type1,
+};
+
+static struct omap_hwmod_class am43xx_dispc_hwmod_class = {
+   .name   = dispc,
+   .sysc   = am43xx_dispc_sysc,
+};
+
+static struct omap_hwmod am43xx_dss_core_hwmod = {
+   .name   = dss_core,
+   .class  = omap2_dss_hwmod_class,
+   .clkdm_name = dss_clkdm,
+   .main_clk   = disp_clk,
+   .sdma_reqs  = am43xx_dss_sdma_chs,
+   .prcm = {
+   .omap4 = {
+   .clkctrl_offs = AM43XX_CM_PER_DSS_CLKCTRL_OFFSET,
+   .modulemode   = MODULEMODE_SWCTRL,
+   },
+   },
+};
+
+/* display controller -dispc*/
+
+static struct omap_hwmod am43xx_dss_dispc_hwmod = {
+   .name   = dss_dispc,
+   .class  = am43xx_dispc_hwmod_class,
+   .clkdm_name = dss_clkdm,
+   .main_clk   = disp_clk,
+   .prcm = {
+   .omap4 = {
+   .clkctrl_offs = AM43XX_CM_PER_DSS_CLKCTRL_OFFSET,
+   },
+   },
+   .dev_attr   = am43xx_dss_dispc_dev_attr,
+};
+
+/*RFBI*/
+
+static struct omap_hwmod am43xx_dss_rfbi_hwmod = {
+   .name   = dss_rfbi,
+   .class  = omap2_rfbi_hwmod_class,
+   .clkdm_name = dss_clkdm,
+   .main_clk   = disp_clk,
+   .prcm = {
+   .omap4 = {
+   .clkctrl_offs = AM43XX_CM_PER_DSS_CLKCTRL_OFFSET,
+   },
+   },
+};
+
 /* Interfaces */
 static struct omap_hwmod_ocp_if am43xx_l3_main__l4_hs = {
.master = am33xx_l3_main_hwmod,
@@ -654,6 +726,34 @@ static struct omap_hwmod_ocp_if am43xx_l3_s__qspi = {
.user   = OCP_USER_MPU | OCP_USER_SDMA,
 };
 
+static struct omap_hwmod_ocp_if am43xx_dss__l3_main = {
+   .master = am43xx_dss_core_hwmod,
+   .slave  = am33xx_l3_main_hwmod,
+   .clk= disp_clk,
+   .user   = OCP_USER_MPU | OCP_USER_SDMA,
+};
+
+static struct omap_hwmod_ocp_if am43xx_l4_ls__dss = {
+   .master = am33xx_l4_ls_hwmod,
+   .slave  = am43xx_dss_core_hwmod,
+   .clk= l4ls_gclk,
+   .user   = OCP_USER_MPU | OCP_USER_SDMA,
+};
+
+static struct omap_hwmod_ocp_if am43xx_l4_ls__dss_dispc = {
+   .master = am33xx_l4_ls_hwmod,
+   .slave  = am43xx_dss_dispc_hwmod,
+   .clk= l4ls_gclk,
+   .user   = OCP_USER_MPU | OCP_USER_SDMA,
+};
+
+static struct omap_hwmod_ocp_if am43xx_l4_ls__dss_rfbi = {
+   .master = am33xx_l4_ls_hwmod,
+   .slave  = am43xx_dss_rfbi_hwmod,
+   .clk= l4ls_gclk,
+   .user   = OCP_USER_MPU | OCP_USER_SDMA,
+};
+
 static struct omap_hwmod_ocp_if *am43xx_hwmod_ocp_ifs[] __initdata = {
am33xx_l4_wkup__synctimer,
am43xx_l4_ls__timer8,
@@ -748,6 +848,10 @@ static struct omap_hwmod_ocp_if *am43xx_hwmod_ocp_ifs[] 
__initdata = {
am43xx_l4_ls__ocp2scp1,
am43xx_l3_s__usbotgss0,
am43xx_l3_s__usbotgss1,
+   am43xx_dss__l3_main,
+   am43xx_l4_ls__dss,
+   am43xx_l4_ls__dss_dispc,
+   am43xx_l4_ls__dss_rfbi,
NULL,
 };
 
diff --git a/arch/arm/mach-omap2/prcm43xx.h b/arch/arm/mach-omap2/prcm43xx.h
index 7785be984edd..ad7b3e9977f8 100644
--- a/arch/arm/mach-omap2/prcm43xx.h
+++ b/arch/arm/mach-omap2/prcm43xx.h
@@ -142,5 +142,6 @@
 #define AM43XX_CM_PER_USBPHYOCP2SCP0_CLKCTRL_OFFSET