Re: [PATCH 05/13] OMAP23: hwmod: Remove _hwmod prefix in name string

2010-07-02 Thread Paul Walmsley 
Hi,

On Wed, 23 Jun 2010, Kevin Hilman wrote:

 From: Benoit Cousson b-cous...@ti.com
 
 In the lastest OMAP4 hwmod data file, the _hwmod was removed
 in order to save some memory space and because it does not
 bring a lot.
 Align OMAP2420, 2430 and 3430 data files with the same convention.
 
 Signed-off-by: Benoit Cousson b-cous...@ti.com
 Cc: Paul Walmsley p...@pwsan.com
 Cc: Rajendra Nayak rna...@ti.com
 Signed-off-by: Kevin Hilman khil...@deeprootsystems.com

I've taken Benoît's original patch for this, so have converted your 
Signed-off-by: into an Acked-by: for this patch.


- Paul

RE: [PATCH 05/13] OMAP23: hwmod: Remove _hwmod prefix in name string

2010-06-24 Thread Cousson, Benoit 
Hi Paul,

From: Paul Walmsley [mailto:p...@pwsan.com]
Sent: Thursday, June 24, 2010 7:05 AM

Benoît,

one minor comment here:

On Wed, 23 Jun 2010, Kevin Hilman wrote:

 From: Benoit Cousson b-cous...@ti.com

 In the lastest OMAP4 hwmod data file, the _hwmod was removed
 in order to save some memory space and because it does not
 bring a lot.
 Align OMAP2420, 2430 and 3430 data files with the same convention.

Shouldn't we also synchronize the names of the structures as
well?  i.e.,
if the name is changed to l3_main, shouldn't the name of the
structure
also be changed from

   static struct omap_hwmod omap2420_l3_hwmod = {

to

   static struct omap_hwmod omap2420_l3_main_hwmod = {

(... as one example?)

You're right, I didn't change that because only the string is relevant
for the lookup, but it will be much more consitent to change the structures
as well.

I'll do it.

Thanks,
Benoit



- Paul


 Signed-off-by: Benoit Cousson b-cous...@ti.com
 Cc: Paul Walmsley p...@pwsan.com
 Cc: Rajendra Nayak rna...@ti.com
 Signed-off-by: Kevin Hilman khil...@deeprootsystems.com
 ---
  arch/arm/mach-omap2/omap_hwmod_2420_data.c |6 +++---
  arch/arm/mach-omap2/omap_hwmod_2430_data.c |6 +++---
  arch/arm/mach-omap2/omap_hwmod_3xxx_data.c |8 
  3 files changed, 10 insertions(+), 10 deletions(-)

 diff --git a/arch/arm/mach-omap2/omap_hwmod_2420_data.c
b/arch/arm/mach-omap2/omap_hwmod_2420_data.c
 index a8b57a6..646386c 100644
 --- a/arch/arm/mach-omap2/omap_hwmod_2420_data.c
 +++ b/arch/arm/mach-omap2/omap_hwmod_2420_data.c
 @@ -59,7 +59,7 @@ static struct omap_hwmod_ocp_if
*omap2420_l3_masters[] = {

  /* L3 */
  static struct omap_hwmod omap2420_l3_hwmod = {
 -.name   = l3_hwmod,
 +.name   = l3_main,
  .class  = l3_hwmod_class,
  .masters= omap2420_l3_masters,
  .masters_cnt= ARRAY_SIZE(omap2420_l3_masters),
 @@ -90,7 +90,7 @@ static struct omap_hwmod_ocp_if
*omap2420_l4_core_masters[] = {

  /* L4 CORE */
  static struct omap_hwmod omap2420_l4_core_hwmod = {
 -.name   = l4_core_hwmod,
 +.name   = l4_core,
  .class  = l4_hwmod_class,
  .masters= omap2420_l4_core_masters,
  .masters_cnt= ARRAY_SIZE(omap2420_l4_core_masters),
 @@ -111,7 +111,7 @@ static struct omap_hwmod_ocp_if
*omap2420_l4_wkup_masters[] = {

  /* L4 WKUP */
  static struct omap_hwmod omap2420_l4_wkup_hwmod = {
 -.name   = l4_wkup_hwmod,
 +.name   = l4_wkup,
  .class  = l4_hwmod_class,
  .masters= omap2420_l4_wkup_masters,
  .masters_cnt= ARRAY_SIZE(omap2420_l4_wkup_masters),
 diff --git a/arch/arm/mach-omap2/omap_hwmod_2430_data.c
b/arch/arm/mach-omap2/omap_hwmod_2430_data.c
 index 8b1f74b..b2100cf 100644
 --- a/arch/arm/mach-omap2/omap_hwmod_2430_data.c
 +++ b/arch/arm/mach-omap2/omap_hwmod_2430_data.c
 @@ -59,7 +59,7 @@ static struct omap_hwmod_ocp_if
*omap2430_l3_masters[] = {

  /* L3 */
  static struct omap_hwmod omap2430_l3_hwmod = {
 -.name   = l3_hwmod,
 +.name   = l3_main,
  .class  = l3_hwmod_class,
  .masters= omap2430_l3_masters,
  .masters_cnt= ARRAY_SIZE(omap2430_l3_masters),
 @@ -92,7 +92,7 @@ static struct omap_hwmod_ocp_if
*omap2430_l4_core_masters[] = {

  /* L4 CORE */
  static struct omap_hwmod omap2430_l4_core_hwmod = {
 -.name   = l4_core_hwmod,
 +.name   = l4_core,
  .class  = l4_hwmod_class,
  .masters= omap2430_l4_core_masters,
  .masters_cnt= ARRAY_SIZE(omap2430_l4_core_masters),
 @@ -113,7 +113,7 @@ static struct omap_hwmod_ocp_if
*omap2430_l4_wkup_masters[] = {

  /* L4 WKUP */
  static struct omap_hwmod omap2430_l4_wkup_hwmod = {
 -.name   = l4_wkup_hwmod,
 +.name   = l4_wkup,
  .class  = l4_hwmod_class,
  .masters= omap2430_l4_wkup_masters,
  .masters_cnt= ARRAY_SIZE(omap2430_l4_wkup_masters),
 diff --git a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
 index e288b20..ec6a5f8 100644
 --- a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
 +++ b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
 @@ -70,7 +70,7 @@ static struct omap_hwmod_ocp_if
*omap3xxx_l3_masters[] = {

  /* L3 */
  static struct omap_hwmod omap3xxx_l3_hwmod = {
 -.name   = l3_hwmod,
 +.name   = l3_main,
  .class  = l3_hwmod_class,
  .masters= omap3xxx_l3_masters,
  .masters_cnt= ARRAY_SIZE(omap3xxx_l3_masters),
 @@ -101,7 +101,7 @@ static struct omap_hwmod_ocp_if
*omap3xxx_l4_core_masters[] = {

  /* L4 CORE */
  static struct omap_hwmod omap3xxx_l4_core_hwmod = {
 -.name   = l4_core_hwmod,
 +.name   = l4_core,
  .class  = l4_hwmod_class,
  .masters= omap3xxx_l4_core_masters,
  .masters_cnt= ARRAY_SIZE(omap3xxx_l4_core_masters),
 @@ -122,7 +122,7 @@ static struct

[PATCH 05/13] OMAP23: hwmod: Remove _hwmod prefix in name string

2010-06-23 Thread Kevin Hilman 
From: Benoit Cousson b-cous...@ti.com

In the lastest OMAP4 hwmod data file, the _hwmod was removed
in order to save some memory space and because it does not
bring a lot.
Align OMAP2420, 2430 and 3430 data files with the same convention.

Signed-off-by: Benoit Cousson b-cous...@ti.com
Cc: Paul Walmsley p...@pwsan.com
Cc: Rajendra Nayak rna...@ti.com
Signed-off-by: Kevin Hilman khil...@deeprootsystems.com
---
 arch/arm/mach-omap2/omap_hwmod_2420_data.c |6 +++---
 arch/arm/mach-omap2/omap_hwmod_2430_data.c |6 +++---
 arch/arm/mach-omap2/omap_hwmod_3xxx_data.c |8 
 3 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/arch/arm/mach-omap2/omap_hwmod_2420_data.c 
b/arch/arm/mach-omap2/omap_hwmod_2420_data.c
index a8b57a6..646386c 100644
--- a/arch/arm/mach-omap2/omap_hwmod_2420_data.c
+++ b/arch/arm/mach-omap2/omap_hwmod_2420_data.c
@@ -59,7 +59,7 @@ static struct omap_hwmod_ocp_if *omap2420_l3_masters[] = {
 
 /* L3 */
 static struct omap_hwmod omap2420_l3_hwmod = {
-   .name   = l3_hwmod,
+   .name   = l3_main,
.class  = l3_hwmod_class,
.masters= omap2420_l3_masters,
.masters_cnt= ARRAY_SIZE(omap2420_l3_masters),
@@ -90,7 +90,7 @@ static struct omap_hwmod_ocp_if *omap2420_l4_core_masters[] = 
{
 
 /* L4 CORE */
 static struct omap_hwmod omap2420_l4_core_hwmod = {
-   .name   = l4_core_hwmod,
+   .name   = l4_core,
.class  = l4_hwmod_class,
.masters= omap2420_l4_core_masters,
.masters_cnt= ARRAY_SIZE(omap2420_l4_core_masters),
@@ -111,7 +111,7 @@ static struct omap_hwmod_ocp_if *omap2420_l4_wkup_masters[] 
= {
 
 /* L4 WKUP */
 static struct omap_hwmod omap2420_l4_wkup_hwmod = {
-   .name   = l4_wkup_hwmod,
+   .name   = l4_wkup,
.class  = l4_hwmod_class,
.masters= omap2420_l4_wkup_masters,
.masters_cnt= ARRAY_SIZE(omap2420_l4_wkup_masters),
diff --git a/arch/arm/mach-omap2/omap_hwmod_2430_data.c 
b/arch/arm/mach-omap2/omap_hwmod_2430_data.c
index 8b1f74b..b2100cf 100644
--- a/arch/arm/mach-omap2/omap_hwmod_2430_data.c
+++ b/arch/arm/mach-omap2/omap_hwmod_2430_data.c
@@ -59,7 +59,7 @@ static struct omap_hwmod_ocp_if *omap2430_l3_masters[] = {
 
 /* L3 */
 static struct omap_hwmod omap2430_l3_hwmod = {
-   .name   = l3_hwmod,
+   .name   = l3_main,
.class  = l3_hwmod_class,
.masters= omap2430_l3_masters,
.masters_cnt= ARRAY_SIZE(omap2430_l3_masters),
@@ -92,7 +92,7 @@ static struct omap_hwmod_ocp_if *omap2430_l4_core_masters[] = 
{
 
 /* L4 CORE */
 static struct omap_hwmod omap2430_l4_core_hwmod = {
-   .name   = l4_core_hwmod,
+   .name   = l4_core,
.class  = l4_hwmod_class,
.masters= omap2430_l4_core_masters,
.masters_cnt= ARRAY_SIZE(omap2430_l4_core_masters),
@@ -113,7 +113,7 @@ static struct omap_hwmod_ocp_if *omap2430_l4_wkup_masters[] 
= {
 
 /* L4 WKUP */
 static struct omap_hwmod omap2430_l4_wkup_hwmod = {
-   .name   = l4_wkup_hwmod,
+   .name   = l4_wkup,
.class  = l4_hwmod_class,
.masters= omap2430_l4_wkup_masters,
.masters_cnt= ARRAY_SIZE(omap2430_l4_wkup_masters),
diff --git a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c 
b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
index e288b20..ec6a5f8 100644
--- a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
+++ b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
@@ -70,7 +70,7 @@ static struct omap_hwmod_ocp_if *omap3xxx_l3_masters[] = {
 
 /* L3 */
 static struct omap_hwmod omap3xxx_l3_hwmod = {
-   .name   = l3_hwmod,
+   .name   = l3_main,
.class  = l3_hwmod_class,
.masters= omap3xxx_l3_masters,
.masters_cnt= ARRAY_SIZE(omap3xxx_l3_masters),
@@ -101,7 +101,7 @@ static struct omap_hwmod_ocp_if *omap3xxx_l4_core_masters[] 
= {
 
 /* L4 CORE */
 static struct omap_hwmod omap3xxx_l4_core_hwmod = {
-   .name   = l4_core_hwmod,
+   .name   = l4_core,
.class  = l4_hwmod_class,
.masters= omap3xxx_l4_core_masters,
.masters_cnt= ARRAY_SIZE(omap3xxx_l4_core_masters),
@@ -122,7 +122,7 @@ static struct omap_hwmod_ocp_if *omap3xxx_l4_per_masters[] 
= {
 
 /* L4 PER */
 static struct omap_hwmod omap3xxx_l4_per_hwmod = {
-   .name   = l4_per_hwmod,
+   .name   = l4_per,
.class  = l4_hwmod_class,
.masters= omap3xxx_l4_per_masters,
.masters_cnt= ARRAY_SIZE(omap3xxx_l4_per_masters),
@@ -143,7 +143,7 @@ static struct omap_hwmod_ocp_if *omap3xxx_l4_wkup_masters[] 
= {
 
 /* L4 WKUP */
 static struct omap_hwmod omap3xxx_l4_wkup_hwmod = {
-   .name   = l4_wkup_hwmod,
+   .name   = l4_wkup,
.class  = l4_hwmod_class,

Re: [PATCH 05/13] OMAP23: hwmod: Remove _hwmod prefix in name string

2010-06-23 Thread Paul Walmsley 
Benoît,

one minor comment here:

On Wed, 23 Jun 2010, Kevin Hilman wrote:

 From: Benoit Cousson b-cous...@ti.com
 
 In the lastest OMAP4 hwmod data file, the _hwmod was removed
 in order to save some memory space and because it does not
 bring a lot.
 Align OMAP2420, 2430 and 3430 data files with the same convention.

Shouldn't we also synchronize the names of the structures as well?  i.e., 
if the name is changed to l3_main, shouldn't the name of the structure 
also be changed from 

   static struct omap_hwmod omap2420_l3_hwmod = {

to 

   static struct omap_hwmod omap2420_l3_main_hwmod = {

(... as one example?)


- Paul

 
 Signed-off-by: Benoit Cousson b-cous...@ti.com
 Cc: Paul Walmsley p...@pwsan.com
 Cc: Rajendra Nayak rna...@ti.com
 Signed-off-by: Kevin Hilman khil...@deeprootsystems.com
 ---
  arch/arm/mach-omap2/omap_hwmod_2420_data.c |6 +++---
  arch/arm/mach-omap2/omap_hwmod_2430_data.c |6 +++---
  arch/arm/mach-omap2/omap_hwmod_3xxx_data.c |8 
  3 files changed, 10 insertions(+), 10 deletions(-)
 
 diff --git a/arch/arm/mach-omap2/omap_hwmod_2420_data.c 
 b/arch/arm/mach-omap2/omap_hwmod_2420_data.c
 index a8b57a6..646386c 100644
 --- a/arch/arm/mach-omap2/omap_hwmod_2420_data.c
 +++ b/arch/arm/mach-omap2/omap_hwmod_2420_data.c
 @@ -59,7 +59,7 @@ static struct omap_hwmod_ocp_if *omap2420_l3_masters[] = {
  
  /* L3 */
  static struct omap_hwmod omap2420_l3_hwmod = {
 - .name   = l3_hwmod,
 + .name   = l3_main,
   .class  = l3_hwmod_class,
   .masters= omap2420_l3_masters,
   .masters_cnt= ARRAY_SIZE(omap2420_l3_masters),
 @@ -90,7 +90,7 @@ static struct omap_hwmod_ocp_if *omap2420_l4_core_masters[] 
 = {
  
  /* L4 CORE */
  static struct omap_hwmod omap2420_l4_core_hwmod = {
 - .name   = l4_core_hwmod,
 + .name   = l4_core,
   .class  = l4_hwmod_class,
   .masters= omap2420_l4_core_masters,
   .masters_cnt= ARRAY_SIZE(omap2420_l4_core_masters),
 @@ -111,7 +111,7 @@ static struct omap_hwmod_ocp_if 
 *omap2420_l4_wkup_masters[] = {
  
  /* L4 WKUP */
  static struct omap_hwmod omap2420_l4_wkup_hwmod = {
 - .name   = l4_wkup_hwmod,
 + .name   = l4_wkup,
   .class  = l4_hwmod_class,
   .masters= omap2420_l4_wkup_masters,
   .masters_cnt= ARRAY_SIZE(omap2420_l4_wkup_masters),
 diff --git a/arch/arm/mach-omap2/omap_hwmod_2430_data.c 
 b/arch/arm/mach-omap2/omap_hwmod_2430_data.c
 index 8b1f74b..b2100cf 100644
 --- a/arch/arm/mach-omap2/omap_hwmod_2430_data.c
 +++ b/arch/arm/mach-omap2/omap_hwmod_2430_data.c
 @@ -59,7 +59,7 @@ static struct omap_hwmod_ocp_if *omap2430_l3_masters[] = {
  
  /* L3 */
  static struct omap_hwmod omap2430_l3_hwmod = {
 - .name   = l3_hwmod,
 + .name   = l3_main,
   .class  = l3_hwmod_class,
   .masters= omap2430_l3_masters,
   .masters_cnt= ARRAY_SIZE(omap2430_l3_masters),
 @@ -92,7 +92,7 @@ static struct omap_hwmod_ocp_if *omap2430_l4_core_masters[] 
 = {
  
  /* L4 CORE */
  static struct omap_hwmod omap2430_l4_core_hwmod = {
 - .name   = l4_core_hwmod,
 + .name   = l4_core,
   .class  = l4_hwmod_class,
   .masters= omap2430_l4_core_masters,
   .masters_cnt= ARRAY_SIZE(omap2430_l4_core_masters),
 @@ -113,7 +113,7 @@ static struct omap_hwmod_ocp_if 
 *omap2430_l4_wkup_masters[] = {
  
  /* L4 WKUP */
  static struct omap_hwmod omap2430_l4_wkup_hwmod = {
 - .name   = l4_wkup_hwmod,
 + .name   = l4_wkup,
   .class  = l4_hwmod_class,
   .masters= omap2430_l4_wkup_masters,
   .masters_cnt= ARRAY_SIZE(omap2430_l4_wkup_masters),
 diff --git a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c 
 b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
 index e288b20..ec6a5f8 100644
 --- a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
 +++ b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
 @@ -70,7 +70,7 @@ static struct omap_hwmod_ocp_if *omap3xxx_l3_masters[] = {
  
  /* L3 */
  static struct omap_hwmod omap3xxx_l3_hwmod = {
 - .name   = l3_hwmod,
 + .name   = l3_main,
   .class  = l3_hwmod_class,
   .masters= omap3xxx_l3_masters,
   .masters_cnt= ARRAY_SIZE(omap3xxx_l3_masters),
 @@ -101,7 +101,7 @@ static struct omap_hwmod_ocp_if 
 *omap3xxx_l4_core_masters[] = {
  
  /* L4 CORE */
  static struct omap_hwmod omap3xxx_l4_core_hwmod = {
 - .name   = l4_core_hwmod,
 + .name   = l4_core,
   .class  = l4_hwmod_class,
   .masters= omap3xxx_l4_core_masters,
   .masters_cnt= ARRAY_SIZE(omap3xxx_l4_core_masters),
 @@ -122,7 +122,7 @@ static struct omap_hwmod_ocp_if 
 *omap3xxx_l4_per_masters[] = {
  
  /* L4 PER */
  static struct omap_hwmod omap3xxx_l4_per_hwmod = {
 - .name   = l4_per_hwmod,
 + .name   = l4_per,