RE: [PATCH 09/12] ARM: OMAP2+: powerdomain: skip register reads for powerdomains known to be on

2012-12-26 Thread Paul Walmsley 
On Wed, 26 Dec 2012, Bedia, Vaibhav wrote:

 In case of AM33xx, this flag should be set for PER and WKUP pwrdms also.
 EMIF, L3, L4 etc come under PER so this domain can't transition on an active
 system. PRCM and Control module come under WKUP, so the WKUP should the kernel
 should attempt to transition WKUP domain also.

Thanks - the patch has been updated to reflect this.

- Paul
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH 09/12] ARM: OMAP2+: powerdomain: skip register reads for powerdomains known to be on

2012-12-25 Thread Bedia, Vaibhav 
Hi Paul,

On Mon, Dec 10, 2012 at 01:33:28, Paul Walmsley wrote:
 There's no need to determine the current power state for powerdomains
 that must be on while the kernel is running.  We mark these
 powerdomains with a new flag, PWRDM_ACTIVE_WITH_KERNEL.  Any
 powerdomain marked with that flag is reported as being in the ON power
 state while the kernel is running.
[...]
 diff --git a/arch/arm/mach-omap2/powerdomains33xx_data.c 
 b/arch/arm/mach-omap2/powerdomains33xx_data.c
 index 869adb8..acb148a 100644
 --- a/arch/arm/mach-omap2/powerdomains33xx_data.c
 +++ b/arch/arm/mach-omap2/powerdomains33xx_data.c
 @@ -123,7 +123,8 @@ static struct powerdomain mpu_33xx_pwrdm = {
   .pwrstst_offs   = AM33XX_PM_MPU_PWRSTST_OFFSET,
   .pwrsts = PWRSTS_OFF_RET_ON,
   .pwrsts_logic_ret   = PWRSTS_OFF_RET,
 - .flags  = PWRDM_HAS_LOWPOWERSTATECHANGE,
 + .flags  = (PWRDM_HAS_LOWPOWERSTATECHANGE |
 +PWRDM_ACTIVE_WITH_KERNEL),

In case of AM33xx, this flag should be set for PER and WKUP pwrdms also.
EMIF, L3, L4 etc come under PER so this domain can't transition on an active
system. PRCM and Control module come under WKUP, so the WKUP should the kernel
should attempt to transition WKUP domain also.

Regards,
Vaibhav

RE: [PATCH 09/12] ARM: OMAP2+: powerdomain: skip register reads for powerdomains known to be on

2012-12-25 Thread Bedia, Vaibhav 
On Wed, Dec 26, 2012 at 11:51:46, Bedia, Vaibhav wrote:
 Hi Paul,
 
 On Mon, Dec 10, 2012 at 01:33:28, Paul Walmsley wrote:
  There's no need to determine the current power state for powerdomains
  that must be on while the kernel is running.  We mark these
  powerdomains with a new flag, PWRDM_ACTIVE_WITH_KERNEL.  Any
  powerdomain marked with that flag is reported as being in the ON power
  state while the kernel is running.
 [...]
  diff --git a/arch/arm/mach-omap2/powerdomains33xx_data.c 
  b/arch/arm/mach-omap2/powerdomains33xx_data.c
  index 869adb8..acb148a 100644
  --- a/arch/arm/mach-omap2/powerdomains33xx_data.c
  +++ b/arch/arm/mach-omap2/powerdomains33xx_data.c
  @@ -123,7 +123,8 @@ static struct powerdomain mpu_33xx_pwrdm = {
  .pwrstst_offs   = AM33XX_PM_MPU_PWRSTST_OFFSET,
  .pwrsts = PWRSTS_OFF_RET_ON,
  .pwrsts_logic_ret   = PWRSTS_OFF_RET,
  -   .flags  = PWRDM_HAS_LOWPOWERSTATECHANGE,
  +   .flags  = (PWRDM_HAS_LOWPOWERSTATECHANGE |
  +  PWRDM_ACTIVE_WITH_KERNEL),
 
 In case of AM33xx, this flag should be set for PER and WKUP pwrdms also.
 EMIF, L3, L4 etc come under PER so this domain can't transition on an active
 system. PRCM and Control module come under WKUP, so

... the kernel should not attempt to change the WKUP power domain state.

Regards,
Vaibhav 

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 09/12] ARM: OMAP2+: powerdomain: skip register reads for powerdomains known to be on

2012-12-20 Thread Paul Walmsley 
On Wed, 19 Dec 2012, Jon Hunter wrote:

 My understanding is that for OMAP4 devices, the core power domain may
 not be active the same time as the MPU power domain. The Cortex-A9 has
 the ability to access some peripherals (such as timer, McBSP) via a
 private bus that does not require the core domain to be active. This is
 a difference from OMAP3 devices, where the core would always be on with
 the MPU power domain.

You are absolutely right and I will drop that part from this patch.


- Paul
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 09/12] ARM: OMAP2+: powerdomain: skip register reads for powerdomains known to be on

2012-12-20 Thread Santosh Shilimkar 

On Thursday 20 December 2012 10:52 PM, Paul Walmsley wrote:

On Wed, 19 Dec 2012, Jon Hunter wrote:


My understanding is that for OMAP4 devices, the core power domain may
not be active the same time as the MPU power domain. The Cortex-A9 has
the ability to access some peripherals (such as timer, McBSP) via a
private bus that does not require the core domain to be active. This is
a difference from OMAP3 devices, where the core would always be on with
the MPU power domain.


You are absolutely right and I will drop that part from this patch.


Just to be clear, MPU has direct path to ABE domain peripherals on
OMAP4. As Jon pointed out MCBSP and few timers are put under this
domain can be directly accessed by MPU without L3. ABE also can
be accessed via L3 by MPU. ABE has a dual map with MPU.


Regards
Santosh

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 09/12] ARM: OMAP2+: powerdomain: skip register reads for powerdomains known to be on

2012-12-19 Thread Jon Hunter 
Hi Paul,

On 12/09/2012 02:03 PM, Paul Walmsley wrote:
 There's no need to determine the current power state for powerdomains
 that must be on while the kernel is running.  We mark these
 powerdomains with a new flag, PWRDM_ACTIVE_WITH_KERNEL.  Any
 powerdomain marked with that flag is reported as being in the ON power
 state while the kernel is running.
 
 Signed-off-by: Paul Walmsley p...@pwsan.com
 Cc: Benoît Cousson b-cous...@ti.com
 ---
  arch/arm/mach-omap2/powerdomain.c   |9 ++---
  arch/arm/mach-omap2/powerdomain.h   |4 
  arch/arm/mach-omap2/powerdomains2xxx_data.c |2 ++
  arch/arm/mach-omap2/powerdomains33xx_data.c |3 ++-
  arch/arm/mach-omap2/powerdomains3xxx_data.c |9 ++---
  arch/arm/mach-omap2/powerdomains44xx_data.c |5 -
  6 files changed, 24 insertions(+), 8 deletions(-)

[snip]

 diff --git a/arch/arm/mach-omap2/powerdomains44xx_data.c 
 b/arch/arm/mach-omap2/powerdomains44xx_data.c
 index 704664c..b64213c 100644
 --- a/arch/arm/mach-omap2/powerdomains44xx_data.c
 +++ b/arch/arm/mach-omap2/powerdomains44xx_data.c
 @@ -53,7 +53,8 @@ static struct powerdomain core_44xx_pwrdm = {
   [3] = PWRSTS_ON,/* ducati_l2ram */
   [4] = PWRSTS_ON,/* ducati_unicache */
   },
 - .flags= PWRDM_HAS_LOWPOWERSTATECHANGE,
 + .flags= (PWRDM_HAS_LOWPOWERSTATECHANGE |
 +  PWRDM_ACTIVE_WITH_KERNEL),
  };

My understanding is that for OMAP4 devices, the core power domain may
not be active the same time as the MPU power domain. The Cortex-A9 has
the ability to access some peripherals (such as timer, McBSP) via a
private bus that does not require the core domain to be active. This is
a difference from OMAP3 devices, where the core would always be on with
the MPU power domain.

Hopefully, Benoit will chime in if I have gotten this wrong ;-)

Cheers
Jon
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 09/12] ARM: OMAP2+: powerdomain: skip register reads for powerdomains known to be on

2012-12-12 Thread Vaibhav Hiremath 


On 12/10/2012 1:33 AM, Paul Walmsley wrote:
 There's no need to determine the current power state for powerdomains
 that must be on while the kernel is running.  We mark these
 powerdomains with a new flag, PWRDM_ACTIVE_WITH_KERNEL.  Any
 powerdomain marked with that flag is reported as being in the ON power
 state while the kernel is running.
 
 Signed-off-by: Paul Walmsley p...@pwsan.com
 Cc: Benoît Cousson b-cous...@ti.com
 ---
  arch/arm/mach-omap2/powerdomain.c   |9 ++---
  arch/arm/mach-omap2/powerdomain.h   |4 
  arch/arm/mach-omap2/powerdomains2xxx_data.c |2 ++
  arch/arm/mach-omap2/powerdomains33xx_data.c |3 ++-
  arch/arm/mach-omap2/powerdomains3xxx_data.c |9 ++---
  arch/arm/mach-omap2/powerdomains44xx_data.c |5 -
  6 files changed, 24 insertions(+), 8 deletions(-)
 
 diff --git a/arch/arm/mach-omap2/powerdomain.c 
 b/arch/arm/mach-omap2/powerdomain.c
 index f5e2727..a4bb0bb 100644
 --- a/arch/arm/mach-omap2/powerdomain.c
 +++ b/arch/arm/mach-omap2/powerdomain.c
 @@ -462,7 +462,8 @@ static int _pwrdm_read_fpwrst(struct powerdomain *pwrdm)
   int pwrst, logic_pwrst, ret;
   u8 fpwrst;
  
 - if (!_pwrdm_pwrst_can_change(pwrdm))
 + if (!_pwrdm_pwrst_can_change(pwrdm) ||
 + pwrdm-flags  PWRDM_ACTIVE_WITH_KERNEL)
   return PWRDM_FUNC_PWRST_ON;
  
   pwrst = arch_pwrdm-pwrdm_read_pwrst(pwrdm);
 @@ -1104,12 +1105,14 @@ bool pwrdm_has_hdwr_sar(struct powerdomain *pwrdm)
  
  int pwrdm_state_switch_nolock(struct powerdomain *pwrdm)
  {
 - int ret;
 + int ret = 0;
  
   if (!pwrdm || !arch_pwrdm)
   return -EINVAL;
  
 - ret = arch_pwrdm-pwrdm_wait_transition(pwrdm);
 + if (!(pwrdm-flags  PWRDM_ACTIVE_WITH_KERNEL))
 + ret = arch_pwrdm-pwrdm_wait_transition(pwrdm);
 +
   if (!ret)
   _pwrdm_state_switch(pwrdm);
  
 diff --git a/arch/arm/mach-omap2/powerdomain.h 
 b/arch/arm/mach-omap2/powerdomain.h
 index f4a189a..10941fd 100644
 --- a/arch/arm/mach-omap2/powerdomain.h
 +++ b/arch/arm/mach-omap2/powerdomain.h
 @@ -78,10 +78,14 @@ enum pwrdm_func_state {
   *
   * PWRDM_HAS_LOWPOWERSTATECHANGE - can transition from a sleep state
   * to a lower sleep state without waking up the powerdomain
 + *
 + * PWRDM_ACTIVE_WITH_KERNEL - this powerdomain's current power state is
 + * guaranteed to be ON whenever the kernel is running
   */
  #define PWRDM_HAS_HDWR_SAR   BIT(0)
  #define PWRDM_HAS_MPU_QUIRK  BIT(1)
  #define PWRDM_HAS_LOWPOWERSTATECHANGEBIT(2)
 +#define PWRDM_ACTIVE_WITH_KERNEL BIT(3)
  
  /*
   * Powerdomain internal flags (struct powerdomain._flags)
 diff --git a/arch/arm/mach-omap2/powerdomains2xxx_data.c 
 b/arch/arm/mach-omap2/powerdomains2xxx_data.c
 index 578eef8..112927f 100644
 --- a/arch/arm/mach-omap2/powerdomains2xxx_data.c
 +++ b/arch/arm/mach-omap2/powerdomains2xxx_data.c
 @@ -54,6 +54,7 @@ static struct powerdomain mpu_24xx_pwrdm = {
   [0] = PWRSTS_ON,
   },
   .voltdm   = { .name = core },
 + .flags= PWRDM_ACTIVE_WITH_KERNEL,
  };
  
  static struct powerdomain core_24xx_pwrdm = {
 @@ -73,6 +74,7 @@ static struct powerdomain core_24xx_pwrdm = {
   [2] = PWRSTS_OFF_RET_ON, /* MEM3ONSTATE */
   },
   .voltdm   = { .name = core },
 + .flags= PWRDM_ACTIVE_WITH_KERNEL,
  };
  
  
 diff --git a/arch/arm/mach-omap2/powerdomains33xx_data.c 
 b/arch/arm/mach-omap2/powerdomains33xx_data.c
 index 869adb8..acb148a 100644
 --- a/arch/arm/mach-omap2/powerdomains33xx_data.c
 +++ b/arch/arm/mach-omap2/powerdomains33xx_data.c
 @@ -123,7 +123,8 @@ static struct powerdomain mpu_33xx_pwrdm = {
   .pwrstst_offs   = AM33XX_PM_MPU_PWRSTST_OFFSET,
   .pwrsts = PWRSTS_OFF_RET_ON,
   .pwrsts_logic_ret   = PWRSTS_OFF_RET,
 - .flags  = PWRDM_HAS_LOWPOWERSTATECHANGE,
 + .flags  = (PWRDM_HAS_LOWPOWERSTATECHANGE |
 +PWRDM_ACTIVE_WITH_KERNEL),

This needs to be applicable for wkup_pwrdm as well.

Thanks,
Vaibhav


   .banks  = 3,
   .logicretstate_mask = AM33XX_LOGICRETSTATE_MASK,
   .mem_on_mask= {
 diff --git a/arch/arm/mach-omap2/powerdomains3xxx_data.c 
 b/arch/arm/mach-omap2/powerdomains3xxx_data.c
 index f0e14e9ef..ade93d3 100644
 --- a/arch/arm/mach-omap2/powerdomains3xxx_data.c
 +++ b/arch/arm/mach-omap2/powerdomains3xxx_data.c
 @@ -58,7 +58,7 @@ static struct powerdomain mpu_3xxx_pwrdm = {
   .prcm_offs= MPU_MOD,
   .pwrsts   = PWRSTS_OFF_RET_ON,
   .pwrsts_logic_ret = PWRSTS_OFF_RET,
 - .flags= PWRDM_HAS_MPU_QUIRK,
 + .flags= (PWRDM_HAS_MPU_QUIRK | PWRDM_ACTIVE_WITH_KERNEL),
   .banks= 1,
   .pwrsts_mem_ret   = {
   [0] = PWRSTS_OFF_RET,
 @@ -74,7 +74,7 @@ static struct powerdomain

[PATCH 09/12] ARM: OMAP2+: powerdomain: skip register reads for powerdomains known to be on

2012-12-09 Thread Paul Walmsley 
There's no need to determine the current power state for powerdomains
that must be on while the kernel is running.  We mark these
powerdomains with a new flag, PWRDM_ACTIVE_WITH_KERNEL.  Any
powerdomain marked with that flag is reported as being in the ON power
state while the kernel is running.

Signed-off-by: Paul Walmsley p...@pwsan.com
Cc: Benoît Cousson b-cous...@ti.com
---
 arch/arm/mach-omap2/powerdomain.c   |9 ++---
 arch/arm/mach-omap2/powerdomain.h   |4 
 arch/arm/mach-omap2/powerdomains2xxx_data.c |2 ++
 arch/arm/mach-omap2/powerdomains33xx_data.c |3 ++-
 arch/arm/mach-omap2/powerdomains3xxx_data.c |9 ++---
 arch/arm/mach-omap2/powerdomains44xx_data.c |5 -
 6 files changed, 24 insertions(+), 8 deletions(-)

diff --git a/arch/arm/mach-omap2/powerdomain.c 
b/arch/arm/mach-omap2/powerdomain.c
index f5e2727..a4bb0bb 100644
--- a/arch/arm/mach-omap2/powerdomain.c
+++ b/arch/arm/mach-omap2/powerdomain.c
@@ -462,7 +462,8 @@ static int _pwrdm_read_fpwrst(struct powerdomain *pwrdm)
int pwrst, logic_pwrst, ret;
u8 fpwrst;
 
-   if (!_pwrdm_pwrst_can_change(pwrdm))
+   if (!_pwrdm_pwrst_can_change(pwrdm) ||
+   pwrdm-flags  PWRDM_ACTIVE_WITH_KERNEL)
return PWRDM_FUNC_PWRST_ON;
 
pwrst = arch_pwrdm-pwrdm_read_pwrst(pwrdm);
@@ -1104,12 +1105,14 @@ bool pwrdm_has_hdwr_sar(struct powerdomain *pwrdm)
 
 int pwrdm_state_switch_nolock(struct powerdomain *pwrdm)
 {
-   int ret;
+   int ret = 0;
 
if (!pwrdm || !arch_pwrdm)
return -EINVAL;
 
-   ret = arch_pwrdm-pwrdm_wait_transition(pwrdm);
+   if (!(pwrdm-flags  PWRDM_ACTIVE_WITH_KERNEL))
+   ret = arch_pwrdm-pwrdm_wait_transition(pwrdm);
+
if (!ret)
_pwrdm_state_switch(pwrdm);
 
diff --git a/arch/arm/mach-omap2/powerdomain.h 
b/arch/arm/mach-omap2/powerdomain.h
index f4a189a..10941fd 100644
--- a/arch/arm/mach-omap2/powerdomain.h
+++ b/arch/arm/mach-omap2/powerdomain.h
@@ -78,10 +78,14 @@ enum pwrdm_func_state {
  *
  * PWRDM_HAS_LOWPOWERSTATECHANGE - can transition from a sleep state
  * to a lower sleep state without waking up the powerdomain
+ *
+ * PWRDM_ACTIVE_WITH_KERNEL - this powerdomain's current power state is
+ * guaranteed to be ON whenever the kernel is running
  */
 #define PWRDM_HAS_HDWR_SAR BIT(0)
 #define PWRDM_HAS_MPU_QUIRKBIT(1)
 #define PWRDM_HAS_LOWPOWERSTATECHANGE  BIT(2)
+#define PWRDM_ACTIVE_WITH_KERNEL   BIT(3)
 
 /*
  * Powerdomain internal flags (struct powerdomain._flags)
diff --git a/arch/arm/mach-omap2/powerdomains2xxx_data.c 
b/arch/arm/mach-omap2/powerdomains2xxx_data.c
index 578eef8..112927f 100644
--- a/arch/arm/mach-omap2/powerdomains2xxx_data.c
+++ b/arch/arm/mach-omap2/powerdomains2xxx_data.c
@@ -54,6 +54,7 @@ static struct powerdomain mpu_24xx_pwrdm = {
[0] = PWRSTS_ON,
},
.voltdm   = { .name = core },
+   .flags= PWRDM_ACTIVE_WITH_KERNEL,
 };
 
 static struct powerdomain core_24xx_pwrdm = {
@@ -73,6 +74,7 @@ static struct powerdomain core_24xx_pwrdm = {
[2] = PWRSTS_OFF_RET_ON, /* MEM3ONSTATE */
},
.voltdm   = { .name = core },
+   .flags= PWRDM_ACTIVE_WITH_KERNEL,
 };
 
 
diff --git a/arch/arm/mach-omap2/powerdomains33xx_data.c 
b/arch/arm/mach-omap2/powerdomains33xx_data.c
index 869adb8..acb148a 100644
--- a/arch/arm/mach-omap2/powerdomains33xx_data.c
+++ b/arch/arm/mach-omap2/powerdomains33xx_data.c
@@ -123,7 +123,8 @@ static struct powerdomain mpu_33xx_pwrdm = {
.pwrstst_offs   = AM33XX_PM_MPU_PWRSTST_OFFSET,
.pwrsts = PWRSTS_OFF_RET_ON,
.pwrsts_logic_ret   = PWRSTS_OFF_RET,
-   .flags  = PWRDM_HAS_LOWPOWERSTATECHANGE,
+   .flags  = (PWRDM_HAS_LOWPOWERSTATECHANGE |
+  PWRDM_ACTIVE_WITH_KERNEL),
.banks  = 3,
.logicretstate_mask = AM33XX_LOGICRETSTATE_MASK,
.mem_on_mask= {
diff --git a/arch/arm/mach-omap2/powerdomains3xxx_data.c 
b/arch/arm/mach-omap2/powerdomains3xxx_data.c
index f0e14e9ef..ade93d3 100644
--- a/arch/arm/mach-omap2/powerdomains3xxx_data.c
+++ b/arch/arm/mach-omap2/powerdomains3xxx_data.c
@@ -58,7 +58,7 @@ static struct powerdomain mpu_3xxx_pwrdm = {
.prcm_offs= MPU_MOD,
.pwrsts   = PWRSTS_OFF_RET_ON,
.pwrsts_logic_ret = PWRSTS_OFF_RET,
-   .flags= PWRDM_HAS_MPU_QUIRK,
+   .flags= (PWRDM_HAS_MPU_QUIRK | PWRDM_ACTIVE_WITH_KERNEL),
.banks= 1,
.pwrsts_mem_ret   = {
[0] = PWRSTS_OFF_RET,
@@ -74,7 +74,7 @@ static struct powerdomain mpu_am35x_pwrdm = {
.prcm_offs= MPU_MOD,
.pwrsts   = PWRSTS_ON,
.pwrsts_logic_ret = PWRSTS_ON,
-   .flags=