Re: [PATCH 1/2] arm: mach-omap2: devices: fix omap3_l3_init() return value
* Santosh Shilimkar santosh.shilim...@ti.com [110317 03:04]: From: Cousson, Benoit [mailto:b-cous...@ti.com] Maybe we should initialize that before, because in theory the timer12 secure violation should have been captured easily with this code? The firewall exceptions handling is removed from L3 handler because PPA has the trap implemented. We faced issues when the trap was enabled in both places. Applying these into fixes. Tony -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/2] arm: mach-omap2: devices: fix omap3_l3_init() return value
Hi Santosh, On 3/17/2011 6:52 AM, Shilimkar, Santosh wrote: -Original Message- From: linux-arm-kernel-boun...@lists.infradead.org [mailto:linux- arm-kernel-boun...@lists.infradead.org] On Behalf Of Aaro Koskinen Sent: Wednesday, March 16, 2011 10:46 PM To: linux-omap@vger.kernel.org; linux-arm- ker...@lists.infradead.org; t...@atomide.com Cc: Aaro Koskinen Subject: [PATCH 1/2] arm: mach-omap2: devices: fix omap3_l3_init() return value Fix the return value for the successful case. Signed-off-by: Aaro Koskinenaaro.koski...@nokia.com --- arch/arm/mach-omap2/devices.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-omap2/devices.c b/arch/arm/mach- omap2/devices.c index 0d2d6a9..d478f53 100644 --- a/arch/arm/mach-omap2/devices.c +++ b/arch/arm/mach-omap2/devices.c @@ -65,7 +65,7 @@ static int __init omap3_l3_init(void) WARN(IS_ERR(od), could not build omap_device for %s\n, oh_name); - return PTR_ERR(od); + return IS_ERR(od) ? PTR_ERR(od) : 0; } postcore_initcall(omap3_l3_init); Maybe we should initialize that before, because in theory the timer12 secure violation should have been captured easily with this code? Regards, Benoit -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH 1/2] arm: mach-omap2: devices: fix omap3_l3_init() return value
-Original Message- From: Cousson, Benoit [mailto:b-cous...@ti.com] Sent: Thursday, March 17, 2011 1:50 PM To: Shilimkar, Santosh Cc: Aaro Koskinen; linux-omap@vger.kernel.org; linux-arm- ker...@lists.infradead.org; t...@atomide.com Subject: Re: [PATCH 1/2] arm: mach-omap2: devices: fix omap3_l3_init() return value Hi Santosh, On 3/17/2011 6:52 AM, Shilimkar, Santosh wrote: -Original Message- From: linux-arm-kernel-boun...@lists.infradead.org [mailto:linux- arm-kernel-boun...@lists.infradead.org] On Behalf Of Aaro Koskinen Sent: Wednesday, March 16, 2011 10:46 PM To: linux-omap@vger.kernel.org; linux-arm- ker...@lists.infradead.org; t...@atomide.com Cc: Aaro Koskinen Subject: [PATCH 1/2] arm: mach-omap2: devices: fix omap3_l3_init() return value Fix the return value for the successful case. Signed-off-by: Aaro Koskinenaaro.koski...@nokia.com --- arch/arm/mach-omap2/devices.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-omap2/devices.c b/arch/arm/mach- omap2/devices.c index 0d2d6a9..d478f53 100644 --- a/arch/arm/mach-omap2/devices.c +++ b/arch/arm/mach-omap2/devices.c @@ -65,7 +65,7 @@ static int __init omap3_l3_init(void) WARN(IS_ERR(od), could not build omap_device for %s\n, oh_name); - return PTR_ERR(od); + return IS_ERR(od) ? PTR_ERR(od) : 0; } postcore_initcall(omap3_l3_init); Maybe we should initialize that before, because in theory the timer12 secure violation should have been captured easily with this code? The firewall exceptions handling is removed from L3 handler because PPA has the trap implemented. We faced issues when the trap was enabled in both places. Regards Santosh -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 1/2] arm: mach-omap2: devices: fix omap3_l3_init() return value
Fix the return value for the successful case. Signed-off-by: Aaro Koskinen aaro.koski...@nokia.com --- arch/arm/mach-omap2/devices.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-omap2/devices.c b/arch/arm/mach-omap2/devices.c index 0d2d6a9..d478f53 100644 --- a/arch/arm/mach-omap2/devices.c +++ b/arch/arm/mach-omap2/devices.c @@ -65,7 +65,7 @@ static int __init omap3_l3_init(void) WARN(IS_ERR(od), could not build omap_device for %s\n, oh_name); - return PTR_ERR(od); + return IS_ERR(od) ? PTR_ERR(od) : 0; } postcore_initcall(omap3_l3_init); -- 1.5.6.5 -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH 1/2] arm: mach-omap2: devices: fix omap3_l3_init() return value
-Original Message- From: linux-arm-kernel-boun...@lists.infradead.org [mailto:linux- arm-kernel-boun...@lists.infradead.org] On Behalf Of Aaro Koskinen Sent: Wednesday, March 16, 2011 10:46 PM To: linux-omap@vger.kernel.org; linux-arm- ker...@lists.infradead.org; t...@atomide.com Cc: Aaro Koskinen Subject: [PATCH 1/2] arm: mach-omap2: devices: fix omap3_l3_init() return value Fix the return value for the successful case. Signed-off-by: Aaro Koskinen aaro.koski...@nokia.com --- arch/arm/mach-omap2/devices.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-omap2/devices.c b/arch/arm/mach- omap2/devices.c index 0d2d6a9..d478f53 100644 --- a/arch/arm/mach-omap2/devices.c +++ b/arch/arm/mach-omap2/devices.c @@ -65,7 +65,7 @@ static int __init omap3_l3_init(void) WARN(IS_ERR(od), could not build omap_device for %s\n, oh_name); - return PTR_ERR(od); + return IS_ERR(od) ? PTR_ERR(od) : 0; } postcore_initcall(omap3_l3_init); Looks good. Acked-by: Santosh Shilimkar santosh.shilim...@ti.com -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
