Re: [PATCH 1/5] staging: tidspbridge: more readable code

[Ramirez Luna, Omar]

2012/1/24 Felipe Contreras felipe.contre...@gmail.com:
 2012/1/23 Víctor Manuel Jáquez Leal vjaq...@igalia.com:
 Uppercase function names are not pretty. Also the code flow readability is
 enhanced.

 Looks good to me.

FWIW, I agree.

Regards,

Omar
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/5] staging: tidspbridge: more readable code

[Felipe Contreras]

2012/1/23 Víctor Manuel Jáquez Leal vjaq...@igalia.com:
 Uppercase function names are not pretty. Also the code flow readability is
 enhanced.

Looks good to me.

-- 
Felipe Contreras
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 1/5] staging: tidspbridge: more readable code

[Víctor Manuel Jáquez Leal]

Uppercase function names are not pretty. Also the code flow readability is
enhanced.

Signed-off-by: Víctor Manuel Jáquez Leal vjaq...@igalia.com
---
 drivers/staging/tidspbridge/rmgr/drv_interface.c |   13 ++---
 1 files changed, 6 insertions(+), 7 deletions(-)

diff --git a/drivers/staging/tidspbridge/rmgr/drv_interface.c 
b/drivers/staging/tidspbridge/rmgr/drv_interface.c
index 76cfc6e..85f6e8e 100644
--- a/drivers/staging/tidspbridge/rmgr/drv_interface.c
+++ b/drivers/staging/tidspbridge/rmgr/drv_interface.c
@@ -428,7 +428,7 @@ func_cont:
 }
 
 #ifdef CONFIG_PM
-static int BRIDGE_SUSPEND(struct platform_device *pdev, pm_message_t state)
+static int bridge_suspend(struct platform_device *pdev, pm_message_t state)
 {
u32 status;
u32 command = PWR_EMERGENCYDEEPSLEEP;
@@ -441,7 +441,7 @@ static int BRIDGE_SUSPEND(struct platform_device *pdev, 
pm_message_t state)
return 0;
 }
 
-static int BRIDGE_RESUME(struct platform_device *pdev)
+static int bridge_resume(struct platform_device *pdev)
 {
u32 status;
 
@@ -453,9 +453,6 @@ static int BRIDGE_RESUME(struct platform_device *pdev)
wake_up(bridge_suspend_data.suspend_wq);
return 0;
 }
-#else
-#define BRIDGE_SUSPEND NULL
-#define BRIDGE_RESUME NULL
 #endif
 
 static struct platform_driver bridge_driver = {
@@ -464,8 +461,10 @@ static struct platform_driver bridge_driver = {
   },
.probe = omap34_xx_bridge_probe,
.remove = __devexit_p(omap34_xx_bridge_remove),
-   .suspend = BRIDGE_SUSPEND,
-   .resume = BRIDGE_RESUME,
+#ifdef CONFIG_PM
+   .suspend = bridge_suspend,
+   .resume = bridge_resume,
+#endif
 };
 
 static int __init bridge_init(void)
-- 
1.7.8.3

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html