Re: [PATCH 11/30] ARM: omap2/n8x0: work around modular omap mmc

2011-10-03 Thread Tony Lindgren 
* Arnd Bergmann a...@arndb.de [111002 11:22]:
 On Sunday 02 October 2011 16:53:31 Russell King - ARM Linux wrote:
  On Sun, Oct 02, 2011 at 04:45:41PM +0200, Arnd Bergmann wrote:
   -#if defined(CONFIG_MENELAUS)   
   \
   - (defined(CONFIG_MMC_OMAP) || defined(CONFIG_MMC_OMAP_MODULE))
   +#if defined(CONFIG_MENELAUS)  defined(CONFIG_MMC_OMAP)
   +/* || defined(CONFIG_MMC_OMAP_MODULE)) */
   +/* FIXME: cannot call omap_mmc_notify_cover_event for 
   ONFIG_MMC_OMAP_MODULE */
  
  #ifdef CONFIG_MMC_OMAP_MODULE
  #warning FIXME: cannot call omap_mmc_notify_cover_event for 
  CONFIG_MMC_OMAP_MODULE
  #endif
  #if defined(CONFIG_MENELAUS)  defined(CONFIG_MMC_OMAP)
  
  So that it can be seen at build time?
  
  Also note the 'ONFIG' typo...
 
 Ok, good idea. I've updated the patch in the git tree accordingly.

Acked-by: Tony Lindgren t...@atomide.com
 
 Depending on what Tony wants, I might send out the entire series
 again once there are no more new comments.

Up to you, I usually prefer to see just updated patches as long
as the mail thread stays readable.

Regards,

Tony
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 11/30] ARM: omap2/n8x0: work around modular omap mmc

2011-10-02 Thread Arnd Bergmann 
When the omap driver is built as a module for n8x0,
n8x0_mmc_set_power_menelaus cannot call into the driver:

arch/arm/mach-omap2/board-n8x0.c:374: undefined reference to 
`omap_mmc_notify_cover_event'

As a workaround, do not provide that device in this case. This needs
to be fixed properly, e.g. by converting n8x0 to be probed through the
device tree and moving that code into the driver.

Signed-off-by: Arnd Bergmann a...@arndb.de
---
 arch/arm/mach-omap2/board-n8x0.c |5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/arch/arm/mach-omap2/board-n8x0.c b/arch/arm/mach-omap2/board-n8x0.c
index e11f0c5..403325d 100644
--- a/arch/arm/mach-omap2/board-n8x0.c
+++ b/arch/arm/mach-omap2/board-n8x0.c
@@ -193,8 +193,9 @@ static struct omap_onenand_platform_data 
board_onenand_data[] = {
 };
 #endif
 
-#if defined(CONFIG_MENELAUS) 
\
-   (defined(CONFIG_MMC_OMAP) || defined(CONFIG_MMC_OMAP_MODULE))
+#if defined(CONFIG_MENELAUS)  defined(CONFIG_MMC_OMAP)
+/* || defined(CONFIG_MMC_OMAP_MODULE)) */
+/* FIXME: cannot call omap_mmc_notify_cover_event for ONFIG_MMC_OMAP_MODULE */
 
 /*
  * On both N800 and N810, only the first of the two MMC controllers is in use.
-- 
1.7.5.4

--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 11/30] ARM: omap2/n8x0: work around modular omap mmc

2011-10-02 Thread Russell King - ARM Linux 
On Sun, Oct 02, 2011 at 04:45:41PM +0200, Arnd Bergmann wrote:
 -#if defined(CONFIG_MENELAUS)   
 \
 - (defined(CONFIG_MMC_OMAP) || defined(CONFIG_MMC_OMAP_MODULE))
 +#if defined(CONFIG_MENELAUS)  defined(CONFIG_MMC_OMAP)
 +/* || defined(CONFIG_MMC_OMAP_MODULE)) */
 +/* FIXME: cannot call omap_mmc_notify_cover_event for ONFIG_MMC_OMAP_MODULE 
 */

#ifdef CONFIG_MMC_OMAP_MODULE
#warning FIXME: cannot call omap_mmc_notify_cover_event for 
CONFIG_MMC_OMAP_MODULE
#endif
#if defined(CONFIG_MENELAUS)  defined(CONFIG_MMC_OMAP)

So that it can be seen at build time?

Also note the 'ONFIG' typo...
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 11/30] ARM: omap2/n8x0: work around modular omap mmc

2011-10-02 Thread Arnd Bergmann 
On Sunday 02 October 2011 16:53:31 Russell King - ARM Linux wrote:
 On Sun, Oct 02, 2011 at 04:45:41PM +0200, Arnd Bergmann wrote:
  -#if defined(CONFIG_MENELAUS) 
\
  - (defined(CONFIG_MMC_OMAP) || defined(CONFIG_MMC_OMAP_MODULE))
  +#if defined(CONFIG_MENELAUS)  defined(CONFIG_MMC_OMAP)
  +/* || defined(CONFIG_MMC_OMAP_MODULE)) */
  +/* FIXME: cannot call omap_mmc_notify_cover_event for 
  ONFIG_MMC_OMAP_MODULE */
 
 #ifdef CONFIG_MMC_OMAP_MODULE
 #warning FIXME: cannot call omap_mmc_notify_cover_event for 
 CONFIG_MMC_OMAP_MODULE
 #endif
 #if defined(CONFIG_MENELAUS)  defined(CONFIG_MMC_OMAP)
 
 So that it can be seen at build time?
 
 Also note the 'ONFIG' typo...

Ok, good idea. I've updated the patch in the git tree accordingly.

Depending on what Tony wants, I might send out the entire series
again once there are no more new comments.

Arnd
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html